Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6329

Remove unnecessary TODO comment from AppLogAggregatorImpl.java

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      After YARN-3116, this TODO comment is unnecessary.

        // TODO: The condition: containerId.getId() == 1 to determine an AM container
        // is not always true.
        private boolean shouldUploadLogs(ContainerLogContext logContext) {
          return logAggPolicy.shouldDoLogAggregation(logContext);
        }
      

        Attachments

        1. YARN-6329.001.patch
          1 kB
          victor bertschinger

          Activity

            People

            • Assignee:
              vbertschinger victor bertschinger
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: