[YARN-6326] Shouldn't use AppAttemptIds to fetch applications while AM Simulator tracks app in SLS

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha4
• Component/s: scheduler-load-simulator
• Hadoop Flags: Reviewed
• Assignee: Yufei Gu
• Reporter: Yufei Gu
• Created: 11/Mar/17 01:01
• Updated: 21/Mar/17 23:26
• Resolved: 21/Mar/17 23:26

Description

This causes a NPE issue. Beside the NPE, the metrics won't reflect the different attempts. We should pass ApplicationId Instead of AppAttemptId. The NPE caused by the issue:

2017-03-13 20:43:39,153 INFO appmaster.AMSimulator: Submit a new application application_1489463017173_0001
java.lang.NullPointerException
	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.AbstractYarnScheduler.getApplicationAttempt(AbstractYarnScheduler.java:327)
	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler.getSchedulerApp(FairScheduler.java:1028)
	at org.apache.hadoop.yarn.sls.scheduler.FairSchedulerMetrics.trackApp(FairSchedulerMetrics.java:68)
	at org.apache.hadoop.yarn.sls.scheduler.ResourceSchedulerWrapper.addTrackedApp(ResourceSchedulerWrapper.java:799)
	at org.apache.hadoop.yarn.sls.appmaster.AMSimulator.trackApp(AMSimulator.java:338)
	at org.apache.hadoop.yarn.sls.appmaster.AMSimulator.firstStep(AMSimulator.java:156)
	at org.apache.hadoop.yarn.sls.scheduler.TaskRunner$Task.run(TaskRunner.java:90)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Exception in thread "pool-6-thread-1" java.lang.NullPointerException
	at org.apache.hadoop.yarn.sls.scheduler.TaskRunner$Task.run(TaskRunner.java:105)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

Issue Links

• is depended upon by: YARN-5654 Not be able to run SLS with FairScheduler