Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6321

TestResources test timeouts are too aggressive

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha4, 2.8.2
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      TestResources is using 1 second timeouts which can cause a spurious test failure when the test machine hits an I/O hiccup or other temporary slowness.

        Activity

        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.
        Hide
        jlowe Jason Lowe added a comment -

        Thanks, Eric! I committed this to trunk, branch-2, and branch-2.8.

        Show
        jlowe Jason Lowe added a comment - Thanks, Eric! I committed this to trunk, branch-2, and branch-2.8.
        Hide
        jlowe Jason Lowe added a comment -

        +1 lgtm. Committing this.

        Show
        jlowe Jason Lowe added a comment - +1 lgtm. Committing this.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 13s Maven dependency ordering for branch
        +1 mvninstall 14m 7s trunk passed
        +1 compile 6m 24s trunk passed
        +1 checkstyle 0m 58s trunk passed
        +1 mvnsite 1m 31s trunk passed
        +1 mvneclipse 0m 54s trunk passed
        +1 findbugs 2m 44s trunk passed
        +1 javadoc 1m 18s trunk passed
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 1m 7s the patch passed
        +1 compile 5m 53s the patch passed
        +1 javac 5m 53s the patch passed
        +1 checkstyle 1m 3s the patch passed
        +1 mvnsite 1m 46s the patch passed
        +1 mvneclipse 0m 50s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 16s the patch passed
        +1 javadoc 1m 19s the patch passed
        +1 unit 3m 3s hadoop-yarn-common in the patch passed.
        -1 unit 42m 41s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 44s The patch does not generate ASF License warnings.
        99m 21s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestResourceTrackerService



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-6321
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12857356/YARN-6321.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ab503835359a 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / deb9f56
        Default Java 1.8.0_121
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-YARN-Build/15227/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15227/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/15227/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 14m 7s trunk passed +1 compile 6m 24s trunk passed +1 checkstyle 0m 58s trunk passed +1 mvnsite 1m 31s trunk passed +1 mvneclipse 0m 54s trunk passed +1 findbugs 2m 44s trunk passed +1 javadoc 1m 18s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 7s the patch passed +1 compile 5m 53s the patch passed +1 javac 5m 53s the patch passed +1 checkstyle 1m 3s the patch passed +1 mvnsite 1m 46s the patch passed +1 mvneclipse 0m 50s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 16s the patch passed +1 javadoc 1m 19s the patch passed +1 unit 3m 3s hadoop-yarn-common in the patch passed. -1 unit 42m 41s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 44s The patch does not generate ASF License warnings. 99m 21s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestResourceTrackerService Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6321 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12857356/YARN-6321.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ab503835359a 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / deb9f56 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/15227/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15227/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/15227/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ebadger Eric Badger added a comment -

        Attaching patch to increase the timeout in all TestResources tests to 10s

        Show
        ebadger Eric Badger added a comment - Attaching patch to increase the timeout in all TestResources tests to 10s
        Hide
        jlowe Jason Lowe added a comment -

        Sample stacktrace from a timeout:

        java.lang.Exception: test timed out after 1000 milliseconds
        	at java.util.zip.Inflater.inflateBytes(Native Method)
        	at java.util.zip.Inflater.inflate(Inflater.java:259)
        	at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:152)
        	at sun.misc.Resource.getBytes(Resource.java:124)
        	at java.net.URLClassLoader.defineClass(URLClassLoader.java:462)
        	at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
        	at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
        	at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
        	at java.security.AccessController.doPrivileged(Native Method)
        	at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
        	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
        	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
        	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        	at java.lang.ClassLoader.defineClass1(Native Method)
        	at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
        	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
        	at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
        	at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
        	at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
        	at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
        	at java.security.AccessController.doPrivileged(Native Method)
        	at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
        	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
        	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
        	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        	at java.lang.Class.getDeclaredConstructors0(Native Method)
        	at java.lang.Class.privateGetDeclaredConstructors(Class.java:2671)
        	at java.lang.Class.getConstructor0(Class.java:3075)
        	at java.lang.Class.getConstructor(Class.java:1825)
        	at org.apache.hadoop.yarn.factories.impl.pb.RecordFactoryPBImpl.newRecordInstance(RecordFactoryPBImpl.java:62)
        	at org.apache.hadoop.yarn.util.Records.newRecord(Records.java:36)
        	at org.apache.hadoop.yarn.api.records.Resource.newInstance(Resource.java:68)
        	at org.apache.hadoop.yarn.util.resource.TestResources.createResource(TestResources.java:28)
        	at org.apache.hadoop.yarn.util.resource.TestResources.testCompareToWithNoneResource(TestResources.java:43)
        

        Clearly the test is just doing startup-related classpath stuff which happened to take a bit longer than normal.

        Show
        jlowe Jason Lowe added a comment - Sample stacktrace from a timeout: java.lang.Exception: test timed out after 1000 milliseconds at java.util.zip.Inflater.inflateBytes(Native Method) at java.util.zip.Inflater.inflate(Inflater.java:259) at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:152) at sun.misc.Resource.getBytes(Resource.java:124) at java.net.URLClassLoader.defineClass(URLClassLoader.java:462) at java.net.URLClassLoader.access$100(URLClassLoader.java:73) at java.net.URLClassLoader$1.run(URLClassLoader.java:368) at java.net.URLClassLoader$1.run(URLClassLoader.java:362) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:361) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:760) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) at java.net.URLClassLoader.defineClass(URLClassLoader.java:467) at java.net.URLClassLoader.access$100(URLClassLoader.java:73) at java.net.URLClassLoader$1.run(URLClassLoader.java:368) at java.net.URLClassLoader$1.run(URLClassLoader.java:362) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:361) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at java.lang.Class.getDeclaredConstructors0(Native Method) at java.lang.Class.privateGetDeclaredConstructors(Class.java:2671) at java.lang.Class.getConstructor0(Class.java:3075) at java.lang.Class.getConstructor(Class.java:1825) at org.apache.hadoop.yarn.factories.impl.pb.RecordFactoryPBImpl.newRecordInstance(RecordFactoryPBImpl.java:62) at org.apache.hadoop.yarn.util.Records.newRecord(Records.java:36) at org.apache.hadoop.yarn.api.records.Resource.newInstance(Resource.java:68) at org.apache.hadoop.yarn.util.resource.TestResources.createResource(TestResources.java:28) at org.apache.hadoop.yarn.util.resource.TestResources.testCompareToWithNoneResource(TestResources.java:43) Clearly the test is just doing startup-related classpath stuff which happened to take a bit longer than normal.

          People

          • Assignee:
            ebadger Eric Badger
            Reporter:
            jlowe Jason Lowe
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development