Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6310

OutputStreams in AggregatedLogFormat.LogWriter can be left open upon exceptions

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha2
    • Fix Version/s: 2.9.0, 2.7.4, 3.0.0-alpha4, 2.8.2
    • Component/s: yarn
    • Labels:
      None

      Activity

      Hide
      vinodkv Vinod Kumar Vavilapalli added a comment -

      2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

      Show
      vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.
      Hide
      jlowe Jason Lowe added a comment -

      Thanks, Haibo! I committed this to trunk, branch-2, branch-2.8, and branch-2.7.

      Show
      jlowe Jason Lowe added a comment - Thanks, Haibo! I committed this to trunk, branch-2, branch-2.8, and branch-2.7.
      Hide
      haibochen Haibo Chen added a comment -

      Thanks a lot for your review, Jason Lowe!

      Show
      haibochen Haibo Chen added a comment - Thanks a lot for your review, Jason Lowe !
      Hide
      jlowe Jason Lowe added a comment -

      +1 lgtm. Committing this.

      Show
      jlowe Jason Lowe added a comment - +1 lgtm. Committing this.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 19s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      +1 mvninstall 14m 10s trunk passed
      +1 compile 0m 28s trunk passed
      +1 checkstyle 0m 21s trunk passed
      +1 mvnsite 0m 29s trunk passed
      +1 mvneclipse 0m 14s trunk passed
      +1 findbugs 1m 0s trunk passed
      +1 javadoc 0m 27s trunk passed
      +1 mvninstall 0m 31s the patch passed
      +1 compile 0m 26s the patch passed
      +1 javac 0m 26s the patch passed
      +1 checkstyle 0m 21s the patch passed
      +1 mvnsite 0m 29s the patch passed
      +1 mvneclipse 0m 13s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 1m 6s the patch passed
      +1 javadoc 0m 25s the patch passed
      +1 unit 2m 34s hadoop-yarn-common in the patch passed.
      +1 asflicense 0m 21s The patch does not generate ASF License warnings.
      25m 16s



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:a9ad5d6
      JIRA Issue YARN-6310
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12857143/YARN-6310.01.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux a10212a61311 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / e96a0b8
      Default Java 1.8.0_121
      findbugs v3.0.0
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15223/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/15223/console
      Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 10s trunk passed +1 compile 0m 28s trunk passed +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 29s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 0s trunk passed +1 javadoc 0m 27s trunk passed +1 mvninstall 0m 31s the patch passed +1 compile 0m 26s the patch passed +1 javac 0m 26s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 0m 29s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 6s the patch passed +1 javadoc 0m 25s the patch passed +1 unit 2m 34s hadoop-yarn-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 25m 16s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6310 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12857143/YARN-6310.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a10212a61311 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e96a0b8 Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15223/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/15223/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      haibochen Haibo Chen added a comment -

      Upload a patch that replace explicit close calls with try clauses

      Show
      haibochen Haibo Chen added a comment - Upload a patch that replace explicit close calls with try clauses

        People

        • Assignee:
          haibochen Haibo Chen
          Reporter:
          haibochen Haibo Chen
        • Votes:
          0 Vote for this issue
          Watchers:
          5 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development