Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: fairscheduler
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The method does three things: compare the min share usage, compare fair share usage by checking weight ratio, break tied by submit time and name. They are mixed with each other which is not easy to read and maintenance, poor style. Additionally, there are potential performance issues, like no need to check weight ratio if minShare usage comparison already indicate the order. It is worth to improve considering huge amount invokings in scheduler.

      1. YARN-6307.001.patch
        6 kB
        Yufei Gu
      2. YARN-6307.002.patch
        8 kB
        Yufei Gu
      3. YARN-6307.003.patch
        8 kB
        Yufei Gu

        Activity

        Hide
        Tao Jie Tao Jie added a comment -

        Thank you Yufei Gu, FairShareComparator#compare is called very frequently in each container allocation process. It would improve the scheduler performance if we can simplify this method.
        Furthermore, I don't think it is necessary to sort the queue hierarchy from the root to leafqueue in every node update. Can we do the sort in the update thread, then share the result for node update? It would reduce much redundant sort. Maybe we can improve this in another JIRA.

        Show
        Tao Jie Tao Jie added a comment - Thank you Yufei Gu , FairShareComparator#compare is called very frequently in each container allocation process. It would improve the scheduler performance if we can simplify this method. Furthermore, I don't think it is necessary to sort the queue hierarchy from the root to leafqueue in every node update. Can we do the sort in the update thread, then share the result for node update? It would reduce much redundant sort. Maybe we can improve this in another JIRA.
        Hide
        yufeigu Yufei Gu added a comment -

        Tao Jie, I like the idea of reduce queue sort frequency, but I don't think it is a good idea to just sort queues in scheduler update thread. Resource usages changes during container assigning, and the sort algorithm(FairShareComparator#compare) heavily relies on resource usages to meet fairness. In that sense, it's hard to avoid queue sort while assigning container. BTW, have you filed separate JIRAs for this idea?

        Show
        yufeigu Yufei Gu added a comment - Tao Jie , I like the idea of reduce queue sort frequency, but I don't think it is a good idea to just sort queues in scheduler update thread. Resource usages changes during container assigning, and the sort algorithm(FairShareComparator#compare) heavily relies on resource usages to meet fairness. In that sense, it's hard to avoid queue sort while assigning container. BTW, have you filed separate JIRAs for this idea?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 13m 51s trunk passed
        +1 compile 0m 39s trunk passed
        +1 checkstyle 0m 27s trunk passed
        +1 mvnsite 0m 44s trunk passed
        +1 findbugs 1m 10s trunk passed
        +1 javadoc 0m 24s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 36s the patch passed
        +1 compile 0m 33s the patch passed
        +1 javac 0m 33s the patch passed
        +1 checkstyle 0m 23s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 2 unchanged - 6 fixed = 2 total (was 8)
        +1 mvnsite 0m 34s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 8s the patch passed
        +1 javadoc 0m 20s the patch passed
              Other Tests
        -1 unit 42m 59s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        65m 38s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
          hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
          hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-6307
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876979/YARN-6307.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 11549a670c66 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e15e271
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-YARN-Build/16400/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16400/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/16400/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 13m 51s trunk passed +1 compile 0m 39s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 44s trunk passed +1 findbugs 1m 10s trunk passed +1 javadoc 0m 24s trunk passed       Patch Compile Tests +1 mvninstall 0m 36s the patch passed +1 compile 0m 33s the patch passed +1 javac 0m 33s the patch passed +1 checkstyle 0m 23s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 2 unchanged - 6 fixed = 2 total (was 8) +1 mvnsite 0m 34s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 8s the patch passed +1 javadoc 0m 20s the patch passed       Other Tests -1 unit 42m 59s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 65m 38s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6307 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876979/YARN-6307.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 11549a670c66 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e15e271 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/16400/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16400/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16400/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        yufeigu Yufei Gu added a comment -

        Rebase it since YARN-6769 was in.

        Show
        yufeigu Yufei Gu added a comment - Rebase it since YARN-6769 was in.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 16m 15s trunk passed
        +1 compile 0m 46s trunk passed
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 0m 46s trunk passed
        +1 findbugs 1m 9s trunk passed
        +1 javadoc 0m 24s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 40s the patch passed
        +1 compile 0m 40s the patch passed
        +1 javac 0m 40s the patch passed
        +1 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 1 unchanged - 6 fixed = 1 total (was 7)
        +1 mvnsite 0m 33s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 4s the patch passed
        +1 javadoc 0m 20s the patch passed
              Other Tests
        -1 unit 42m 37s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        67m 58s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation
          hadoop.yarn.server.resourcemanager.TestRMRestart
          hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-6307
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877419/YARN-6307.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux d89308444468 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f413ee3
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-YARN-Build/16454/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16454/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/16454/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 16m 15s trunk passed +1 compile 0m 46s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 0m 46s trunk passed +1 findbugs 1m 9s trunk passed +1 javadoc 0m 24s trunk passed       Patch Compile Tests +1 mvninstall 0m 40s the patch passed +1 compile 0m 40s the patch passed +1 javac 0m 40s the patch passed +1 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 1 unchanged - 6 fixed = 1 total (was 7) +1 mvnsite 0m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 4s the patch passed +1 javadoc 0m 20s the patch passed       Other Tests -1 unit 42m 37s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 67m 58s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6307 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877419/YARN-6307.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d89308444468 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f413ee3 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/16454/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16454/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16454/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        Nice patch, Yufei Gu. Here are my comments:

        1. Since we're unnesting all the if blocks, let's take do that here, too:
                if (res == 0) {
                  // Apps are tied in fairness ratio. Break the tie by submit time and job
                  // name to get a deterministic ordering, which is useful for unit tests.
                  res = (int) Math.signum(s1.getStartTime() - s2.getStartTime());
                  if (res == 0) {
                    res = s1.getName().compareTo(s2.getName());
                  }
                }
        2. Let's not stack the declarations:
                double useToWeightRatio1, useToWeightRatio2;

        Otherwise, looks good.

        Show
        templedf Daniel Templeton added a comment - Nice patch, Yufei Gu . Here are my comments: Since we're unnesting all the if blocks, let's take do that here, too: if (res == 0) { // Apps are tied in fairness ratio. Break the tie by submit time and job // name to get a deterministic ordering, which is useful for unit tests. res = ( int ) Math .signum(s1.getStartTime() - s2.getStartTime()); if (res == 0) { res = s1.getName().compareTo(s2.getName()); } } Let's not stack the declarations: double useToWeightRatio1, useToWeightRatio2; Otherwise, looks good.
        Hide
        yufeigu Yufei Gu added a comment -

        Thanks Daniel Templeton for the review. Uploaded patch v3 for your comments.

        Show
        yufeigu Yufei Gu added a comment - Thanks Daniel Templeton for the review. Uploaded patch v3 for your comments.
        Hide
        templedf Daniel Templeton added a comment -

        LGTM. Given the frequency with which this method is called, any performance concerns about unrolling the nested if statements? My hunch is that the compiler and/or JIT will make it ultimately irrelevant, but I didn't find anything conclusive online.

        Show
        templedf Daniel Templeton added a comment - LGTM. Given the frequency with which this method is called, any performance concerns about unrolling the nested if statements? My hunch is that the compiler and/or JIT will make it ultimately irrelevant, but I didn't find anything conclusive online.
        Hide
        yufeigu Yufei Gu added a comment -

        The overhead of this refactoring would be
        1. More check on variable res, at most 4 more checking which possible need 4-8 more CPU instructions, which is fine.
        2. Overhead of function invoking. JVM does inline methods. https://stackoverflow.com/questions/2096361/are-there-inline-functions-in-java

        Moreover, this refactor will reduce the computation of fair share comparison, since it does fair share ratio computation anyway before my patch while it is invoked only if necessary after my patch. In that sense, I don't think we need to worry about performance.

        Show
        yufeigu Yufei Gu added a comment - The overhead of this refactoring would be 1. More check on variable res , at most 4 more checking which possible need 4-8 more CPU instructions, which is fine. 2. Overhead of function invoking. JVM does inline methods. https://stackoverflow.com/questions/2096361/are-there-inline-functions-in-java Moreover, this refactor will reduce the computation of fair share comparison, since it does fair share ratio computation anyway before my patch while it is invoked only if necessary after my patch. In that sense, I don't think we need to worry about performance.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 14m 49s trunk passed
        +1 compile 0m 44s trunk passed
        +1 checkstyle 0m 33s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 findbugs 1m 20s trunk passed
        +1 javadoc 0m 28s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 43s the patch passed
        +1 compile 0m 43s the patch passed
        +1 javac 0m 43s the patch passed
        +1 checkstyle 0m 28s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 2 unchanged - 6 fixed = 2 total (was 8)
        +1 mvnsite 0m 44s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 21s the patch passed
        +1 javadoc 0m 25s the patch passed
              Other Tests
        -1 unit 54m 8s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 1m 1s The patch does not generate ASF License warnings.
        80m 6s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
        Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA
          org.apache.hadoop.yarn.server.resourcemanager.TestReservationSystemWithRMHA
          org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-6307
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878696/YARN-6307.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 78e57f813648 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / c98201b
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-YARN-Build/16537/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16537/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/16537/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 14m 49s trunk passed +1 compile 0m 44s trunk passed +1 checkstyle 0m 33s trunk passed +1 mvnsite 0m 54s trunk passed +1 findbugs 1m 20s trunk passed +1 javadoc 0m 28s trunk passed       Patch Compile Tests +1 mvninstall 0m 43s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed +1 checkstyle 0m 28s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 2 unchanged - 6 fixed = 2 total (was 8) +1 mvnsite 0m 44s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 21s the patch passed +1 javadoc 0m 25s the patch passed       Other Tests -1 unit 54m 8s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 1m 1s The patch does not generate ASF License warnings. 80m 6s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA   org.apache.hadoop.yarn.server.resourcemanager.TestReservationSystemWithRMHA   org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6307 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878696/YARN-6307.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 78e57f813648 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c98201b Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/16537/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16537/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16537/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12054 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12054/)
        YARN-6307. Refactor FairShareComparator#compare (Contributed by Yufei Gu (templedf: rev f81a4efb8c40f99a9a6b7b42d3b6eeedf43eb27a)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/FairSharePolicy.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12054 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12054/ ) YARN-6307 . Refactor FairShareComparator#compare (Contributed by Yufei Gu (templedf: rev f81a4efb8c40f99a9a6b7b42d3b6eeedf43eb27a) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/FairSharePolicy.java
        Hide
        templedf Daniel Templeton added a comment -

        Thanks for the patch, Yufei Gu. Committed to trunk and branch-2.

        Show
        templedf Daniel Templeton added a comment - Thanks for the patch, Yufei Gu . Committed to trunk and branch-2.

          People

          • Assignee:
            yufeigu Yufei Gu
            Reporter:
            yufeigu Yufei Gu
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development