Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6307

Refactor FairShareComparator#compare

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: fairscheduler
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The method does three things: compare the min share usage, compare fair share usage by checking weight ratio, break tied by submit time and name. They are mixed with each other which is not easy to read and maintenance, poor style. Additionally, there are potential performance issues, like no need to check weight ratio if minShare usage comparison already indicate the order. It is worth to improve considering huge amount invokings in scheduler.

        Attachments

        1. YARN-6307.003.patch
          8 kB
          Yufei Gu
        2. YARN-6307.002.patch
          8 kB
          Yufei Gu
        3. YARN-6307.001.patch
          6 kB
          Yufei Gu

          Activity

            People

            • Assignee:
              yufeigu Yufei Gu
              Reporter:
              yufeigu Yufei Gu
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: