Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6280

Introduce deselect query param to skip ResourceRequest from getApp/getApps REST API

    Details

    • Hadoop Flags:
      Reviewed

      Description

      Begin from v2.7, the ResourceManager Cluster Applications REST API returns ResourceRequest list. It's a very large construction in AppInfo.
      As a test, we use below URI to query only 2 results:
      http://<rm http address:port>/ws/v1/cluster/apps?states=running,accepted&limit=2
      The results are very different:

      Hadoop version Total Character Total Word Total Lines Size
      2.4.1 1192 42 42 1.2 KB
      2.7.1 1222179 48740 48735 1.21 MB

      Most RESTful API requesters don't know about this after upgraded and their old queries may cause ResourceManager more GC consuming and slower. Even if they know this but have no idea to reduce the impact of ResourceManager except slow down their query frequency.

      The patch adding a query parameter "showResourceRequests" to help requesters who don't need this information to reduce the overhead. In consideration of compatibility of interface, the default value is true if they don't set the parameter, so the behaviour is the same as now.

      1. YARN-6280.001.patch
        8 kB
        Lantao Jin
      2. YARN-6280.002.patch
        13 kB
        Lantao Jin
      3. YARN-6280.003.patch
        13 kB
        Lantao Jin
      4. YARN-6280.004.patch
        13 kB
        Lantao Jin
      5. YARN-6280.005.patch
        13 kB
        Lantao Jin
      6. YARN-6280.006.patch
        13 kB
        Lantao Jin
      7. YARN-6280.007.patch
        13 kB
        Lantao Jin
      8. YARN-6280.008.patch
        15 kB
        Lantao Jin
      9. YARN-6280.009.patch
        15 kB
        Lantao Jin
      10. YARN-6280.010.patch
        23 kB
        Lantao Jin
      11. YARN-6280.011.patch
        26 kB
        Sunil G
      12. YARN-6280-branch-2.001.patch
        23 kB
        Lantao Jin
      13. YARN-6280-branch-2.002.patch
        25 kB
        Lantao Jin

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 12m 34s trunk passed
          +1 compile 0m 31s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 32s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 0m 58s trunk passed
          +1 javadoc 0m 20s trunk passed
          -1 mvninstall 0m 28s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 compile 0m 27s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 javac 0m 27s hadoop-yarn-server-resourcemanager in the patch failed.
          -0 checkstyle 0m 23s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 5 new + 106 unchanged - 3 fixed = 111 total (was 109)
          -1 mvnsite 0m 29s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 17s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 javadoc 0m 18s the patch passed
          -1 unit 0m 28s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          20m 29s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-6280
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12855848/YARN-6280.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f5a0904d02ab 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / eb5a179
          Default Java 1.8.0_121
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/15152/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/15152/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/15152/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15152/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/15152/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15152/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15152/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15152/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15152/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 12m 34s trunk passed +1 compile 0m 31s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 32s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 58s trunk passed +1 javadoc 0m 20s trunk passed -1 mvninstall 0m 28s hadoop-yarn-server-resourcemanager in the patch failed. -1 compile 0m 27s hadoop-yarn-server-resourcemanager in the patch failed. -1 javac 0m 27s hadoop-yarn-server-resourcemanager in the patch failed. -0 checkstyle 0m 23s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 5 new + 106 unchanged - 3 fixed = 111 total (was 109) -1 mvnsite 0m 29s hadoop-yarn-server-resourcemanager in the patch failed. +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 17s hadoop-yarn-server-resourcemanager in the patch failed. +1 javadoc 0m 18s the patch passed -1 unit 0m 28s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 20m 29s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12855848/YARN-6280.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f5a0904d02ab 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / eb5a179 Default Java 1.8.0_121 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/15152/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/15152/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/15152/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15152/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/15152/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15152/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15152/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15152/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15152/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 14m 12s trunk passed
          +1 compile 0m 32s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 34s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 0m 59s trunk passed
          +1 javadoc 0m 21s trunk passed
          -1 mvninstall 0m 28s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 compile 0m 28s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 javac 0m 28s hadoop-yarn-server-resourcemanager in the patch failed.
          -0 checkstyle 0m 23s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 5 new + 105 unchanged - 3 fixed = 110 total (was 108)
          -1 mvnsite 0m 29s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 17s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 javadoc 0m 18s the patch passed
          -1 unit 0m 27s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          22m 20s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-6280
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12855852/YARN-6280.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4c060c50ea10 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / eb5a179
          Default Java 1.8.0_121
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/15153/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/15153/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/15153/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15153/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/15153/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15153/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15153/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15153/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15153/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 12s trunk passed +1 compile 0m 32s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 34s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 59s trunk passed +1 javadoc 0m 21s trunk passed -1 mvninstall 0m 28s hadoop-yarn-server-resourcemanager in the patch failed. -1 compile 0m 28s hadoop-yarn-server-resourcemanager in the patch failed. -1 javac 0m 28s hadoop-yarn-server-resourcemanager in the patch failed. -0 checkstyle 0m 23s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 5 new + 105 unchanged - 3 fixed = 110 total (was 108) -1 mvnsite 0m 29s hadoop-yarn-server-resourcemanager in the patch failed. +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 17s hadoop-yarn-server-resourcemanager in the patch failed. +1 javadoc 0m 18s the patch passed -1 unit 0m 27s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 22m 20s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12855852/YARN-6280.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4c060c50ea10 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / eb5a179 Default Java 1.8.0_121 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/15153/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/15153/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/15153/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15153/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/15153/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15153/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15153/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15153/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15153/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 13m 50s trunk passed
          +1 compile 0m 34s trunk passed
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 0m 36s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 1m 5s trunk passed
          +1 javadoc 0m 23s trunk passed
          +1 mvninstall 0m 33s the patch passed
          +1 compile 0m 32s the patch passed
          +1 javac 0m 32s the patch passed
          -0 checkstyle 0m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132)
          +1 mvnsite 0m 33s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 11s the patch passed
          +1 javadoc 0m 20s the patch passed
          -1 unit 41m 9s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          64m 5s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-6280
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12856058/YARN-6280.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 5cbf38cd38d3 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c1386a9
          Default Java 1.8.0_121
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15174/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15174/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15174/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15174/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 13m 50s trunk passed +1 compile 0m 34s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 36s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 5s trunk passed +1 javadoc 0m 23s trunk passed +1 mvninstall 0m 33s the patch passed +1 compile 0m 32s the patch passed +1 javac 0m 32s the patch passed -0 checkstyle 0m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132) +1 mvnsite 0m 33s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 11s the patch passed +1 javadoc 0m 20s the patch passed -1 unit 41m 9s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 64m 5s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12856058/YARN-6280.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5cbf38cd38d3 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c1386a9 Default Java 1.8.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15174/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15174/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15174/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15174/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          +1 for the issue. This is causing payload of app object to become heavy.
          cc :/ Sunil G

          Show
          rohithsharma Rohith Sharma K S added a comment - +1 for the issue. This is causing payload of app object to become heavy. cc :/ Sunil G
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          In get app API, ResourceRequest is embedded by default. So, should filter be inverted i.e hideResourceRequest?

          Show
          rohithsharma Rohith Sharma K S added a comment - In get app API, ResourceRequest is embedded by default. So, should filter be inverted i.e hideResourceRequest?
          Hide
          zhaoyunjiong yunjiong zhao added a comment -

          How about change the default behavior to hide ResouceRequest?

          Show
          zhaoyunjiong yunjiong zhao added a comment - How about change the default behavior to hide ResouceRequest?
          Hide
          cltlfcjin Lantao Jin added a comment -

          Agree with yunjiong zhao. Need more suggestions from community. Is it acceptable from API compatibility side?

          Show
          cltlfcjin Lantao Jin added a comment - Agree with yunjiong zhao . Need more suggestions from community. Is it acceptable from API compatibility side?
          Hide
          cltlfcjin Lantao Jin added a comment -

          Hi Sunil G, could you review this when you get a chance?

          Show
          cltlfcjin Lantao Jin added a comment - Hi Sunil G , could you review this when you get a chance?
          Hide
          sunilg Sunil G added a comment -

          Lantao Jin
          Thanks for the patch.

          I think we need to keep the default behavior as it exists from 2.7 onwards. As Rohith Sharma K S suggested, lets have hideResourceRequest as a query param instead of showResourceRequest. By default, we can keep hideResourceRequest as false. So we will serve apps with ResourceRequests always. If query param hideResourceRequest is given as true, we will skip it and reply. We can document and advise to use this filter when issues like this occurs.

          Show
          sunilg Sunil G added a comment - Lantao Jin Thanks for the patch. I think we need to keep the default behavior as it exists from 2.7 onwards. As Rohith Sharma K S suggested, lets have hideResourceRequest as a query param instead of showResourceRequest . By default, we can keep hideResourceRequest as false. So we will serve apps with ResourceRequests always. If query param hideResourceRequest is given as true, we will skip it and reply. We can document and advise to use this filter when issues like this occurs.
          Hide
          cltlfcjin Lantao Jin added a comment -

          Hi Sunil G, I've updated the parameter with hideResourceRequest in file 004.patch.

          Show
          cltlfcjin Lantao Jin added a comment - Hi Sunil G , I've updated the parameter with hideResourceRequest in file 004.patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 22s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 13m 30s trunk passed
          +1 compile 0m 37s trunk passed
          +1 checkstyle 0m 30s trunk passed
          +1 mvnsite 0m 39s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 1m 18s trunk passed
          +1 javadoc 0m 26s trunk passed
          +1 mvninstall 0m 44s the patch passed
          +1 compile 0m 43s the patch passed
          +1 javac 0m 43s the patch passed
          -0 checkstyle 0m 30s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132)
          +1 mvnsite 0m 45s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 36s the patch passed
          +1 javadoc 0m 26s the patch passed
          -1 unit 42m 27s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          66m 50s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestResourceTrackerService
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-6280
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12858667/YARN-6280.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux cb2bdacea810 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 34424e9
          Default Java 1.8.0_121
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15265/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15265/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15265/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15265/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 13m 30s trunk passed +1 compile 0m 37s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 0m 39s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 18s trunk passed +1 javadoc 0m 26s trunk passed +1 mvninstall 0m 44s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed -0 checkstyle 0m 30s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132) +1 mvnsite 0m 45s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 36s the patch passed +1 javadoc 0m 26s the patch passed -1 unit 42m 27s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 66m 50s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestResourceTrackerService   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12858667/YARN-6280.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cb2bdacea810 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 34424e9 Default Java 1.8.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15265/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15265/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15265/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15265/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 12m 32s trunk passed
          +1 compile 0m 33s trunk passed
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 0m 34s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 1s trunk passed
          +1 javadoc 0m 21s trunk passed
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 30s the patch passed
          +1 javac 0m 30s the patch passed
          -0 checkstyle 0m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132)
          +1 mvnsite 0m 32s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 4s the patch passed
          +1 javadoc 0m 18s the patch passed
          -1 unit 39m 32s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          60m 43s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps
            hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-6280
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12858669/YARN-6280.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 85801377aa69 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 34424e9
          Default Java 1.8.0_121
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15266/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15266/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15266/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15266/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 12m 32s trunk passed +1 compile 0m 33s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 34s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 1s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 32s the patch passed +1 compile 0m 30s the patch passed +1 javac 0m 30s the patch passed -0 checkstyle 0m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132) +1 mvnsite 0m 32s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 4s the patch passed +1 javadoc 0m 18s the patch passed -1 unit 39m 32s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 60m 43s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps   hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12858669/YARN-6280.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 85801377aa69 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 34424e9 Default Java 1.8.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15266/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15266/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15266/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15266/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 14m 11s trunk passed
          +1 compile 0m 35s trunk passed
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 0m 37s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 5s trunk passed
          +1 javadoc 0m 22s trunk passed
          +1 mvninstall 0m 33s the patch passed
          +1 compile 0m 32s the patch passed
          +1 javac 0m 32s the patch passed
          -0 checkstyle 0m 26s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132)
          +1 mvnsite 0m 34s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 12s the patch passed
          +1 javadoc 0m 19s the patch passed
          -1 unit 41m 0s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          64m 23s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler
            hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-6280
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12858862/YARN-6280.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f3d53ced3aa6 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / bb6a214
          Default Java 1.8.0_121
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15287/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15287/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15287/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15287/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 14m 11s trunk passed +1 compile 0m 35s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 37s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 5s trunk passed +1 javadoc 0m 22s trunk passed +1 mvninstall 0m 33s the patch passed +1 compile 0m 32s the patch passed +1 javac 0m 32s the patch passed -0 checkstyle 0m 26s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132) +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 12s the patch passed +1 javadoc 0m 19s the patch passed -1 unit 41m 0s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 64m 23s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12858862/YARN-6280.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f3d53ced3aa6 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bb6a214 Default Java 1.8.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15287/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15287/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15287/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15287/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cltlfcjin Lantao Jin added a comment -

          Does the failed test cases caused by my patch? Seems the failed parts are unconcerned about it. Sunil G

          Show
          cltlfcjin Lantao Jin added a comment - Does the failed test cases caused by my patch? Seems the failed parts are unconcerned about it. Sunil G
          Hide
          sunilg Sunil G added a comment -

          Thsi test case failure seems related.
          https://builds.apache.org/job/PreCommit-YARN-Build/15287/testReport/org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity/TestCapacityScheduler/testAMLimitUsage/

          org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler.testAMLimitUsage
          
          Failing for the past 1 build (Since Failed#15287 )
          Took 0.23 sec.
          Stacktrace
          
          java.lang.reflect.UndeclaredThrowableException: null
          	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils.validateResourceRequest(SchedulerUtils.java:253)
          	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils.normalizeAndValidateRequest(SchedulerUtils.java:218)
          	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils.normalizeAndValidateRequest(SchedulerUtils.java:189)
          	at org.apache.hadoop.yarn.server.resourcemanager.RMAppManager.validateAndCreateResourceRequest(RMAppManager.java:497)
          	at org.apache.hadoop.yarn.server.resourcemanager.RMAppManager.createAndPopulateNewRMApp(RMAppManager.java:384)
          	at org.apache.hadoop.yarn.server.resourcemanager.RMAppManager.submitApplication(RMAppManager.java:295)
          	at org.apache.hadoop.yarn.server.resourcemanager.ClientRMService.submitApplication(ClientRMService.java:664)
          	at org.apache.hadoop.yarn.server.resourcemanager.MockRM$2.run(MockRM.java:752)
          	at org.apache.hadoop.yarn.server.resourcemanager.MockRM$2.run(MockRM.java:746)
          	at java.security.AccessController.doPrivileged(Native Method)
          	at javax.security.auth.Subject.doAs(Subject.java:422)
          	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1965)
          	at org.apache.hadoop.yarn.server.resourcemanager.MockRM.submitApp(MockRM.java:765)
          	at org.apache.hadoop.yarn.server.resourcemanager.MockRM.submitApp(MockRM.java:665)
          	at org.apache.hadoop.yarn.server.resourcemanager.MockRM.submitApp(MockRM.java:572)
          	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler.verifyAMLimitForLeafQueue(TestCapacityScheduler.java:3570)
          	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler.testAMLimitUsage(TestCapacityScheduler.java:3432)
          
          Show
          sunilg Sunil G added a comment - Thsi test case failure seems related. https://builds.apache.org/job/PreCommit-YARN-Build/15287/testReport/org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity/TestCapacityScheduler/testAMLimitUsage/ org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler.testAMLimitUsage Failing for the past 1 build (Since Failed#15287 ) Took 0.23 sec. Stacktrace java.lang.reflect.UndeclaredThrowableException: null at org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils.validateResourceRequest(SchedulerUtils.java:253) at org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils.normalizeAndValidateRequest(SchedulerUtils.java:218) at org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils.normalizeAndValidateRequest(SchedulerUtils.java:189) at org.apache.hadoop.yarn.server.resourcemanager.RMAppManager.validateAndCreateResourceRequest(RMAppManager.java:497) at org.apache.hadoop.yarn.server.resourcemanager.RMAppManager.createAndPopulateNewRMApp(RMAppManager.java:384) at org.apache.hadoop.yarn.server.resourcemanager.RMAppManager.submitApplication(RMAppManager.java:295) at org.apache.hadoop.yarn.server.resourcemanager.ClientRMService.submitApplication(ClientRMService.java:664) at org.apache.hadoop.yarn.server.resourcemanager.MockRM$2.run(MockRM.java:752) at org.apache.hadoop.yarn.server.resourcemanager.MockRM$2.run(MockRM.java:746) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1965) at org.apache.hadoop.yarn.server.resourcemanager.MockRM.submitApp(MockRM.java:765) at org.apache.hadoop.yarn.server.resourcemanager.MockRM.submitApp(MockRM.java:665) at org.apache.hadoop.yarn.server.resourcemanager.MockRM.submitApp(MockRM.java:572) at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler.verifyAMLimitForLeafQueue(TestCapacityScheduler.java:3570) at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler.testAMLimitUsage(TestCapacityScheduler.java:3432)
          Hide
          sunilg Sunil G added a comment -

          Thank you for the patch. Some general comments

          1. hideResourceRequest could be used everywhere instead of mixing up with skipResourceRequest. Any of this is fine, and we can use that in all file.
          2. Could you add a code comment near the new if check in AppInfo where we skip adding resource requests. This will help to mention whats default and the behavior.

          Show
          sunilg Sunil G added a comment - Thank you for the patch. Some general comments 1. hideResourceRequest could be used everywhere instead of mixing up with skipResourceRequest. Any of this is fine, and we can use that in all file. 2. Could you add a code comment near the new if check in AppInfo where we skip adding resource requests. This will help to mention whats default and the behavior.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Lantao Jin thanks for your contribution, this is very useful and related to YARN-6285. Added you to contributor list and assigned JIRA to you.

          Show
          leftnoteasy Wangda Tan added a comment - Lantao Jin thanks for your contribution, this is very useful and related to YARN-6285 . Added you to contributor list and assigned JIRA to you.
          Hide
          cltlfcjin Lantao Jin added a comment -

          Thanks Sunil G, now the 006.patch succeeded in my side via dev-support/bin/test-patch

          Show
          cltlfcjin Lantao Jin added a comment - Thanks Sunil G , now the 006.patch succeeded in my side via dev-support/bin/test-patch
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 11m 44s trunk passed
          +1 compile 0m 31s trunk passed
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 0m 32s trunk passed
          +1 mvneclipse 0m 11s trunk passed
          +1 findbugs 0m 58s trunk passed
          +1 javadoc 0m 19s trunk passed
          +1 mvninstall 0m 29s the patch passed
          +1 compile 0m 25s the patch passed
          +1 javac 0m 25s the patch passed
          -0 checkstyle 0m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 4 new + 133 unchanged - 3 fixed = 137 total (was 136)
          +1 mvnsite 0m 27s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 6s the patch passed
          +1 javadoc 0m 15s the patch passed
          -1 unit 38m 24s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 15s The patch does not generate ASF License warnings.
          58m 4s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-6280
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862419/YARN-6280.006.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 18598fb632eb 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e7167e4
          Default Java 1.8.0_121
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15556/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15556/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15556/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15556/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 11m 44s trunk passed +1 compile 0m 31s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 32s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 0m 58s trunk passed +1 javadoc 0m 19s trunk passed +1 mvninstall 0m 29s the patch passed +1 compile 0m 25s the patch passed +1 javac 0m 25s the patch passed -0 checkstyle 0m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 4 new + 133 unchanged - 3 fixed = 137 total (was 136) +1 mvnsite 0m 27s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 6s the patch passed +1 javadoc 0m 15s the patch passed -1 unit 38m 24s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 58m 4s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862419/YARN-6280.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 18598fb632eb 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e7167e4 Default Java 1.8.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15556/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15556/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15556/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15556/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          +1. LGTM.
          Rohith Sharma K S, do you have some more comments ?

          Show
          sunilg Sunil G added a comment - +1. LGTM. Rohith Sharma K S , do you have some more comments ?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 14m 19s trunk passed
          +1 compile 0m 37s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 39s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          +1 findbugs 1m 3s trunk passed
          +1 javadoc 0m 21s trunk passed
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 31s the patch passed
          +1 javac 0m 31s the patch passed
          -0 checkstyle 0m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 4 new + 133 unchanged - 3 fixed = 137 total (was 136)
          +1 mvnsite 0m 34s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 5s the patch passed
          +1 javadoc 0m 19s the patch passed
          -1 unit 38m 48s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          62m 13s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:612578f
          JIRA Issue YARN-6280
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862657/YARN-6280.007.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 816e08039646 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 443aa51
          Default Java 1.8.0_121
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15565/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15565/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15565/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15565/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 14m 19s trunk passed +1 compile 0m 37s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 39s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 3s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 32s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed -0 checkstyle 0m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 4 new + 133 unchanged - 3 fixed = 137 total (was 136) +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 5s the patch passed +1 javadoc 0m 19s the patch passed -1 unit 38m 48s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 62m 13s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:612578f JIRA Issue YARN-6280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862657/YARN-6280.007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 816e08039646 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 443aa51 Default Java 1.8.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15565/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15565/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15565/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15565/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cltlfcjin Lantao Jin added a comment -

          Sunil G Seems this unit test failure also can reproduce in a clean working directory:

          Failed tests:
          TestRMRestart.testFinishedAppRemovalAfterRMRestart:1673 expected null, but was:<submit_time: 1491818079324 application_submission_context { application_id

          Unknown macro: { id}

          application_name: "" queue: "default" priority

          Unknown macro: { priority}

          am_container_spec { } cancel_tokens_when_complete: true maxAppAttempts: 2 resource

          Unknown macro: { memory}

          applicationType: "YARN" keep_containers_across_application_attempts: false attempt_failures_validity_interval: 0 am_container_resource_request { priority

          Unknown macro: { priority}

          resource_name: "*" capability

          Unknown macro: { memory}

          num_containers: 1 relax_locality: true node_label_expression: "" execution_type_request

          Unknown macro: { execution_type}

          } } user: "lajin" start_time: 1491818079325 application_state: RMAPP_FINISHED finish_time: 1491818079360>

          Tests run: 30, Failures: 1, Errors: 0, Skipped: 0

          [INFO] ------------------------------------------------------------------------
          [INFO] BUILD FAILURE
          [INFO] ------------------------------------------------------------------------
          [INFO] Total time: 01:33 min
          [INFO] Finished at: 2017-04-10T02:54:39-07:00
          [INFO] Final Memory: 60M/1073M
          [INFO] ------------------------------------------------------------------------
          [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project hadoop-yarn-server-resourcemanager: There are test failures.
          [ERROR]
          [ERROR] Please refer to /home/lajin/git/apache/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/target/surefire-reports for the individual test results.
          [ERROR] -> [Help 1]
          [ERROR]
          [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [ERROR]
          [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
          [lajin@apache-3913 hadoop-yarn-server-resourcemanager]$ git status

          1. On branch trunk
            nothing to commit, working directory clean
            [lajin@apache-3913 hadoop-yarn-server-resourcemanager]$
          Show
          cltlfcjin Lantao Jin added a comment - Sunil G Seems this unit test failure also can reproduce in a clean working directory: Failed tests: TestRMRestart.testFinishedAppRemovalAfterRMRestart:1673 expected null, but was:<submit_time: 1491818079324 application_submission_context { application_id Unknown macro: { id} application_name: "" queue: "default" priority Unknown macro: { priority} am_container_spec { } cancel_tokens_when_complete: true maxAppAttempts: 2 resource Unknown macro: { memory} applicationType: "YARN" keep_containers_across_application_attempts: false attempt_failures_validity_interval: 0 am_container_resource_request { priority Unknown macro: { priority} resource_name: "*" capability Unknown macro: { memory} num_containers: 1 relax_locality: true node_label_expression: "" execution_type_request Unknown macro: { execution_type} } } user: "lajin" start_time: 1491818079325 application_state: RMAPP_FINISHED finish_time: 1491818079360> Tests run: 30, Failures: 1, Errors: 0, Skipped: 0 [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:33 min [INFO] Finished at: 2017-04-10T02:54:39-07:00 [INFO] Final Memory: 60M/1073M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project hadoop-yarn-server-resourcemanager: There are test failures. [ERROR] [ERROR] Please refer to /home/lajin/git/apache/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/target/surefire-reports for the individual test results. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [lajin@apache-3913 hadoop-yarn-server-resourcemanager] $ git status On branch trunk nothing to commit, working directory clean [lajin@apache-3913 hadoop-yarn-server-resourcemanager] $
          Hide
          cltlfcjin Lantao Jin added a comment -

          Is it due to YARN-5548?

          Show
          cltlfcjin Lantao Jin added a comment - Is it due to YARN-5548 ?
          Hide
          sunilg Sunil G added a comment -

          YARN-5548 is tracking and it should be a better way to handle the pblm.
          In one of above jenkins, there was a failure in TestCapacityScheduler.testAMLimitUsage. See this comment. I guess thats fixed by you already rt.

          Show
          sunilg Sunil G added a comment - YARN-5548 is tracking and it should be a better way to handle the pblm. In one of above jenkins, there was a failure in TestCapacityScheduler.testAMLimitUsage. See this comment . I guess thats fixed by you already rt.
          Hide
          cltlfcjin Lantao Jin added a comment -

          So, nothing to do from my side except waiting YARN-5548 to be done?Sunil G

          Show
          cltlfcjin Lantao Jin added a comment - So, nothing to do from my side except waiting YARN-5548 to be done? Sunil G
          Hide
          sunilg Sunil G added a comment - - edited

          Thats not required. We could push this in since its a known failure and we can make it pass locally.
          However I ll run jenkins one more time before checking this in.

          Show
          sunilg Sunil G added a comment - - edited Thats not required. We could push this in since its a known failure and we can make it pass locally. However I ll run jenkins one more time before checking this in.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 14m 14s trunk passed
          +1 compile 0m 36s trunk passed
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 0m 38s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          +1 findbugs 1m 6s trunk passed
          +1 javadoc 0m 22s trunk passed
          +1 mvninstall 0m 33s the patch passed
          +1 compile 0m 32s the patch passed
          +1 javac 0m 32s the patch passed
          -0 checkstyle 0m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 4 new + 133 unchanged - 3 fixed = 137 total (was 136)
          +1 mvnsite 0m 36s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 9s the patch passed
          +1 javadoc 0m 19s the patch passed
          +1 unit 39m 9s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          62m 46s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ac17dc
          JIRA Issue YARN-6280
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862657/YARN-6280.007.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 2b55779b1ef6 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6b015d0
          Default Java 1.8.0_121
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15672/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15672/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15672/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 14m 14s trunk passed +1 compile 0m 36s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 0m 38s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 6s trunk passed +1 javadoc 0m 22s trunk passed +1 mvninstall 0m 33s the patch passed +1 compile 0m 32s the patch passed +1 javac 0m 32s the patch passed -0 checkstyle 0m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 4 new + 133 unchanged - 3 fixed = 137 total (was 136) +1 mvnsite 0m 36s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 9s the patch passed +1 javadoc 0m 19s the patch passed +1 unit 39m 9s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 62m 46s Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue YARN-6280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862657/YARN-6280.007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2b55779b1ef6 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6b015d0 Default Java 1.8.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15672/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15672/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15672/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jianhe Jian He added a comment -

          one minor comment: how about making this generic by adding an param like: unselect="resourceRequests,..", which takes a list of unselected fields.
          This is more flexible and can be used to strip off more fields if there's such use case in future.

          Show
          jianhe Jian He added a comment - one minor comment: how about making this generic by adding an param like: unselect="resourceRequests,..", which takes a list of unselected fields. This is more flexible and can be used to strip off more fields if there's such use case in future.
          Hide
          sunilg Sunil G added a comment -

          Thanks Jian He for the comment.

          So do you mean to add something like this.
          @QueryParam("deSelect") and the String associated with this could be comma separated.

          Something like deSelect=resourceRequests,resourceReport. If some entries are here, we should hide them. Correct?
          But I have couple of doubts here:

          1. these option has to be pre-defined. Currently we support only to hide resourceRequests. So even if other options are given, we have to skip them.
          2. How can we inform user that which are all valid entries we can deselect? May be documentation?
          Show
          sunilg Sunil G added a comment - Thanks Jian He for the comment. So do you mean to add something like this. @QueryParam("deSelect") and the String associated with this could be comma separated. Something like deSelect=resourceRequests,resourceReport . If some entries are here, we should hide them. Correct? But I have couple of doubts here: these option has to be pre-defined. Currently we support only to hide resourceRequests. So even if other options are given, we have to skip them. How can we inform user that which are all valid entries we can deselect? May be documentation?
          Hide
          jianhe Jian He added a comment -

          yes, it would be like "unselect=ResourceRequests", we definitely need to document this then.
          Similarly, it can have select options, but that's not required now.

          Show
          jianhe Jian He added a comment - yes, it would be like "unselect=ResourceRequests", we definitely need to document this then. Similarly, it can have select options, but that's not required now.
          Hide
          cltlfcjin Lantao Jin added a comment -

          Hi Sunil G, what do you think? Should it be opened a new ticket or be changed here (ticket title may need to change)?

          Show
          cltlfcjin Lantao Jin added a comment - Hi Sunil G , what do you think? Should it be opened a new ticket or be changed here (ticket title may need to change)?
          Hide
          sunilg Sunil G added a comment -

          I think its a generalized approach and its better to handle here.
          We could change the name of the title. Even in future, if we need to deselect some entries, we can use this. So its better option.

          Show
          sunilg Sunil G added a comment - I think its a generalized approach and its better to handle here. We could change the name of the title. Even in future, if we need to deselect some entries, we can use this. So its better option.
          Hide
          cltlfcjin Lantao Jin added a comment -

          Upload YARN-6280.008.patch for making it generic. Please code review.

          Show
          cltlfcjin Lantao Jin added a comment - Upload YARN-6280 .008.patch for making it generic. Please code review.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 13m 8s trunk passed
          +1 compile 0m 32s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 34s trunk passed
          +1 mvneclipse 0m 17s trunk passed
          -1 findbugs 0m 56s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in trunk has 8 extant Findbugs warnings.
          +1 javadoc 0m 21s trunk passed
          +1 mvninstall 0m 31s the patch passed
          +1 compile 0m 28s the patch passed
          +1 javac 0m 28s the patch passed
          -0 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 8 new + 110 unchanged - 2 fixed = 118 total (was 112)
          +1 mvnsite 0m 31s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 59s the patch passed
          +1 javadoc 0m 17s the patch passed
          +1 unit 40m 37s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          62m 18s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ac17dc
          JIRA Issue YARN-6280
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865343/YARN-6280.008.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 38270796e8d0 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 61cda39e
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15761/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15761/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15761/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15761/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 13m 8s trunk passed +1 compile 0m 32s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 34s trunk passed +1 mvneclipse 0m 17s trunk passed -1 findbugs 0m 56s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in trunk has 8 extant Findbugs warnings. +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 31s the patch passed +1 compile 0m 28s the patch passed +1 javac 0m 28s the patch passed -0 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 8 new + 110 unchanged - 2 fixed = 118 total (was 112) +1 mvnsite 0m 31s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 59s the patch passed +1 javadoc 0m 17s the patch passed +1 unit 40m 37s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 62m 18s Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue YARN-6280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865343/YARN-6280.008.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 38270796e8d0 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 61cda39e Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15761/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15761/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15761/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15761/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cltlfcjin Lantao Jin added a comment -

          I checked the report of findbugs and seems none of the listed items related to my patch...

          Show
          cltlfcjin Lantao Jin added a comment - I checked the report of findbugs and seems none of the listed items related to my patch...
          Hide
          cltlfcjin Lantao Jin added a comment -

          Sunil G, could you please do the code review and run the jenkins? The failures detected by findbugs kept in trunk for a while.

          Show
          cltlfcjin Lantao Jin added a comment - Sunil G , could you please do the code review and run the jenkins? The failures detected by findbugs kept in trunk for a while.
          Hide
          sunilg Sunil G added a comment -

          Thanks Lantao Jin

          Few comments

          1. DeSelectQuery.java could be inside webapp package itself. I do not think its a common api class yet.
          2. DeSelectQuery. I think setDeSelect need not have to be invoked from constructor. This method cud throw some exceptions, so it may be better as a separate public method which could be invoked from RMWebService api.
          3. Java doc for DeSelectParam could be more descriptive and could explain abt possible params which are supported now.
          4. In setDeSelect exception block, currently LOG.info is used. It could be warn.
          5. in below code
            43	    if (deSelect != null && !deSelect.isEmpty()) {
            44	      for (String query : deSelect) {
            45	        if (query != null && !query.trim().isEmpty()) {
            

            I think query wont be null here. u may skip that. in first if condition, i think deSelect.isEmpty() could be avoided. for loop will skip if deSelect is empty. What you need is just check for null against deSelect. Its better a simple null check could be added and return directly.

          6. Currently you have mentioned resourceRequests could be set in deSelect. Thinking out loud, is it more error prone or tougher for user to give exact resourceRequests. Could we name it resource-requests ? thoughts
          Show
          sunilg Sunil G added a comment - Thanks Lantao Jin Few comments DeSelectQuery.java could be inside webapp package itself. I do not think its a common api class yet. DeSelectQuery . I think setDeSelect need not have to be invoked from constructor. This method cud throw some exceptions, so it may be better as a separate public method which could be invoked from RMWebService api. Java doc for DeSelectParam could be more descriptive and could explain abt possible params which are supported now. In setDeSelect exception block, currently LOG.info is used. It could be warn. in below code 43 if (deSelect != null && !deSelect.isEmpty()) { 44 for ( String query : deSelect) { 45 if (query != null && !query.trim().isEmpty()) { I think query wont be null here. u may skip that. in first if condition, i think deSelect.isEmpty() could be avoided. for loop will skip if deSelect is empty. What you need is just check for null against deSelect. Its better a simple null check could be added and return directly. Currently you have mentioned resourceRequests could be set in deSelect . Thinking out loud, is it more error prone or tougher for user to give exact resourceRequests . Could we name it resource-requests ? thoughts
          Hide
          cltlfcjin Lantao Jin added a comment -

          Thanks Sunil G. About (6), the reason use exact resourceRequests is from the result of REST API.
          http://<rm http address:port>/ws/v1/cluster/apps?states=running,accepted&limit=2

          <resourceRequests>
          <capability>
          <memory>4096</memory>
          <virtualCores>1</virtualCores>
          </capability>
          <nodeLabelExpression/>
          <numContainers>0</numContainers>
          <priority>
          <priority>0</priority>
          </priority>
          <relaxLocality>true</relaxLocality>
          <resourceName>*</resourceName>
          </resourceRequests>
          <resourceRequests>
          <capability>
          <memory>2816</memory>
          <virtualCores>1</virtualCores>
          </capability>
          <nodeLabelExpression/>
          <numContainers>0</numContainers>
          <priority>
          <priority>20</priority>
          </priority>
          <relaxLocality>true</relaxLocality>
          <resourceName>datanode1</resourceName>
          </resourceRequests>
          <resourceRequests>
          <capability>
          <memory>2816</memory>
          <virtualCores>1</virtualCores>
          </capability>
          <nodeLabelExpression/>
          <numContainers>0</numContainers>
          <priority>
          <priority>20</priority>
          </priority>
          <relaxLocality>true</relaxLocality>
          <resourceName>datanode2</resourceName>
          </resourceRequests>

          I thing this is the element what a user wants to reduce. But if it described in documentation, resource-requests is more friendly to user.

          Show
          cltlfcjin Lantao Jin added a comment - Thanks Sunil G . About (6), the reason use exact resourceRequests is from the result of REST API. http://<rm http address:port>/ws/v1/cluster/apps?states=running,accepted&limit=2 <resourceRequests> <capability> <memory>4096</memory> <virtualCores>1</virtualCores> </capability> <nodeLabelExpression/> <numContainers>0</numContainers> <priority> <priority>0</priority> </priority> <relaxLocality>true</relaxLocality> <resourceName>*</resourceName> </resourceRequests> <resourceRequests> <capability> <memory>2816</memory> <virtualCores>1</virtualCores> </capability> <nodeLabelExpression/> <numContainers>0</numContainers> <priority> <priority>20</priority> </priority> <relaxLocality>true</relaxLocality> <resourceName>datanode1</resourceName> </resourceRequests> <resourceRequests> <capability> <memory>2816</memory> <virtualCores>1</virtualCores> </capability> <nodeLabelExpression/> <numContainers>0</numContainers> <priority> <priority>20</priority> </priority> <relaxLocality>true</relaxLocality> <resourceName>datanode2</resourceName> </resourceRequests> I thing this is the element what a user wants to reduce. But if it described in documentation, resource-requests is more friendly to user.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 15m 9s trunk passed
          +1 compile 0m 37s trunk passed
          +1 checkstyle 0m 30s trunk passed
          +1 mvnsite 0m 39s trunk passed
          +1 mvneclipse 0m 19s trunk passed
          +1 findbugs 1m 10s trunk passed
          +1 javadoc 0m 24s trunk passed
          +1 mvninstall 0m 43s the patch passed
          +1 compile 0m 42s the patch passed
          +1 javac 0m 42s the patch passed
          -0 checkstyle 0m 28s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 9 new + 110 unchanged - 2 fixed = 119 total (was 112)
          +1 mvnsite 0m 44s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 19s the patch passed
          +1 javadoc 0m 26s the patch passed
          -1 unit 47m 13s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          73m 5s



          Reason Tests
          Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestRMStoreCommands
            org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA
            org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA
            org.apache.hadoop.yarn.server.resourcemanager.TestRMHAForNodeLabels



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6280
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867369/YARN-6280.009.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 48c28faf8ae5 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1e71fe8
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15894/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15894/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15894/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15894/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 15m 9s trunk passed +1 compile 0m 37s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 0m 39s trunk passed +1 mvneclipse 0m 19s trunk passed +1 findbugs 1m 10s trunk passed +1 javadoc 0m 24s trunk passed +1 mvninstall 0m 43s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed -0 checkstyle 0m 28s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 9 new + 110 unchanged - 2 fixed = 119 total (was 112) +1 mvnsite 0m 44s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 19s the patch passed +1 javadoc 0m 26s the patch passed -1 unit 47m 13s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 73m 5s Reason Tests Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestRMStoreCommands   org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA   org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA   org.apache.hadoop.yarn.server.resourcemanager.TestRMHAForNodeLabels Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867369/YARN-6280.009.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 48c28faf8ae5 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1e71fe8 Default Java 1.8.0_121 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15894/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15894/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15894/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15894/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cltlfcjin Lantao Jin added a comment -

          The timeout unit tests on my side seem all good:

          Running org.apache.hadoop.yarn.server.resourcemanager.TestRMStoreCommands
          Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.137 sec - in org.apache.hadoop.yarn.server.resourcemanager.TestRMStoreCommands

          Running org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA
          Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.708 sec - in org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA

          Running org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA
          Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.601 sec - in org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA

          Running org.apache.hadoop.yarn.server.resourcemanager.TestRMHAForNodeLabels
          Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.372 sec - in org.apache.hadoop.yarn.server.resourcemanager.TestRMHAForNodeLabels

          Show
          cltlfcjin Lantao Jin added a comment - The timeout unit tests on my side seem all good: Running org.apache.hadoop.yarn.server.resourcemanager.TestRMStoreCommands Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.137 sec - in org.apache.hadoop.yarn.server.resourcemanager.TestRMStoreCommands Running org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.708 sec - in org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA Running org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.601 sec - in org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA Running org.apache.hadoop.yarn.server.resourcemanager.TestRMHAForNodeLabels Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.372 sec - in org.apache.hadoop.yarn.server.resourcemanager.TestRMHAForNodeLabels
          Hide
          sunilg Sunil G added a comment -

          the reason use exact resourceRequests is from the result of REST API.

          Yes. Makes sense to me.

          One more nit:
          In current patch while parsing for DeSelectParam with Enum#valueOf, you were using RunTimeException to get errors. Usually IllegalArgumentException is used if the specified enum type has no constant with the specified name, or the specified class object does not represent an enum type. IllegalArgumentException is a type of RunTimeException, but any other reasons other than this?

          Show
          sunilg Sunil G added a comment - the reason use exact resourceRequests is from the result of REST API. Yes. Makes sense to me. One more nit: In current patch while parsing for DeSelectParam with Enum#valueOf , you were using RunTimeException to get errors. Usually IllegalArgumentException is used if the specified enum type has no constant with the specified name, or the specified class object does not represent an enum type. IllegalArgumentException is a type of RunTimeException, but any other reasons other than this?
          Hide
          cltlfcjin Lantao Jin added a comment -

          Sunil G, Enum#valueOf could throw NPE as well if the param is null. However, here I have verified this condition and IllegalArgumentException is enough. Use RunTimeException is just for simple because whatever it is, it will change to BadRequestException. Should I change back to IAE here?

          Show
          cltlfcjin Lantao Jin added a comment - Sunil G , Enum#valueOf could throw NPE as well if the param is null. However, here I have verified this condition and IllegalArgumentException is enough. Use RunTimeException is just for simple because whatever it is, it will change to BadRequestException . Should I change back to IAE here?
          Hide
          sunilg Sunil G added a comment -

          I think its fine. Rohith Sharma K S, any further comments?

          Show
          sunilg Sunil G added a comment - I think its fine. Rohith Sharma K S , any further comments?
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Overall patch looks good. Some nits

          1. DeSelectParam enum values change to upper case. It will be consistent across all other enum classes.
          2. Can you add JavaDoc for this change? you need to edit ResourceManagerRest.md
          3. Does DeSelectQuery --> DeSelectFields make sense?
          4. Instead of deSelectXYZ methods adding every time, there can be a contains() method which validate enum value.
          Show
          rohithsharma Rohith Sharma K S added a comment - Overall patch looks good. Some nits DeSelectParam enum values change to upper case. It will be consistent across all other enum classes. Can you add JavaDoc for this change? you need to edit ResourceManagerRest.md Does DeSelectQuery --> DeSelectFields make sense? Instead of deSelectXYZ methods adding every time, there can be a contains() method which validate enum value.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 51s Maven dependency ordering for branch
          +1 mvninstall 15m 12s trunk passed
          +1 compile 9m 14s trunk passed
          +1 checkstyle 0m 57s trunk passed
          +1 mvnsite 1m 7s trunk passed
          +1 mvneclipse 0m 40s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 1m 19s trunk passed
          +1 javadoc 0m 47s trunk passed
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 0m 45s the patch passed
          +1 compile 8m 18s the patch passed
          +1 javac 8m 18s the patch passed
          -0 checkstyle 0m 52s hadoop-yarn-project/hadoop-yarn: The patch generated 8 new + 112 unchanged - 0 fixed = 120 total (was 112)
          +1 mvnsite 1m 5s the patch passed
          +1 mvneclipse 0m 40s the patch passed
          -1 whitespace 0m 0s The patch has 72 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 1m 23s the patch passed
          +1 javadoc 0m 44s the patch passed
          -1 unit 40m 1s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 unit 0m 15s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 33s The patch does not generate ASF License warnings.
          93m 27s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6280
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12870946/YARN-6280.010.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux de8fed3bd300 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8d9084e
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16079/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/16079/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16079/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16079/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16079/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 51s Maven dependency ordering for branch +1 mvninstall 15m 12s trunk passed +1 compile 9m 14s trunk passed +1 checkstyle 0m 57s trunk passed +1 mvnsite 1m 7s trunk passed +1 mvneclipse 0m 40s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 1m 19s trunk passed +1 javadoc 0m 47s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 45s the patch passed +1 compile 8m 18s the patch passed +1 javac 8m 18s the patch passed -0 checkstyle 0m 52s hadoop-yarn-project/hadoop-yarn: The patch generated 8 new + 112 unchanged - 0 fixed = 120 total (was 112) +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 40s the patch passed -1 whitespace 0m 0s The patch has 72 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 1m 23s the patch passed +1 javadoc 0m 44s the patch passed -1 unit 40m 1s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 0m 15s hadoop-yarn-site in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 93m 27s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12870946/YARN-6280.010.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux de8fed3bd300 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8d9084e Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16079/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/16079/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16079/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16079/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/16079/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 10s Maven dependency ordering for branch
          +1 mvninstall 13m 13s trunk passed
          +1 compile 8m 32s trunk passed
          +1 checkstyle 0m 52s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 41s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 1m 2s trunk passed
          +1 javadoc 0m 44s trunk passed
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 0m 41s the patch passed
          +1 compile 7m 32s the patch passed
          +1 javac 7m 32s the patch passed
          -0 checkstyle 0m 52s hadoop-yarn-project/hadoop-yarn: The patch generated 8 new + 112 unchanged - 0 fixed = 120 total (was 112)
          +1 mvnsite 1m 0s the patch passed
          +1 mvneclipse 0m 39s the patch passed
          +1 whitespace 0m 1s The patch has no whitespace issues.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 1m 11s the patch passed
          +1 javadoc 0m 42s the patch passed
          -1 unit 38m 57s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 unit 0m 16s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 34s The patch does not generate ASF License warnings.
          87m 33s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation
            hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6280
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12870975/YARN-6280.010.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a42a4bb86729 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8d9084e
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16083/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16083/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16083/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16083/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 13m 13s trunk passed +1 compile 8m 32s trunk passed +1 checkstyle 0m 52s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 41s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 1m 2s trunk passed +1 javadoc 0m 44s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 41s the patch passed +1 compile 7m 32s the patch passed +1 javac 7m 32s the patch passed -0 checkstyle 0m 52s hadoop-yarn-project/hadoop-yarn: The patch generated 8 new + 112 unchanged - 0 fixed = 120 total (was 112) +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 39s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 1m 11s the patch passed +1 javadoc 0m 42s the patch passed -1 unit 38m 57s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 0m 16s hadoop-yarn-site in the patch passed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 87m 33s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation   hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12870975/YARN-6280.010.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a42a4bb86729 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8d9084e Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16083/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16083/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16083/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/16083/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cltlfcjin Lantao Jin added a comment -

          Hi Rohith Sharma K S, I've updated ResourceManagerRest.md and the patch. Please review.

          Show
          cltlfcjin Lantao Jin added a comment - Hi Rohith Sharma K S , I've updated ResourceManagerRest.md and the patch. Please review.
          Hide
          cltlfcjin Lantao Jin added a comment -

          Re-upload the 010.patch to resolve the new 8 checkstyle warnings.

          Show
          cltlfcjin Lantao Jin added a comment - Re-upload the 010.patch to resolve the new 8 checkstyle warnings.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 40s Maven dependency ordering for branch
          +1 mvninstall 14m 30s trunk passed
          +1 compile 9m 30s trunk passed
          +1 checkstyle 0m 55s trunk passed
          +1 mvnsite 1m 10s trunk passed
          +1 mvneclipse 0m 43s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 1m 15s trunk passed
          +1 javadoc 0m 46s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 0m 46s the patch passed
          +1 compile 8m 17s the patch passed
          +1 javac 8m 17s the patch passed
          -0 checkstyle 0m 50s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 112 unchanged - 0 fixed = 113 total (was 112)
          +1 mvnsite 1m 3s the patch passed
          +1 mvneclipse 0m 39s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 1m 12s the patch passed
          +1 javadoc 0m 43s the patch passed
          -1 unit 40m 17s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 unit 0m 15s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 32s The patch does not generate ASF License warnings.
          93m 1s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestOpportunisticContainerAllocatorAMService
          Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6280
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12870990/YARN-6280.010.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1577ee1f4be8 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 056cc72
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16084/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16084/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16084/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16084/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 40s Maven dependency ordering for branch +1 mvninstall 14m 30s trunk passed +1 compile 9m 30s trunk passed +1 checkstyle 0m 55s trunk passed +1 mvnsite 1m 10s trunk passed +1 mvneclipse 0m 43s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 1m 15s trunk passed +1 javadoc 0m 46s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 46s the patch passed +1 compile 8m 17s the patch passed +1 javac 8m 17s the patch passed -0 checkstyle 0m 50s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 112 unchanged - 0 fixed = 113 total (was 112) +1 mvnsite 1m 3s the patch passed +1 mvneclipse 0m 39s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 1m 12s the patch passed +1 javadoc 0m 43s the patch passed -1 unit 40m 17s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 0m 15s hadoop-yarn-site in the patch passed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 93m 1s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestOpportunisticContainerAllocatorAMService Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12870990/YARN-6280.010.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1577ee1f4be8 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 056cc72 Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16084/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16084/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16084/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/16084/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          Code changes are looking fine for me.
          In ResourceManagerRest.md file, I could see that resourceRequests is added as example in 3 places. I suppose it was not needed for this patch, but it was fundamentally missing from earlier itself, correct?

          Show
          sunilg Sunil G added a comment - Code changes are looking fine for me. In ResourceManagerRest.md file, I could see that resourceRequests is added as example in 3 places. I suppose it was not needed for this patch, but it was fundamentally missing from earlier itself, correct?
          Hide
          cltlfcjin Lantao Jin added a comment -

          Sunil G Correct. And it also could help to illustrate the new parameter deSelects as an example.

          Show
          cltlfcjin Lantao Jin added a comment - Sunil G Correct. And it also could help to illustrate the new parameter deSelects as an example.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          One quick comment,
          line no 94,

          1. Keep RESOURCE_REQUESTS as-is. Do not pass any arguments to it.
          2. Given 1st is accepted, remove corresponding codes for constructors.
            line no 67, nit
          3. need not to have else block.

          Can you keep 009 patch code and only modify DeSelectType to upper case such as RESOURCE_REQUESTS.

          Show
          rohithsharma Rohith Sharma K S added a comment - One quick comment, line no 94, Keep RESOURCE_REQUESTS as-is. Do not pass any arguments to it. Given 1st is accepted, remove corresponding codes for constructors. line no 67, nit need not to have else block. Can you keep 009 patch code and only modify DeSelectType to upper case such as RESOURCE_REQUESTS.
          Hide
          cltlfcjin Lantao Jin added a comment -

          Rohith Sharma K S I don't think it's friendly if user query like deSelects=RESOURCE_REQUESTS, WHATEVER_UPPER_CASE. So I used to using lower case or add an argument as its literals to mapping the RESTful API (lower case) to Enum variable.

          Show
          cltlfcjin Lantao Jin added a comment - Rohith Sharma K S I don't think it's friendly if user query like deSelects=RESOURCE_REQUESTS, WHATEVER_UPPER_CASE . So I used to using lower case or add an argument as its literals to mapping the RESTful API (lower case) to Enum variable.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Ahh, I see. I am +1 for existing patch.

          Show
          rohithsharma Rohith Sharma K S added a comment - Ahh, I see. I am +1 for existing patch.
          Hide
          sunilg Sunil G added a comment -

          Thanks Rohith Sharma K S. Committing shortly.

          Show
          sunilg Sunil G added a comment - Thanks Rohith Sharma K S . Committing shortly.
          Hide
          sunilg Sunil G added a comment -

          Lantao Jin
          I just rebased latest patch. May be you could confirm once before I commit the patch.

          Show
          sunilg Sunil G added a comment - Lantao Jin I just rebased latest patch. May be you could confirm once before I commit the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 10s Maven dependency ordering for branch
          +1 mvninstall 14m 9s trunk passed
          +1 compile 14m 37s trunk passed
          +1 checkstyle 1m 7s trunk passed
          +1 mvnsite 1m 30s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 1m 31s trunk passed
          +1 javadoc 1m 4s trunk passed
          0 mvndep 0m 12s Maven dependency ordering for patch
          +1 mvninstall 0m 56s the patch passed
          +1 compile 9m 11s the patch passed
          +1 javac 9m 11s the patch passed
          -0 checkstyle 0m 57s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 84 unchanged - 0 fixed = 85 total (was 84)
          +1 mvnsite 1m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 1m 26s the patch passed
          +1 javadoc 0m 52s the patch passed
          -1 unit 50m 12s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 unit 0m 17s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 52s The patch does not generate ASF License warnings.
          108m 37s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
          Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore
            org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6280
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873313/YARN-6280.011.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b0dab0fa8680 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4ebc23b
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16193/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16193/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16193/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16193/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 14m 9s trunk passed +1 compile 14m 37s trunk passed +1 checkstyle 1m 7s trunk passed +1 mvnsite 1m 30s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 1m 31s trunk passed +1 javadoc 1m 4s trunk passed 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 0m 56s the patch passed +1 compile 9m 11s the patch passed +1 javac 9m 11s the patch passed -0 checkstyle 0m 57s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 84 unchanged - 0 fixed = 85 total (was 84) +1 mvnsite 1m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 1m 26s the patch passed +1 javadoc 0m 52s the patch passed -1 unit 50m 12s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 0m 17s hadoop-yarn-site in the patch passed. +1 asflicense 0m 52s The patch does not generate ASF License warnings. 108m 37s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore   org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873313/YARN-6280.011.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b0dab0fa8680 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4ebc23b Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16193/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16193/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16193/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/16193/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cltlfcjin Lantao Jin added a comment -

          Hi Sunil G, LGTM. The test failure seems not relates to our patch.

          Show
          cltlfcjin Lantao Jin added a comment - Hi Sunil G , LGTM. The test failure seems not relates to our patch.
          Hide
          sunilg Sunil G added a comment -

          Thanks Lantao Jin,
          Rohith Sharma K S, could you also please help to check latest patch as YARN-6634 introduced some recent changes in RMWebServices.

          Show
          sunilg Sunil G added a comment - Thanks Lantao Jin , Rohith Sharma K S , could you also please help to check latest patch as YARN-6634 introduced some recent changes in RMWebServices.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          +1 LGTM

          Show
          rohithsharma Rohith Sharma K S added a comment - +1 LGTM
          Hide
          sunilg Sunil G added a comment -

          Committed to trunk. Lantao Jin, could you please help to share branch-2 patch

          Show
          sunilg Sunil G added a comment - Committed to trunk. Lantao Jin , could you please help to share branch-2 patch
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11947 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11947/)
          YARN-6280. Introduce deselect query param to skip ResourceRequest from (sunilg: rev c1edca101c32a5999100bc6031784274d416b599)

          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/DeSelectFields.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AppInfo.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServiceProtocol.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11947 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11947/ ) YARN-6280 . Introduce deselect query param to skip ResourceRequest from (sunilg: rev c1edca101c32a5999100bc6031784274d416b599) (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/DeSelectFields.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AppInfo.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServiceProtocol.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
          Hide
          andrew.wang Andrew Wang added a comment -

          Resolving for now so I can run release notes generation, please re-open for the backport if needed.

          Show
          andrew.wang Andrew Wang added a comment - Resolving for now so I can run release notes generation, please re-open for the backport if needed.
          Hide
          sunilg Sunil G added a comment -

          Lantao Jin could you please help to share branch-2 patch. If you do not have bandwidth, I could provide the same.

          Show
          sunilg Sunil G added a comment - Lantao Jin could you please help to share branch-2 patch. If you do not have bandwidth, I could provide the same.
          Hide
          cltlfcjin Lantao Jin added a comment -

          Sunil G, attached.

          Show
          cltlfcjin Lantao Jin added a comment - Sunil G , attached.
          Hide
          sunilg Sunil G added a comment -

          A quick comment. In branch-2 patch, ResourceManagerRest.md is missing. Any issues?

          Show
          sunilg Sunil G added a comment - A quick comment. In branch-2 patch, ResourceManagerRest.md is missing. Any issues?
          Hide
          cltlfcjin Lantao Jin added a comment - - edited

          Oh, thanks your reminding. I updated the patch.

          Show
          cltlfcjin Lantao Jin added a comment - - edited Oh, thanks your reminding. I updated the patch.
          Hide
          sunilg Sunil G added a comment -

          Reopening to run jenkins for branch-2 patch

          Show
          sunilg Sunil G added a comment - Reopening to run jenkins for branch-2 patch
          Hide
          cltlfcjin Lantao Jin added a comment -

          run jenkins please

          Show
          cltlfcjin Lantao Jin added a comment - run jenkins please
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
                branch-2 Compile Tests
          0 mvndep 0m 11s Maven dependency ordering for branch
          -1 mvninstall 6m 24s root in branch-2 failed.
          +1 compile 1m 53s branch-2 passed with JDK v1.8.0_131
          +1 compile 2m 14s branch-2 passed with JDK v1.7.0_131
          +1 checkstyle 0m 41s branch-2 passed
          +1 mvnsite 0m 55s branch-2 passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 1m 10s branch-2 passed
          +1 javadoc 0m 30s branch-2 passed with JDK v1.8.0_131
          +1 javadoc 0m 35s branch-2 passed with JDK v1.7.0_131
                Patch Compile Tests
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 0m 40s the patch passed
          +1 compile 1m 51s the patch passed with JDK v1.8.0_131
          +1 javac 1m 51s the patch passed
          +1 compile 2m 13s the patch passed with JDK v1.7.0_131
          +1 javac 2m 13s the patch passed
          -0 checkstyle 0m 41s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 107 unchanged - 5 fixed = 111 total (was 112)
          +1 mvnsite 0m 54s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 1m 20s the patch passed
          +1 javadoc 0m 28s the patch passed with JDK v1.8.0_131
          +1 javadoc 0m 34s the patch passed with JDK v1.7.0_131
                Other Tests
          -1 unit 43m 20s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          +1 unit 0m 9s hadoop-yarn-site in the patch passed with JDK v1.7.0_131.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          116m 39s



          Reason Tests
          JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation
          JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue YARN-6280
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876857/YARN-6280-branch-2.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6624580ffc69 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / af8a227
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/16413/artifact/patchprocess/branch-mvninstall-root.txt
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16413/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16413/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16413/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16413/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       branch-2 Compile Tests 0 mvndep 0m 11s Maven dependency ordering for branch -1 mvninstall 6m 24s root in branch-2 failed. +1 compile 1m 53s branch-2 passed with JDK v1.8.0_131 +1 compile 2m 14s branch-2 passed with JDK v1.7.0_131 +1 checkstyle 0m 41s branch-2 passed +1 mvnsite 0m 55s branch-2 passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 1m 10s branch-2 passed +1 javadoc 0m 30s branch-2 passed with JDK v1.8.0_131 +1 javadoc 0m 35s branch-2 passed with JDK v1.7.0_131       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 40s the patch passed +1 compile 1m 51s the patch passed with JDK v1.8.0_131 +1 javac 1m 51s the patch passed +1 compile 2m 13s the patch passed with JDK v1.7.0_131 +1 javac 2m 13s the patch passed -0 checkstyle 0m 41s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 107 unchanged - 5 fixed = 111 total (was 112) +1 mvnsite 0m 54s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 1m 20s the patch passed +1 javadoc 0m 28s the patch passed with JDK v1.8.0_131 +1 javadoc 0m 34s the patch passed with JDK v1.7.0_131       Other Tests -1 unit 43m 20s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. +1 unit 0m 9s hadoop-yarn-site in the patch passed with JDK v1.7.0_131. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 116m 39s Reason Tests JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue YARN-6280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876857/YARN-6280-branch-2.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6624580ffc69 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / af8a227 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/16413/artifact/patchprocess/branch-mvninstall-root.txt findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16413/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16413/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16413/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/16413/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          +1 committing patch to branch-2 as mvninstall with patch is passed.

          Show
          sunilg Sunil G added a comment - +1 committing patch to branch-2 as mvninstall with patch is passed.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
                branch-2 Compile Tests
          0 mvndep 0m 25s Maven dependency ordering for branch
          -1 mvninstall 6m 54s root in branch-2 failed.
          +1 compile 1m 54s branch-2 passed with JDK v1.8.0_131
          +1 compile 2m 15s branch-2 passed with JDK v1.7.0_131
          +1 checkstyle 0m 43s branch-2 passed
          +1 mvnsite 0m 59s branch-2 passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 1m 12s branch-2 passed
          +1 javadoc 0m 31s branch-2 passed with JDK v1.8.0_131
          +1 javadoc 0m 35s branch-2 passed with JDK v1.7.0_131
                Patch Compile Tests
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 0m 41s the patch passed
          +1 compile 1m 49s the patch passed with JDK v1.8.0_131
          +1 javac 1m 49s the patch passed
          +1 compile 2m 13s the patch passed with JDK v1.7.0_131
          +1 javac 2m 13s the patch passed
          -0 checkstyle 0m 40s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 107 unchanged - 5 fixed = 111 total (was 112)
          +1 mvnsite 0m 53s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 1m 21s the patch passed
          +1 javadoc 0m 28s the patch passed with JDK v1.8.0_131
          +1 javadoc 0m 34s the patch passed with JDK v1.7.0_131
                Other Tests
          -1 unit 43m 24s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          +1 unit 0m 10s hadoop-yarn-site in the patch passed with JDK v1.7.0_131.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          117m 59s



          Reason Tests
          JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
          JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler
            hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue YARN-6280
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876857/YARN-6280-branch-2.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux bb37b553f006 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / af8a227
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/16414/artifact/patchprocess/branch-mvninstall-root.txt
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16414/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16414/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16414/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16414/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       branch-2 Compile Tests 0 mvndep 0m 25s Maven dependency ordering for branch -1 mvninstall 6m 54s root in branch-2 failed. +1 compile 1m 54s branch-2 passed with JDK v1.8.0_131 +1 compile 2m 15s branch-2 passed with JDK v1.7.0_131 +1 checkstyle 0m 43s branch-2 passed +1 mvnsite 0m 59s branch-2 passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 1m 12s branch-2 passed +1 javadoc 0m 31s branch-2 passed with JDK v1.8.0_131 +1 javadoc 0m 35s branch-2 passed with JDK v1.7.0_131       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 41s the patch passed +1 compile 1m 49s the patch passed with JDK v1.8.0_131 +1 javac 1m 49s the patch passed +1 compile 2m 13s the patch passed with JDK v1.7.0_131 +1 javac 2m 13s the patch passed -0 checkstyle 0m 40s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 107 unchanged - 5 fixed = 111 total (was 112) +1 mvnsite 0m 53s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 1m 21s the patch passed +1 javadoc 0m 28s the patch passed with JDK v1.8.0_131 +1 javadoc 0m 34s the patch passed with JDK v1.7.0_131       Other Tests -1 unit 43m 24s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. +1 unit 0m 10s hadoop-yarn-site in the patch passed with JDK v1.7.0_131. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 117m 59s Reason Tests JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler   hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue YARN-6280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876857/YARN-6280-branch-2.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bb37b553f006 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / af8a227 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/16414/artifact/patchprocess/branch-mvninstall-root.txt findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16414/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16414/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16414/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/16414/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          Lantao Jin

          Couple of comments in branch-2 patch. (Sorry for late findings)

          1. I could see the addition of DeSelectFields in getApps api for branch-2. But same change is not visible for getApp api. Same is available in trunk.
          2. In ResourceManagerRest.md, I could see an explanation for deSelects as below in trunk.
            * deSelects - a generic fields which will be skipped in the result.
            

          But same is missing in branch-2. Please help to check the same.

          Show
          sunilg Sunil G added a comment - Lantao Jin Couple of comments in branch-2 patch. (Sorry for late findings) I could see the addition of DeSelectFields in getApps api for branch-2. But same change is not visible for getApp api. Same is available in trunk. In ResourceManagerRest.md , I could see an explanation for deSelects as below in trunk. * deSelects - a generic fields which will be skipped in the result. But same is missing in branch-2. Please help to check the same.
          Hide
          cltlfcjin Lantao Jin added a comment -

          Thank you Sunil G, re-upload.

          Show
          cltlfcjin Lantao Jin added a comment - Thank you Sunil G , re-upload.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
                branch-2 Compile Tests
          0 mvndep 0m 34s Maven dependency ordering for branch
          +1 mvninstall 6m 50s branch-2 passed
          +1 compile 2m 5s branch-2 passed with JDK v1.8.0_131
          +1 compile 2m 22s branch-2 passed with JDK v1.7.0_131
          +1 checkstyle 0m 42s branch-2 passed
          +1 mvnsite 0m 56s branch-2 passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 1m 14s branch-2 passed
          +1 javadoc 0m 31s branch-2 passed with JDK v1.8.0_131
          +1 javadoc 0m 36s branch-2 passed with JDK v1.7.0_131
                Patch Compile Tests
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 0m 43s the patch passed
          +1 compile 1m 56s the patch passed with JDK v1.8.0_131
          +1 javac 1m 56s the patch passed
          +1 compile 2m 19s the patch passed with JDK v1.7.0_131
          +1 javac 2m 19s the patch passed
          -0 checkstyle 0m 42s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 107 unchanged - 5 fixed = 111 total (was 112)
          +1 mvnsite 0m 54s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 1m 25s the patch passed
          +1 javadoc 0m 29s the patch passed with JDK v1.8.0_131
          +1 javadoc 0m 34s the patch passed with JDK v1.7.0_131
                Other Tests
          -1 unit 44m 56s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          +1 unit 0m 9s hadoop-yarn-site in the patch passed with JDK v1.7.0_131.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          122m 10s



          Reason Tests
          JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation
          JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue YARN-6280
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877272/YARN-6280-branch-2.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 7b32a426d0c4 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / af80d10
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16442/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16442/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16442/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16442/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       branch-2 Compile Tests 0 mvndep 0m 34s Maven dependency ordering for branch +1 mvninstall 6m 50s branch-2 passed +1 compile 2m 5s branch-2 passed with JDK v1.8.0_131 +1 compile 2m 22s branch-2 passed with JDK v1.7.0_131 +1 checkstyle 0m 42s branch-2 passed +1 mvnsite 0m 56s branch-2 passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 1m 14s branch-2 passed +1 javadoc 0m 31s branch-2 passed with JDK v1.8.0_131 +1 javadoc 0m 36s branch-2 passed with JDK v1.7.0_131       Patch Compile Tests 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 43s the patch passed +1 compile 1m 56s the patch passed with JDK v1.8.0_131 +1 javac 1m 56s the patch passed +1 compile 2m 19s the patch passed with JDK v1.7.0_131 +1 javac 2m 19s the patch passed -0 checkstyle 0m 42s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 107 unchanged - 5 fixed = 111 total (was 112) +1 mvnsite 0m 54s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 1m 25s the patch passed +1 javadoc 0m 29s the patch passed with JDK v1.8.0_131 +1 javadoc 0m 34s the patch passed with JDK v1.7.0_131       Other Tests -1 unit 44m 56s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. +1 unit 0m 9s hadoop-yarn-site in the patch passed with JDK v1.7.0_131. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 122m 10s Reason Tests JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue YARN-6280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877272/YARN-6280-branch-2.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7b32a426d0c4 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / af80d10 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16442/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16442/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16442/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/16442/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          Committed to trunk and branch-2. Thanks Lantao Jin for the contribution. Thanks Rohith Sharma K S and Jian He for additional reviews.

          Show
          sunilg Sunil G added a comment - Committed to trunk and branch-2. Thanks Lantao Jin for the contribution. Thanks Rohith Sharma K S and Jian He for additional reviews.

            People

            • Assignee:
              cltlfcjin Lantao Jin
              Reporter:
              cltlfcjin Lantao Jin
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development