Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6175

FairScheduler: Negative vcore for resource needed to preempt

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0
    • Component/s: fairscheduler
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Both old preemption code (2.8 and before) and new preemption code could have negative vcores while calculating resources needed to preempt.

      For old preemption, you can find following messages in RM logs:

      Should preempt <memory:2048, vCores:-2> 
      

      The related code is in method resourceDeficit().

      For new preemption code, there are no messages in RM logs, the related code is in method fairShareStarvation().

      The negative value isn't only a display issue, but also may cause missing necessary preemption.

      1. YARN-6175.001.patch
        8 kB
        Yufei Gu
      2. YARN-6175.branch-2.8.002.patch
        4 kB
        Yufei Gu
      3. YARN-6175.branch-2.8.003.patch
        4 kB
        Yufei Gu

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user flyrain opened a pull request:

          https://github.com/apache/hadoop/pull/194

          YARN-6175. Negative vcore for resource needed to preempt.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/flyrain/hadoop yarn-6175

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/hadoop/pull/194.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #194


          commit 1151efe4afb5390c43e61f1b578d5c2772dd9017
          Author: Yufei Gu <yufei.gu@cloudera.com>
          Date: 2017-02-14T20:22:18Z

          YARN-6175. Negative vcore for resource needed to preempt.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user flyrain opened a pull request: https://github.com/apache/hadoop/pull/194 YARN-6175 . Negative vcore for resource needed to preempt. You can merge this pull request into a Git repository by running: $ git pull https://github.com/flyrain/hadoop yarn-6175 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/194.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #194 commit 1151efe4afb5390c43e61f1b578d5c2772dd9017 Author: Yufei Gu <yufei.gu@cloudera.com> Date: 2017-02-14T20:22:18Z YARN-6175 . Negative vcore for resource needed to preempt.
          Hide
          yufeigu Yufei Gu added a comment -

          The issue in new preemption code is fixed in YARN-6163. This Jira is only for 2.8.
          The patch v1 borrow the method Resources.subtractFromNonNegative() from YARN-6163.

          Show
          yufeigu Yufei Gu added a comment - The issue in new preemption code is fixed in YARN-6163 . This Jira is only for 2.8. The patch v1 borrow the method Resources.subtractFromNonNegative() from YARN-6163 .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 24s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 38s Maven dependency ordering for branch
          +1 mvninstall 10m 36s branch-2.8 passed
          +1 compile 2m 13s branch-2.8 passed with JDK v1.8.0_121
          +1 compile 2m 23s branch-2.8 passed with JDK v1.7.0_121
          +1 checkstyle 0m 40s branch-2.8 passed
          +1 mvnsite 1m 24s branch-2.8 passed
          +1 mvneclipse 0m 40s branch-2.8 passed
          +1 findbugs 2m 45s branch-2.8 passed
          +1 javadoc 0m 56s branch-2.8 passed with JDK v1.8.0_121
          +1 javadoc 0m 59s branch-2.8 passed with JDK v1.7.0_121
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 4s the patch passed
          +1 compile 2m 7s the patch passed with JDK v1.8.0_121
          +1 javac 2m 7s the patch passed
          +1 compile 2m 39s the patch passed with JDK v1.7.0_121
          +1 javac 2m 39s the patch passed
          +1 checkstyle 0m 37s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 113 unchanged - 3 fixed = 113 total (was 116)
          +1 mvnsite 1m 18s the patch passed
          +1 mvneclipse 0m 30s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 4s the patch passed
          +1 javadoc 0m 56s the patch passed with JDK v1.8.0_121
          +1 javadoc 1m 3s the patch passed with JDK v1.7.0_121
          +1 unit 2m 33s hadoop-yarn-common in the patch passed with JDK v1.7.0_121.
          -1 unit 77m 23s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          204m 34s



          Reason Tests
          JDK v1.8.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
          JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerSurgicalPreemption
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Issue YARN-6175
          GITHUB PR https://github.com/apache/hadoop/pull/194
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d15b2bfa0342 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / 8f9aae0
          Default Java 1.7.0_121
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/14943/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt
          JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14943/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14943/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 38s Maven dependency ordering for branch +1 mvninstall 10m 36s branch-2.8 passed +1 compile 2m 13s branch-2.8 passed with JDK v1.8.0_121 +1 compile 2m 23s branch-2.8 passed with JDK v1.7.0_121 +1 checkstyle 0m 40s branch-2.8 passed +1 mvnsite 1m 24s branch-2.8 passed +1 mvneclipse 0m 40s branch-2.8 passed +1 findbugs 2m 45s branch-2.8 passed +1 javadoc 0m 56s branch-2.8 passed with JDK v1.8.0_121 +1 javadoc 0m 59s branch-2.8 passed with JDK v1.7.0_121 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 4s the patch passed +1 compile 2m 7s the patch passed with JDK v1.8.0_121 +1 javac 2m 7s the patch passed +1 compile 2m 39s the patch passed with JDK v1.7.0_121 +1 javac 2m 39s the patch passed +1 checkstyle 0m 37s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 113 unchanged - 3 fixed = 113 total (was 116) +1 mvnsite 1m 18s the patch passed +1 mvneclipse 0m 30s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 4s the patch passed +1 javadoc 0m 56s the patch passed with JDK v1.8.0_121 +1 javadoc 1m 3s the patch passed with JDK v1.7.0_121 +1 unit 2m 33s hadoop-yarn-common in the patch passed with JDK v1.7.0_121. -1 unit 77m 23s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 204m 34s Reason Tests JDK v1.8.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerSurgicalPreemption   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Issue YARN-6175 GITHUB PR https://github.com/apache/hadoop/pull/194 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d15b2bfa0342 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / 8f9aae0 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/14943/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14943/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14943/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          wilfreds Wilfred Spiegelenburg added a comment -

          The change overall looks good. The junit test failures are not related to the change.

          +1 (non binding)

          Show
          wilfreds Wilfred Spiegelenburg added a comment - The change overall looks good. The junit test failures are not related to the change. +1 (non binding)
          Hide
          yufeigu Yufei Gu added a comment -

          Thanks Wilfred Spiegelenburg for the review. Karthik Kambatla, wanna take a look?

          Show
          yufeigu Yufei Gu added a comment - Thanks Wilfred Spiegelenburg for the review. Karthik Kambatla , wanna take a look?
          Hide
          kasha Karthik Kambatla added a comment -

          Just skimmed through the patch. When using subtractFromNonNegative, we should make sure we are not masking real bugs. Are all the cases here okay to use this method?

          Also, since YARN-6163 is close to be done, let us look into this once that is committed.

          Show
          kasha Karthik Kambatla added a comment - Just skimmed through the patch. When using subtractFromNonNegative , we should make sure we are not masking real bugs. Are all the cases here okay to use this method? Also, since YARN-6163 is close to be done, let us look into this once that is committed.
          Hide
          yufeigu Yufei Gu added a comment -

          Karthik Kambatla, would you like take a look since YARN-6163 is done.

          Show
          yufeigu Yufei Gu added a comment - Karthik Kambatla , would you like take a look since YARN-6163 is done.
          Hide
          yufeigu Yufei Gu added a comment -

          Uploaded patch v2 which is in line with YARN-6163.

          Show
          yufeigu Yufei Gu added a comment - Uploaded patch v2 which is in line with YARN-6163 .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 24s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 19s Maven dependency ordering for branch
          +1 mvninstall 10m 13s branch-2.8 passed
          +1 compile 2m 32s branch-2.8 passed with JDK v1.8.0_121
          +1 compile 2m 39s branch-2.8 passed with JDK v1.7.0_121
          +1 checkstyle 0m 44s branch-2.8 passed
          +1 mvnsite 1m 35s branch-2.8 passed
          +1 mvneclipse 0m 38s branch-2.8 passed
          +1 findbugs 2m 49s branch-2.8 passed
          +1 javadoc 0m 59s branch-2.8 passed with JDK v1.8.0_121
          +1 javadoc 1m 5s branch-2.8 passed with JDK v1.7.0_121
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 1m 14s the patch passed
          +1 compile 2m 41s the patch passed with JDK v1.8.0_121
          +1 javac 2m 41s the patch passed
          +1 compile 2m 48s the patch passed with JDK v1.7.0_121
          +1 javac 2m 48s the patch passed
          +1 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 111 unchanged - 3 fixed = 111 total (was 114)
          +1 mvnsite 1m 15s the patch passed
          +1 mvneclipse 0m 30s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 41s the patch passed
          +1 javadoc 0m 45s the patch passed with JDK v1.8.0_121
          +1 javadoc 0m 51s the patch passed with JDK v1.7.0_121
          +1 unit 2m 28s hadoop-yarn-common in the patch passed with JDK v1.7.0_121.
          -1 unit 76m 11s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          201m 50s



          Reason Tests
          JDK v1.8.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
          JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Issue YARN-6175
          GITHUB PR https://github.com/apache/hadoop/pull/194
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 16caa8798288 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / 83a5896
          Default Java 1.7.0_121
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/14989/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt
          JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14989/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14989/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 19s Maven dependency ordering for branch +1 mvninstall 10m 13s branch-2.8 passed +1 compile 2m 32s branch-2.8 passed with JDK v1.8.0_121 +1 compile 2m 39s branch-2.8 passed with JDK v1.7.0_121 +1 checkstyle 0m 44s branch-2.8 passed +1 mvnsite 1m 35s branch-2.8 passed +1 mvneclipse 0m 38s branch-2.8 passed +1 findbugs 2m 49s branch-2.8 passed +1 javadoc 0m 59s branch-2.8 passed with JDK v1.8.0_121 +1 javadoc 1m 5s branch-2.8 passed with JDK v1.7.0_121 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 1m 14s the patch passed +1 compile 2m 41s the patch passed with JDK v1.8.0_121 +1 javac 2m 41s the patch passed +1 compile 2m 48s the patch passed with JDK v1.7.0_121 +1 javac 2m 48s the patch passed +1 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 111 unchanged - 3 fixed = 111 total (was 114) +1 mvnsite 1m 15s the patch passed +1 mvneclipse 0m 30s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 41s the patch passed +1 javadoc 0m 45s the patch passed with JDK v1.8.0_121 +1 javadoc 0m 51s the patch passed with JDK v1.7.0_121 +1 unit 2m 28s hadoop-yarn-common in the patch passed with JDK v1.7.0_121. -1 unit 76m 11s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 201m 50s Reason Tests JDK v1.8.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Issue YARN-6175 GITHUB PR https://github.com/apache/hadoop/pull/194 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 16caa8798288 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / 83a5896 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/14989/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14989/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14989/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          kasha Karthik Kambatla added a comment -

          In FairScheduler.java, do we still need the Resources.max call?

          Show
          kasha Karthik Kambatla added a comment - In FairScheduler.java, do we still need the Resources.max call?
          Hide
          yufeigu Yufei Gu added a comment -

          Karthik Kambatla, good catch. Resources.max isn't necessary. Uploaded the patch v3 to fix it.

          Show
          yufeigu Yufei Gu added a comment - Karthik Kambatla , good catch. Resources.max isn't necessary. Uploaded the patch v3 to fix it.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 25s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 28s Maven dependency ordering for branch
          +1 mvninstall 9m 53s branch-2.8 passed
          +1 compile 2m 43s branch-2.8 passed with JDK v1.8.0_121
          +1 compile 2m 45s branch-2.8 passed with JDK v1.7.0_121
          +1 checkstyle 0m 37s branch-2.8 passed
          +1 mvnsite 1m 25s branch-2.8 passed
          +1 mvneclipse 0m 36s branch-2.8 passed
          +1 findbugs 2m 53s branch-2.8 passed
          +1 javadoc 0m 56s branch-2.8 passed with JDK v1.8.0_121
          +1 javadoc 1m 4s branch-2.8 passed with JDK v1.7.0_121
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 9s the patch passed
          +1 compile 2m 32s the patch passed with JDK v1.8.0_121
          +1 javac 2m 32s hadoop-yarn-project_hadoop-yarn-jdk1.8.0_121 with JDK v1.8.0_121 generated 0 new + 58 unchanged - 1 fixed = 58 total (was 59)
          +1 compile 2m 52s the patch passed with JDK v1.7.0_121
          +1 javac 2m 52s hadoop-yarn-project_hadoop-yarn-jdk1.7.0_121 with JDK v1.7.0_121 generated 0 new + 68 unchanged - 2 fixed = 68 total (was 70)
          +1 checkstyle 0m 39s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 100 unchanged - 2 fixed = 100 total (was 102)
          +1 mvnsite 1m 18s the patch passed
          +1 mvneclipse 0m 34s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 29s the patch passed
          +1 javadoc 1m 1s the patch passed with JDK v1.8.0_121
          +1 javadoc 1m 4s the patch passed with JDK v1.7.0_121
          +1 unit 2m 29s hadoop-yarn-common in the patch passed with JDK v1.7.0_121.
          -1 unit 75m 39s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          203m 6s



          Reason Tests
          JDK v1.8.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
          JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Issue YARN-6175
          GITHUB PR https://github.com/apache/hadoop/pull/194
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f7a492c36642 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / 10d54eb
          Default Java 1.7.0_121
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15026/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt
          JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15026/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15026/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 28s Maven dependency ordering for branch +1 mvninstall 9m 53s branch-2.8 passed +1 compile 2m 43s branch-2.8 passed with JDK v1.8.0_121 +1 compile 2m 45s branch-2.8 passed with JDK v1.7.0_121 +1 checkstyle 0m 37s branch-2.8 passed +1 mvnsite 1m 25s branch-2.8 passed +1 mvneclipse 0m 36s branch-2.8 passed +1 findbugs 2m 53s branch-2.8 passed +1 javadoc 0m 56s branch-2.8 passed with JDK v1.8.0_121 +1 javadoc 1m 4s branch-2.8 passed with JDK v1.7.0_121 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 9s the patch passed +1 compile 2m 32s the patch passed with JDK v1.8.0_121 +1 javac 2m 32s hadoop-yarn-project_hadoop-yarn-jdk1.8.0_121 with JDK v1.8.0_121 generated 0 new + 58 unchanged - 1 fixed = 58 total (was 59) +1 compile 2m 52s the patch passed with JDK v1.7.0_121 +1 javac 2m 52s hadoop-yarn-project_hadoop-yarn-jdk1.7.0_121 with JDK v1.7.0_121 generated 0 new + 68 unchanged - 2 fixed = 68 total (was 70) +1 checkstyle 0m 39s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 100 unchanged - 2 fixed = 100 total (was 102) +1 mvnsite 1m 18s the patch passed +1 mvneclipse 0m 34s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 29s the patch passed +1 javadoc 1m 1s the patch passed with JDK v1.8.0_121 +1 javadoc 1m 4s the patch passed with JDK v1.7.0_121 +1 unit 2m 29s hadoop-yarn-common in the patch passed with JDK v1.7.0_121. -1 unit 75m 39s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 203m 6s Reason Tests JDK v1.8.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Issue YARN-6175 GITHUB PR https://github.com/apache/hadoop/pull/194 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f7a492c36642 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / 10d54eb Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/15026/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15026/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/15026/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          kasha Karthik Kambatla added a comment -

          Thanks for finding and fixing this issue, Yufei. Just committed this to branch-2.8.

          Show
          kasha Karthik Kambatla added a comment - Thanks for finding and fixing this issue, Yufei. Just committed this to branch-2.8.
          Hide
          yufeigu Yufei Gu added a comment -

          Thanks Karthik Kambatla for the review and commit.

          Show
          yufeigu Yufei Gu added a comment - Thanks Karthik Kambatla for the review and commit.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user flyrain commented on the issue:

          https://github.com/apache/hadoop/pull/194

          Committed

          Show
          githubbot ASF GitHub Bot added a comment - Github user flyrain commented on the issue: https://github.com/apache/hadoop/pull/194 Committed
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user flyrain closed the pull request at:

          https://github.com/apache/hadoop/pull/194

          Show
          githubbot ASF GitHub Bot added a comment - Github user flyrain closed the pull request at: https://github.com/apache/hadoop/pull/194
          Hide
          dossett@gmail.com Aaron Dossett added a comment -

          I am seeing log messages like this: Note the value of -8

          2017-06-12 21:52:12,937 INFO org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler: Should preempt <memory:28672, vCores:-8> res for queue root.production.scheduled_jobs: resDueToMinShare = <memory:0, vCores:0>, resDueToFairShare = <memory:28672, vCores:-8>
          

          Is that likely an instance of this bug?

          Show
          dossett@gmail.com Aaron Dossett added a comment - I am seeing log messages like this: Note the value of -8 2017-06-12 21:52:12,937 INFO org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler: Should preempt <memory:28672, vCores:-8> res for queue root.production.scheduled_jobs: resDueToMinShare = <memory:0, vCores:0>, resDueToFairShare = <memory:28672, vCores:-8> Is that likely an instance of this bug?
          Hide
          yufeigu Yufei Gu added a comment -

          Aaron Dossett, what version do you use? Do you use fair scheduler?

          Show
          yufeigu Yufei Gu added a comment - Aaron Dossett , what version do you use? Do you use fair scheduler?
          Hide
          dossett@gmail.com Aaron Dossett added a comment -

          Yufei GuI'm running CDH 5.10.0. I double checked the Cloudera release notes and CDH 5.10.1 does include this fix, so I'll look to upgrade. Thanks!

          Show
          dossett@gmail.com Aaron Dossett added a comment - Yufei Gu I'm running CDH 5.10.0. I double checked the Cloudera release notes and CDH 5.10.1 does include this fix, so I'll look to upgrade. Thanks!

            People

            • Assignee:
              yufeigu Yufei Gu
              Reporter:
              yufeigu Yufei Gu
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development