[YARN-6125] The application attempt's diagnostic message should have a maximum size

• Type: Improvement
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.7.0
• Fix Version/s: 2.9.0, 3.0.0-alpha4
• Component/s: resourcemanager
• Target Version/s: 3.0.0-alpha4
• Assignee: Andras Piros
• Reporter: Daniel Templeton
• Created: 26/Jan/17 18:08
• Updated: 30/Sep/19 06:27
• Resolved: 17/Feb/17 22:26

Description

We've found through experience that the diagnostic message can grow unbounded. I've seen attempts that have diagnostic messages over 1MB. Since the message is stored in the state store, it's a bad idea to allow the message to grow unbounded. Instead, there should be a property that sets a maximum size on the message.

I suspect that some of the ZK state store issues we've seen in the past were due to the size of the diagnostic messages and not to the size of the classpath, as is the current prevailing opinion.

An open question is how best to prune the message once it grows too large. Should we

1. truncate the tail,
2. truncate the head,
3. truncate the middle,
4. add another property to make the behavior selectable, or
5. none of the above?

Issue Links

• is duplicated by: YARN-9065 App's diags is too long,written zk error
• is related to: YARN-8691 AMRMClient unregisterApplicationMaster Api's appMessage should have a maximum size
• relates to: YARN-9847 ZKRMStateStore will cause zk connection loss when writing huge data into znode