Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: scheduler
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. YARN-6118.002.patch
      0.9 kB
      Andres Perez
    2. YARN-6118.patch
      0.9 kB
      Andres Perez

      Activity

      Hide
      aaperezl Andres Perez added a comment -

      Could I take this simple task?

      Show
      aaperezl Andres Perez added a comment - Could I take this simple task?
      Hide
      sunilg Sunil G added a comment -

      I think you can assign yourself and provide a patch.

      Show
      sunilg Sunil G added a comment - I think you can assign yourself and provide a patch.
      Hide
      aaperezl Andres Perez added a comment -

      I can't because I'm still not in the approved list for yarn

      Show
      aaperezl Andres Perez added a comment - I can't because I'm still not in the approved list for yarn
      Hide
      sunilg Sunil G added a comment -

      Please check it now, I added you to the contributor list.

      Show
      sunilg Sunil G added a comment - Please check it now, I added you to the contributor list.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 23s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      +1 mvninstall 13m 36s trunk passed
      +1 compile 0m 33s trunk passed
      +1 checkstyle 0m 18s trunk passed
      +1 mvnsite 0m 29s trunk passed
      +1 mvneclipse 0m 14s trunk passed
      +1 findbugs 1m 1s trunk passed
      +1 javadoc 0m 30s trunk passed
      +1 mvninstall 0m 26s the patch passed
      +1 compile 0m 27s the patch passed
      +1 javac 0m 27s the patch passed
      +1 checkstyle 0m 16s the patch passed
      +1 mvnsite 0m 31s the patch passed
      +1 mvneclipse 0m 11s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 1m 6s the patch passed
      +1 javadoc 0m 27s the patch passed
      +1 unit 2m 23s hadoop-yarn-common in the patch passed.
      +1 asflicense 0m 23s The patch does not generate ASF License warnings.
      24m 32s



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:a9ad5d6
      JIRA Issue YARN-6118
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849779/YARN-6118.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux a4d185a09b44 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / ebd4005
      Default Java 1.8.0_121
      findbugs v3.0.0
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14773/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/14773/console
      Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 36s trunk passed +1 compile 0m 33s trunk passed +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 29s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 1s trunk passed +1 javadoc 0m 30s trunk passed +1 mvninstall 0m 26s the patch passed +1 compile 0m 27s the patch passed +1 javac 0m 27s the patch passed +1 checkstyle 0m 16s the patch passed +1 mvnsite 0m 31s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 6s the patch passed +1 javadoc 0m 27s the patch passed +1 unit 2m 23s hadoop-yarn-common in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 24m 32s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6118 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849779/YARN-6118.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a4d185a09b44 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ebd4005 Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14773/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/14773/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      sunilg Sunil G added a comment -

      Thanks Andres Perez

      A minor nit.
      Instead of Check if a resource does not provide memory or virtual cores., I think you can mention like Check whether a resource object is empty. (0 memory and 0 virtual cores) something like this. Because does not provide memory or virtual cores may not be correct.

      Show
      sunilg Sunil G added a comment - Thanks Andres Perez A minor nit. Instead of Check if a resource does not provide memory or virtual cores. , I think you can mention like Check whether a resource object is empty. (0 memory and 0 virtual cores) something like this. Because does not provide memory or virtual cores may not be correct.
      Hide
      aaperezl Andres Perez added a comment -

      I have corrected the wording as suggested

      Show
      aaperezl Andres Perez added a comment - I have corrected the wording as suggested
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 26s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      +1 mvninstall 14m 12s trunk passed
      +1 compile 0m 36s trunk passed
      +1 checkstyle 0m 21s trunk passed
      +1 mvnsite 0m 35s trunk passed
      +1 mvneclipse 0m 14s trunk passed
      +1 findbugs 1m 3s trunk passed
      +1 javadoc 0m 29s trunk passed
      +1 mvninstall 0m 29s the patch passed
      +1 compile 0m 27s the patch passed
      +1 javac 0m 27s the patch passed
      +1 checkstyle 0m 18s the patch passed
      +1 mvnsite 0m 29s the patch passed
      +1 mvneclipse 0m 11s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 1m 9s the patch passed
      +1 javadoc 0m 28s the patch passed
      +1 unit 2m 31s hadoop-yarn-common in the patch passed.
      +1 asflicense 0m 20s The patch does not generate ASF License warnings.
      25m 56s



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:a9ad5d6
      JIRA Issue YARN-6118
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12851740/YARN-6118.002.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 3c9622533229 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / 37b4acf
      Default Java 1.8.0_121
      findbugs v3.0.0
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14866/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/14866/console
      Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 26s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 12s trunk passed +1 compile 0m 36s trunk passed +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 35s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 3s trunk passed +1 javadoc 0m 29s trunk passed +1 mvninstall 0m 29s the patch passed +1 compile 0m 27s the patch passed +1 javac 0m 27s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 29s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 9s the patch passed +1 javadoc 0m 28s the patch passed +1 unit 2m 31s hadoop-yarn-common in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 25m 56s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6118 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12851740/YARN-6118.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3c9622533229 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 37b4acf Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14866/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/14866/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      sunilg Sunil G added a comment -

      +1. Committing later today if there are no other comments.

      Show
      sunilg Sunil G added a comment - +1. Committing later today if there are no other comments.
      Hide
      sunilg Sunil G added a comment -

      Thanks Andres Perez for the contribution. Committed to trunk and branch-2.

      Show
      sunilg Sunil G added a comment - Thanks Andres Perez for the contribution. Committed to trunk and branch-2.
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11231 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11231/)
      YARN-6118. Add javadoc for Resources.isNone. Contributed by Andres (sunilg: rev 3a0a0a485a4145e3bd2e5946731ee1d901b51ead)

      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/resource/Resources.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11231 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11231/ ) YARN-6118 . Add javadoc for Resources.isNone. Contributed by Andres (sunilg: rev 3a0a0a485a4145e3bd2e5946731ee1d901b51ead) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/resource/Resources.java

        People

        • Assignee:
          aaperezl Andres Perez
          Reporter:
          kasha Karthik Kambatla
        • Votes:
          0 Vote for this issue
          Watchers:
          5 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development