Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6112

UpdateCallDuration is calculated only when debug logging is enabled

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: fairscheduler
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In the update thread of Fair Scheduler, the fsOpDurations.addUpdateCallDuration() records the duration of update(), it should be independent to LOG level. YARN-4752 put the it inside a LOG.isDebugEnabled() block. Not sure any particular reason to do that. cc Karthik Kambatla

      1. YARN-6112.001.patch
        1 kB
        Yufei Gu
      2. YARN-6112.002.patch
        1 kB
        Yufei Gu
      3. YARN-6112.003.patch
        3 kB
        Yufei Gu
      4. YARN-6112.branch-2.001.patch
        2 kB
        Yufei Gu

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11228 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11228/)
        YARN-6112. UpdateCallDuration is calculated only when debug logging is (kasha: rev 9b85053583a3560f93062b656061d11b1b9c664f)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSOpDurations.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11228 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11228/ ) YARN-6112 . UpdateCallDuration is calculated only when debug logging is (kasha: rev 9b85053583a3560f93062b656061d11b1b9c664f) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSOpDurations.java
        Hide
        yufeigu Yufei Gu added a comment -

        Thanks Karthik Kambatla for the review and commit.

        Show
        yufeigu Yufei Gu added a comment - Thanks Karthik Kambatla for the review and commit.
        Hide
        kasha Karthik Kambatla added a comment -

        Just committed this to trunk and branch-2. Thanks for fixing this, Yufei.

        Show
        kasha Karthik Kambatla added a comment - Just committed this to trunk and branch-2. Thanks for fixing this, Yufei.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 26s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 12m 30s branch-2 passed
        +1 compile 0m 31s branch-2 passed with JDK v1.8.0_121
        +1 compile 0m 32s branch-2 passed with JDK v1.7.0_121
        +1 checkstyle 0m 24s branch-2 passed
        +1 mvnsite 0m 40s branch-2 passed
        +1 mvneclipse 0m 19s branch-2 passed
        +1 findbugs 1m 13s branch-2 passed
        +1 javadoc 0m 23s branch-2 passed with JDK v1.8.0_121
        +1 javadoc 0m 24s branch-2 passed with JDK v1.7.0_121
        +1 mvninstall 0m 31s the patch passed
        +1 compile 0m 25s the patch passed with JDK v1.8.0_121
        +1 javac 0m 25s the patch passed
        +1 compile 0m 32s the patch passed with JDK v1.7.0_121
        +1 javac 0m 32s the patch passed
        +1 checkstyle 0m 20s the patch passed
        +1 mvnsite 0m 39s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 26s the patch passed
        +1 javadoc 0m 18s the patch passed with JDK v1.8.0_121
        +1 javadoc 0m 23s the patch passed with JDK v1.7.0_121
        -1 unit 40m 44s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121.
        +1 asflicense 0m 35s The patch does not generate ASF License warnings.
        105m 38s



        Reason Tests
        JDK v1.8.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
        JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue YARN-6112
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12851493/YARN-6112.branch-2.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 36dae673401c 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 85261cb
        Default Java 1.7.0_121
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14853/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt
        JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14853/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14853/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 26s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 12m 30s branch-2 passed +1 compile 0m 31s branch-2 passed with JDK v1.8.0_121 +1 compile 0m 32s branch-2 passed with JDK v1.7.0_121 +1 checkstyle 0m 24s branch-2 passed +1 mvnsite 0m 40s branch-2 passed +1 mvneclipse 0m 19s branch-2 passed +1 findbugs 1m 13s branch-2 passed +1 javadoc 0m 23s branch-2 passed with JDK v1.8.0_121 +1 javadoc 0m 24s branch-2 passed with JDK v1.7.0_121 +1 mvninstall 0m 31s the patch passed +1 compile 0m 25s the patch passed with JDK v1.8.0_121 +1 javac 0m 25s the patch passed +1 compile 0m 32s the patch passed with JDK v1.7.0_121 +1 javac 0m 32s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 0m 39s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 26s the patch passed +1 javadoc 0m 18s the patch passed with JDK v1.8.0_121 +1 javadoc 0m 23s the patch passed with JDK v1.7.0_121 -1 unit 40m 44s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 105m 38s Reason Tests JDK v1.8.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue YARN-6112 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12851493/YARN-6112.branch-2.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 36dae673401c 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 85261cb Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/14853/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14853/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/14853/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        kasha Karthik Kambatla added a comment -

        +1 for the branch-2 patch too, pending Jenkins.

        Show
        kasha Karthik Kambatla added a comment - +1 for the branch-2 patch too, pending Jenkins.
        Hide
        yufeigu Yufei Gu added a comment -

        Karthik Kambatla, thanks for the review. Uploaded the patch for branch-2.

        Show
        yufeigu Yufei Gu added a comment - Karthik Kambatla , thanks for the review. Uploaded the patch for branch-2.
        Hide
        kasha Karthik Kambatla added a comment -

        +1 on the trunk patch. Yufei Gu - can you post another patch for branch-2 that keeps the metric, but fixes the original problem reported on this JIRA?

        Show
        kasha Karthik Kambatla added a comment - +1 on the trunk patch. Yufei Gu - can you post another patch for branch-2 that keeps the metric, but fixes the original problem reported on this JIRA?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 12m 36s trunk passed
        +1 compile 0m 32s trunk passed
        +1 checkstyle 0m 21s trunk passed
        +1 mvnsite 0m 33s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 0m 58s trunk passed
        +1 javadoc 0m 20s trunk passed
        +1 mvninstall 0m 30s the patch passed
        +1 compile 0m 29s the patch passed
        +1 javac 0m 29s the patch passed
        +1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 46 unchanged - 1 fixed = 46 total (was 47)
        +1 mvnsite 0m 30s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 2s the patch passed
        +1 javadoc 0m 17s the patch passed
        +1 unit 39m 14s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        59m 54s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-6112
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849602/YARN-6112.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 166687af5eac 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 55c9f6d
        Default Java 1.8.0_121
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14762/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14762/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 12m 36s trunk passed +1 compile 0m 32s trunk passed +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 33s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 0m 58s trunk passed +1 javadoc 0m 20s trunk passed +1 mvninstall 0m 30s the patch passed +1 compile 0m 29s the patch passed +1 javac 0m 29s the patch passed +1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 46 unchanged - 1 fixed = 46 total (was 47) +1 mvnsite 0m 30s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 2s the patch passed +1 javadoc 0m 17s the patch passed +1 unit 39m 14s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 59m 54s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6112 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849602/YARN-6112.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 166687af5eac 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 55c9f6d Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14762/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/14762/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        yufeigu Yufei Gu added a comment -

        Patch 003:
        Remove the updateCall metrics and related measurement in function update since it is identical to updateThreadRun right now. We'll keep it in branch-2 as Karthik Kambatla suggested.

        Show
        yufeigu Yufei Gu added a comment - Patch 003: Remove the updateCall metrics and related measurement in function update since it is identical to updateThreadRun right now. We'll keep it in branch-2 as Karthik Kambatla suggested.
        Hide
        yufeigu Yufei Gu added a comment -

        The patch 002 moves measurement outside the writelock.

        Show
        yufeigu Yufei Gu added a comment - The patch 002 moves measurement outside the writelock.
        Hide
        yufeigu Yufei Gu added a comment - - edited

        There is an another duration measurement outside of the function update() (shows in following code), which did the measurement outside the writelock. It's a bit surprise me, by looking at the original design in YARN-2352. There are two because there is one more line after update(). We should remove one of measurements since they are identical now. One of my concerns is that is it OK to remove one of the metrics(updateThreadRun, updateCall)?

         
                  long start = getClock().getTime();
                  update();
                  long duration = getClock().getTime() - start;
                  fsOpDurations.addUpdateThreadRunDuration(duration);
        
        Show
        yufeigu Yufei Gu added a comment - - edited There is an another duration measurement outside of the function update() (shows in following code), which did the measurement outside the writelock. It's a bit surprise me, by looking at the original design in YARN-2352 . There are two because there is one more line after update() . We should remove one of measurements since they are identical now. One of my concerns is that is it OK to remove one of the metrics(updateThreadRun, updateCall)? long start = getClock().getTime(); update(); long duration = getClock().getTime() - start; fsOpDurations.addUpdateThreadRunDuration(duration);
        Hide
        kasha Karthik Kambatla added a comment -

        Sorry for screwing it up. Absolutely, it is a mistake.

        That said, maybe the code corresponding to measuring these durations should be outside the writelock. Could you also update nodeUpdate similarly?

        Show
        kasha Karthik Kambatla added a comment - Sorry for screwing it up. Absolutely, it is a mistake. That said, maybe the code corresponding to measuring these durations should be outside the writelock. Could you also update nodeUpdate similarly?
        Hide
        templedf Daniel Templeton added a comment -

        If Karthik Kambatla agrees that change is a mistake, I'm +1 for the patch.

        Show
        templedf Daniel Templeton added a comment - If Karthik Kambatla agrees that change is a mistake, I'm +1 for the patch.
        Hide
        templedf Daniel Templeton added a comment -

        Karthik Kambatla, the issue is that the call to fsOpDurations.addUpdateCallDuration() now (post 4752) happens inside the if (LOG.isDebugEnabled() block. Before it was done whether debug was enabled or not, which appears to be the right thing.

        Show
        templedf Daniel Templeton added a comment - Karthik Kambatla , the issue is that the call to fsOpDurations.addUpdateCallDuration() now (post 4752) happens inside the if (LOG.isDebugEnabled() block. Before it was done whether debug was enabled or not, which appears to be the right thing.
        Hide
        kasha Karthik Kambatla added a comment -

        I didn't quite understand the description. If we use the usual logger, we are to log at a specified level right? INFO, DEBUG?

        To reduce the noise in the logs, I believe we thought DEBUG was enough for this. The isDebugEnabled check is so we don't perform the string concatenation when debug logging is not enabled.

        Show
        kasha Karthik Kambatla added a comment - I didn't quite understand the description. If we use the usual logger, we are to log at a specified level right? INFO, DEBUG? To reduce the noise in the logs, I believe we thought DEBUG was enough for this. The isDebugEnabled check is so we don't perform the string concatenation when debug logging is not enabled.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 17m 53s trunk passed
        +1 compile 0m 48s trunk passed
        +1 checkstyle 0m 29s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 19s trunk passed
        +1 findbugs 1m 34s trunk passed
        +1 javadoc 0m 41s trunk passed
        +1 mvninstall 0m 53s the patch passed
        +1 compile 0m 46s the patch passed
        +1 javac 0m 46s the patch passed
        +1 checkstyle 0m 26s the patch passed
        +1 mvnsite 0m 50s the patch passed
        +1 mvneclipse 0m 17s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 41s the patch passed
        +1 javadoc 0m 21s the patch passed
        -1 unit 41m 26s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        71m 19s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestOpportunisticContainerAllocatorAMService
          hadoop.yarn.server.resourcemanager.TestRMRestart



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-6112
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849011/YARN-6112.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux b611a2beee87 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ce83205
        Default Java 1.8.0_121
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14738/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14738/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14738/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 17m 53s trunk passed +1 compile 0m 48s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 19s trunk passed +1 findbugs 1m 34s trunk passed +1 javadoc 0m 41s trunk passed +1 mvninstall 0m 53s the patch passed +1 compile 0m 46s the patch passed +1 javac 0m 46s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 41s the patch passed +1 javadoc 0m 21s the patch passed -1 unit 41m 26s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 71m 19s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestOpportunisticContainerAllocatorAMService   hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6112 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849011/YARN-6112.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b611a2beee87 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ce83205 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/14738/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14738/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/14738/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            yufeigu Yufei Gu
            Reporter:
            yufeigu Yufei Gu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development