Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6104

RegistrySecurity overrides zookeeper sasl system properties

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None

      Description

      If the RM is configured with JAVA_OPTS setting the zookeeper.sasl.client.username and zookeeper.sasl.clientconfig properties, these are ignored and overwritten by RegistrySecurity in setZKSaslClientProperties.

      1. YARN-6104.002.patch
        3 kB
        Billie Rinaldi
      2. YARN-6104.001.patch
        1 kB
        Billie Rinaldi

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11147 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11147/)
        YARN-6104. RegistrySecurity overrides zookeeper sasl system properties. (jianhe: rev efc8faa1bae79c17047e920beeb8af983db08e93)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/RegistrySecurity.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/test/java/org/apache/hadoop/registry/secure/TestSecureRegistry.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11147 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11147/ ) YARN-6104 . RegistrySecurity overrides zookeeper sasl system properties. (jianhe: rev efc8faa1bae79c17047e920beeb8af983db08e93) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/RegistrySecurity.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/test/java/org/apache/hadoop/registry/secure/TestSecureRegistry.java
        Hide
        jianhe Jian He added a comment -

        committed to trunk and branch-2, thanks Billie !

        Show
        jianhe Jian He added a comment - committed to trunk and branch-2, thanks Billie !
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 16m 40s trunk passed
        +1 compile 0m 19s trunk passed
        +1 checkstyle 0m 16s trunk passed
        +1 mvnsite 0m 21s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 0m 33s trunk passed
        +1 javadoc 0m 16s trunk passed
        +1 mvninstall 0m 19s the patch passed
        +1 compile 0m 17s the patch passed
        +1 javac 0m 17s the patch passed
        +1 checkstyle 0m 13s the patch passed
        +1 mvnsite 0m 18s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 34s the patch passed
        +1 javadoc 0m 12s the patch passed
        +1 unit 0m 45s hadoop-yarn-registry in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        23m 26s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-6104
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847884/YARN-6104.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 0a4ec663059c 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 78b487b
        Default Java 1.8.0_111
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14678/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14678/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 16m 40s trunk passed +1 compile 0m 19s trunk passed +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 21s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 0m 33s trunk passed +1 javadoc 0m 16s trunk passed +1 mvninstall 0m 19s the patch passed +1 compile 0m 17s the patch passed +1 javac 0m 17s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 18s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 34s the patch passed +1 javadoc 0m 12s the patch passed +1 unit 0m 45s hadoop-yarn-registry in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 23m 26s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6104 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847884/YARN-6104.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0a4ec663059c 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 78b487b Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14678/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry Console output https://builds.apache.org/job/PreCommit-YARN-Build/14678/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        billie.rinaldi Billie Rinaldi added a comment -

        Added unit test.

        Show
        billie.rinaldi Billie Rinaldi added a comment - Added unit test.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 12m 45s trunk passed
        +1 compile 0m 15s trunk passed
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 16s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 0m 24s trunk passed
        +1 javadoc 0m 12s trunk passed
        +1 mvninstall 0m 13s the patch passed
        +1 compile 0m 12s the patch passed
        +1 javac 0m 12s the patch passed
        +1 checkstyle 0m 11s the patch passed
        +1 mvnsite 0m 14s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 27s the patch passed
        +1 javadoc 0m 10s the patch passed
        +1 unit 0m 40s hadoop-yarn-registry in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        18m 22s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-6104
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847875/YARN-6104.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 29f8309e3735 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 78b487b
        Default Java 1.8.0_111
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14674/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14674/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 12m 45s trunk passed +1 compile 0m 15s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 16s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 24s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 13s the patch passed +1 compile 0m 12s the patch passed +1 javac 0m 12s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 14s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 27s the patch passed +1 javadoc 0m 10s the patch passed +1 unit 0m 40s hadoop-yarn-registry in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 18m 22s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6104 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847875/YARN-6104.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 29f8309e3735 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 78b487b Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14674/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry Console output https://builds.apache.org/job/PreCommit-YARN-Build/14674/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            billie.rinaldi Billie Rinaldi
            Reporter:
            billie.rinaldi Billie Rinaldi
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development