Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6102

RMActiveService context to be updated with new RMContext on failover

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.8.0, 2.7.3
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      2017-01-17 16:42:17,911 FATAL [AsyncDispatcher event handler] event.AsyncDispatcher (AsyncDispatcher.java:dispatch(200)) - Error in dispatcher thread
      java.lang.Exception: No handler for registered for class org.apache.hadoop.yarn.server.resourcemanager.rmnode.RMNodeEventType
              at org.apache.hadoop.yarn.event.AsyncDispatcher.dispatch(AsyncDispatcher.java:196)
              at org.apache.hadoop.yarn.event.AsyncDispatcher$1.run(AsyncDispatcher.java:120)
              at java.lang.Thread.run(Thread.java:745)
      2017-01-17 16:42:17,914 INFO  [AsyncDispatcher ShutDown handler] event.AsyncDispatcher (AsyncDispatcher.java:run(303)) - Exiting, bbye..

      The same stack i was also noticed in TestResourceTrackerOnHA exits abnormally, after some analysis, i was able to reproduce.

      Once the nodeHeartBeat is sent to RM, inside org.apache.hadoop.yarn.server.resourcemanager.ResourceTrackerService.nodeHeartbeat(NodeHeartbeatRequest), before sending it to dispatcher through
      this.rmContext.getDispatcher().getEventHandler().handle(nodeStatusEvent); if RM failover is called, the dispatcher is reset
      The new dispatcher is however first started and then the events are registered at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.reinitialize(boolean)

      So event order will look like
      1. Send Node heartbeat to ResourceTrackerService
      2. In ResourceTrackerService.nodeHeartbeat, before passing to dispatcher call RM failover
      3. In RM Failover, current active will reset dispatcher @reinitialize i.e ( resetDispatcher(); + createAndInitActiveServices(); )

      Now between resetDispatcher(); and createAndInitActiveServices(); , the ResourceTrackerService.nodeHeartbeat invokes dipatcher

      This will cause the above error as at point of time when STATUS_UPDATE event is given to dispatcher in ResourceTrackerService , the new dispatcher(from the failover) may be started but not yet registered for events
      Using same steps(with pausing JVM at debug), i was able to reproduce this in production cluster also. for STATUS_UPDATE active service event, when the service is yet to forward the event to RM dispatcher but a failover is called and dispatcher reset is between resetDispatcher(); & createAndInitActiveServices();

      1. eventOrder.JPG
        30 kB
        Ajith S
      2. YARN-6102.01.patch
        23 kB
        Rohith Sharma K S
      3. YARN-6102.02.patch
        43 kB
        Rohith Sharma K S
      4. YARN-6102.03.patch
        44 kB
        Rohith Sharma K S
      5. YARN-6102.04.patch
        47 kB
        Rohith Sharma K S
      6. YARN-6102.05.patch
        48 kB
        Rohith Sharma K S
      7. YARN-6102.06.patch
        57 kB
        Rohith Sharma K S
      8. YARN-6102.07.patch
        57 kB
        Rohith Sharma K S
      9. YARN-6102-branch-2.001.patch
        46 kB
        Rohith Sharma K S
      10. YARN-6102-branch-2.002.patch
        46 kB
        Rohith Sharma K S
      11. YARN-6102-branch-2.002-addednum.patch
        1.0 kB
        Rohith Sharma K S
      12. YARN-6102-YARN-5355-branch-2.addendum.patch
        7 kB
        Varun Saxena

        Issue Links

          Activity

          Hide
          varun_saxena Varun Saxena added a comment -

          Cherry picked this to YARN-5355-branch-2 too (along with branch-2 addendum). But another addendum was required for YARN-5355-branch-2.
          Updating the addendum patch

          Show
          varun_saxena Varun Saxena added a comment - Cherry picked this to YARN-5355 -branch-2 too (along with branch-2 addendum). But another addendum was required for YARN-5355 -branch-2. Updating the addendum patch
          Hide
          sunilg Sunil G added a comment -

          Test case failures are known. Committing addendum patch to branch-2.

          Show
          sunilg Sunil G added a comment - Test case failures are known. Committing addendum patch to branch-2.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 28s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                branch-2 Compile Tests
          +1 mvninstall 7m 6s branch-2 passed
          +1 compile 0m 32s branch-2 passed with JDK v1.8.0_131
          +1 compile 0m 33s branch-2 passed with JDK v1.7.0_131
          +1 checkstyle 0m 24s branch-2 passed
          +1 mvnsite 0m 39s branch-2 passed
          +1 findbugs 1m 15s branch-2 passed
          +1 javadoc 0m 22s branch-2 passed with JDK v1.8.0_131
          +1 javadoc 0m 24s branch-2 passed with JDK v1.7.0_131
                Patch Compile Tests
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 26s the patch passed with JDK v1.8.0_131
          +1 javac 0m 26s the patch passed
          +1 compile 0m 31s the patch passed with JDK v1.7.0_131
          +1 javac 0m 31s the patch passed
          +1 checkstyle 0m 21s the patch passed
          +1 mvnsite 0m 39s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 26s the patch passed
          +1 javadoc 0m 20s the patch passed with JDK v1.8.0_131
          +1 javadoc 0m 24s the patch passed with JDK v1.7.0_131
                Other Tests
          -1 unit 44m 11s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          106m 4s



          Reason Tests
          JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation
          JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue YARN-6102
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878964/YARN-6102-branch-2.002-addednum.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 91c0aaba5b95 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 554c3cd
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16554/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16554/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16554/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 28s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       branch-2 Compile Tests +1 mvninstall 7m 6s branch-2 passed +1 compile 0m 32s branch-2 passed with JDK v1.8.0_131 +1 compile 0m 33s branch-2 passed with JDK v1.7.0_131 +1 checkstyle 0m 24s branch-2 passed +1 mvnsite 0m 39s branch-2 passed +1 findbugs 1m 15s branch-2 passed +1 javadoc 0m 22s branch-2 passed with JDK v1.8.0_131 +1 javadoc 0m 24s branch-2 passed with JDK v1.7.0_131       Patch Compile Tests +1 mvninstall 0m 32s the patch passed +1 compile 0m 26s the patch passed with JDK v1.8.0_131 +1 javac 0m 26s the patch passed +1 compile 0m 31s the patch passed with JDK v1.7.0_131 +1 javac 0m 31s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 0m 39s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 26s the patch passed +1 javadoc 0m 20s the patch passed with JDK v1.8.0_131 +1 javadoc 0m 24s the patch passed with JDK v1.7.0_131       Other Tests -1 unit 44m 11s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 106m 4s Reason Tests JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue YARN-6102 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878964/YARN-6102-branch-2.002-addednum.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 91c0aaba5b95 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 554c3cd Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/16554/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16554/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16554/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          Opened to run jenkins.

          Show
          sunilg Sunil G added a comment - Opened to run jenkins.
          Hide
          varun_saxena Varun Saxena added a comment -

          I will cherry pick this fix into branch YARN-5355 too to ensure closure of YARN-6847.
          It is also leading to QA report failure in YARN-6130.

          Show
          varun_saxena Varun Saxena added a comment - I will cherry pick this fix into branch YARN-5355 too to ensure closure of YARN-6847 . It is also leading to QA report failure in YARN-6130 .
          Hide
          rohithsharma Rohith Sharma K S added a comment - - edited

          Sunil G as we discussed offline, branch-2 patch was setting dispatcher to new RMContext twice. There is no functionality impact from this but I have updated addednum patch for it.

          Show
          rohithsharma Rohith Sharma K S added a comment - - edited Sunil G as we discussed offline, branch-2 patch was setting dispatcher to new RMContext twice. There is no functionality impact from this but I have updated addednum patch for it.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          thanks Sunil G Jian He Naganarasimha G R Ajith S for the reviews.

          Show
          rohithsharma Rohith Sharma K S added a comment - thanks Sunil G Jian He Naganarasimha G R Ajith S for the reviews.
          Hide
          sunilg Sunil G added a comment -

          Committed to trunk/branch-2. Thanks Rohith Sharma K S for the patch and thanks Jian He Ajith S Naganarasimha Garla for additional reviews.

          Show
          sunilg Sunil G added a comment - Committed to trunk/branch-2. Thanks Rohith Sharma K S for the patch and thanks Jian He Ajith S Naganarasimha Garla for additional reviews.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          test failures are unrelated to the patch.. there are other open JIRA exist.

          Show
          rohithsharma Rohith Sharma K S added a comment - test failures are unrelated to the patch.. there are other open JIRA exist.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                branch-2 Compile Tests
          +1 mvninstall 6m 48s branch-2 passed
          +1 compile 0m 31s branch-2 passed with JDK v1.8.0_131
          +1 compile 0m 33s branch-2 passed with JDK v1.7.0_131
          +1 checkstyle 0m 23s branch-2 passed
          +1 mvnsite 0m 38s branch-2 passed
          +1 findbugs 1m 15s branch-2 passed
          +1 javadoc 0m 21s branch-2 passed with JDK v1.8.0_131
          +1 javadoc 0m 25s branch-2 passed with JDK v1.7.0_131
                Patch Compile Tests
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 29s the patch passed with JDK v1.8.0_131
          +1 javac 0m 29s the patch passed
          +1 compile 0m 31s the patch passed with JDK v1.7.0_131
          +1 javac 0m 31s the patch passed
          +1 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 137 unchanged - 9 fixed = 137 total (was 146)
          +1 mvnsite 0m 38s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 26s the patch passed
          +1 javadoc 0m 20s the patch passed with JDK v1.8.0_131
          +1 javadoc 0m 24s the patch passed with JDK v1.7.0_131
                Other Tests
          -1 unit 44m 59s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          107m 3s



          Reason Tests
          JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation
          JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue YARN-6102
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878594/YARN-6102-branch-2.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 38ad25c33c36 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / c108372
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16529/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16529/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16529/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       branch-2 Compile Tests +1 mvninstall 6m 48s branch-2 passed +1 compile 0m 31s branch-2 passed with JDK v1.8.0_131 +1 compile 0m 33s branch-2 passed with JDK v1.7.0_131 +1 checkstyle 0m 23s branch-2 passed +1 mvnsite 0m 38s branch-2 passed +1 findbugs 1m 15s branch-2 passed +1 javadoc 0m 21s branch-2 passed with JDK v1.8.0_131 +1 javadoc 0m 25s branch-2 passed with JDK v1.7.0_131       Patch Compile Tests +1 mvninstall 0m 32s the patch passed +1 compile 0m 29s the patch passed with JDK v1.8.0_131 +1 javac 0m 29s the patch passed +1 compile 0m 31s the patch passed with JDK v1.7.0_131 +1 javac 0m 31s the patch passed +1 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 137 unchanged - 9 fixed = 137 total (was 146) +1 mvnsite 0m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 26s the patch passed +1 javadoc 0m 20s the patch passed with JDK v1.8.0_131 +1 javadoc 0m 24s the patch passed with JDK v1.7.0_131       Other Tests -1 unit 44m 59s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 107m 3s Reason Tests JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue YARN-6102 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878594/YARN-6102-branch-2.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 38ad25c33c36 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / c108372 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/16529/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16529/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16529/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          updated branch-2 patch fixing findbugs. Test failures are unrelated to patch and many open JIRAs are exist.

          Show
          rohithsharma Rohith Sharma K S added a comment - updated branch-2 patch fixing findbugs. Test failures are unrelated to patch and many open JIRAs are exist.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                branch-2 Compile Tests
          +1 mvninstall 6m 52s branch-2 passed
          +1 compile 0m 31s branch-2 passed with JDK v1.8.0_131
          +1 compile 0m 34s branch-2 passed with JDK v1.7.0_131
          +1 checkstyle 0m 25s branch-2 passed
          +1 mvnsite 0m 40s branch-2 passed
          +1 findbugs 1m 18s branch-2 passed
          +1 javadoc 0m 23s branch-2 passed with JDK v1.8.0_131
          +1 javadoc 0m 26s branch-2 passed with JDK v1.7.0_131
                Patch Compile Tests
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 29s the patch passed with JDK v1.8.0_131
          +1 javac 0m 29s the patch passed
          +1 compile 0m 32s the patch passed with JDK v1.7.0_131
          +1 javac 0m 32s the patch passed
          +1 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 137 unchanged - 9 fixed = 137 total (was 146)
          +1 mvnsite 0m 37s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 1m 33s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 0m 19s the patch passed with JDK v1.8.0_131
          +1 javadoc 0m 23s the patch passed with JDK v1.7.0_131
                Other Tests
          -1 unit 44m 18s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          106m 36s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
            Unused field:ResourceManager.java
          JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
          JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue YARN-6102
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878575/YARN-6102-branch-2.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c2736fc58931 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / daa7685
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16527/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16527/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16527/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16527/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       branch-2 Compile Tests +1 mvninstall 6m 52s branch-2 passed +1 compile 0m 31s branch-2 passed with JDK v1.8.0_131 +1 compile 0m 34s branch-2 passed with JDK v1.7.0_131 +1 checkstyle 0m 25s branch-2 passed +1 mvnsite 0m 40s branch-2 passed +1 findbugs 1m 18s branch-2 passed +1 javadoc 0m 23s branch-2 passed with JDK v1.8.0_131 +1 javadoc 0m 26s branch-2 passed with JDK v1.7.0_131       Patch Compile Tests +1 mvninstall 0m 32s the patch passed +1 compile 0m 29s the patch passed with JDK v1.8.0_131 +1 javac 0m 29s the patch passed +1 compile 0m 32s the patch passed with JDK v1.7.0_131 +1 javac 0m 32s the patch passed +1 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 137 unchanged - 9 fixed = 137 total (was 146) +1 mvnsite 0m 37s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 33s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 0m 19s the patch passed with JDK v1.8.0_131 +1 javadoc 0m 23s the patch passed with JDK v1.7.0_131       Other Tests -1 unit 44m 18s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 106m 36s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager   Unused field:ResourceManager.java JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue YARN-6102 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878575/YARN-6102-branch-2.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c2736fc58931 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / daa7685 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16527/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html unit https://builds.apache.org/job/PreCommit-YARN-Build/16527/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16527/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16527/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          updated branch-2 patch!

          Show
          rohithsharma Rohith Sharma K S added a comment - updated branch-2 patch!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12047 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12047/)
          YARN-6102. RMActiveService context to be updated with new RMContext on (sunilg: rev e3153284288d6cfa7a28511dfefe1c8a7d6b4eda)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TimelineServiceV2Publisher.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TestSystemMetricsPublisherForV2.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/CuratorBasedElectorService.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHA.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMActiveServiceContext.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ActiveStandbyElectorBasedElectorService.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMServiceContext.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMEmbeddedElector.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/timelineservice/RMTimelineCollectorManager.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12047 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12047/ ) YARN-6102 . RMActiveService context to be updated with new RMContext on (sunilg: rev e3153284288d6cfa7a28511dfefe1c8a7d6b4eda) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TimelineServiceV2Publisher.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TestSystemMetricsPublisherForV2.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/CuratorBasedElectorService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHA.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMActiveServiceContext.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ActiveStandbyElectorBasedElectorService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMServiceContext.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMEmbeddedElector.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/timelineservice/RMTimelineCollectorManager.java
          Hide
          sunilg Sunil G added a comment -

          Thanks Rohith Sharma K S, Committed to trunk. branch-2 cherry pick fails though. Please help to share branch-2 patch.

          Show
          sunilg Sunil G added a comment - Thanks Rohith Sharma K S , Committed to trunk. branch-2 cherry pick fails though. Please help to share branch-2 patch.
          Hide
          sunilg Sunil G added a comment -

          +1 . Committing shortly if there are no objections.

          Show
          sunilg Sunil G added a comment - +1 . Committing shortly if there are no objections.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 13m 37s trunk passed
          +1 compile 0m 33s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 36s trunk passed
          +1 findbugs 0m 57s trunk passed
          +1 javadoc 0m 21s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 30s the patch passed
          +1 javac 0m 30s the patch passed
          +1 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 138 unchanged - 8 fixed = 138 total (was 146)
          +1 mvnsite 0m 32s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 3s the patch passed
          +1 javadoc 0m 18s the patch passed
                Other Tests
          -1 unit 42m 39s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          64m 19s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6102
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878121/YARN-6102.07.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux dda060a31f97 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c21c260
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16498/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16498/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16498/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 37s trunk passed +1 compile 0m 33s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 36s trunk passed +1 findbugs 0m 57s trunk passed +1 javadoc 0m 21s trunk passed       Patch Compile Tests +1 mvninstall 0m 32s the patch passed +1 compile 0m 30s the patch passed +1 javac 0m 30s the patch passed +1 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 138 unchanged - 8 fixed = 138 total (was 146) +1 mvnsite 0m 32s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 3s the patch passed +1 javadoc 0m 18s the patch passed       Other Tests -1 unit 42m 39s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 64m 19s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6102 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878121/YARN-6102.07.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dda060a31f97 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c21c260 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/16498/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16498/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16498/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          attached the patch fixing java doc errors.

          Show
          rohithsharma Rohith Sharma K S added a comment - attached the patch fixing java doc errors.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 14m 44s trunk passed
          +1 compile 0m 38s trunk passed
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 0m 37s trunk passed
          +1 findbugs 1m 10s trunk passed
          +1 javadoc 0m 25s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 37s the patch passed
          +1 compile 0m 35s the patch passed
          +1 javac 0m 35s the patch passed
          +1 checkstyle 0m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 137 unchanged - 8 fixed = 137 total (was 145)
          +1 mvnsite 0m 44s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 17s the patch passed
          -1 javadoc 0m 21s hadoop-yarn-server-resourcemanager in the patch failed.
                Other Tests
          -1 unit 43m 23s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          67m 18s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6102
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878100/YARN-6102.06.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 7c3681434861 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c21c260
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16496/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16496/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16496/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16496/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       trunk Compile Tests +1 mvninstall 14m 44s trunk passed +1 compile 0m 38s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 37s trunk passed +1 findbugs 1m 10s trunk passed +1 javadoc 0m 25s trunk passed       Patch Compile Tests +1 mvninstall 0m 37s the patch passed +1 compile 0m 35s the patch passed +1 javac 0m 35s the patch passed +1 checkstyle 0m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 137 unchanged - 8 fixed = 137 total (was 145) +1 mvnsite 0m 44s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 17s the patch passed -1 javadoc 0m 21s hadoop-yarn-server-resourcemanager in the patch failed.       Other Tests -1 unit 43m 23s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 67m 18s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6102 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878100/YARN-6102.06.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7c3681434861 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c21c260 Default Java 1.8.0_131 findbugs v3.1.0-RC1 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16496/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16496/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16496/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16496/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Updating a patch adding more java doc as per Sunil's offline comments.

          Show
          rohithsharma Rohith Sharma K S added a comment - Updating a patch adding more java doc as per Sunil's offline comments.
          Hide
          sunilg Sunil G added a comment -

          RMServiceContext and RMActiveServiceContext is a better option to handle general and HA services which are derived from RMContext. Sounds good. I will take a close at the patch and share comments if any.

          Show
          sunilg Sunil G added a comment - RMServiceContext and RMActiveServiceContext is a better option to handle general and HA services which are derived from RMContext. Sounds good. I will take a close at the patch and share comments if any.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 13m 15s trunk passed
          +1 compile 0m 34s trunk passed
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 0m 36s trunk passed
          +1 findbugs 0m 59s trunk passed
          +1 javadoc 0m 21s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 30s the patch passed
          +1 javac 0m 30s the patch passed
          +1 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 136 unchanged - 7 fixed = 136 total (was 143)
          +1 mvnsite 0m 34s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 4s the patch passed
          +1 javadoc 0m 18s the patch passed
                Other Tests
          -1 unit 42m 17s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          63m 44s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6102
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876856/YARN-6102.05.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4c5902f85adc 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b628d0d
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16383/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16383/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16383/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 15s trunk passed +1 compile 0m 34s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 36s trunk passed +1 findbugs 0m 59s trunk passed +1 javadoc 0m 21s trunk passed       Patch Compile Tests +1 mvninstall 0m 32s the patch passed +1 compile 0m 30s the patch passed +1 javac 0m 30s the patch passed +1 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 136 unchanged - 7 fixed = 136 total (was 143) +1 mvnsite 0m 34s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 4s the patch passed +1 javadoc 0m 18s the patch passed       Other Tests -1 unit 42m 17s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 63m 44s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6102 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876856/YARN-6102.05.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4c5902f85adc 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b628d0d Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/16383/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16383/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16383/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          patch for fixing findbug

          Show
          rohithsharma Rohith Sharma K S added a comment - patch for fixing findbug
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 13m 27s trunk passed
          +1 compile 0m 33s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 37s trunk passed
          +1 findbugs 0m 59s trunk passed
          +1 javadoc 0m 21s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 33s the patch passed
          +1 compile 0m 33s the patch passed
          +1 javac 0m 33s the patch passed
          +1 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 137 unchanged - 6 fixed = 137 total (was 143)
          +1 mvnsite 0m 35s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 1m 12s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          -1 javadoc 0m 19s hadoop-yarn-server-resourcemanager in the patch failed.
                Other Tests
          -1 unit 42m 28s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          64m 18s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
            Unused field:ResourceManager.java
          Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6102
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876831/YARN-6102.04.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a43864a32289 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b628d0d
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16382/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16382/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16382/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16382/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16382/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 27s trunk passed +1 compile 0m 33s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 37s trunk passed +1 findbugs 0m 59s trunk passed +1 javadoc 0m 21s trunk passed       Patch Compile Tests +1 mvninstall 0m 33s the patch passed +1 compile 0m 33s the patch passed +1 javac 0m 33s the patch passed +1 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 137 unchanged - 6 fixed = 137 total (was 143) +1 mvnsite 0m 35s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 12s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) -1 javadoc 0m 19s hadoop-yarn-server-resourcemanager in the patch failed.       Other Tests -1 unit 42m 28s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 64m 18s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager   Unused field:ResourceManager.java Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6102 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876831/YARN-6102.04.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a43864a32289 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b628d0d Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16382/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16382/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16382/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16382/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16382/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          updated the patch fixing review comments.

          1. renamed globalServiceContext to serviceContext.
          2. grouped setters/getters of serviceContext and active service context separately.
          Show
          rohithsharma Rohith Sharma K S added a comment - updated the patch fixing review comments. renamed globalServiceContext to serviceContext. grouped setters/getters of serviceContext and active service context separately.
          Hide
          jianhe Jian He added a comment -

          the rmContext related looks a bit confusing.
          could you add comments to explain what each context means ?
          And maybe call it alwaysOnService instead of globalService ?
          and try to group the setter/getter for each context separately in the code layout and may draw a line in between.

          Show
          jianhe Jian He added a comment - the rmContext related looks a bit confusing. could you add comments to explain what each context means ? And maybe call it alwaysOnService instead of globalService ? and try to group the setter/getter for each context separately in the code layout and may draw a line in between.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 13m 21s trunk passed
          +1 compile 0m 35s trunk passed
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 0m 37s trunk passed
          +1 findbugs 1m 6s trunk passed
          +1 javadoc 0m 22s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 38s the patch passed
          +1 compile 0m 34s the patch passed
          +1 javac 0m 34s the patch passed
          +1 checkstyle 0m 26s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 137 unchanged - 6 fixed = 137 total (was 143)
          +1 mvnsite 0m 41s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 9s the patch passed
          +1 javadoc 0m 21s the patch passed
                Other Tests
          -1 unit 43m 8s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          65m 19s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6102
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876655/YARN-6102.03.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0a261c0a5fb2 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3a7f02b
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16373/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16373/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16373/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 21s trunk passed +1 compile 0m 35s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 37s trunk passed +1 findbugs 1m 6s trunk passed +1 javadoc 0m 22s trunk passed       Patch Compile Tests +1 mvninstall 0m 38s the patch passed +1 compile 0m 34s the patch passed +1 javac 0m 34s the patch passed +1 checkstyle 0m 26s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 137 unchanged - 6 fixed = 137 total (was 143) +1 mvnsite 0m 41s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 9s the patch passed +1 javadoc 0m 21s the patch passed       Other Tests -1 unit 43m 8s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 65m 19s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6102 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876655/YARN-6102.03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0a261c0a5fb2 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3a7f02b Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/16373/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16373/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16373/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 13m 22s trunk passed
          +1 compile 0m 33s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 36s trunk passed
          +1 findbugs 0m 59s trunk passed
          +1 javadoc 0m 21s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 33s the patch passed
          +1 compile 0m 31s the patch passed
          +1 javac 0m 31s the patch passed
          -0 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 6 new + 136 unchanged - 6 fixed = 142 total (was 142)
          +1 mvnsite 0m 33s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 4s the patch passed
          +1 javadoc 0m 19s the patch passed
                Other Tests
          -1 unit 41m 27s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          62m 52s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.resourcetracker.TestRMNMRPCResponseId
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebAppFairScheduler
            hadoop.yarn.server.resourcemanager.TestRMNodeTransitions
            hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestReservationQueue
            hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry
            hadoop.yarn.server.resourcemanager.reservation.TestFairSchedulerPlanFollower
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue
            hadoop.yarn.server.resourcemanager.TestAppManager
            hadoop.yarn.server.resourcemanager.webapp.TestAppPage
            hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestChildQueueOrder
            hadoop.yarn.server.resourcemanager.rmapp.attempt.TestRMAppAttemptTransitions
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestReservations
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler
            hadoop.yarn.server.resourcemanager.resourcetracker.TestNMReconnect
            hadoop.yarn.server.resourcemanager.reservation.TestReservationSystem
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestQueueState
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestQueueMappings
            hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestQueueParsing
            hadoop.yarn.server.resourcemanager.reservation.TestCapacitySchedulerPlanFollower
            hadoop.yarn.server.resourcemanager.webapp.TestRedirectionErrorPage
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestApplicationLimitsByPartition
            hadoop.yarn.server.resourcemanager.logaggregationstatus.TestRMAppLogAggregationStatus
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestQueueStateManager
            hadoop.yarn.server.resourcemanager.scheduler.TestAbstractYarnScheduler
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestParentQueue
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestApplicationLimits
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebApp
            hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
            hadoop.yarn.server.resourcemanager.webapp.TestNodesPage



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6102
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876610/YARN-6102.02.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a0463aae29b3 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 34f113d
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16369/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16369/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16369/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16369/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 22s trunk passed +1 compile 0m 33s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 36s trunk passed +1 findbugs 0m 59s trunk passed +1 javadoc 0m 21s trunk passed       Patch Compile Tests +1 mvninstall 0m 33s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed -0 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 6 new + 136 unchanged - 6 fixed = 142 total (was 142) +1 mvnsite 0m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 4s the patch passed +1 javadoc 0m 19s the patch passed       Other Tests -1 unit 41m 27s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 62m 52s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.resourcetracker.TestRMNMRPCResponseId   hadoop.yarn.server.resourcemanager.webapp.TestRMWebAppFairScheduler   hadoop.yarn.server.resourcemanager.TestRMNodeTransitions   hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestReservationQueue   hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry   hadoop.yarn.server.resourcemanager.reservation.TestFairSchedulerPlanFollower   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue   hadoop.yarn.server.resourcemanager.TestAppManager   hadoop.yarn.server.resourcemanager.webapp.TestAppPage   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestChildQueueOrder   hadoop.yarn.server.resourcemanager.rmapp.attempt.TestRMAppAttemptTransitions   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestReservations   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler   hadoop.yarn.server.resourcemanager.resourcetracker.TestNMReconnect   hadoop.yarn.server.resourcemanager.reservation.TestReservationSystem   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestQueueState   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestQueueMappings   hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestQueueParsing   hadoop.yarn.server.resourcemanager.reservation.TestCapacitySchedulerPlanFollower   hadoop.yarn.server.resourcemanager.webapp.TestRedirectionErrorPage   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestApplicationLimitsByPartition   hadoop.yarn.server.resourcemanager.logaggregationstatus.TestRMAppLogAggregationStatus   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestQueueStateManager   hadoop.yarn.server.resourcemanager.scheduler.TestAbstractYarnScheduler   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestParentQueue   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestApplicationLimits   hadoop.yarn.server.resourcemanager.webapp.TestRMWebApp   hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer   hadoop.yarn.server.resourcemanager.webapp.TestNodesPage Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6102 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876610/YARN-6102.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a0463aae29b3 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 34f113d Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16369/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16369/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16369/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16369/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          updated the patch adding test case and some minor refactoring of RMContext.

          Show
          rohithsharma Rohith Sharma K S added a comment - updated the patch adding test case and some minor refactoring of RMContext.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Assigning JIRA to myself as reporter not responded for a while.

          Show
          rohithsharma Rohith Sharma K S added a comment - Assigning JIRA to myself as reporter not responded for a while.
          Hide
          sunilg Sunil G added a comment -

          How about recreating RMContext for each transition?

          I think this is a better and cleaner solution here. Other option will delay the switchover given some events are pending in dispatcher queue.
          Also this solution does not impact the new active services, give old events will play out with old context and which will be taken back by gc later.

          Show
          sunilg Sunil G added a comment - How about recreating RMContext for each transition? I think this is a better and cleaner solution here. Other option will delay the switchover given some events are pending in dispatcher queue. Also this solution does not impact the new active services, give old events will play out with old context and which will be taken back by gc later.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 13m 19s trunk passed
          +1 compile 0m 35s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 36s trunk passed
          +1 findbugs 0m 57s trunk passed
          +1 javadoc 0m 21s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 30s the patch passed
          +1 javac 0m 30s the patch passed
          -0 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 118 unchanged - 2 fixed = 119 total (was 120)
          +1 mvnsite 0m 33s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 4s the patch passed
          +1 javadoc 0m 19s the patch passed
                Other Tests
          -1 unit 42m 16s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          63m 37s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
            hadoop.yarn.server.resourcemanager.metrics.TestSystemMetricsPublisher



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6102
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876398/YARN-6102.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3bf7535a2df2 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3de47ab
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16348/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16348/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16348/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16348/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 19s trunk passed +1 compile 0m 35s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 36s trunk passed +1 findbugs 0m 57s trunk passed +1 javadoc 0m 21s trunk passed       Patch Compile Tests +1 mvninstall 0m 32s the patch passed +1 compile 0m 30s the patch passed +1 javac 0m 30s the patch passed -0 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 118 unchanged - 2 fixed = 119 total (was 120) +1 mvnsite 0m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 4s the patch passed +1 javadoc 0m 19s the patch passed       Other Tests -1 unit 42m 16s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 63m 37s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer   hadoop.yarn.server.resourcemanager.metrics.TestSystemMetricsPublisher Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6102 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876398/YARN-6102.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3bf7535a2df2 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3de47ab Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16348/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16348/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16348/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16348/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          updated the proposed 2nd solution that modifies YARN code.

          Show
          rohithsharma Rohith Sharma K S added a comment - updated the proposed 2nd solution that modifies YARN code.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          I think there are 2 solution to solve this issue.

          1. Ensure RPC threads are stopped. This would be expensive where in every thread need to join or any other mechanism.
          2. How about recreating RMContext for each transition? This allows to take always new context and deal with it. cc :/ Jian He
          Show
          rohithsharma Rohith Sharma K S added a comment - I think there are 2 solution to solve this issue. Ensure RPC threads are stopped. This would be expensive where in every thread need to join or any other mechanism. How about recreating RMContext for each transition? This allows to take always new context and deal with it. cc :/ Jian He
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          thanks Ajith S and Naganarasimha G R for explanation.

          Stopping of service will not stop the rpc thread handling the current event/call

          ahh .. I see.. then as a solution need to ensure RPC threads are stopped before return from service stop method.

          Ajith S would you change your patch to ensuring RPC threads are stopped? This will common solution for all such race condition issues.

          Show
          rohithsharma Rohith Sharma K S added a comment - thanks Ajith S and Naganarasimha G R for explanation. Stopping of service will not stop the rpc thread handling the current event/call ahh .. I see.. then as a solution need to ensure RPC threads are stopped before return from service stop method. Ajith S would you change your patch to ensuring RPC threads are stopped? This will common solution for all such race condition issues.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          To add to Ajith S 's point, Stopping of service will not stop the rpc thread handling the current event/call. So if node heartbeat has come to ResourceTrackerService and before it send the nodeStatusEvent if the failover happens and the dispatcher is replaced in RMcontext, this issue can occur. (Event order also capturing the same !)

          Show
          Naganarasimha Naganarasimha G R added a comment - To add to Ajith S 's point, Stopping of service will not stop the rpc thread handling the current event/call. So if node heartbeat has come to ResourceTrackerService and before it send the nodeStatusEvent if the failover happens and the dispatcher is replaced in RMcontext, this issue can occur. (Event order also capturing the same !)
          Hide
          ajithshetty Ajith S added a comment -

          attaching event order for reference

          Show
          ajithshetty Ajith S added a comment - attaching event order for reference
          Hide
          ajithshetty Ajith S added a comment - - edited

          Rohith Sharma K S and Sunil G
          As i mentioned, the nodeheart beat has been triggered and received by resourcetracker service before service stop, but not yet passed to dispatcher so its drainEvent will not process it

          Show
          ajithshetty Ajith S added a comment - - edited Rohith Sharma K S and Sunil G As i mentioned, the nodeheart beat has been triggered and received by resourcetracker service before service stop, but not yet passed to dispatcher so its drainEvent will not process it
          Hide
          sunilg Sunil G added a comment -

          In resetDispatcher,

          (1)    removeService((Service)rmDispatcher);
              // Need to stop previous rmDispatcher before assigning new dispatcher
              // otherwise causes "AsyncDispatcher event handler" thread leak
          (2)    ((Service) rmDispatcher).stop();
              rmDispatcher = dispatcher;
              addIfService(rmDispatcher);
          (3)  rmContext.setDispatcher(rmDispatcher);
          

          RPC is already stopped. At (2), dispatcher is also stopped. Altogether, there wont be any more new events cached, and all events would have been drained. Later at (3), we set a new dispatcher. At this time, ideally there should not be any events sent to old dispatcher. Could you attach more logs etc.

          Show
          sunilg Sunil G added a comment - In resetDispatcher, (1) removeService((Service)rmDispatcher); // Need to stop previous rmDispatcher before assigning new dispatcher // otherwise causes "AsyncDispatcher event handler" thread leak (2) ((Service) rmDispatcher).stop(); rmDispatcher = dispatcher; addIfService(rmDispatcher); (3) rmContext.setDispatcher(rmDispatcher); RPC is already stopped. At (2), dispatcher is also stopped. Altogether, there wont be any more new events cached, and all events would have been drained. Later at (3), we set a new dispatcher. At this time, ideally there should not be any events sent to old dispatcher. Could you attach more logs etc.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Before dispatcher reset, active services stop has been called. As a result, node heart beat wont be triggered after service stop has been called. While resetting dispatcher, only outstanding events are processed from AsyncDispatcher i.e stop(). I am wondering how previously triggered event is added to newly created dispatcher? Is there issue with stop()?
          Could you attach a test only patch recurring this scenario which will be very much helpful?

          Show
          rohithsharma Rohith Sharma K S added a comment - Before dispatcher reset, active services stop has been called. As a result, node heart beat wont be triggered after service stop has been called. While resetting dispatcher, only outstanding events are processed from AsyncDispatcher i.e stop(). I am wondering how previously triggered event is added to newly created dispatcher? Is there issue with stop()? Could you attach a test only patch recurring this scenario which will be very much helpful?
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Good catch Ajith S,
          But i would not recommend the first approach here as the problem is older services in RM's active service if it refer to the newer Async dispatcher then state of the services will not be proper. I would prefer to go with the 2nd approach itself and as well we might need to handle for all the active services, i.e. dispatcher should be saved durign the init and refer to it rather than getting it from rmContext.

          Show
          Naganarasimha Naganarasimha G R added a comment - Good catch Ajith S , But i would not recommend the first approach here as the problem is older services in RM's active service if it refer to the newer Async dispatcher then state of the services will not be proper. I would prefer to go with the 2nd approach itself and as well we might need to handle for all the active services, i.e. dispatcher should be saved durign the init and refer to it rather than getting it from rmContext .
          Hide
          ajithshetty Ajith S added a comment -

          Here i can think of two approaches
          1. We correct the flow of starting AsyncDispatcher in org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.reinitialize(boolean) i.e first register and then start
          2. We pass the dispatcher object instance to active services and using that for all operations so that it avoids using the new dispatcher on failover for old events

          Please suggest

          Show
          ajithshetty Ajith S added a comment - Here i can think of two approaches 1. We correct the flow of starting AsyncDispatcher in org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.reinitialize(boolean) i.e first register and then start 2. We pass the dispatcher object instance to active services and using that for all operations so that it avoids using the new dispatcher on failover for old events Please suggest

            People

            • Assignee:
              rohithsharma Rohith Sharma K S
              Reporter:
              ajithshetty Ajith S
            • Votes:
              0 Vote for this issue
              Watchers:
              14 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development