Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6022

Revert changes of AbstractResourceRequest

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None

      Description

      YARN-5774 added AbstractResourceRequest to make easier internal scheduler change, this is not a correct approach: For example, with this change, we need to make AbstractResourceRequest to be public/stable. And end users can use it like:

      AbstractResourceRequest request = ...
      request.setCapability(...)
      

      But AbstractResourceRequest should not be visible by application at all.

      We need to revert it from branch-2.8 / branch-2 / trunk.

      1. YARN-6022.branch-2.006.patch
        15 kB
        Daniel Templeton
      2. YARN-6022.branch-2.005.patch
        15 kB
        Daniel Templeton
      3. YARN-6022.005.patch
        16 kB
        Daniel Templeton
      4. YARN-6022.004.patch
        16 kB
        Daniel Templeton
      5. YARN-6022.003.patch
        15 kB
        Wangda Tan
      6. YARN-6022.002.patch
        15 kB
        Wangda Tan
      7. YARN-6022.001.patch
        15 kB
        Wangda Tan

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12840 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12840/)
        Revert "YARN-6022. Document Docker work as experimental (Contributed by (templedf: rev 07951b586e273ed8596c5f24b1e8d7f627d0104c)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/DockerContainers.md
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12840 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12840/ ) Revert " YARN-6022 . Document Docker work as experimental (Contributed by (templedf: rev 07951b586e273ed8596c5f24b1e8d7f627d0104c) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/DockerContainers.md
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12838 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12838/)
        YARN-6022. Document Docker work as experimental (Contributed by Varun (templedf: rev 66be6c848b47ae7248b0658e3bb2149d2387cebd)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/DockerContainers.md
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12838 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12838/ ) YARN-6022 . Document Docker work as experimental (Contributed by Varun (templedf: rev 66be6c848b47ae7248b0658e3bb2149d2387cebd) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/DockerContainers.md
        Hide
        leftnoteasy Wangda Tan added a comment -

        Committed to branch-2, and it is already committed to trunk.

        Thanks reviews from Daniel Templeton/Arun Suresh/Junping Du/Karthik Kambatla!

        Show
        leftnoteasy Wangda Tan added a comment - Committed to branch-2, and it is already committed to trunk. Thanks reviews from Daniel Templeton / Arun Suresh / Junping Du / Karthik Kambatla !
        Hide
        leftnoteasy Wangda Tan added a comment -

        Daniel Templeton,

        Really appreciate your help for updating branch-2 patch. +1 and will commit it soon.

        Show
        leftnoteasy Wangda Tan added a comment - Daniel Templeton , Really appreciate your help for updating branch-2 patch. +1 and will commit it soon.
        Hide
        templedf Daniel Templeton added a comment -

        Wangda Tan, since I did the branch-2 patch, do I need your +1 to commit it?

        Show
        templedf Daniel Templeton added a comment - Wangda Tan , since I did the branch-2 patch, do I need your +1 to commit it?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 11s Maven dependency ordering for branch
        +1 mvninstall 7m 20s branch-2 passed
        +1 compile 2m 45s branch-2 passed with JDK v1.8.0_111
        +1 compile 2m 39s branch-2 passed with JDK v1.7.0_121
        +1 checkstyle 0m 45s branch-2 passed
        +1 mvnsite 1m 16s branch-2 passed
        +1 mvneclipse 0m 31s branch-2 passed
        +1 findbugs 2m 45s branch-2 passed
        +1 javadoc 0m 52s branch-2 passed with JDK v1.8.0_111
        +1 javadoc 0m 47s branch-2 passed with JDK v1.7.0_121
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 1m 7s the patch passed
        +1 compile 2m 42s the patch passed with JDK v1.8.0_111
        +1 javac 2m 42s the patch passed
        +1 compile 2m 37s the patch passed with JDK v1.7.0_121
        +1 javac 2m 37s the patch passed
        -0 checkstyle 0m 47s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 159 unchanged - 1 fixed = 161 total (was 160)
        +1 mvnsite 1m 15s the patch passed
        +1 mvneclipse 0m 30s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 11s the patch passed
        +1 javadoc 0m 40s the patch passed with JDK v1.8.0_111
        +1 javadoc 0m 46s the patch passed with JDK v1.7.0_121
        +1 unit 0m 29s hadoop-yarn-api in the patch passed with JDK v1.7.0_121.
        -1 unit 41m 53s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        125m 8s



        Reason Tests
        JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart
          hadoop.yarn.server.resourcemanager.TestRMRestart



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue YARN-6022
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846496/YARN-6022.branch-2.006.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f07d2ba477e0 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / b600577
        Default Java 1.7.0_121
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14617/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14617/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt
        JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14617/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14617/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 7m 20s branch-2 passed +1 compile 2m 45s branch-2 passed with JDK v1.8.0_111 +1 compile 2m 39s branch-2 passed with JDK v1.7.0_121 +1 checkstyle 0m 45s branch-2 passed +1 mvnsite 1m 16s branch-2 passed +1 mvneclipse 0m 31s branch-2 passed +1 findbugs 2m 45s branch-2 passed +1 javadoc 0m 52s branch-2 passed with JDK v1.8.0_111 +1 javadoc 0m 47s branch-2 passed with JDK v1.7.0_121 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 7s the patch passed +1 compile 2m 42s the patch passed with JDK v1.8.0_111 +1 javac 2m 42s the patch passed +1 compile 2m 37s the patch passed with JDK v1.7.0_121 +1 javac 2m 37s the patch passed -0 checkstyle 0m 47s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 159 unchanged - 1 fixed = 161 total (was 160) +1 mvnsite 1m 15s the patch passed +1 mvneclipse 0m 30s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 11s the patch passed +1 javadoc 0m 40s the patch passed with JDK v1.8.0_111 +1 javadoc 0m 46s the patch passed with JDK v1.7.0_121 +1 unit 0m 29s hadoop-yarn-api in the patch passed with JDK v1.7.0_121. -1 unit 41m 53s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 125m 8s Reason Tests JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart   hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue YARN-6022 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846496/YARN-6022.branch-2.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f07d2ba477e0 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / b600577 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14617/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14617/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14617/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14617/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        Oops. Screwed up patch5. Hopefully this works better.

        Show
        templedf Daniel Templeton added a comment - Oops. Screwed up patch5. Hopefully this works better.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 13s Maven dependency ordering for branch
        +1 mvninstall 10m 7s branch-2 passed
        +1 compile 2m 36s branch-2 passed with JDK v1.8.0_111
        +1 compile 2m 39s branch-2 passed with JDK v1.7.0_121
        +1 checkstyle 0m 55s branch-2 passed
        +1 mvnsite 1m 20s branch-2 passed
        +1 mvneclipse 0m 34s branch-2 passed
        +1 findbugs 2m 50s branch-2 passed
        +1 javadoc 0m 49s branch-2 passed with JDK v1.8.0_111
        +1 javadoc 0m 53s branch-2 passed with JDK v1.7.0_121
        0 mvndep 0m 13s Maven dependency ordering for patch
        -1 mvninstall 0m 23s hadoop-yarn-server-resourcemanager in the patch failed.
        -1 compile 1m 41s hadoop-yarn in the patch failed with JDK v1.8.0_111.
        -1 javac 1m 41s hadoop-yarn in the patch failed with JDK v1.8.0_111.
        -1 compile 1m 54s hadoop-yarn in the patch failed with JDK v1.7.0_121.
        -1 javac 1m 54s hadoop-yarn in the patch failed with JDK v1.7.0_121.
        -0 checkstyle 0m 49s hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 158 unchanged - 1 fixed = 161 total (was 159)
        -1 mvnsite 0m 27s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 mvneclipse 0m 32s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 0m 25s hadoop-yarn-server-resourcemanager in the patch failed.
        -1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111 with JDK v1.8.0_111 generated 1 new + 921 unchanged - 0 fixed = 922 total (was 921)
        -1 javadoc 0m 28s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121 with JDK v1.7.0_121 generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
        +1 unit 0m 32s hadoop-yarn-api in the patch passed with JDK v1.7.0_121.
        -1 unit 0m 24s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121.
        +1 asflicense 0m 24s The patch does not generate ASF License warnings.
        44m 54s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue YARN-6022
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846188/YARN-6022.branch-2.005.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f42c7ec48725 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / ba5d482
        Default Java 1.7.0_121
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
        findbugs v3.0.0
        mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        compile https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_111.txt
        javac https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_111.txt
        compile https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_121.txt
        javac https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_121.txt
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt
        JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14600/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14600/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 10m 7s branch-2 passed +1 compile 2m 36s branch-2 passed with JDK v1.8.0_111 +1 compile 2m 39s branch-2 passed with JDK v1.7.0_121 +1 checkstyle 0m 55s branch-2 passed +1 mvnsite 1m 20s branch-2 passed +1 mvneclipse 0m 34s branch-2 passed +1 findbugs 2m 50s branch-2 passed +1 javadoc 0m 49s branch-2 passed with JDK v1.8.0_111 +1 javadoc 0m 53s branch-2 passed with JDK v1.7.0_121 0 mvndep 0m 13s Maven dependency ordering for patch -1 mvninstall 0m 23s hadoop-yarn-server-resourcemanager in the patch failed. -1 compile 1m 41s hadoop-yarn in the patch failed with JDK v1.8.0_111. -1 javac 1m 41s hadoop-yarn in the patch failed with JDK v1.8.0_111. -1 compile 1m 54s hadoop-yarn in the patch failed with JDK v1.7.0_121. -1 javac 1m 54s hadoop-yarn in the patch failed with JDK v1.7.0_121. -0 checkstyle 0m 49s hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 158 unchanged - 1 fixed = 161 total (was 159) -1 mvnsite 0m 27s hadoop-yarn-server-resourcemanager in the patch failed. +1 mvneclipse 0m 32s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 25s hadoop-yarn-server-resourcemanager in the patch failed. -1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111 with JDK v1.8.0_111 generated 1 new + 921 unchanged - 0 fixed = 922 total (was 921) -1 javadoc 0m 28s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121 with JDK v1.7.0_121 generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) +1 unit 0m 32s hadoop-yarn-api in the patch passed with JDK v1.7.0_121. -1 unit 0m 24s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 44m 54s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue YARN-6022 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846188/YARN-6022.branch-2.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f42c7ec48725 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / ba5d482 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_111.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_111.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_121.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_121.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14600/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14600/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14600/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 1s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 30s Maven dependency ordering for branch
        +1 mvninstall 7m 40s branch-2 passed
        +1 compile 2m 16s branch-2 passed with JDK v1.8.0_111
        +1 compile 2m 25s branch-2 passed with JDK v1.7.0_121
        +1 checkstyle 0m 46s branch-2 passed
        +1 mvnsite 1m 16s branch-2 passed
        +1 mvneclipse 0m 31s branch-2 passed
        +1 findbugs 2m 34s branch-2 passed
        +1 javadoc 0m 42s branch-2 passed with JDK v1.8.0_111
        +1 javadoc 0m 46s branch-2 passed with JDK v1.7.0_121
        0 mvndep 0m 12s Maven dependency ordering for patch
        -1 mvninstall 0m 21s hadoop-yarn-server-resourcemanager in the patch failed.
        -1 compile 1m 41s hadoop-yarn in the patch failed with JDK v1.8.0_111.
        -1 javac 1m 41s hadoop-yarn in the patch failed with JDK v1.8.0_111.
        -1 compile 1m 38s hadoop-yarn in the patch failed with JDK v1.7.0_121.
        -1 javac 1m 38s hadoop-yarn in the patch failed with JDK v1.7.0_121.
        -0 checkstyle 0m 44s hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 158 unchanged - 1 fixed = 161 total (was 159)
        -1 mvnsite 0m 23s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 mvneclipse 0m 29s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 0m 23s hadoop-yarn-server-resourcemanager in the patch failed.
        -1 javadoc 0m 22s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111 with JDK v1.8.0_111 generated 1 new + 921 unchanged - 0 fixed = 922 total (was 921)
        -1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121 with JDK v1.7.0_121 generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
        +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_121.
        -1 unit 0m 21s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        39m 50s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue YARN-6022
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846188/YARN-6022.branch-2.005.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 0ffd0c73ea0f 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / ba5d482
        Default Java 1.7.0_121
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
        findbugs v3.0.0
        mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        compile https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_111.txt
        javac https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_111.txt
        compile https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_121.txt
        javac https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_121.txt
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt
        JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14599/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14599/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 1s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 30s Maven dependency ordering for branch +1 mvninstall 7m 40s branch-2 passed +1 compile 2m 16s branch-2 passed with JDK v1.8.0_111 +1 compile 2m 25s branch-2 passed with JDK v1.7.0_121 +1 checkstyle 0m 46s branch-2 passed +1 mvnsite 1m 16s branch-2 passed +1 mvneclipse 0m 31s branch-2 passed +1 findbugs 2m 34s branch-2 passed +1 javadoc 0m 42s branch-2 passed with JDK v1.8.0_111 +1 javadoc 0m 46s branch-2 passed with JDK v1.7.0_121 0 mvndep 0m 12s Maven dependency ordering for patch -1 mvninstall 0m 21s hadoop-yarn-server-resourcemanager in the patch failed. -1 compile 1m 41s hadoop-yarn in the patch failed with JDK v1.8.0_111. -1 javac 1m 41s hadoop-yarn in the patch failed with JDK v1.8.0_111. -1 compile 1m 38s hadoop-yarn in the patch failed with JDK v1.7.0_121. -1 javac 1m 38s hadoop-yarn in the patch failed with JDK v1.7.0_121. -0 checkstyle 0m 44s hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 158 unchanged - 1 fixed = 161 total (was 159) -1 mvnsite 0m 23s hadoop-yarn-server-resourcemanager in the patch failed. +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 23s hadoop-yarn-server-resourcemanager in the patch failed. -1 javadoc 0m 22s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111 with JDK v1.8.0_111 generated 1 new + 921 unchanged - 0 fixed = 922 total (was 921) -1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121 with JDK v1.7.0_121 generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_121. -1 unit 0m 21s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 39m 50s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue YARN-6022 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846188/YARN-6022.branch-2.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0ffd0c73ea0f 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / ba5d482 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_111.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_111.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_121.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_121.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14599/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14599/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14599/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11084 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11084/)
        YARN-6022. Revert changes of AbstractResourceRequest (Contributed by (templedf: rev ac16400e1fb85a4186e5bf5bbc9cf204735ae74f)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceRequest.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/UpdateContainerRequest.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAppManager.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMServerUtils.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/YarnScheduler.java
        • (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/AbstractResourceRequest.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerUtils.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/scheduler/SchedulerRequestKey.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11084 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11084/ ) YARN-6022 . Revert changes of AbstractResourceRequest (Contributed by (templedf: rev ac16400e1fb85a4186e5bf5bbc9cf204735ae74f) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceRequest.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/UpdateContainerRequest.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAppManager.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMServerUtils.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/YarnScheduler.java (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/AbstractResourceRequest.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerUtils.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/scheduler/SchedulerRequestKey.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java
        Hide
        templedf Daniel Templeton added a comment -

        There was a trivial conflict in branch-2. Here's the adjusted patch.

        Show
        templedf Daniel Templeton added a comment - There was a trivial conflict in branch-2. Here's the adjusted patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 9s Maven dependency ordering for branch
        +1 mvninstall 12m 28s trunk passed
        +1 compile 4m 53s trunk passed
        +1 checkstyle 0m 45s trunk passed
        +1 mvnsite 1m 36s trunk passed
        +1 mvneclipse 0m 57s trunk passed
        +1 findbugs 2m 52s trunk passed
        +1 javadoc 1m 10s trunk passed
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 1m 12s the patch passed
        +1 compile 4m 35s the patch passed
        +1 javac 4m 35s the patch passed
        -0 checkstyle 0m 43s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 146 unchanged - 2 fixed = 148 total (was 148)
        +1 mvnsite 1m 33s the patch passed
        +1 mvneclipse 0m 54s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 13s the patch passed
        +1 javadoc 1m 8s the patch passed
        +1 unit 0m 29s hadoop-yarn-api in the patch passed.
        +1 unit 0m 32s hadoop-yarn-server-common in the patch passed.
        -1 unit 39m 27s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 28s The patch does not generate ASF License warnings.
        87m 50s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-6022
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846047/YARN-6022.005.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 972746ffab7d 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 2977bc6
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14590/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14590/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14590/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14590/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 12m 28s trunk passed +1 compile 4m 53s trunk passed +1 checkstyle 0m 45s trunk passed +1 mvnsite 1m 36s trunk passed +1 mvneclipse 0m 57s trunk passed +1 findbugs 2m 52s trunk passed +1 javadoc 1m 10s trunk passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 12s the patch passed +1 compile 4m 35s the patch passed +1 javac 4m 35s the patch passed -0 checkstyle 0m 43s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 146 unchanged - 2 fixed = 148 total (was 148) +1 mvnsite 1m 33s the patch passed +1 mvneclipse 0m 54s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 13s the patch passed +1 javadoc 1m 8s the patch passed +1 unit 0m 29s hadoop-yarn-api in the patch passed. +1 unit 0m 32s hadoop-yarn-server-common in the patch passed. -1 unit 39m 27s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 87m 50s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6022 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846047/YARN-6022.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 972746ffab7d 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2977bc6 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14590/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14590/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14590/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14590/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        Now that Jenkins is happy, I'll commit this afternoon.

        Show
        templedf Daniel Templeton added a comment - Now that Jenkins is happy, I'll commit this afternoon.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 12s Maven dependency ordering for branch
        +1 mvninstall 15m 7s trunk passed
        +1 compile 5m 47s trunk passed
        +1 checkstyle 0m 51s trunk passed
        +1 mvnsite 1m 50s trunk passed
        +1 mvneclipse 1m 2s trunk passed
        +1 findbugs 3m 43s trunk passed
        +1 javadoc 1m 18s trunk passed
        0 mvndep 0m 12s Maven dependency ordering for patch
        +1 mvninstall 1m 32s the patch passed
        +1 compile 5m 29s the patch passed
        +1 javac 5m 29s the patch passed
        -0 checkstyle 0m 52s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 146 unchanged - 2 fixed = 148 total (was 148)
        +1 mvnsite 1m 58s the patch passed
        +1 mvneclipse 0m 57s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 47s the patch passed
        +1 javadoc 1m 13s the patch passed
        +1 unit 0m 35s hadoop-yarn-api in the patch passed.
        +1 unit 0m 37s hadoop-yarn-server-common in the patch passed.
        +1 unit 41m 45s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 31s The patch does not generate ASF License warnings.
        98m 6s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-6022
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846047/YARN-6022.005.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 7e178cba6479 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 2977bc6
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14589/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14589/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14589/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 12s Maven dependency ordering for branch +1 mvninstall 15m 7s trunk passed +1 compile 5m 47s trunk passed +1 checkstyle 0m 51s trunk passed +1 mvnsite 1m 50s trunk passed +1 mvneclipse 1m 2s trunk passed +1 findbugs 3m 43s trunk passed +1 javadoc 1m 18s trunk passed 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 1m 32s the patch passed +1 compile 5m 29s the patch passed +1 javac 5m 29s the patch passed -0 checkstyle 0m 52s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 146 unchanged - 2 fixed = 148 total (was 148) +1 mvnsite 1m 58s the patch passed +1 mvneclipse 0m 57s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 47s the patch passed +1 javadoc 1m 13s the patch passed +1 unit 0m 35s hadoop-yarn-api in the patch passed. +1 unit 0m 37s hadoop-yarn-server-common in the patch passed. +1 unit 41m 45s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 98m 6s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6022 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846047/YARN-6022.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7e178cba6479 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2977bc6 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14589/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14589/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14589/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        Fixed checkstyle and javadoc issues.

        Show
        templedf Daniel Templeton added a comment - Fixed checkstyle and javadoc issues.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 32s Maven dependency ordering for branch
        +1 mvninstall 12m 35s trunk passed
        +1 compile 5m 7s trunk passed
        +1 checkstyle 0m 44s trunk passed
        +1 mvnsite 1m 43s trunk passed
        +1 mvneclipse 0m 57s trunk passed
        +1 findbugs 2m 59s trunk passed
        +1 javadoc 1m 10s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 12s the patch passed
        +1 compile 4m 34s the patch passed
        +1 javac 4m 34s the patch passed
        -0 checkstyle 0m 44s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 146 unchanged - 2 fixed = 150 total (was 148)
        +1 mvnsite 1m 33s the patch passed
        +1 mvneclipse 0m 55s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 13s the patch passed
        -1 javadoc 0m 25s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 1 new + 913 unchanged - 0 fixed = 914 total (was 913)
        +1 unit 0m 31s hadoop-yarn-api in the patch passed.
        +1 unit 0m 32s hadoop-yarn-server-common in the patch passed.
        -1 unit 39m 30s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 31s The patch does not generate ASF License warnings.
        88m 53s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-6022
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845907/YARN-6022.004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 4bca9e47b577 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8850c05
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14575/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14575/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14575/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14575/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14575/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 32s Maven dependency ordering for branch +1 mvninstall 12m 35s trunk passed +1 compile 5m 7s trunk passed +1 checkstyle 0m 44s trunk passed +1 mvnsite 1m 43s trunk passed +1 mvneclipse 0m 57s trunk passed +1 findbugs 2m 59s trunk passed +1 javadoc 1m 10s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 12s the patch passed +1 compile 4m 34s the patch passed +1 javac 4m 34s the patch passed -0 checkstyle 0m 44s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 146 unchanged - 2 fixed = 150 total (was 148) +1 mvnsite 1m 33s the patch passed +1 mvneclipse 0m 55s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 13s the patch passed -1 javadoc 0m 25s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 1 new + 913 unchanged - 0 fixed = 914 total (was 913) +1 unit 0m 31s hadoop-yarn-api in the patch passed. +1 unit 0m 32s hadoop-yarn-server-common in the patch passed. -1 unit 39m 30s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 88m 53s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6022 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845907/YARN-6022.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4bca9e47b577 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8850c05 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14575/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14575/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14575/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14575/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14575/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        leftnoteasy Wangda Tan added a comment -
        Show
        leftnoteasy Wangda Tan added a comment - Thanks Daniel Templeton !
        Hide
        templedf Daniel Templeton added a comment -

        Rebased patch. I'll commit after Jenkins gives me the all-clear.

        Show
        templedf Daniel Templeton added a comment - Rebased patch. I'll commit after Jenkins gives me the all-clear.
        Hide
        templedf Daniel Templeton added a comment -

        Bah, nevermind. The conflict is trivial. I'll take care of it.

        Show
        templedf Daniel Templeton added a comment - Bah, nevermind. The conflict is trivial. I'll take care of it.
        Hide
        templedf Daniel Templeton added a comment -

        Sorry, Wangda Tan, there's a conflict now. Mind rebasing?

        Show
        templedf Daniel Templeton added a comment - Sorry, Wangda Tan , there's a conflict now. Mind rebasing?
        Hide
        templedf Daniel Templeton added a comment -

        Fair point. Fine, let's just get this in. +1 I'll commit tomorrow if no one else pops up with any concerns.

        Show
        templedf Daniel Templeton added a comment - Fair point. Fine, let's just get this in. +1 I'll commit tomorrow if no one else pops up with any concerns.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Daniel Templeton, I'm afraid not, since ResourceRequest doesn't have accept to scheduler Java project. Another approach is to use Resource.set(...) method to update fields of Resource in-place, however, when Resource is a read-only instance (like Resources.NONE), it throws runtime exception and bring down RM. So I think we may need to keep it like this.

        Show
        leftnoteasy Wangda Tan added a comment - Daniel Templeton , I'm afraid not, since ResourceRequest doesn't have accept to scheduler Java project. Another approach is to use Resource.set(...) method to update fields of Resource in-place, however, when Resource is a read-only instance (like Resources.NONE), it throws runtime exception and bring down RM. So I think we may need to keep it like this.
        Hide
        templedf Daniel Templeton added a comment -

        The last patch looks clean. Looking at it, though, request.setCapability(scheduler.getNormalizedResource(request.getCapability())) seems like a really clumsy construct. Would it be less awkward to add a @Private normalize method to the request classes so we could call request.normalize(scheduler) instead?

        Show
        templedf Daniel Templeton added a comment - The last patch looks clean. Looking at it, though, request.setCapability(scheduler.getNormalizedResource(request.getCapability())) seems like a really clumsy construct. Would it be less awkward to add a @Private normalize method to the request classes so we could call request.normalize(scheduler) instead?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 43s Maven dependency ordering for branch
        +1 mvninstall 13m 8s trunk passed
        +1 compile 5m 12s trunk passed
        +1 checkstyle 0m 46s trunk passed
        +1 mvnsite 1m 13s trunk passed
        +1 mvneclipse 0m 41s trunk passed
        +1 findbugs 2m 19s trunk passed
        +1 javadoc 0m 52s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 0m 58s the patch passed
        +1 compile 4m 42s the patch passed
        +1 javac 4m 42s the patch passed
        -0 checkstyle 0m 46s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 147 unchanged - 1 fixed = 151 total (was 148)
        +1 mvnsite 1m 11s the patch passed
        +1 mvneclipse 0m 39s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 53s the patch passed
        -1 javadoc 0m 31s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 1 new + 913 unchanged - 0 fixed = 914 total (was 913)
        +1 unit 0m 37s hadoop-yarn-api in the patch passed.
        -1 unit 40m 43s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 35s The patch does not generate ASF License warnings.
        87m 26s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart
          hadoop.yarn.server.resourcemanager.TestRMRestart



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-6022
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845460/YARN-6022.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6da7fada7a3a 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8fadd69
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14539/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14539/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14539/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14539/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14539/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 43s Maven dependency ordering for branch +1 mvninstall 13m 8s trunk passed +1 compile 5m 12s trunk passed +1 checkstyle 0m 46s trunk passed +1 mvnsite 1m 13s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 2m 19s trunk passed +1 javadoc 0m 52s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 58s the patch passed +1 compile 4m 42s the patch passed +1 javac 4m 42s the patch passed -0 checkstyle 0m 46s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 147 unchanged - 1 fixed = 151 total (was 148) +1 mvnsite 1m 11s the patch passed +1 mvneclipse 0m 39s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 53s the patch passed -1 javadoc 0m 31s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 1 new + 913 unchanged - 0 fixed = 914 total (was 913) +1 unit 0m 37s hadoop-yarn-api in the patch passed. -1 unit 40m 43s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 87m 26s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart   hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6022 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845460/YARN-6022.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6da7fada7a3a 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8fadd69 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14539/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14539/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14539/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14539/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14539/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks for review, Daniel Templeton, attached 003 patch addressed your comment.

        Show
        leftnoteasy Wangda Tan added a comment - Thanks for review, Daniel Templeton , attached 003 patch addressed your comment.
        Hide
        templedf Daniel Templeton added a comment -

        Looks generally good. Thanks, Wangda Tan. My only comment is that AbstractYarnScheduler.getNormalizeResource() should be AbstractYarnScheduler.getNormalizedResource().

        Show
        templedf Daniel Templeton added a comment - Looks generally good. Thanks, Wangda Tan . My only comment is that AbstractYarnScheduler.getNormalizeResource() should be AbstractYarnScheduler.getNormalizedResource() .
        Hide
        leftnoteasy Wangda Tan added a comment -

        Just forgot one thing, UpdateContainerRequest should be public/unstable. That is another problem created by YARN-5744, which makes common fields of ResourceRequest/UpdateContainerRequest must have identical visibility. (002)

        Show
        leftnoteasy Wangda Tan added a comment - Just forgot one thing, UpdateContainerRequest should be public/unstable. That is another problem created by YARN-5744 , which makes common fields of ResourceRequest/UpdateContainerRequest must have identical visibility. (002)
        Hide
        leftnoteasy Wangda Tan added a comment -

        Attached ver.1 patch for review.

        Show
        leftnoteasy Wangda Tan added a comment - Attached ver.1 patch for review.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Why wouldn't the user write the same thing as before:

        Because it is a public/stable interface, how you stop user to do that?

        I don't think it's the end of days ..

        It's a little bit of an odd API change

        I'm fine with implementing that change as long as we can do it before it gets in the way of beta1.

        Fine if you think this solution is fine, and previous one is odd. I can fix it.

        Assigning to myself.

        Show
        leftnoteasy Wangda Tan added a comment - Why wouldn't the user write the same thing as before: Because it is a public/stable interface, how you stop user to do that? I don't think it's the end of days .. It's a little bit of an odd API change I'm fine with implementing that change as long as we can do it before it gets in the way of beta1. Fine if you think this solution is fine, and previous one is odd. I can fix it. Assigning to myself.
        Hide
        templedf Daniel Templeton added a comment -

        According to API definition, user should write code like:

        AbstractResourceRequest r = new ResourceRequest(...);
        r.setCapability(..._

        I don't quite follow that. Why wouldn't the user write the same thing as before:

        ResourceRequest r = new ResourceRequest(...);
        r.setCapability(..._

        ?

        I agree that internal changes should not cause external API changes, but this change doesn't change the API in any meaningful way. No user code will break. Nothing will change about the way users write code. The only change is that the compatibility accessors move from the top section of the Method Summary section in the ResourceRequest and UpdateContainerRequest javadocs into the Methods inherited from... part of the Method Summary section. I did a little digging and was unable to find any wisdom on the interwebs that labels a change like this as a breaking change. (The most complete doc I found was https://wiki.eclipse.org/Evolving_Java-based_APIs_2.)

        It's a little bit of an odd API change, but I don't think it's the end of days. Wangda Tan's suggestion on YARN-5774 to change the normalize API to accept a Resource instead of a request sounds like a cleaner solution. I'm fine with implementing that change as long as we can do it before it gets in the way of beta1.

        Show
        templedf Daniel Templeton added a comment - According to API definition, user should write code like: AbstractResourceRequest r = new ResourceRequest(...); r.setCapability(..._ I don't quite follow that. Why wouldn't the user write the same thing as before: ResourceRequest r = new ResourceRequest(...); r.setCapability(..._ ? I agree that internal changes should not cause external API changes, but this change doesn't change the API in any meaningful way. No user code will break. Nothing will change about the way users write code. The only change is that the compatibility accessors move from the top section of the Method Summary section in the ResourceRequest and UpdateContainerRequest javadocs into the Methods inherited from... part of the Method Summary section. I did a little digging and was unable to find any wisdom on the interwebs that labels a change like this as a breaking change. (The most complete doc I found was https://wiki.eclipse.org/Evolving_Java-based_APIs_2 .) It's a little bit of an odd API change, but I don't think it's the end of days. Wangda Tan 's suggestion on YARN-5774 to change the normalize API to accept a Resource instead of a request sounds like a cleaner solution. I'm fine with implementing that change as long as we can do it before it gets in the way of beta1.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Karthik Kambatla / Arun Suresh,

        Missed your last comment somehow, apologize for the last reply. Since this is not included by branch-2.8, so we should have enough time to change it.

        I want to revert the change because two part:
        1) It makes a stable API inherit from an unstable API, which is very confusing. Even if we don't want user to use the AbstractRR, but it is unavoidable. According to API definition, user should write code like:

        AbstractResourceRequest r = new ResourceRequest(...);
        r.setCapability(..._
        

        Apparently we don't want user to do things like this because AbstractRR could be changed.

        2) Most importantly, it is not necessary. YARN-5774 only requires scheduler returns normalized resource instead of update resource inside a given resource request. To me, we should avoid changing user-facing API because of internal implementation, this change is completely avoidable. I suggest to keep the original API.

        Thoughts?

        Show
        leftnoteasy Wangda Tan added a comment - Karthik Kambatla / Arun Suresh , Missed your last comment somehow, apologize for the last reply. Since this is not included by branch-2.8, so we should have enough time to change it. I want to revert the change because two part: 1) It makes a stable API inherit from an unstable API, which is very confusing. Even if we don't want user to use the AbstractRR, but it is unavoidable. According to API definition, user should write code like: AbstractResourceRequest r = new ResourceRequest(...); r.setCapability(..._ Apparently we don't want user to do things like this because AbstractRR could be changed. 2) Most importantly, it is not necessary. YARN-5774 only requires scheduler returns normalized resource instead of update resource inside a given resource request. To me, we should avoid changing user-facing API because of internal implementation, this change is completely avoidable. I suggest to keep the original API. Thoughts?
        Hide
        asuresh Arun Suresh added a comment -

        Wangda Tan, Karthik Kambatla, do you guys want to just move this to @Public @Unstable now (thereby unblocking the release) and maybe refactor this later ?

        Show
        asuresh Arun Suresh added a comment - Wangda Tan , Karthik Kambatla , do you guys want to just move this to @Public @Unstable now (thereby unblocking the release) and maybe refactor this later ?
        Hide
        djp Junping Du added a comment -

        Remove 2.8 from target version given YARN-5774 was not actually in branch-2.8.

        Show
        djp Junping Du added a comment - Remove 2.8 from target version given YARN-5774 was not actually in branch-2.8.
        Hide
        kasha Karthik Kambatla added a comment -

        For example, with this change, we need to make AbstractResourceRequest to be public/stable

        Why? Why not leave the AbstractResourceRequest as @Public @Unstable? That way, users will not be able to use AbstractResourceRequest directly but the methods on ResourceRequest remain Public-Stable.

        I may be missing the incompatibility part. Wangda Tan - mind clarifying it for me may be with an example of what fails to work now?

        Show
        kasha Karthik Kambatla added a comment - For example, with this change, we need to make AbstractResourceRequest to be public/stable Why? Why not leave the AbstractResourceRequest as @Public @Unstable? That way, users will not be able to use AbstractResourceRequest directly but the methods on ResourceRequest remain Public-Stable. I may be missing the incompatibility part. Wangda Tan - mind clarifying it for me may be with an example of what fails to work now?
        Hide
        leftnoteasy Wangda Tan added a comment -

        I would prefer to think about interface of SchedulerResourceRequest (or AbstractSchedulerResourceRequest) under the context of YARN-5959, I agree to add the class if you plan to use it to solve other issues like unifying UpdatedContainerRequest and ResourceRequest in allocation logic. If it is only for resource normalization, I prefer to add a specific normalize resource method to scheduler.

        Show
        leftnoteasy Wangda Tan added a comment - I would prefer to think about interface of SchedulerResourceRequest (or AbstractSchedulerResourceRequest) under the context of YARN-5959 , I agree to add the class if you plan to use it to solve other issues like unifying UpdatedContainerRequest and ResourceRequest in allocation logic. If it is only for resource normalization, I prefer to add a specific normalize resource method to scheduler.
        Hide
        asuresh Arun Suresh added a comment -

        So, looks like the original class was created to unify Update requests and new Resource Request. So I think we should capture that in the new class.
        Given that the Scheduler deals with resources as requests and returns containers as response, I was thinking it should have atleast these 3 fields:

        1. Resource capability
        2. ContainerId containerToUpdate (defaults to null)
        3. int numContainers (if containerToUpdate != null, this will be 1)
        Show
        asuresh Arun Suresh added a comment - So, looks like the original class was created to unify Update requests and new Resource Request. So I think we should capture that in the new class. Given that the Scheduler deals with resources as requests and returns containers as response, I was thinking it should have atleast these 3 fields: Resource capability ContainerId containerToUpdate (defaults to null) int numContainers (if containerToUpdate != null, this will be 1)
        Hide
        leftnoteasy Wangda Tan added a comment -

        Have a SchedulerResourceRequest wrapper class that takes either a standard ResourceRequest or UpdateContainerRequest in the constructor.

        If AbstractResourceRequest is only created for:

        public void normalizeRequest(AbstractResourceRequest ask)
        

        I would prefer to rename it to: normalizeCapability, change parameter from AbstractResourceRequest to Resource, returns normalized Resource for input Resource.
        Or we can direct invoke setMemory/setVirtualCores to update the Resource in-place.

        Thoughts?

        Show
        leftnoteasy Wangda Tan added a comment - Have a SchedulerResourceRequest wrapper class that takes either a standard ResourceRequest or UpdateContainerRequest in the constructor. If AbstractResourceRequest is only created for: public void normalizeRequest(AbstractResourceRequest ask) I would prefer to rename it to: normalizeCapability, change parameter from AbstractResourceRequest to Resource, returns normalized Resource for input Resource. Or we can direct invoke setMemory/setVirtualCores to update the Resource in-place. Thoughts?
        Hide
        asuresh Arun Suresh added a comment -

        Hmmm... not sure why the inheritance is a problem..
        But I agree, maybe a better approach would be containment:
        Have a SchedulerResourceRequest wrapper class that takes either a standard ResourceRequest or UpdateContainerRequest in the constructor.

        Show
        asuresh Arun Suresh added a comment - Hmmm... not sure why the inheritance is a problem.. But I agree, maybe a better approach would be containment: Have a SchedulerResourceRequest wrapper class that takes either a standard ResourceRequest or UpdateContainerRequest in the constructor.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Probably mark it to private is not enough, because we should not make a public/stable class (ResourceRequest) inherit from a private/unstable class. And no matter what is the annotation of the AbstractResourceRequest itself, we have to mark get/setCapability to public/stable. I think we need to remove the class itself and update scheduler implementation accordingly.

        Thoughts?

        Show
        leftnoteasy Wangda Tan added a comment - Probably mark it to private is not enough, because we should not make a public/stable class (ResourceRequest) inherit from a private/unstable class. And no matter what is the annotation of the AbstractResourceRequest itself, we have to mark get/setCapability to public/stable. I think we need to remove the class itself and update scheduler implementation accordingly. Thoughts?
        Hide
        asuresh Arun Suresh added a comment -

        Agree with Wangda Tan, we should also probably mark it as @Private

        Show
        asuresh Arun Suresh added a comment - Agree with Wangda Tan , we should also probably mark it as @Private

          People

          • Assignee:
            leftnoteasy Wangda Tan
            Reporter:
            leftnoteasy Wangda Tan
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development