Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6012

Remove node label (removeFromClusterNodeLabels) document is missing

    Details

    • Hadoop Flags:
      Reviewed

      Description

      Add corresponding documentation for

      yarn rmadmin -removeFromClusterNodeLabels "x,y"
      

      in yarn node labels doc page.

      1. YARN-6012.001.patch
        2 kB
        Ying Zhang
      2. YARN-6012.002.patch
        2 kB
        Ying Zhang

        Activity

        Hide
        sunilg Sunil G added a comment -

        Could you please upload a patch. I can help to review.

        Show
        sunilg Sunil G added a comment - Could you please upload a patch. I can help to review.
        Hide
        Ying Zhang Ying Zhang added a comment -

        Hi Sunil G, it is a small complement to node label document, please take a look. Thank you.

        Show
        Ying Zhang Ying Zhang added a comment - Hi Sunil G , it is a small complement to node label document, please take a look. Thank you.
        Hide
        templedf Daniel Templeton added a comment -

        Thanks, Ying Zhang, for the patch. I can see that the new docs are styled after the add/modify docs, but it would be really nice to have docs that are reader-friendly.

        For example, instead of "Remove cluster node labels: Executing yarn rmadmin -removeFromClusterNodeLabels "<label1,label2,label3>" (label splitted by ",") to remove node labels.", it would be nice to be a bit more readable, such as "To remove one or more node labels, execute the following command: yarn rmadmin -removeFromClusterNodeLabels "<label>[,<label>,...]". The command argument should be a comma-separated list of node labels to remove."

        The rest of the bullets in the new docs can be made similarly more friendly by making them text instead of terse bullets.

        Show
        templedf Daniel Templeton added a comment - Thanks, Ying Zhang , for the patch. I can see that the new docs are styled after the add/modify docs, but it would be really nice to have docs that are reader-friendly. For example, instead of "Remove cluster node labels: Executing yarn rmadmin -removeFromClusterNodeLabels "<label1,label2,label3>" (label splitted by ",") to remove node labels.", it would be nice to be a bit more readable, such as "To remove one or more node labels, execute the following command: yarn rmadmin -removeFromClusterNodeLabels "<label> [,<label>,...] " . The command argument should be a comma-separated list of node labels to remove." The rest of the bullets in the new docs can be made similarly more friendly by making them text instead of terse bullets.
        Hide
        Ying Zhang Ying Zhang added a comment - - edited

        Hi Daniel Templeton, thanks for the quick review. I did have followed the style of the add/modify section.
        Updated a new patch. Please take a look.

        Show
        Ying Zhang Ying Zhang added a comment - - edited Hi Daniel Templeton , thanks for the quick review. I did have followed the style of the add/modify section. Updated a new patch. Please take a look.
        Hide
        Ying Zhang Ying Zhang added a comment - - edited

        Re-attach the patch file to start Jenkins.

        Show
        Ying Zhang Ying Zhang added a comment - - edited Re-attach the patch file to start Jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 mvninstall 12m 31s trunk passed
        +1 mvnsite 0m 13s trunk passed
        +1 mvnsite 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        13m 43s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-6012
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846736/YARN-6012.002.patch
        Optional Tests asflicense mvnsite
        uname Linux 9f86bfbfa946 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4db119b
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14636/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 mvninstall 12m 31s trunk passed +1 mvnsite 0m 13s trunk passed +1 mvnsite 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 13m 43s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6012 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846736/YARN-6012.002.patch Optional Tests asflicense mvnsite uname Linux 9f86bfbfa946 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4db119b modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site Console output https://builds.apache.org/job/PreCommit-YARN-Build/14636/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        Looks good to me. +1

        Show
        templedf Daniel Templeton added a comment - Looks good to me. +1
        Hide
        templedf Daniel Templeton added a comment -

        Thanks for the patch, Ying Zhang! Committed to trunk.

        Show
        templedf Daniel Templeton added a comment - Thanks for the patch, Ying Zhang ! Committed to trunk.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11163 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11163/)
        YARN-6012. Remove node label (removeFromClusterNodeLabels) document is (templedf: rev a2c50127d12b0aefcf1b050e0ab0d2df2abb30b3)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeLabel.md
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11163 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11163/ ) YARN-6012 . Remove node label (removeFromClusterNodeLabels) document is (templedf: rev a2c50127d12b0aefcf1b050e0ab0d2df2abb30b3) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeLabel.md

          People

          • Assignee:
            Ying Zhang Ying Zhang
            Reporter:
            cheersyang Weiwei Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development