Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6004

Refactor TestResourceLocalizationService#testDownloadingResourcesOnContainer so that it is less than 150 lines

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • None
    • 2.9.0, 3.0.0-alpha4
    • test
    • Reviewed

    Description

      The TestResourceLocalizationService#testDownloadingResourcesOnContainerKill method is over 150 lines:

      ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/TestResourceLocalizationService.java:1128: @Test(timeout = 20000):3: Method length is 242 lines (max allowed is 150).

      This method needs to be refactored and broken up into smaller methods.

      Attachments

        1. YARN-6004-trunk.002.patch
          20 kB
          Chris Trezzo
        2. YARN-6004-trunk.001.patch
          20 kB
          Chris Trezzo
        3. YARN-6004-branch-2.001.patch
          20 kB
          Chris Trezzo

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            ctrezzo Chris Trezzo
            ctrezzo Chris Trezzo
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment