Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: yarn-native-services
    • Component/s: None
    • Labels:
      None

      Description

      The AMRMClientAsync onError callback occurred due to an InterruptedException in this case. The AM may need to kill itself once the client reaches this state, but it should not kill the entire application.

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 28s yarn-native-services passed
          +1 compile 0m 23s yarn-native-services passed
          +1 checkstyle 0m 17s yarn-native-services passed
          +1 mvnsite 0m 27s yarn-native-services passed
          +1 mvneclipse 0m 15s yarn-native-services passed
          -1 findbugs 0m 52s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core in yarn-native-services has 268 extant Findbugs warnings.
          -1 javadoc 0m 27s hadoop-yarn-slider-core in yarn-native-services failed.
          +1 mvninstall 0m 22s the patch passed
          +1 compile 0m 21s the patch passed
          +1 javac 0m 21s the patch passed
          +1 checkstyle 0m 15s the patch passed
          +1 mvnsite 0m 24s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 56s the patch passed
          -1 javadoc 0m 23s hadoop-yarn-slider-core in the patch failed.
          +1 unit 1m 13s hadoop-yarn-slider-core in the patch passed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          16m 11s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5996
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843061/YARN-5996-yarn-native-services.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 69393c4a3258 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision yarn-native-services / fc259d5
          Default Java 1.8.0_111
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14276/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-slider_hadoop-yarn-slider-core-warnings.html
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14276/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-slider_hadoop-yarn-slider-core.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14276/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-slider_hadoop-yarn-slider-core.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14276/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14276/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 28s yarn-native-services passed +1 compile 0m 23s yarn-native-services passed +1 checkstyle 0m 17s yarn-native-services passed +1 mvnsite 0m 27s yarn-native-services passed +1 mvneclipse 0m 15s yarn-native-services passed -1 findbugs 0m 52s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core in yarn-native-services has 268 extant Findbugs warnings. -1 javadoc 0m 27s hadoop-yarn-slider-core in yarn-native-services failed. +1 mvninstall 0m 22s the patch passed +1 compile 0m 21s the patch passed +1 javac 0m 21s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 24s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 56s the patch passed -1 javadoc 0m 23s hadoop-yarn-slider-core in the patch failed. +1 unit 1m 13s hadoop-yarn-slider-core in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 16m 11s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5996 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843061/YARN-5996-yarn-native-services.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 69393c4a3258 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision yarn-native-services / fc259d5 Default Java 1.8.0_111 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14276/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-slider_hadoop-yarn-slider-core-warnings.html javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14276/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-slider_hadoop-yarn-slider-core.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14276/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-slider_hadoop-yarn-slider-core.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14276/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core Console output https://builds.apache.org/job/PreCommit-YARN-Build/14276/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          gsaha Gour Saha added a comment -

          Billie Rinaldi the 002 patch looks good to me. The only thing that crosses my mind is that, are there any specific error code that we need to look for in onError which signals that according to YARN that specific error is irrecoverable for the application and that it should give up and shutdown?

          Show
          gsaha Gour Saha added a comment - Billie Rinaldi the 002 patch looks good to me. The only thing that crosses my mind is that, are there any specific error code that we need to look for in onError which signals that according to YARN that specific error is irrecoverable for the application and that it should give up and shutdown?
          Hide
          jianhe Jian He added a comment -

          I checked the possible exceptions, didn't find such error that must force app to kill itself. So, I think it should be fine.

          Show
          jianhe Jian He added a comment - I checked the possible exceptions, didn't find such error that must force app to kill itself. So, I think it should be fine.
          Hide
          gsaha Gour Saha added a comment -

          Perfect, in that case, +1 for the 002 patch.

          Show
          gsaha Gour Saha added a comment - Perfect, in that case, +1 for the 002 patch.
          Hide
          gsaha Gour Saha added a comment -

          Committed to yarn-native-services branch.

          Show
          gsaha Gour Saha added a comment - Committed to yarn-native-services branch.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13193 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13193/)
          YARN-5996. Native services AM kills app on AMRMClientAsync onError call. (jianhe: rev c11f4b3c219f0146e6b9b525270159581fd8b87e)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core/src/main/java/org/apache/slider/server/appmaster/SliderAppMaster.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13193 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13193/ ) YARN-5996 . Native services AM kills app on AMRMClientAsync onError call. (jianhe: rev c11f4b3c219f0146e6b9b525270159581fd8b87e) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core/src/main/java/org/apache/slider/server/appmaster/SliderAppMaster.java

            People

            • Assignee:
              billie.rinaldi Billie Rinaldi
              Reporter:
              billie.rinaldi Billie Rinaldi
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development