Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5991

Yarn Distributed Shell does not print throwable t to App Master When failed to start container

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: None
    • Labels:
    • Environment:

      apache hadoop 2.7.1, centos 6.5

    • Hadoop Flags:
      Reviewed

      Description

      16/12/12 16:27:20 INFO impl.NMClientAsyncImpl: Processing Event EventType: START_CONTAINER for Container container_1481517162158_0027_01_000003
      16/12/12 16:27:20 INFO impl.NMClientAsyncImpl: Processing Event EventType: START_CONTAINER for Container container_1481517162158_0027_01_000004
      16/12/12 16:27:20 INFO impl.NMClientAsyncImpl: Processing Event EventType: START_CONTAINER for Container container_1481517162158_0027_01_000002
      16/12/12 16:27:20 INFO impl.ContainerManagementProtocolProxy: Opening proxy : slave02:22710
      16/12/12 16:27:20 INFO impl.ContainerManagementProtocolProxy: Opening proxy : slave01:34140
      16/12/12 16:27:20 INFO impl.ContainerManagementProtocolProxy: Opening proxy : master:52037
      16/12/12 16:27:20 ERROR launcher.ApplicationMaster: Failed to start Container container_1481517162158_0027_01_000002

        Activity

        Hide
        andrew.wang Andrew Wang added a comment -

        I'm unsetting the "incompatible" flag since this looks like it just changes a log print, which is not covered by compatibility.

        Show
        andrew.wang Andrew Wang added a comment - I'm unsetting the "incompatible" flag since this looks like it just changes a log print, which is not covered by compatibility.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11082 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11082/)
        YARN-5991. Yarn Distributed Shell does not print throwable t to App (templedf: rev 71a4acf74bc9ca34f0e57835c9d6e3efbe7c0567)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11082 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11082/ ) YARN-5991 . Yarn Distributed Shell does not print throwable t to App (templedf: rev 71a4acf74bc9ca34f0e57835c9d6e3efbe7c0567) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
        Hide
        templedf Daniel Templeton added a comment -

        Thanks for the patch, Jim Frankola. Committed to trunk.

        Show
        templedf Daniel Templeton added a comment - Thanks for the patch, Jim Frankola . Committed to trunk.
        Hide
        templedf Daniel Templeton added a comment -

        Patch looks good to me. +1 Committing now.

        Show
        templedf Daniel Templeton added a comment - Patch looks good to me. +1 Committing now.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 12m 52s trunk passed
        +1 compile 0m 16s trunk passed
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 18s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 0m 24s trunk passed
        +1 javadoc 0m 12s trunk passed
        +1 mvninstall 0m 15s the patch passed
        +1 compile 0m 13s the patch passed
        +1 javac 0m 13s the patch passed
        +1 checkstyle 0m 10s the patch passed
        +1 mvnsite 0m 15s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 28s the patch passed
        +1 javadoc 0m 10s the patch passed
        +1 unit 8m 55s hadoop-yarn-applications-distributedshell in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        26m 52s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5991
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846086/YARN-5991.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f5cefc6e758e 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 2977bc6
        Default Java 1.8.0_111
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14593/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14593/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 12m 52s trunk passed +1 compile 0m 16s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 18s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 0m 24s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 15s the patch passed +1 compile 0m 13s the patch passed +1 javac 0m 13s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 15s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 28s the patch passed +1 javadoc 0m 10s the patch passed +1 unit 8m 55s hadoop-yarn-applications-distributedshell in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 26m 52s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5991 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846086/YARN-5991.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f5cefc6e758e 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2977bc6 Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14593/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell Console output https://builds.apache.org/job/PreCommit-YARN-Build/14593/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        Frankola Jim Frankola added a comment -

        Fixed jira

        Show
        Frankola Jim Frankola added a comment - Fixed jira
        Hide
        dashwang dashwang added a comment -

        I think "Throwable t" should to be logged into stdErr of AM.

        Show
        dashwang dashwang added a comment - I think "Throwable t" should to be logged into stdErr of AM.
        Hide
        dashwang dashwang added a comment - - edited

        The source code of ApplicationMaster.java is:

            @Override
            public void onStartContainerError(ContainerId containerId, Throwable t) {
              LOG.error("Failed to start Container " + containerId);
              containers.remove(containerId);
              applicationMaster.numCompletedContainers.incrementAndGet();
              applicationMaster.numFailedContainers.incrementAndGet();
            }
        

        that did not tell us the real reason for start container error!

        Show
        dashwang dashwang added a comment - - edited The source code of ApplicationMaster.java is: @Override public void onStartContainerError(ContainerId containerId, Throwable t) { LOG.error( "Failed to start Container " + containerId); containers.remove(containerId); applicationMaster.numCompletedContainers.incrementAndGet(); applicationMaster.numFailedContainers.incrementAndGet(); } that did not tell us the real reason for start container error!

          People

          • Assignee:
            Frankola Jim Frankola
            Reporter:
            dashwang dashwang
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development