Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: scheduler
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently it returns a list of ApplicationTimeout objects, to get a particular timeout, the caller code needs to iterate the list and compare the timeoutType to get the corresponding value. Is a map data structure easier for use code?

      1. YARN-5965.1.patch
        16 kB
        Rohith Sharma K S
      2. YARN-5965.0.patch
        16 kB
        Rohith Sharma K S

        Issue Links

          Activity

          Hide
          jianhe Jian He added a comment -

          Sunil G, Rohith Sharma K S your opinion ?
          I was working on YARN-5768, don't have strong opinion on this, just want to hear your thoughts whether it's worth to change it or not.

          Show
          jianhe Jian He added a comment - Sunil G , Rohith Sharma K S your opinion ? I was working on YARN-5768 , don't have strong opinion on this, just want to hear your thoughts whether it's worth to change it or not.
          Hide
          sunilg Sunil G added a comment -

          Hi.

          Currently we use map in REST end and for cli. So I think we can keep the same syntax here. Something like below.

          public abstract Map<TimeoutType, ApplicationTimeout> getApplicationTimeouts();
          Thoughts?

          Show
          sunilg Sunil G added a comment - Hi. Currently we use map in REST end and for cli. So I think we can keep the same syntax here. Something like below. public abstract Map<TimeoutType, ApplicationTimeout> getApplicationTimeouts(); Thoughts?
          Hide
          jianhe Jian He added a comment -

          yep, sounds good to me.

          Show
          jianhe Jian He added a comment - yep, sounds good to me.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          updated patch changing return type to Map.

          Show
          rohithsharma Rohith Sharma K S added a comment - updated patch changing return type to Map.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 59s Maven dependency ordering for branch
          +1 mvninstall 7m 42s trunk passed
          +1 compile 5m 14s trunk passed
          +1 checkstyle 0m 48s trunk passed
          +1 mvnsite 2m 39s trunk passed
          +1 mvneclipse 1m 21s trunk passed
          +1 findbugs 4m 27s trunk passed
          +1 javadoc 1m 43s trunk passed
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 2m 4s the patch passed
          +1 compile 5m 6s the patch passed
          +1 cc 5m 6s the patch passed
          +1 javac 5m 6s the patch passed
          -0 checkstyle 0m 53s hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 319 unchanged - 0 fixed = 322 total (was 319)
          +1 mvnsite 2m 41s the patch passed
          +1 mvneclipse 1m 19s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 51s the patch passed
          +1 javadoc 1m 48s the patch passed
          +1 unit 0m 35s hadoop-yarn-api in the patch passed.
          +1 unit 2m 44s hadoop-yarn-common in the patch passed.
          -1 unit 39m 7s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 unit 16m 19s hadoop-yarn-client in the patch passed.
          +1 asflicense 0m 32s The patch does not generate ASF License warnings.
          111m 59s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5965
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841945/YARN-5965.0.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 6109507ea2ca 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7b988e8
          Default Java 1.8.0_111
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14196/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/14196/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14196/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14196/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 59s Maven dependency ordering for branch +1 mvninstall 7m 42s trunk passed +1 compile 5m 14s trunk passed +1 checkstyle 0m 48s trunk passed +1 mvnsite 2m 39s trunk passed +1 mvneclipse 1m 21s trunk passed +1 findbugs 4m 27s trunk passed +1 javadoc 1m 43s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 2m 4s the patch passed +1 compile 5m 6s the patch passed +1 cc 5m 6s the patch passed +1 javac 5m 6s the patch passed -0 checkstyle 0m 53s hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 319 unchanged - 0 fixed = 322 total (was 319) +1 mvnsite 2m 41s the patch passed +1 mvneclipse 1m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 51s the patch passed +1 javadoc 1m 48s the patch passed +1 unit 0m 35s hadoop-yarn-api in the patch passed. +1 unit 2m 44s hadoop-yarn-common in the patch passed. -1 unit 39m 7s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 16m 19s hadoop-yarn-client in the patch passed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 111m 59s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5965 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841945/YARN-5965.0.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 6109507ea2ca 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7b988e8 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14196/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14196/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14196/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14196/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          Thanks Rohith Sharma K S

          Few minor nits:

                    optional string appNodeLabelExpression = 24;
                    optional string amNodeLabelExpression = 25;
          	  repeated AppTimeoutMapProto application_timeouts = 26;
          	}
          	
          	message AppTimeoutMapProto {
          	  optional ApplicationTimeoutTypeProto application_timeout_type = 1;
          	  optional ApplicationTimeoutProto application_timeouts = 2;
          	}	
          }
          

          1. AppTimeoutMapProto application_timeouts, could it be like appTimeouts and AppTimeoutsMapProto
          2. AppTimeoutMapProto -> AppTimeoutsMapProto
          3. application_timeouts -> application_timeout

          Show
          sunilg Sunil G added a comment - Thanks Rohith Sharma K S Few minor nits: optional string appNodeLabelExpression = 24; optional string amNodeLabelExpression = 25; repeated AppTimeoutMapProto application_timeouts = 26; } message AppTimeoutMapProto { optional ApplicationTimeoutTypeProto application_timeout_type = 1; optional ApplicationTimeoutProto application_timeouts = 2; } } 1. AppTimeoutMapProto application_timeouts , could it be like appTimeouts and AppTimeoutsMapProto 2. AppTimeoutMapProto -> AppTimeoutsMapProto 3. application_timeouts -> application_timeout
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          updated patch addressing comments

          Show
          rohithsharma Rohith Sharma K S added a comment - updated patch addressing comments
          Hide
          jianhe Jian He added a comment -

          lgtm

          Show
          jianhe Jian He added a comment - lgtm
          Hide
          sunilg Sunil G added a comment -

          +1 from my end as well. i could commit the same in a day if there are no objections.

          Show
          sunilg Sunil G added a comment - +1 from my end as well. i could commit the same in a day if there are no objections.
          Hide
          sunilg Sunil G added a comment -

          Still jenkins has not ran on latest patch. I triggered a build manually now.

          Show
          sunilg Sunil G added a comment - Still jenkins has not ran on latest patch. I triggered a build manually now.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 59s Maven dependency ordering for branch
          +1 mvninstall 7m 23s trunk passed
          +1 compile 5m 5s trunk passed
          +1 checkstyle 0m 47s trunk passed
          +1 mvnsite 2m 27s trunk passed
          +1 mvneclipse 1m 24s trunk passed
          +1 findbugs 3m 58s trunk passed
          +1 javadoc 1m 51s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 46s the patch passed
          +1 compile 4m 40s the patch passed
          +1 cc 4m 40s the patch passed
          +1 javac 4m 40s the patch passed
          -0 checkstyle 0m 48s hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 314 unchanged - 0 fixed = 317 total (was 314)
          +1 mvnsite 2m 22s the patch passed
          +1 mvneclipse 1m 17s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 32s the patch passed
          +1 javadoc 1m 43s the patch passed
          +1 unit 0m 31s hadoop-yarn-api in the patch passed.
          +1 unit 2m 29s hadoop-yarn-common in the patch passed.
          -1 unit 42m 37s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 unit 16m 20s hadoop-yarn-client in the patch passed.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          112m 38s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5965
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842108/YARN-5965.1.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux da5959d299e8 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 563480d
          Default Java 1.8.0_111
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14208/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/14208/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14208/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14208/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 59s Maven dependency ordering for branch +1 mvninstall 7m 23s trunk passed +1 compile 5m 5s trunk passed +1 checkstyle 0m 47s trunk passed +1 mvnsite 2m 27s trunk passed +1 mvneclipse 1m 24s trunk passed +1 findbugs 3m 58s trunk passed +1 javadoc 1m 51s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 46s the patch passed +1 compile 4m 40s the patch passed +1 cc 4m 40s the patch passed +1 javac 4m 40s the patch passed -0 checkstyle 0m 48s hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 314 unchanged - 0 fixed = 317 total (was 314) +1 mvnsite 2m 22s the patch passed +1 mvneclipse 1m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 32s the patch passed +1 javadoc 1m 43s the patch passed +1 unit 0m 31s hadoop-yarn-api in the patch passed. +1 unit 2m 29s hadoop-yarn-common in the patch passed. -1 unit 42m 37s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 16m 20s hadoop-yarn-client in the patch passed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 112m 38s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5965 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842108/YARN-5965.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux da5959d299e8 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 563480d Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14208/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14208/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14208/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14208/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          Test case failure looks not related. Committing the patch.

          Show
          sunilg Sunil G added a comment - Test case failure looks not related. Committing the patch.
          Hide
          sunilg Sunil G added a comment -

          Committed to trunk and branch-2. Thank you Rohith Sharma K S for the contribution and thank you Jian He for the review.

          Show
          sunilg Sunil G added a comment - Committed to trunk and branch-2. Thank you Rohith Sharma K S for the contribution and thank you Jian He for the review.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10960 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10960/)
          YARN-5965. Retrospect ApplicationReport#getApplicationTimeouts. (sunil: rev ab923a53fcf55d4d75aa027d46e3c4a659015325)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/TestApplicationLifetimeMonitor.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationReport.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ApplicationReportPBImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10960 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10960/ ) YARN-5965 . Retrospect ApplicationReport#getApplicationTimeouts. (sunil: rev ab923a53fcf55d4d75aa027d46e3c4a659015325) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/TestApplicationLifetimeMonitor.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationReport.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ApplicationReportPBImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java

            People

            • Assignee:
              rohithsharma Rohith Sharma K S
              Reporter:
              jianhe Jian He
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development