Hadoop YARN
  1. Hadoop YARN
  2. YARN-594

Update test and add comments in YARN-534

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.0-beta
    • Component/s: None
    • Labels:
      None

      Description

      This jira is simply to add some comments in the patch YARN-534 and update the test case

        Issue Links

          Activity

          Hide
          Jian He added a comment -

          the patch add comments in YARN-534 and update the test case

          Show
          Jian He added a comment - the patch add comments in YARN-534 and update the test case
          Hide
          Bikas Saha added a comment -

          Why do we need to change rm1.stop()?

          -    rm1.stop();
           
               // start new RM   
               MockRM rm2 = new MockRM(conf, memStore);
          @@ -378,7 +377,12 @@ public void testRMRestartOnMaxAppAttempts() throws Exception {
               Assert.assertNull(rm2.getRMContext().getRMApps()
                   .get(app1.getApplicationId()));
           
          -    // stop the RM
          +    // verify that app2 is stored, app1 is removed
          +    Assert.assertNotNull(rmAppState.get(app2.getApplicationId()));
          +    Assert.assertNull(rmAppState.get(app1.getApplicationId()));
          +
          +    // stop the RM  
          +    rm1.stop();
          
          Show
          Bikas Saha added a comment - Why do we need to change rm1.stop()? - rm1.stop(); // start new RM MockRM rm2 = new MockRM(conf, memStore); @@ -378,7 +377,12 @@ public void testRMRestartOnMaxAppAttempts() throws Exception { Assert.assertNull(rm2.getRMContext().getRMApps() .get(app1.getApplicationId())); - // stop the RM + // verify that app2 is stored, app1 is removed + Assert.assertNotNull(rmAppState.get(app2.getApplicationId())); + Assert.assertNull(rmAppState.get(app1.getApplicationId())); + + // stop the RM + rm1.stop();
          Hide
          Jian He added a comment -

          Because if rm1.stop(), the store dispatcher is stopped, its not able to process remove event any more, app1 still remain

          Show
          Jian He added a comment - Because if rm1.stop(), the store dispatcher is stopped, its not able to process remove event any more, app1 still remain
          Hide
          Bikas Saha added a comment -

          Arent store operations happening on the store internal dispatcher?

          Show
          Bikas Saha added a comment - Arent store operations happening on the store internal dispatcher?
          Hide
          Jian He added a comment -

          yes, rm1.stop() call store.close(), then call dispatcher.stop(), and this dispatcher is the store internal dispatcher

          Show
          Jian He added a comment - yes, rm1.stop() call store.close(), then call dispatcher.stop(), and this dispatcher is the store internal dispatcher
          Hide
          Bikas Saha added a comment -

          ok makes sense. +1

          Show
          Bikas Saha added a comment - ok makes sense. +1
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12579617/YARN-594.1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/788//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/788//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12579617/YARN-594.1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/788//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/788//console This message is automatically generated.
          Hide
          Bikas Saha added a comment -

          +1. Committed to trunk and branch-2.

          Show
          Bikas Saha added a comment - +1. Committed to trunk and branch-2.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk-Commit #3645 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3645/)
          YARN-594. Update test and add comments in YARN-534 (Jian He via bikas) (Revision 1470243)

          Result = SUCCESS
          bikas : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1470243
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAppManager.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMRestart.java
          Show
          Hudson added a comment - Integrated in Hadoop-trunk-Commit #3645 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3645/ ) YARN-594 . Update test and add comments in YARN-534 (Jian He via bikas) (Revision 1470243) Result = SUCCESS bikas : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1470243 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAppManager.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMRestart.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Yarn-trunk #190 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/190/)
          YARN-594. Update test and add comments in YARN-534 (Jian He via bikas) (Revision 1470243)

          Result = SUCCESS
          bikas : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1470243
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAppManager.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMRestart.java
          Show
          Hudson added a comment - Integrated in Hadoop-Yarn-trunk #190 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/190/ ) YARN-594 . Update test and add comments in YARN-534 (Jian He via bikas) (Revision 1470243) Result = SUCCESS bikas : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1470243 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAppManager.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMRestart.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1379 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1379/)
          YARN-594. Update test and add comments in YARN-534 (Jian He via bikas) (Revision 1470243)

          Result = FAILURE
          bikas : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1470243
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAppManager.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMRestart.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1379 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1379/ ) YARN-594 . Update test and add comments in YARN-534 (Jian He via bikas) (Revision 1470243) Result = FAILURE bikas : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1470243 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAppManager.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMRestart.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1406 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1406/)
          YARN-594. Update test and add comments in YARN-534 (Jian He via bikas) (Revision 1470243)

          Result = SUCCESS
          bikas : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1470243
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAppManager.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMRestart.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1406 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1406/ ) YARN-594 . Update test and add comments in YARN-534 (Jian He via bikas) (Revision 1470243) Result = SUCCESS bikas : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1470243 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAppManager.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMRestart.java

            People

            • Assignee:
              Jian He
              Reporter:
              Jian He
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development