Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5085 Add support for change of container ExecutionType
  3. YARN-5938

Refactoring OpportunisticContainerAllocator to use SchedulerRequestKey instead of Priority and other misc fixes

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None

      Description

      Minor code re-organization to do the following:

      1. The OpportunisticContainerAllocatorAMService currently allocates outside the ApplicationAttempt lock maintained by the ApplicationMasterService. This should happen inside the lock.
      2. Refactored out some code to simplify the allocate() method.
      3. Removed some unused fields inside the OpportunisticContainerAllocator.
      4. Re-organized some of the code in the OpportunisticContainerAllocatorAMService::allocate method to make it a bit more readable.
      5. Moved SchedulerRequestKey to a new package, so it can be used by the OpportunisticContainerAllocator/Context.
      6. Moved all usages of Priority in the OpportunisticContainerAllocator -> SchedulerRequestKey.
      1. YARN-5938.001.patch
        31 kB
        Arun Suresh
      2. YARN-5938.002.patch
        88 kB
        Arun Suresh
      3. YARN-5938.003.patch
        89 kB
        Arun Suresh
      4. YARN-5938-YARN-5085.001.patch
        31 kB
        Arun Suresh
      5. YARN-5938-YARN-5085.002.patch
        80 kB
        Arun Suresh
      6. YARN-5938-YARN-5085.003.patch
        80 kB
        Arun Suresh
      7. YARN-5938-YARN-5085.004.patch
        81 kB
        Arun Suresh

        Activity

        Hide
        asuresh Arun Suresh added a comment -

        Uploading patch

        Show
        asuresh Arun Suresh added a comment - Uploading patch
        Hide
        asuresh Arun Suresh added a comment -

        Like I mentioned, this is mostly just a re-factoring change. Karthik Kambatla, Varun Saxena (since you helped review YARN-5918, so you might have some context)

        Show
        asuresh Arun Suresh added a comment - Like I mentioned, this is mostly just a re-factoring change. Karthik Kambatla , Varun Saxena (since you helped review YARN-5918 , so you might have some context)
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 54s Maven dependency ordering for branch
        +1 mvninstall 7m 25s trunk passed
        +1 compile 1m 36s trunk passed
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 1m 29s trunk passed
        +1 mvneclipse 0m 45s trunk passed
        +1 findbugs 2m 25s trunk passed
        +1 javadoc 0m 56s trunk passed
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 1m 15s the patch passed
        +1 compile 1m 32s the patch passed
        +1 javac 1m 32s the patch passed
        -0 checkstyle 0m 29s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 11 new + 33 unchanged - 9 fixed = 44 total (was 42)
        +1 mvnsite 1m 27s the patch passed
        +1 mvneclipse 0m 41s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 43s the patch passed
        +1 javadoc 0m 53s the patch passed
        +1 unit 0m 28s hadoop-yarn-server-common in the patch passed.
        +1 unit 13m 47s hadoop-yarn-server-nodemanager in the patch passed.
        -1 unit 40m 3s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        85m 29s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
          hadoop.yarn.server.resourcemanager.TestApplicationMasterService
          hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing
          hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler
          hadoop.yarn.server.resourcemanager.ahs.TestRMApplicationHistoryWriter



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5938
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840757/YARN-5938.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3f7c8a7b49aa 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / be88d57
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14089/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14089/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14089/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14089/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 54s Maven dependency ordering for branch +1 mvninstall 7m 25s trunk passed +1 compile 1m 36s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 29s trunk passed +1 mvneclipse 0m 45s trunk passed +1 findbugs 2m 25s trunk passed +1 javadoc 0m 56s trunk passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 15s the patch passed +1 compile 1m 32s the patch passed +1 javac 1m 32s the patch passed -0 checkstyle 0m 29s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 11 new + 33 unchanged - 9 fixed = 44 total (was 42) +1 mvnsite 1m 27s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 43s the patch passed +1 javadoc 0m 53s the patch passed +1 unit 0m 28s hadoop-yarn-server-common in the patch passed. +1 unit 13m 47s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 40m 3s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 85m 29s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.TestApplicationMasterService   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing   hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler   hadoop.yarn.server.resourcemanager.ahs.TestRMApplicationHistoryWriter Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5938 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840757/YARN-5938.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3f7c8a7b49aa 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / be88d57 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14089/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14089/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14089/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server Console output https://builds.apache.org/job/PreCommit-YARN-Build/14089/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        asuresh Arun Suresh added a comment -

        Created new branch for YARN-5085.
        Updated patch to fix test cases.

        Show
        asuresh Arun Suresh added a comment - Created new branch for YARN-5085 . Updated patch to fix test cases.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 8s Maven dependency ordering for branch
        +1 mvninstall 6m 51s YARN-5085 passed
        +1 compile 1m 32s YARN-5085 passed
        +1 checkstyle 0m 30s YARN-5085 passed
        +1 mvnsite 1m 33s YARN-5085 passed
        +1 mvneclipse 0m 49s YARN-5085 passed
        +1 findbugs 2m 25s YARN-5085 passed
        +1 javadoc 0m 59s YARN-5085 passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 19s the patch passed
        +1 compile 1m 27s the patch passed
        +1 javac 1m 27s the patch passed
        -0 checkstyle 0m 28s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 11 new + 33 unchanged - 9 fixed = 44 total (was 42)
        +1 mvnsite 1m 24s the patch passed
        +1 mvneclipse 0m 37s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 34s the patch passed
        +1 javadoc 0m 49s the patch passed
        +1 unit 0m 26s hadoop-yarn-server-common in the patch passed.
        +1 unit 13m 35s hadoop-yarn-server-nodemanager in the patch passed.
        +1 unit 42m 13s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        85m 59s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5938
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840879/YARN-5938-YARN-5085.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux cc24ee8315b5 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-5085 / 00096dc
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14104/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14104/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14104/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 6m 51s YARN-5085 passed +1 compile 1m 32s YARN-5085 passed +1 checkstyle 0m 30s YARN-5085 passed +1 mvnsite 1m 33s YARN-5085 passed +1 mvneclipse 0m 49s YARN-5085 passed +1 findbugs 2m 25s YARN-5085 passed +1 javadoc 0m 59s YARN-5085 passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 19s the patch passed +1 compile 1m 27s the patch passed +1 javac 1m 27s the patch passed -0 checkstyle 0m 28s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 11 new + 33 unchanged - 9 fixed = 44 total (was 42) +1 mvnsite 1m 24s the patch passed +1 mvneclipse 0m 37s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 34s the patch passed +1 javadoc 0m 49s the patch passed +1 unit 0m 26s hadoop-yarn-server-common in the patch passed. +1 unit 13m 35s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 42m 13s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 85m 59s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5938 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840879/YARN-5938-YARN-5085.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cc24ee8315b5 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-5085 / 00096dc Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14104/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14104/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server Console output https://builds.apache.org/job/PreCommit-YARN-Build/14104/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        asuresh Arun Suresh added a comment -

        Updating patch.. moved SchedulerRequestKey to a common, so it can be used by the OpportunisticAllocator

        Show
        asuresh Arun Suresh added a comment - Updating patch.. moved SchedulerRequestKey to a common, so it can be used by the OpportunisticAllocator
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 12 new or modified test files.
        0 mvndep 0m 10s Maven dependency ordering for branch
        +1 mvninstall 10m 55s YARN-5085 passed
        +1 compile 5m 4s YARN-5085 passed
        +1 checkstyle 1m 4s YARN-5085 passed
        +1 mvnsite 2m 56s YARN-5085 passed
        +1 mvneclipse 1m 38s YARN-5085 passed
        +1 findbugs 4m 46s YARN-5085 passed
        +1 javadoc 2m 10s YARN-5085 passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 2m 2s the patch passed
        +1 compile 4m 39s the patch passed
        +1 javac 4m 39s the patch passed
        -0 checkstyle 1m 5s hadoop-yarn-project/hadoop-yarn: The patch generated 16 new + 1498 unchanged - 14 fixed = 1514 total (was 1512)
        +1 mvnsite 2m 50s the patch passed
        +1 mvneclipse 1m 32s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 5m 19s the patch passed
        +1 javadoc 2m 5s the patch passed
        +1 unit 0m 31s hadoop-yarn-api in the patch passed.
        +1 unit 2m 25s hadoop-yarn-common in the patch passed.
        +1 unit 0m 34s hadoop-yarn-server-common in the patch passed.
        +1 unit 13m 40s hadoop-yarn-server-nodemanager in the patch passed.
        -1 unit 42m 35s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 31s The patch does not generate ASF License warnings.
        117m 51s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
          hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5938
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841405/YARN-5938-YARN-5085.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 68060417d15c 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-5085 / c87b3a4
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14156/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14156/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14156/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14156/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 12 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 10m 55s YARN-5085 passed +1 compile 5m 4s YARN-5085 passed +1 checkstyle 1m 4s YARN-5085 passed +1 mvnsite 2m 56s YARN-5085 passed +1 mvneclipse 1m 38s YARN-5085 passed +1 findbugs 4m 46s YARN-5085 passed +1 javadoc 2m 10s YARN-5085 passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 2m 2s the patch passed +1 compile 4m 39s the patch passed +1 javac 4m 39s the patch passed -0 checkstyle 1m 5s hadoop-yarn-project/hadoop-yarn: The patch generated 16 new + 1498 unchanged - 14 fixed = 1514 total (was 1512) +1 mvnsite 2m 50s the patch passed +1 mvneclipse 1m 32s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 5m 19s the patch passed +1 javadoc 2m 5s the patch passed +1 unit 0m 31s hadoop-yarn-api in the patch passed. +1 unit 2m 25s hadoop-yarn-common in the patch passed. +1 unit 0m 34s hadoop-yarn-server-common in the patch passed. +1 unit 13m 40s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 42m 35s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 117m 51s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5938 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841405/YARN-5938-YARN-5085.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 68060417d15c 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-5085 / c87b3a4 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14156/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14156/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14156/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14156/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        asuresh Arun Suresh added a comment -

        Updating patch after rebasing with trunk.

        Show
        asuresh Arun Suresh added a comment - Updating patch after rebasing with trunk.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 6s YARN-5938 does not apply to YARN-5085. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue YARN-5938
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842836/YARN-5938-YARN-5085.003.patch
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14257/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 6s YARN-5938 does not apply to YARN-5085 . Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue YARN-5938 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842836/YARN-5938-YARN-5085.003.patch Console output https://builds.apache.org/job/PreCommit-YARN-Build/14257/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        asuresh Arun Suresh added a comment -

        Reattaching patch : fixed rebase error

        Show
        asuresh Arun Suresh added a comment - Reattaching patch : fixed rebase error
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 12 new or modified test files.
        0 mvndep 0m 53s Maven dependency ordering for branch
        +1 mvninstall 6m 59s YARN-5085 passed
        +1 compile 4m 58s YARN-5085 passed
        +1 checkstyle 1m 4s YARN-5085 passed
        +1 mvnsite 2m 57s YARN-5085 passed
        +1 mvneclipse 1m 35s YARN-5085 passed
        +1 findbugs 4m 56s YARN-5085 passed
        +1 javadoc 2m 7s YARN-5085 passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 2m 9s the patch passed
        +1 compile 4m 43s the patch passed
        +1 javac 4m 43s the patch passed
        -0 checkstyle 1m 6s hadoop-yarn-project/hadoop-yarn: The patch generated 16 new + 1501 unchanged - 13 fixed = 1517 total (was 1514)
        +1 mvnsite 2m 50s the patch passed
        +1 mvneclipse 1m 33s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 5m 21s the patch passed
        +1 javadoc 2m 3s the patch passed
        +1 unit 0m 31s hadoop-yarn-api in the patch passed.
        +1 unit 2m 25s hadoop-yarn-common in the patch passed.
        +1 unit 0m 32s hadoop-yarn-server-common in the patch passed.
        +1 unit 13m 41s hadoop-yarn-server-nodemanager in the patch passed.
        -1 unit 42m 23s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 29s The patch does not generate ASF License warnings.
        114m 42s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
          hadoop.yarn.server.resourcemanager.scheduler.fair.TestContinuousScheduling



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5938
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842839/YARN-5938-YARN-5085.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 067b1d351c06 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-5085 / f66f618
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14258/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14258/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14258/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14258/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 12 new or modified test files. 0 mvndep 0m 53s Maven dependency ordering for branch +1 mvninstall 6m 59s YARN-5085 passed +1 compile 4m 58s YARN-5085 passed +1 checkstyle 1m 4s YARN-5085 passed +1 mvnsite 2m 57s YARN-5085 passed +1 mvneclipse 1m 35s YARN-5085 passed +1 findbugs 4m 56s YARN-5085 passed +1 javadoc 2m 7s YARN-5085 passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 2m 9s the patch passed +1 compile 4m 43s the patch passed +1 javac 4m 43s the patch passed -0 checkstyle 1m 6s hadoop-yarn-project/hadoop-yarn: The patch generated 16 new + 1501 unchanged - 13 fixed = 1517 total (was 1514) +1 mvnsite 2m 50s the patch passed +1 mvneclipse 1m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 5m 21s the patch passed +1 javadoc 2m 3s the patch passed +1 unit 0m 31s hadoop-yarn-api in the patch passed. +1 unit 2m 25s hadoop-yarn-common in the patch passed. +1 unit 0m 32s hadoop-yarn-server-common in the patch passed. +1 unit 13m 41s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 42m 23s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 114m 42s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.scheduler.fair.TestContinuousScheduling Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5938 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842839/YARN-5938-YARN-5085.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 067b1d351c06 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-5085 / f66f618 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14258/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14258/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14258/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14258/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Arun Suresh,

        Thanks for working on this patch, generally looks good, several minor comments:

        1) OpportunisticContainerAllocator#allocateContainers, why change from AllocateRequest to several separated param? Is it possible that we need some other fields in AllocateRequest?

        2) ApplicationMasterService#allocate -> internalAllocate

        3) OpportunisticContainerContext: Remove unused imports

        Show
        leftnoteasy Wangda Tan added a comment - Arun Suresh , Thanks for working on this patch, generally looks good, several minor comments: 1) OpportunisticContainerAllocator#allocateContainers, why change from AllocateRequest to several separated param? Is it possible that we need some other fields in AllocateRequest? 2) ApplicationMasterService#allocate -> internalAllocate 3) OpportunisticContainerContext: Remove unused imports
        Hide
        asuresh Arun Suresh added a comment -

        Thanks for the review Wangda Tan

        OpportunisticContainerAllocator#allocateContainers, why change from AllocateRequest to several separated param? Is it possible that we need some other fields in AllocateRequest?

        So, Firslty, I wanted to decouple the OpportunisticContainerAllocator from the AllocateRequest object and Secondly.. we were doing
        1. allocateRequest.setAskList(<all opportunistic requests>)
        2. then OpportunisticContainerAllocator::allocate()
        3. then doing a allocateRequest.setAskList(<all guaranteed requests>)
        4. super.allocate()
        The above sequence seemed a bit "hacky"... and made a code flow a bit difficult to follow.. the refactoring fixes that.
        It is possible we might need other things later from the AllocateRequest, but we can address that as and when we need to (there are better ways like updating the OpportunisticContainerContext etc.)

        Will update the patch addressing your remaining comments shortly..

        Show
        asuresh Arun Suresh added a comment - Thanks for the review Wangda Tan OpportunisticContainerAllocator#allocateContainers, why change from AllocateRequest to several separated param? Is it possible that we need some other fields in AllocateRequest? So, Firslty, I wanted to decouple the OpportunisticContainerAllocator from the AllocateRequest object and Secondly.. we were doing 1. allocateRequest.setAskList(<all opportunistic requests>) 2. then OpportunisticContainerAllocator::allocate() 3. then doing a allocateRequest.setAskList(<all guaranteed requests>) 4. super.allocate() The above sequence seemed a bit "hacky"... and made a code flow a bit difficult to follow.. the refactoring fixes that. It is possible we might need other things later from the AllocateRequest, but we can address that as and when we need to (there are better ways like updating the OpportunisticContainerContext etc.) Will update the patch addressing your remaining comments shortly..
        Hide
        asuresh Arun Suresh added a comment -

        Updating patch based on Wangda Tan's suggestions.

        ApplicationMasterService#allocate -> internalAllocate

        I renamed it to allocateInternal() to maintain consistency with other places such as ContainerManager#startContainerInternal()

        Show
        asuresh Arun Suresh added a comment - Updating patch based on Wangda Tan 's suggestions. ApplicationMasterService#allocate -> internalAllocate I renamed it to allocateInternal() to maintain consistency with other places such as ContainerManager#startContainerInternal()
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks Arun Suresh.

        +1 pending jenkins.

        Show
        leftnoteasy Wangda Tan added a comment - Thanks Arun Suresh . +1 pending jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 12 new or modified test files.
        0 mvndep 0m 9s Maven dependency ordering for branch
        +1 mvninstall 16m 29s YARN-5085 passed
        +1 compile 5m 19s YARN-5085 passed
        +1 checkstyle 1m 5s YARN-5085 passed
        +1 mvnsite 3m 15s YARN-5085 passed
        +1 mvneclipse 1m 35s YARN-5085 passed
        +1 findbugs 5m 33s YARN-5085 passed
        +1 javadoc 2m 21s YARN-5085 passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 2m 6s the patch passed
        +1 compile 4m 47s the patch passed
        +1 javac 4m 47s the patch passed
        -0 checkstyle 1m 3s hadoop-yarn-project/hadoop-yarn: The patch generated 11 new + 1502 unchanged - 13 fixed = 1513 total (was 1515)
        +1 mvnsite 2m 39s the patch passed
        +1 mvneclipse 1m 29s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 5m 15s the patch passed
        +1 javadoc 2m 1s the patch passed
        +1 unit 0m 31s hadoop-yarn-api in the patch passed.
        +1 unit 2m 24s hadoop-yarn-common in the patch passed.
        +1 unit 0m 31s hadoop-yarn-server-common in the patch passed.
        +1 unit 12m 55s hadoop-yarn-server-nodemanager in the patch passed.
        +1 unit 39m 33s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 33s The patch does not generate ASF License warnings.
        120m 55s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5938
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843998/YARN-5938-YARN-5085.004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux b82920e8e7ff 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-5085 / fcbe152
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14396/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14396/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14396/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 12 new or modified test files. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 16m 29s YARN-5085 passed +1 compile 5m 19s YARN-5085 passed +1 checkstyle 1m 5s YARN-5085 passed +1 mvnsite 3m 15s YARN-5085 passed +1 mvneclipse 1m 35s YARN-5085 passed +1 findbugs 5m 33s YARN-5085 passed +1 javadoc 2m 21s YARN-5085 passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 2m 6s the patch passed +1 compile 4m 47s the patch passed +1 javac 4m 47s the patch passed -0 checkstyle 1m 3s hadoop-yarn-project/hadoop-yarn: The patch generated 11 new + 1502 unchanged - 13 fixed = 1513 total (was 1515) +1 mvnsite 2m 39s the patch passed +1 mvneclipse 1m 29s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 5m 15s the patch passed +1 javadoc 2m 1s the patch passed +1 unit 0m 31s hadoop-yarn-api in the patch passed. +1 unit 2m 24s hadoop-yarn-common in the patch passed. +1 unit 0m 31s hadoop-yarn-server-common in the patch passed. +1 unit 12m 55s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 39m 33s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 120m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5938 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843998/YARN-5938-YARN-5085.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b82920e8e7ff 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-5085 / fcbe152 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14396/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14396/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14396/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        asuresh Arun Suresh added a comment -

        Committed to branch YARN-5085
        Thanks for the review Wangda Tan

        Show
        asuresh Arun Suresh added a comment - Committed to branch YARN-5085 Thanks for the review Wangda Tan
        Hide
        asuresh Arun Suresh added a comment -

        Attaching a trunk patch... will check it into trunk after a good jenkins run.

        Show
        asuresh Arun Suresh added a comment - Attaching a trunk patch... will check it into trunk after a good jenkins run.
        Hide
        asuresh Arun Suresh added a comment -

        Reopening to run against trunk

        Show
        asuresh Arun Suresh added a comment - Reopening to run against trunk
        Hide
        asuresh Arun Suresh added a comment -

        Re-attaching patch..

        Show
        asuresh Arun Suresh added a comment - Re-attaching patch..
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 12 new or modified test files.
        0 mvndep 0m 9s Maven dependency ordering for branch
        +1 mvninstall 13m 33s trunk passed
        +1 compile 4m 55s trunk passed
        +1 checkstyle 1m 3s trunk passed
        +1 mvnsite 2m 51s trunk passed
        +1 mvneclipse 1m 40s trunk passed
        -1 findbugs 0m 23s hadoop-yarn-api in trunk failed.
        -1 findbugs 1m 22s branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/findbugsXml.xml)
        +1 javadoc 2m 2s trunk passed
        0 mvndep 0m 13s Maven dependency ordering for patch
        +1 mvninstall 2m 43s the patch passed
        +1 compile 5m 12s the patch passed
        -1 javac 5m 12s hadoop-yarn-project_hadoop-yarn generated 26 new + 9 unchanged - 2 fixed = 35 total (was 11)
        +1 checkstyle 1m 11s the patch passed
        +1 mvnsite 3m 21s the patch passed
        +1 mvneclipse 1m 26s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 1m 20s patch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/target/findbugsXml.xml)
        -1 findbugs 1m 7s patch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/findbugsXml.xml)
        -1 findbugs 0m 47s patch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/target/findbugsXml.xml)
        +1 javadoc 0m 19s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 123 unchanged - 123 fixed = 123 total (was 246)
        +1 javadoc 0m 32s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 0 new + 4579 unchanged - 4579 fixed = 4579 total (was 9158)
        +1 javadoc 0m 21s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 0 new + 161 unchanged - 161 fixed = 161 total (was 322)
        +1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 0 new + 235 unchanged - 235 fixed = 235 total (was 470)
        +1 javadoc 0m 25s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 913 unchanged - 1013 fixed = 913 total (was 1926)
        +1 unit 0m 33s hadoop-yarn-api in the patch passed.
        +1 unit 2m 41s hadoop-yarn-common in the patch passed.
        +1 unit 0m 41s hadoop-yarn-server-common in the patch passed.
        -1 unit 0m 46s hadoop-yarn-server-nodemanager in the patch failed.
        -1 unit 0m 34s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 34s The patch does not generate ASF License warnings.
        66m 43s



        Reason Tests
        Failed junit tests hadoop.yarn.server.nodemanager.TestNodeManagerResync



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5938
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844705/YARN-5938.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 379c50b08581 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ea54752
        Default Java 1.8.0_111
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14469/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14469/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
        javac https://builds.apache.org/job/PreCommit-YARN-Build/14469/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14469/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14469/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14469/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14469/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14469/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14469/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14469/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 12 new or modified test files. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 13m 33s trunk passed +1 compile 4m 55s trunk passed +1 checkstyle 1m 3s trunk passed +1 mvnsite 2m 51s trunk passed +1 mvneclipse 1m 40s trunk passed -1 findbugs 0m 23s hadoop-yarn-api in trunk failed. -1 findbugs 1m 22s branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/findbugsXml.xml) +1 javadoc 2m 2s trunk passed 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 2m 43s the patch passed +1 compile 5m 12s the patch passed -1 javac 5m 12s hadoop-yarn-project_hadoop-yarn generated 26 new + 9 unchanged - 2 fixed = 35 total (was 11) +1 checkstyle 1m 11s the patch passed +1 mvnsite 3m 21s the patch passed +1 mvneclipse 1m 26s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 20s patch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/target/findbugsXml.xml) -1 findbugs 1m 7s patch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/findbugsXml.xml) -1 findbugs 0m 47s patch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/target/findbugsXml.xml) +1 javadoc 0m 19s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 123 unchanged - 123 fixed = 123 total (was 246) +1 javadoc 0m 32s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 0 new + 4579 unchanged - 4579 fixed = 4579 total (was 9158) +1 javadoc 0m 21s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 0 new + 161 unchanged - 161 fixed = 161 total (was 322) +1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 0 new + 235 unchanged - 235 fixed = 235 total (was 470) +1 javadoc 0m 25s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 913 unchanged - 1013 fixed = 913 total (was 1926) +1 unit 0m 33s hadoop-yarn-api in the patch passed. +1 unit 2m 41s hadoop-yarn-common in the patch passed. +1 unit 0m 41s hadoop-yarn-server-common in the patch passed. -1 unit 0m 46s hadoop-yarn-server-nodemanager in the patch failed. -1 unit 0m 34s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 66m 43s Reason Tests Failed junit tests hadoop.yarn.server.nodemanager.TestNodeManagerResync Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5938 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844705/YARN-5938.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 379c50b08581 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ea54752 Default Java 1.8.0_111 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14469/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14469/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/14469/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14469/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14469/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14469/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14469/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14469/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14469/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14469/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 12 new or modified test files.
        0 mvndep 0m 43s Maven dependency ordering for branch
        +1 mvninstall 12m 30s trunk passed
        +1 compile 4m 53s trunk passed
        +1 checkstyle 1m 3s trunk passed
        +1 mvnsite 2m 40s trunk passed
        +1 mvneclipse 1m 34s trunk passed
        +1 findbugs 4m 39s trunk passed
        +1 javadoc 2m 5s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 2m 0s the patch passed
        +1 compile 4m 34s the patch passed
        +1 javac 4m 34s the patch passed
        -0 checkstyle 1m 3s hadoop-yarn-project/hadoop-yarn: The patch generated 8 new + 1558 unchanged - 13 fixed = 1566 total (was 1571)
        +1 mvnsite 2m 34s the patch passed
        +1 mvneclipse 1m 29s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 5m 11s the patch passed
        +1 javadoc 2m 1s the patch passed
        +1 unit 0m 30s hadoop-yarn-api in the patch passed.
        +1 unit 2m 24s hadoop-yarn-common in the patch passed.
        +1 unit 0m 32s hadoop-yarn-server-common in the patch passed.
        +1 unit 12m 56s hadoop-yarn-server-nodemanager in the patch passed.
        -1 unit 38m 52s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 31s The patch does not generate ASF License warnings.
        114m 0s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5938
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844708/YARN-5938.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6167dcc701ba 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ea54752
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14472/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14472/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14472/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14472/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 12 new or modified test files. 0 mvndep 0m 43s Maven dependency ordering for branch +1 mvninstall 12m 30s trunk passed +1 compile 4m 53s trunk passed +1 checkstyle 1m 3s trunk passed +1 mvnsite 2m 40s trunk passed +1 mvneclipse 1m 34s trunk passed +1 findbugs 4m 39s trunk passed +1 javadoc 2m 5s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 2m 0s the patch passed +1 compile 4m 34s the patch passed +1 javac 4m 34s the patch passed -0 checkstyle 1m 3s hadoop-yarn-project/hadoop-yarn: The patch generated 8 new + 1558 unchanged - 13 fixed = 1566 total (was 1571) +1 mvnsite 2m 34s the patch passed +1 mvneclipse 1m 29s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 5m 11s the patch passed +1 javadoc 2m 1s the patch passed +1 unit 0m 30s hadoop-yarn-api in the patch passed. +1 unit 2m 24s hadoop-yarn-common in the patch passed. +1 unit 0m 32s hadoop-yarn-server-common in the patch passed. +1 unit 12m 56s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 38m 52s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 114m 0s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5938 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844708/YARN-5938.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6167dcc701ba 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ea54752 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14472/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14472/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14472/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14472/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        asuresh Arun Suresh added a comment -

        Fixing some of the checkstyle warnings.
        The testcase failure is not releated..

        Show
        asuresh Arun Suresh added a comment - Fixing some of the checkstyle warnings. The testcase failure is not releated..
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 12 new or modified test files.
        0 mvndep 0m 45s Maven dependency ordering for branch
        -1 mvninstall 5m 51s root in trunk failed.
        -1 compile 1m 16s hadoop-yarn in trunk failed.
        +1 checkstyle 1m 8s trunk passed
        -1 mvnsite 0m 29s hadoop-yarn-server-nodemanager in trunk failed.
        -1 mvnsite 0m 31s hadoop-yarn-server-resourcemanager in trunk failed.
        +1 mvneclipse 1m 10s trunk passed
        -1 findbugs 1m 2s branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/target/findbugsXml.xml)
        +1 javadoc 2m 25s trunk passed
        0 mvndep 0m 13s Maven dependency ordering for patch
        +1 mvninstall 5m 0s the patch passed
        +1 compile 6m 17s the patch passed
        -1 javac 6m 17s hadoop-yarn-project_hadoop-yarn generated 61 new + 9 unchanged - 2 fixed = 70 total (was 11)
        -0 checkstyle 1m 25s hadoop-yarn-project/hadoop-yarn: The patch generated 3130 new + 1565 unchanged - 0 fixed = 4695 total (was 1565)
        +1 mvnsite 6m 6s the patch passed
        +1 mvneclipse 3m 6s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 11m 21s the patch passed
        -1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 123 new + 246 unchanged - 0 fixed = 369 total (was 246)
        -1 javadoc 0m 32s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 4579 new + 9158 unchanged - 0 fixed = 13737 total (was 9158)
        -1 javadoc 0m 22s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 161 new + 322 unchanged - 0 fixed = 483 total (was 322)
        -1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 235 new + 470 unchanged - 0 fixed = 705 total (was 470)
        -1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 913 new + 1826 unchanged - 100 fixed = 2739 total (was 1926)
        -1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 123 new + 246 unchanged - 0 fixed = 369 total (was 246)
        -1 javadoc 0m 33s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 4579 new + 9158 unchanged - 0 fixed = 13737 total (was 9158)
        -1 javadoc 0m 21s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 161 new + 322 unchanged - 0 fixed = 483 total (was 322)
        -1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 235 new + 470 unchanged - 0 fixed = 705 total (was 470)
        -1 javadoc 0m 27s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 913 new + 1826 unchanged - 100 fixed = 2739 total (was 1926)
        +1 unit 0m 32s hadoop-yarn-api in the patch passed.
        +1 unit 2m 26s hadoop-yarn-common in the patch passed.
        +1 unit 0m 33s hadoop-yarn-server-common in the patch passed.
        +1 unit 13m 3s hadoop-yarn-server-nodemanager in the patch passed.
        -1 unit 39m 18s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 unit 0m 31s hadoop-yarn-api in the patch passed.
        +1 unit 2m 25s hadoop-yarn-common in the patch passed.
        +1 unit 0m 33s hadoop-yarn-server-common in the patch passed.
        -1 unit 13m 2s hadoop-yarn-server-nodemanager in the patch failed.
        -1 unit 33m 49s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        179m 41s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestResourceManager
          hadoop.yarn.server.resourcemanager.TestResourceManager



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5938
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844708/YARN-5938.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux fcdcced4b980 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ea54752
        Default Java 1.8.0_111
        mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/branch-mvninstall-root.txt
        compile https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn.txt
        mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
        mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
        javac https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14471/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14471/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 12 new or modified test files. 0 mvndep 0m 45s Maven dependency ordering for branch -1 mvninstall 5m 51s root in trunk failed. -1 compile 1m 16s hadoop-yarn in trunk failed. +1 checkstyle 1m 8s trunk passed -1 mvnsite 0m 29s hadoop-yarn-server-nodemanager in trunk failed. -1 mvnsite 0m 31s hadoop-yarn-server-resourcemanager in trunk failed. +1 mvneclipse 1m 10s trunk passed -1 findbugs 1m 2s branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/target/findbugsXml.xml) +1 javadoc 2m 25s trunk passed 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 5m 0s the patch passed +1 compile 6m 17s the patch passed -1 javac 6m 17s hadoop-yarn-project_hadoop-yarn generated 61 new + 9 unchanged - 2 fixed = 70 total (was 11) -0 checkstyle 1m 25s hadoop-yarn-project/hadoop-yarn: The patch generated 3130 new + 1565 unchanged - 0 fixed = 4695 total (was 1565) +1 mvnsite 6m 6s the patch passed +1 mvneclipse 3m 6s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 11m 21s the patch passed -1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 123 new + 246 unchanged - 0 fixed = 369 total (was 246) -1 javadoc 0m 32s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 4579 new + 9158 unchanged - 0 fixed = 13737 total (was 9158) -1 javadoc 0m 22s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 161 new + 322 unchanged - 0 fixed = 483 total (was 322) -1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 235 new + 470 unchanged - 0 fixed = 705 total (was 470) -1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 913 new + 1826 unchanged - 100 fixed = 2739 total (was 1926) -1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 123 new + 246 unchanged - 0 fixed = 369 total (was 246) -1 javadoc 0m 33s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 4579 new + 9158 unchanged - 0 fixed = 13737 total (was 9158) -1 javadoc 0m 21s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 161 new + 322 unchanged - 0 fixed = 483 total (was 322) -1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 235 new + 470 unchanged - 0 fixed = 705 total (was 470) -1 javadoc 0m 27s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 913 new + 1826 unchanged - 100 fixed = 2739 total (was 1926) +1 unit 0m 32s hadoop-yarn-api in the patch passed. +1 unit 2m 26s hadoop-yarn-common in the patch passed. +1 unit 0m 33s hadoop-yarn-server-common in the patch passed. +1 unit 13m 3s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 39m 18s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 0m 31s hadoop-yarn-api in the patch passed. +1 unit 2m 25s hadoop-yarn-common in the patch passed. +1 unit 0m 33s hadoop-yarn-server-common in the patch passed. -1 unit 13m 2s hadoop-yarn-server-nodemanager in the patch failed. -1 unit 33m 49s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 179m 41s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestResourceManager   hadoop.yarn.server.resourcemanager.TestResourceManager Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5938 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844708/YARN-5938.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fcdcced4b980 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ea54752 Default Java 1.8.0_111 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14471/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14471/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14471/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 12 new or modified test files.
        0 mvndep 0m 19s Maven dependency ordering for branch
        +1 mvninstall 13m 24s trunk passed
        +1 compile 4m 54s trunk passed
        +1 checkstyle 1m 8s trunk passed
        +1 mvnsite 2m 54s trunk passed
        +1 mvneclipse 1m 34s trunk passed
        +1 findbugs 5m 13s trunk passed
        +1 javadoc 2m 4s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 2m 1s the patch passed
        +1 compile 4m 50s the patch passed
        +1 javac 4m 50s the patch passed
        -0 checkstyle 1m 1s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 1557 unchanged - 13 fixed = 1558 total (was 1570)
        +1 mvnsite 2m 42s the patch passed
        +1 mvneclipse 1m 30s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 5m 30s the patch passed
        +1 javadoc 2m 15s the patch passed
        +1 unit 0m 34s hadoop-yarn-api in the patch passed.
        +1 unit 2m 32s hadoop-yarn-common in the patch passed.
        +1 unit 0m 32s hadoop-yarn-server-common in the patch passed.
        +1 unit 13m 9s hadoop-yarn-server-nodemanager in the patch passed.
        -1 unit 39m 28s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 29s The patch does not generate ASF License warnings.
        117m 21s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5938
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844711/YARN-5938.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2621617dfd0e 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ea54752
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14475/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14475/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14475/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14475/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 12 new or modified test files. 0 mvndep 0m 19s Maven dependency ordering for branch +1 mvninstall 13m 24s trunk passed +1 compile 4m 54s trunk passed +1 checkstyle 1m 8s trunk passed +1 mvnsite 2m 54s trunk passed +1 mvneclipse 1m 34s trunk passed +1 findbugs 5m 13s trunk passed +1 javadoc 2m 4s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 2m 1s the patch passed +1 compile 4m 50s the patch passed +1 javac 4m 50s the patch passed -0 checkstyle 1m 1s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 1557 unchanged - 13 fixed = 1558 total (was 1570) +1 mvnsite 2m 42s the patch passed +1 mvneclipse 1m 30s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 5m 30s the patch passed +1 javadoc 2m 15s the patch passed +1 unit 0m 34s hadoop-yarn-api in the patch passed. +1 unit 2m 32s hadoop-yarn-common in the patch passed. +1 unit 0m 32s hadoop-yarn-server-common in the patch passed. +1 unit 13m 9s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 39m 28s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 117m 21s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5938 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844711/YARN-5938.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2621617dfd0e 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ea54752 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14475/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14475/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14475/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14475/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        asuresh Arun Suresh added a comment -

        The failed test case runs locally and the checkstyle warning fix would require further refactoring of the ApplicationMasterService::allocateInternal() method, which should probably tackled as a separate patch.

        Committing this shortly

        Show
        asuresh Arun Suresh added a comment - The failed test case runs locally and the checkstyle warning fix would require further refactoring of the ApplicationMasterService::allocateInternal() method, which should probably tackled as a separate patch. Committing this shortly
        Hide
        asuresh Arun Suresh added a comment -

        Committed this to trunk..

        Show
        asuresh Arun Suresh added a comment - Committed this to trunk..
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11042 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11042/)
        YARN-5938. Refactoring OpportunisticContainerAllocator to use (arun suresh: rev ac1e5d4f77e3b9df8dcacb0b1f72eecc27931eb8)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fifo/FifoAppAttempt.java
        • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/scheduler/SchedulerRequestKey.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/FiCaSchedulerApp.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/UpdateContainerRequest.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/TestSchedulerApplicationAttempt.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/monitor/capacity/TestProportionalCapacityPreemptionPolicy.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestReservations.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/Application.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestContinuousScheduling.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerReservedEvent.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/placement/SchedulingPlacementSet.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/RemoteNode.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/allocator/RegularContainerAllocator.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java
        • (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerRequestKey.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/TestAppSchedulingInfo.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/scheduler/OpportunisticContainerAllocator.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerNode.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/scheduler/DistributedScheduler.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/FiCaSchedulerNode.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/SchedulerContainer.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ApplicationMasterService.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/distributed/NodeQueueLoadMonitor.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestLeafQueue.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/scheduler/OpportunisticContainerContext.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainer.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/Task.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fifo/FifoScheduler.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/monitor/capacity/ProportionalCapacityPreemptionPolicyMockFramework.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestFSAppAttempt.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/allocator/IncreaseContainerAllocator.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestUtils.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/OpportunisticContainerAllocatorAMService.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11042 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11042/ ) YARN-5938 . Refactoring OpportunisticContainerAllocator to use (arun suresh: rev ac1e5d4f77e3b9df8dcacb0b1f72eecc27931eb8) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fifo/FifoAppAttempt.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/scheduler/SchedulerRequestKey.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/FiCaSchedulerApp.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/UpdateContainerRequest.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/TestSchedulerApplicationAttempt.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/monitor/capacity/TestProportionalCapacityPreemptionPolicy.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestReservations.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/Application.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestContinuousScheduling.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerReservedEvent.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/placement/SchedulingPlacementSet.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/RemoteNode.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/allocator/RegularContainerAllocator.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerRequestKey.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/TestAppSchedulingInfo.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/scheduler/OpportunisticContainerAllocator.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerNode.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/scheduler/DistributedScheduler.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/FiCaSchedulerNode.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/SchedulerContainer.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ApplicationMasterService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/distributed/NodeQueueLoadMonitor.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestLeafQueue.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/scheduler/OpportunisticContainerContext.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainer.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/Task.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fifo/FifoScheduler.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/monitor/capacity/ProportionalCapacityPreemptionPolicyMockFramework.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestFSAppAttempt.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/allocator/IncreaseContainerAllocator.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestUtils.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/OpportunisticContainerAllocatorAMService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java
        Hide
        asuresh Arun Suresh added a comment -

        Committing this to branch-2

        Show
        asuresh Arun Suresh added a comment - Committing this to branch-2

          People

          • Assignee:
            asuresh Arun Suresh
            Reporter:
            asuresh Arun Suresh
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development