Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: scheduler
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. ResourceManagerRest.html
      258 kB
      Rohith Sharma K S
    2. YarnCommands.html
      43 kB
      Rohith Sharma K S
    3. YARN-5931.0.patch
      8 kB
      Rohith Sharma K S
    4. YARN-5931.1.patch
      12 kB
      Rohith Sharma K S
    5. YARN-5931.2.patch
      13 kB
      Rohith Sharma K S
    6. YARN-5931.3.patch
      13 kB
      Rohith Sharma K S
    7. YARN-5931.4.patch
      12 kB
      Rohith Sharma K S
    8. YARN-5931.5.patch
      12 kB
      Rohith Sharma K S
    9. YARN-5931.6.patch
      12 kB
      Rohith Sharma K S

      Activity

      Hide
      templedf Daniel Templeton added a comment -

      Thanks for the patch, Rohith Sharma K S! Committed to trunk and branch-2.

      Show
      templedf Daniel Templeton added a comment - Thanks for the patch, Rohith Sharma K S ! Committed to trunk and branch-2.
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11059 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11059/)
      YARN-5931. Document timeout interfaces CLI and REST APIs (Contributed by (templedf: rev 165d01a73e5f328108a9e876c7a751a3c2cec4a8)

      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/YarnCommands.md
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/monitor/RMAppLifetimeMonitor.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationTimeout.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11059 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11059/ ) YARN-5931 . Document timeout interfaces CLI and REST APIs (Contributed by (templedf: rev 165d01a73e5f328108a9e876c7a751a3c2cec4a8) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/YarnCommands.md (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/monitor/RMAppLifetimeMonitor.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationTimeout.java
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 11s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      0 mvndep 0m 46s Maven dependency ordering for branch
      +1 mvninstall 12m 53s trunk passed
      +1 compile 4m 57s trunk passed
      +1 checkstyle 0m 45s trunk passed
      +1 mvnsite 2m 4s trunk passed
      +1 mvneclipse 1m 13s trunk passed
      0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
      +1 findbugs 3m 22s trunk passed
      +1 javadoc 1m 39s trunk passed
      0 mvndep 0m 10s Maven dependency ordering for patch
      +1 mvninstall 1m 31s the patch passed
      +1 compile 4m 35s the patch passed
      +1 javac 4m 35s the patch passed
      +1 checkstyle 0m 44s the patch passed
      +1 mvnsite 2m 1s the patch passed
      +1 mvneclipse 1m 9s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 xml 0m 2s The patch has no ill-formed XML file.
      0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
      +1 findbugs 3m 38s the patch passed
      +1 javadoc 1m 33s the patch passed
      +1 unit 0m 31s hadoop-yarn-api in the patch passed.
      +1 unit 2m 24s hadoop-yarn-common in the patch passed.
      -1 unit 38m 30s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 unit 0m 14s hadoop-yarn-site in the patch passed.
      +1 asflicense 0m 31s The patch does not generate ASF License warnings.
      93m 38s



      Reason Tests
      Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:a9ad5d6
      JIRA Issue YARN-5931
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845148/YARN-5931.6.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
      uname Linux dc2ec64d61c6 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / c6a5b68
      Default Java 1.8.0_111
      findbugs v3.0.0
      unit https://builds.apache.org/job/PreCommit-YARN-Build/14505/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14505/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/14505/console
      Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 46s Maven dependency ordering for branch +1 mvninstall 12m 53s trunk passed +1 compile 4m 57s trunk passed +1 checkstyle 0m 45s trunk passed +1 mvnsite 2m 4s trunk passed +1 mvneclipse 1m 13s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 3m 22s trunk passed +1 javadoc 1m 39s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 31s the patch passed +1 compile 4m 35s the patch passed +1 javac 4m 35s the patch passed +1 checkstyle 0m 44s the patch passed +1 mvnsite 2m 1s the patch passed +1 mvneclipse 1m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 3m 38s the patch passed +1 javadoc 1m 33s the patch passed +1 unit 0m 31s hadoop-yarn-api in the patch passed. +1 unit 2m 24s hadoop-yarn-common in the patch passed. -1 unit 38m 30s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 0m 14s hadoop-yarn-site in the patch passed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 93m 38s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5931 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845148/YARN-5931.6.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux dc2ec64d61c6 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c6a5b68 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/14505/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14505/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14505/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      templedf Daniel Templeton added a comment - - edited

      LGTM +1 after you resolve the whitespace and checkstyle issues.

      Show
      templedf Daniel Templeton added a comment - - edited LGTM +1 after you resolve the whitespace and checkstyle issues.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 16s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      0 mvndep 0m 11s Maven dependency ordering for branch
      +1 mvninstall 13m 34s trunk passed
      +1 compile 5m 41s trunk passed
      +1 checkstyle 0m 52s trunk passed
      +1 mvnsite 2m 20s trunk passed
      +1 mvneclipse 1m 14s trunk passed
      0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
      +1 findbugs 3m 27s trunk passed
      +1 javadoc 1m 37s trunk passed
      0 mvndep 0m 10s Maven dependency ordering for patch
      +1 mvninstall 1m 28s the patch passed
      +1 compile 4m 58s the patch passed
      +1 javac 4m 58s the patch passed
      -0 checkstyle 0m 48s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 206 unchanged - 0 fixed = 207 total (was 206)
      +1 mvnsite 2m 23s the patch passed
      +1 mvneclipse 1m 9s the patch passed
      -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
      -1 whitespace 0m 0s The patch 12 line(s) with tabs.
      +1 xml 0m 1s The patch has no ill-formed XML file.
      0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
      +1 findbugs 3m 50s the patch passed
      +1 javadoc 1m 34s the patch passed
      +1 unit 0m 31s hadoop-yarn-api in the patch passed.
      +1 unit 2m 38s hadoop-yarn-common in the patch passed.
      +1 unit 40m 33s hadoop-yarn-server-resourcemanager in the patch passed.
      +1 unit 0m 14s hadoop-yarn-site in the patch passed.
      +1 asflicense 0m 31s The patch does not generate ASF License warnings.
      98m 19s



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:a9ad5d6
      JIRA Issue YARN-5931
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845072/YARN-5931.5.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
      uname Linux 4a4b8535bf0c 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / a4f6665
      Default Java 1.8.0_111
      findbugs v3.0.0
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14491/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14491/artifact/patchprocess/whitespace-eol.txt
      whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14491/artifact/patchprocess/whitespace-tabs.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14491/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/14491/console
      Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 13m 34s trunk passed +1 compile 5m 41s trunk passed +1 checkstyle 0m 52s trunk passed +1 mvnsite 2m 20s trunk passed +1 mvneclipse 1m 14s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 3m 27s trunk passed +1 javadoc 1m 37s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 28s the patch passed +1 compile 4m 58s the patch passed +1 javac 4m 58s the patch passed -0 checkstyle 0m 48s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 206 unchanged - 0 fixed = 207 total (was 206) +1 mvnsite 2m 23s the patch passed +1 mvneclipse 1m 9s the patch passed -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 0s The patch 12 line(s) with tabs. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 3m 50s the patch passed +1 javadoc 1m 34s the patch passed +1 unit 0m 31s hadoop-yarn-api in the patch passed. +1 unit 2m 38s hadoop-yarn-common in the patch passed. +1 unit 40m 33s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 0m 14s hadoop-yarn-site in the patch passed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 98m 19s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5931 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845072/YARN-5931.5.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 4a4b8535bf0c 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a4f6665 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14491/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14491/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14491/artifact/patchprocess/whitespace-tabs.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14491/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14491/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      rohithsharma Rohith Sharma K S added a comment -

      but the change to the Cluster Applications API isn't in the latest patch.

      yeah, I did not add purposefully. Those changes are not required in this patch. If you look at patch-0, it was not there. Somehow those unnecessary changes carry forwarded in patch 1 to 3. Again while fixing review comments I noticed today that these change are not required. So, I removed it.

      I have updated patch with fixing last comment.

      Show
      rohithsharma Rohith Sharma K S added a comment - but the change to the Cluster Applications API isn't in the latest patch. yeah, I did not add purposefully. Those changes are not required in this patch. If you look at patch-0, it was not there. Somehow those unnecessary changes carry forwarded in patch 1 to 3. Again while fixing review comments I noticed today that these change are not required. So, I removed it. I have updated patch with fixing last comment.
      Hide
      templedf Daniel Templeton added a comment -

      In case you cut a new patch to add it back, I'll point out one other thing. I just noticed on the timeouts docs, you use "ApplicationTimeout objects" in the line we were discussing, but "application timeouts" or "timeout objects" further down.

      Show
      templedf Daniel Templeton added a comment - In case you cut a new patch to add it back, I'll point out one other thing. I just noticed on the timeouts docs, you use "ApplicationTimeout objects" in the line we were discussing, but "application timeouts" or "timeout objects" further down.
      Hide
      templedf Daniel Templeton added a comment -

      LGTM, but the change to the Cluster Applications API isn't in the latest patch.

      Show
      templedf Daniel Templeton added a comment - LGTM, but the change to the Cluster Applications API isn't in the latest patch.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 13s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      0 mvndep 0m 43s Maven dependency ordering for branch
      +1 mvninstall 13m 27s trunk passed
      +1 compile 5m 3s trunk passed
      +1 checkstyle 0m 46s trunk passed
      +1 mvnsite 2m 4s trunk passed
      +1 mvneclipse 1m 12s trunk passed
      0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
      +1 findbugs 3m 36s trunk passed
      +1 javadoc 1m 40s trunk passed
      0 mvndep 0m 10s Maven dependency ordering for patch
      +1 mvninstall 1m 49s the patch passed
      +1 compile 5m 10s the patch passed
      +1 javac 5m 10s the patch passed
      -0 checkstyle 0m 48s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 206 unchanged - 0 fixed = 207 total (was 206)
      +1 mvnsite 2m 8s the patch passed
      +1 mvneclipse 1m 10s the patch passed
      -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
      -1 whitespace 0m 0s The patch 12 line(s) with tabs.
      +1 xml 0m 1s The patch has no ill-formed XML file.
      0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
      +1 findbugs 3m 43s the patch passed
      +1 javadoc 1m 34s the patch passed
      +1 unit 0m 32s hadoop-yarn-api in the patch passed.
      +1 unit 2m 35s hadoop-yarn-common in the patch passed.
      -1 unit 39m 47s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 unit 0m 14s hadoop-yarn-site in the patch passed.
      +1 asflicense 0m 30s The patch does not generate ASF License warnings.
      97m 14s



      Reason Tests
      Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:a9ad5d6
      JIRA Issue YARN-5931
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845024/YARN-5931.4.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
      uname Linux 2d447fd856b6 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / e9f1396
      Default Java 1.8.0_111
      findbugs v3.0.0
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14489/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14489/artifact/patchprocess/whitespace-eol.txt
      whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14489/artifact/patchprocess/whitespace-tabs.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/14489/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14489/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/14489/console
      Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 43s Maven dependency ordering for branch +1 mvninstall 13m 27s trunk passed +1 compile 5m 3s trunk passed +1 checkstyle 0m 46s trunk passed +1 mvnsite 2m 4s trunk passed +1 mvneclipse 1m 12s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 3m 36s trunk passed +1 javadoc 1m 40s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 49s the patch passed +1 compile 5m 10s the patch passed +1 javac 5m 10s the patch passed -0 checkstyle 0m 48s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 206 unchanged - 0 fixed = 207 total (was 206) +1 mvnsite 2m 8s the patch passed +1 mvneclipse 1m 10s the patch passed -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 0s The patch 12 line(s) with tabs. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 3m 43s the patch passed +1 javadoc 1m 34s the patch passed +1 unit 0m 32s hadoop-yarn-api in the patch passed. +1 unit 2m 35s hadoop-yarn-common in the patch passed. -1 unit 39m 47s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 0m 14s hadoop-yarn-site in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 97m 14s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5931 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845024/YARN-5931.4.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 2d447fd856b6 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e9f1396 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14489/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14489/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14489/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14489/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14489/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14489/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      rohithsharma Rohith Sharma K S added a comment -

      updated patch fixing review comments.

      Show
      rohithsharma Rohith Sharma K S added a comment - updated patch fixing review comments.
      Hide
      templedf Daniel Templeton added a comment -

      I agree, but it should be "collection", not "collections".

      Show
      templedf Daniel Templeton added a comment - I agree, but it should be "collection", not "collections".
      Hide
      rohithsharma Rohith Sharma K S added a comment -

      I think this sentence is more meaning full. "When you run a GET operation on this resource, a collections of ApplicationTimeout object is returned"

      Show
      rohithsharma Rohith Sharma K S added a comment - I think this sentence is more meaning full. "When you run a GET operation on this resource, a collections of ApplicationTimeout object is returned"
      Hide
      templedf Daniel Templeton added a comment -

      Thanks for the update. Two more things:

      • This one is still outstanding: "When you run a GET operation on this resource, you can obtain a collection of Application Timeout Objects." should be "When you run a GET operation on this resource, a collection of Application Timeout Objects is returned."
      • In the Cluster Applications API, you say that a collection "are" returned. It should be "is."
      Show
      templedf Daniel Templeton added a comment - Thanks for the update. Two more things: This one is still outstanding: "When you run a GET operation on this resource, you can obtain a collection of Application Timeout Objects." should be "When you run a GET operation on this resource, a collection of Application Timeout Objects is returned." In the Cluster Applications API, you say that a collection "are" returned. It should be "is."
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 14s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      0 mvndep 0m 52s Maven dependency ordering for branch
      +1 mvninstall 14m 22s trunk passed
      +1 compile 4m 52s trunk passed
      +1 checkstyle 0m 45s trunk passed
      +1 mvnsite 2m 3s trunk passed
      +1 mvneclipse 1m 12s trunk passed
      0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
      +1 findbugs 3m 18s trunk passed
      +1 javadoc 1m 41s trunk passed
      0 mvndep 0m 10s Maven dependency ordering for patch
      +1 mvninstall 1m 32s the patch passed
      +1 compile 4m 40s the patch passed
      +1 javac 4m 40s the patch passed
      -0 checkstyle 0m 48s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 206 unchanged - 0 fixed = 207 total (was 206)
      +1 mvnsite 2m 11s the patch passed
      +1 mvneclipse 1m 5s the patch passed
      -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
      -1 whitespace 0m 1s The patch 12 line(s) with tabs.
      +1 xml 0m 1s The patch has no ill-formed XML file.
      0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
      +1 findbugs 4m 8s the patch passed
      +1 javadoc 1m 34s the patch passed
      +1 unit 0m 34s hadoop-yarn-api in the patch passed.
      +1 unit 2m 36s hadoop-yarn-common in the patch passed.
      +1 unit 39m 45s hadoop-yarn-server-resourcemanager in the patch passed.
      +1 unit 0m 11s hadoop-yarn-site in the patch passed.
      +1 asflicense 0m 28s The patch does not generate ASF License warnings.
      97m 7s



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:a9ad5d6
      JIRA Issue YARN-5931
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844894/YARN-5931.3.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
      uname Linux 050d68bc68fb 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / f6715b2
      Default Java 1.8.0_111
      findbugs v3.0.0
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14484/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14484/artifact/patchprocess/whitespace-eol.txt
      whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14484/artifact/patchprocess/whitespace-tabs.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14484/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/14484/console
      Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 52s Maven dependency ordering for branch +1 mvninstall 14m 22s trunk passed +1 compile 4m 52s trunk passed +1 checkstyle 0m 45s trunk passed +1 mvnsite 2m 3s trunk passed +1 mvneclipse 1m 12s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 3m 18s trunk passed +1 javadoc 1m 41s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 32s the patch passed +1 compile 4m 40s the patch passed +1 javac 4m 40s the patch passed -0 checkstyle 0m 48s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 206 unchanged - 0 fixed = 207 total (was 206) +1 mvnsite 2m 11s the patch passed +1 mvneclipse 1m 5s the patch passed -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 1s The patch 12 line(s) with tabs. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 4m 8s the patch passed +1 javadoc 1m 34s the patch passed +1 unit 0m 34s hadoop-yarn-api in the patch passed. +1 unit 2m 36s hadoop-yarn-common in the patch passed. +1 unit 39m 45s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 0m 11s hadoop-yarn-site in the patch passed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 97m 7s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5931 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844894/YARN-5931.3.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 050d68bc68fb 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f6715b2 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14484/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14484/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14484/artifact/patchprocess/whitespace-tabs.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14484/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14484/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      sunilg Sunil G added a comment -

      Thanks Rohith Sharma K S
      Looks fine. I will wait for Daniel Templeton also.

      Show
      sunilg Sunil G added a comment - Thanks Rohith Sharma K S Looks fine. I will wait for Daniel Templeton also.
      Hide
      rohithsharma Rohith Sharma K S added a comment -

      Updated patch fixing review comments

      Show
      rohithsharma Rohith Sharma K S added a comment - Updated patch fixing review comments
      Hide
      templedf Daniel Templeton added a comment -

      A few more comments:

      • "The possible combination of values" should just be "The possible values"
      • "Timeout is configured and Application is RUNNING." should be "Timeout is configured and application is RUNNING."
      • "When you run a GET operation on this resource, you can obtain a collection of Application Objects." should be "When you run a GET operation on this resource, a collection of Application Objects is returned." Yeah, it's passive voice, but this isn't a 9th grade book report.
      • "When you run a GET operation on this resource, you can obtain a collection of Application Timeout Objects." should be "When you run a GET operation on this resource, a collection of Application Timeout Objects is returned."
      • "Each timeout object represents timeout type" should be "Each timeout object is composed of a timeout type"
      • "Time at which application will get expired" should be "Time at which the application will expire"
      • In general, I disagree with the earlier comment that the "the"s should be dropped in the docs. It's fine in the javadocs, but the user docs should use "the application", i.e. they shouldn't be in developer speak.
      • With "Valid values are the members of the ApplicationTimeoutType enum: LIFETIME", I'd be more explicit instead of using developer speak. Something like, "Valid values are the members of the ApplicationTimeoutType enum. LIFETIME is currently the only valid value."
      • "Update timeout of an application from the time of request in seconds." is confusing. How about "Update application timeout (from the time of request) in seconds."

      On a more meta level, 3s is fine with me. 1s would even be fine.

      Show
      templedf Daniel Templeton added a comment - A few more comments: "The possible combination of values" should just be "The possible values" "Timeout is configured and Application is RUNNING." should be "Timeout is configured and application is RUNNING." "When you run a GET operation on this resource, you can obtain a collection of Application Objects." should be "When you run a GET operation on this resource, a collection of Application Objects is returned." Yeah, it's passive voice, but this isn't a 9th grade book report. "When you run a GET operation on this resource, you can obtain a collection of Application Timeout Objects." should be "When you run a GET operation on this resource, a collection of Application Timeout Objects is returned." "Each timeout object represents timeout type" should be "Each timeout object is composed of a timeout type" "Time at which application will get expired" should be "Time at which the application will expire" In general, I disagree with the earlier comment that the "the"s should be dropped in the docs. It's fine in the javadocs, but the user docs should use "the application", i.e. they shouldn't be in developer speak. With "Valid values are the members of the ApplicationTimeoutType enum: LIFETIME", I'd be more explicit instead of using developer speak. Something like, "Valid values are the members of the ApplicationTimeoutType enum. LIFETIME is currently the only valid value." "Update timeout of an application from the time of request in seconds." is confusing. How about "Update application timeout (from the time of request) in seconds." On a more meta level, 3s is fine with me. 1s would even be fine.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 13s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      0 mvndep 0m 54s Maven dependency ordering for branch
      +1 mvninstall 15m 44s trunk passed
      +1 compile 5m 58s trunk passed
      +1 checkstyle 0m 51s trunk passed
      +1 mvnsite 2m 26s trunk passed
      +1 mvneclipse 1m 16s trunk passed
      0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
      +1 findbugs 3m 55s trunk passed
      +1 javadoc 1m 49s trunk passed
      0 mvndep 0m 11s Maven dependency ordering for patch
      +1 mvninstall 2m 2s the patch passed
      +1 compile 5m 53s the patch passed
      +1 javac 5m 53s the patch passed
      -0 checkstyle 0m 54s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 206 unchanged - 0 fixed = 207 total (was 206)
      +1 mvnsite 2m 17s the patch passed
      +1 mvneclipse 1m 12s the patch passed
      -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
      -1 whitespace 0m 0s The patch 12 line(s) with tabs.
      +1 xml 0m 2s The patch has no ill-formed XML file.
      0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
      +1 findbugs 3m 39s the patch passed
      +1 javadoc 1m 45s the patch passed
      +1 unit 0m 34s hadoop-yarn-api in the patch passed.
      +1 unit 2m 26s hadoop-yarn-common in the patch passed.
      -1 unit 38m 43s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 unit 0m 14s hadoop-yarn-site in the patch passed.
      +1 asflicense 0m 29s The patch does not generate ASF License warnings.
      101m 57s



      Reason Tests
      Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestContinuousScheduling
        hadoop.yarn.server.resourcemanager.TestRMRestart



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:a9ad5d6
      JIRA Issue YARN-5931
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844740/YARN-5931.2.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
      uname Linux aaa23b8ce1ca 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / ea54752
      Default Java 1.8.0_111
      findbugs v3.0.0
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14477/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14477/artifact/patchprocess/whitespace-eol.txt
      whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14477/artifact/patchprocess/whitespace-tabs.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/14477/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14477/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/14477/console
      Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 54s Maven dependency ordering for branch +1 mvninstall 15m 44s trunk passed +1 compile 5m 58s trunk passed +1 checkstyle 0m 51s trunk passed +1 mvnsite 2m 26s trunk passed +1 mvneclipse 1m 16s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 3m 55s trunk passed +1 javadoc 1m 49s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 2m 2s the patch passed +1 compile 5m 53s the patch passed +1 javac 5m 53s the patch passed -0 checkstyle 0m 54s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 206 unchanged - 0 fixed = 207 total (was 206) +1 mvnsite 2m 17s the patch passed +1 mvneclipse 1m 12s the patch passed -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 0s The patch 12 line(s) with tabs. +1 xml 0m 2s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 3m 39s the patch passed +1 javadoc 1m 45s the patch passed +1 unit 0m 34s hadoop-yarn-api in the patch passed. +1 unit 2m 26s hadoop-yarn-common in the patch passed. -1 unit 38m 43s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 0m 14s hadoop-yarn-site in the patch passed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 101m 57s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestContinuousScheduling   hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5931 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844740/YARN-5931.2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux aaa23b8ce1ca 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ea54752 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14477/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14477/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14477/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14477/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14477/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14477/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      rohithsharma Rohith Sharma K S added a comment -

      updated patch fixing review comments..

      Show
      rohithsharma Rohith Sharma K S added a comment - updated patch fixing review comments..
      Hide
      sunilg Sunil G added a comment -

      Few minor nits:

      {ISO8601 date string, positive integer} : Timeout is configured and Application is RUNNING.

      Could we also say that app will be timeout after configured timeout. Something like Timeout is configured and Application is RUNNING. It also indicates that the application will be timed out after mentioned timeout in the response

      String diagnostics = "Application is killed by ResourceManager due to exceeding its lifetime period";

      Could it be like "Application is killed by ResourceManager as it has exceeded the lifetime period."

      Response Body of XMLtype

      All three XML response bodies seems not correct. It should be <timeout> and </timeout>. Some places timeouts is used incorrectly. Kindly check.

      Show
      sunilg Sunil G added a comment - Few minor nits: {ISO8601 date string, positive integer} : Timeout is configured and Application is RUNNING. Could we also say that app will be timeout after configured timeout. Something like Timeout is configured and Application is RUNNING. It also indicates that the application will be timed out after mentioned timeout in the response String diagnostics = "Application is killed by ResourceManager due to exceeding its lifetime period"; Could it be like "Application is killed by ResourceManager as it has exceeded the lifetime period." Response Body of XMLtype All three XML response bodies seems not correct. It should be <timeout> and </timeout>. Some places timeouts is used incorrectly. Kindly check.
      Hide
      jianhe Jian He added a comment -

      sounds good to me

      Show
      jianhe Jian He added a comment - sounds good to me
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 22s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      0 mvndep 0m 12s Maven dependency ordering for branch
      +1 mvninstall 9m 7s trunk passed
      +1 compile 6m 17s trunk passed
      +1 checkstyle 0m 50s trunk passed
      +1 mvnsite 2m 34s trunk passed
      +1 mvneclipse 1m 9s trunk passed
      0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
      +1 findbugs 3m 16s trunk passed
      +1 javadoc 1m 37s trunk passed
      0 mvndep 0m 10s Maven dependency ordering for patch
      +1 mvninstall 1m 30s the patch passed
      +1 compile 4m 34s the patch passed
      +1 javac 4m 34s the patch passed
      +1 checkstyle 0m 45s the patch passed
      +1 mvnsite 2m 6s the patch passed
      +1 mvneclipse 1m 9s the patch passed
      -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
      -1 whitespace 0m 0s The patch 12 line(s) with tabs.
      +1 xml 0m 1s The patch has no ill-formed XML file.
      0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
      +1 findbugs 3m 37s the patch passed
      +1 javadoc 1m 34s the patch passed
      +1 unit 0m 31s hadoop-yarn-api in the patch passed.
      +1 unit 2m 24s hadoop-yarn-common in the patch passed.
      +1 unit 38m 49s hadoop-yarn-server-resourcemanager in the patch passed.
      +1 unit 0m 13s hadoop-yarn-site in the patch passed.
      +1 asflicense 0m 28s The patch does not generate ASF License warnings.
      91m 26s



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:a9ad5d6
      JIRA Issue YARN-5931
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843212/YARN-5931.1.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
      uname Linux b1c6f79883cc 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / 72bff19
      Default Java 1.8.0_111
      findbugs v3.0.0
      whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14296/artifact/patchprocess/whitespace-eol.txt
      whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14296/artifact/patchprocess/whitespace-tabs.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14296/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/14296/console
      Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 12s Maven dependency ordering for branch +1 mvninstall 9m 7s trunk passed +1 compile 6m 17s trunk passed +1 checkstyle 0m 50s trunk passed +1 mvnsite 2m 34s trunk passed +1 mvneclipse 1m 9s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 3m 16s trunk passed +1 javadoc 1m 37s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 30s the patch passed +1 compile 4m 34s the patch passed +1 javac 4m 34s the patch passed +1 checkstyle 0m 45s the patch passed +1 mvnsite 2m 6s the patch passed +1 mvneclipse 1m 9s the patch passed -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 0s The patch 12 line(s) with tabs. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 3m 37s the patch passed +1 javadoc 1m 34s the patch passed +1 unit 0m 31s hadoop-yarn-api in the patch passed. +1 unit 2m 24s hadoop-yarn-common in the patch passed. +1 unit 38m 49s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 0m 13s hadoop-yarn-site in the patch passed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 91m 26s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5931 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843212/YARN-5931.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux b1c6f79883cc 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 72bff19 Default Java 1.8.0_111 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14296/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14296/artifact/patchprocess/whitespace-tabs.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14296/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14296/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      rohithsharma Rohith Sharma K S added a comment -

      Updating patch fixing review comments. I have made other changes also along with it

      1. Improved JavaDoc for ApplicationTimeout Object.
      2. Changed the default value for monitor interval to 3seconds. I feel, 60 seconds is too high. cc:/ Jian He What do you think?
      Show
      rohithsharma Rohith Sharma K S added a comment - Updating patch fixing review comments. I have made other changes also along with it Improved JavaDoc for ApplicationTimeout Object. Changed the default value for monitor interval to 3seconds. I feel, 60 seconds is too high. cc:/ Jian He What do you think?
      Hide
      jianhe Jian He added a comment -
      • " Update timeout of an application from NOW. ApplicationId can be passed using 'appId' option. Timeout value is in seconds."
        May be "Update timeout of an application from the time of request in seconds. ApplicationId can be specified using 'appId' option" ?
      Show
      jianhe Jian He added a comment - " Update timeout of an application from NOW. ApplicationId can be passed using 'appId' option. Timeout value is in seconds." May be "Update timeout of an application from the time of request in seconds. ApplicationId can be specified using 'appId' option" ?
      Hide
      rohithsharma Rohith Sharma K S added a comment -

      Thanks Sunil for the review. I will update the patch fixing review comments.

      Show
      rohithsharma Rohith Sharma K S added a comment - Thanks Sunil for the review. I will update the patch fixing review comments.
      Hide
      sunilg Sunil G added a comment -

      Hi Rohith Sharma K S

      Few comments:

      Update timeout of an application from NOW.

      I think "Update timeout of an application from current time." may be better.

      The Cluster Application Timeouts API

      "The" could be removed.

      you obtain a collection of Application Timeout Object

      Each timeout object represent

      Could be
      "you can obtain a collection of Application Timeout Object"
      "Each timeout object represents"

              "type": "LIFETIME",
              "expiryTime": "UNLIMITED",
              "remainingTimeInSeconds": -1
      

      Is it better to show valid example.?

      Show
      sunilg Sunil G added a comment - Hi Rohith Sharma K S Few comments: Update timeout of an application from NOW. I think "Update timeout of an application from current time." may be better. The Cluster Application Timeouts API "The" could be removed. you obtain a collection of Application Timeout Object Each timeout object represent Could be "you can obtain a collection of Application Timeout Object" "Each timeout object represents" "type": "LIFETIME", "expiryTime": "UNLIMITED", "remainingTimeInSeconds": -1 Is it better to show valid example.?
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 17s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 mvninstall 8m 24s trunk passed
      +1 mvnsite 0m 19s trunk passed
      +1 mvnsite 0m 13s the patch passed
      -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
      -1 whitespace 0m 0s The patch 12 line(s) with tabs.
      +1 asflicense 0m 20s The patch does not generate ASF License warnings.
      9m 56s



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:a9ad5d6
      JIRA Issue YARN-5931
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840622/YARN-5931.0.patch
      Optional Tests asflicense mvnsite
      uname Linux 59f7900f06c0 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / 5d5614f
      whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14080/artifact/patchprocess/whitespace-eol.txt
      whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14080/artifact/patchprocess/whitespace-tabs.txt
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/14080/console
      Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 mvninstall 8m 24s trunk passed +1 mvnsite 0m 19s trunk passed +1 mvnsite 0m 13s the patch passed -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 0s The patch 12 line(s) with tabs. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 9m 56s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5931 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840622/YARN-5931.0.patch Optional Tests asflicense mvnsite uname Linux 59f7900f06c0 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5d5614f whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14080/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14080/artifact/patchprocess/whitespace-tabs.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site Console output https://builds.apache.org/job/PreCommit-YARN-Build/14080/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      rohithsharma Rohith Sharma K S added a comment -

      attaching the patch. Kindly review the patch

      Show
      rohithsharma Rohith Sharma K S added a comment - attaching the patch. Kindly review the patch
      Hide
      rohithsharma Rohith Sharma K S added a comment -

      updating the html page for patch.

      Show
      rohithsharma Rohith Sharma K S added a comment - updating the html page for patch.

        People

        • Assignee:
          rohithsharma Rohith Sharma K S
          Reporter:
          rohithsharma Rohith Sharma K S
        • Votes:
          0 Vote for this issue
          Watchers:
          6 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development