A small fix inside function canAssignToThisQueue() for printing DEBUG info. Please see patch attached.
Could you please attach a patch here.
Hi Sunil G, patch attached. Thank you.
It is just a small fix. I believe the intention is to print some debug information when we are able to assign to the queue, i.e., returning true. (See YARN-3361 where this change was made at the first place.)
This message was automatically generated.
The UT failure is known and tracked by YARN-5548.
Thanks for the patch. I ll take a look today.
Hi Ying Zhang
Your observation is correct. We are using that debug log to get some more information when assign to queue is passed. So your patch is correct. I think we can also add one more debug info in case when we return false case also (wherever we have current debug log). We could print
LOG.debug("Failed to assignToQueue: " + getQueueName() + " usedResources: " + queueUsage.getUsed() + ", clusterResources: " + clusterResource + ", maxLimitCapacity: " + currentLimitResource + ", currTotalUsed:" + usedExceptKillable);
Hi Sunil G, thanks for the review. Agree. I've updated the patch, please take a look. Besides those you've listed here, I'm thinking "resourceCouldBeUnreserved" would also be useful.
Thanks. Looks fine for me. Will wait for jenkins to come back.
Not sure why there wasn't Jenkins result. Delete and re-attach YARN-5899.002.patch to try to start Jenkins again.
This patch only introduces some modification to debug information. No test case is needed. I've enabled DEBUG mode and test it manually. Failed test case TestRMRestart.testFinishedAppRemovalAfterRMRestart is known and tracked by YARN-5548.
+1. Committing later today if there are no objections.
Thanks Ying Zhang for the contribution. Committed to trunk and branch-2.
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #11097 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11097/)
YARN-5899. Debug log in AbstractCSQueue#canAssignToThisQueue needs (sunilg: rev 9594c35dcb655add1991d8fd15897b40c4ad6205)
Thanks Sunil G for the review and commit.