Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-1963 Support priorities across applications within the same queue
  3. YARN-5865

Retrospect updateApplicationPriority api to handle state store exception in align with YARN-5611

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Post YARN-5611, revisit dynamic update of application priority logic with respect to state store error handling.

      1. YARN-5865.0001.patch
        4 kB
        Sunil G
      2. YARN-5865.0002.patch
        42 kB
        Sunil G
      3. YARN-5865.0003.patch
        45 kB
        Sunil G
      4. YARN-5865.0004.patch
        49 kB
        Sunil G
      5. YARN-5865.0005.patch
        47 kB
        Sunil G
      6. YARN-5865.0006.patch
        47 kB
        Sunil G
      7. YARN-5865.branch-2.0001.patch
        43 kB
        Sunil G
      8. YARN-5865.branch-2.0002.patch
        43 kB
        Sunil G

        Activity

        Hide
        sunilg Sunil G added a comment -

        Updating an initial version of the patch. cc/Rohith Sharma K S and Jian He

        Show
        sunilg Sunil G added a comment - Updating an initial version of the patch. cc/ Rohith Sharma K S and Jian He
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 46s trunk passed
        +1 compile 0m 32s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 37s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 1m 0s trunk passed
        +1 javadoc 0m 22s trunk passed
        +1 mvninstall 0m 32s the patch passed
        +1 compile 0m 30s the patch passed
        +1 javac 0m 30s the patch passed
        +1 checkstyle 0m 19s the patch passed
        +1 mvnsite 0m 36s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 3s the patch passed
        +1 javadoc 0m 19s the patch passed
        +1 unit 41m 5s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        56m 28s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:e809691
        JIRA Issue YARN-5865
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838358/YARN-5865.0001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 38af88531a3c 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ca68f9c
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13858/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13858/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 46s trunk passed +1 compile 0m 32s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 37s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 0s trunk passed +1 javadoc 0m 22s trunk passed +1 mvninstall 0m 32s the patch passed +1 compile 0m 30s the patch passed +1 javac 0m 30s the patch passed +1 checkstyle 0m 19s the patch passed +1 mvnsite 0m 36s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 3s the patch passed +1 javadoc 0m 19s the patch passed +1 unit 41m 5s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 56m 28s Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue YARN-5865 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838358/YARN-5865.0001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 38af88531a3c 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ca68f9c Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13858/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13858/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jianhe Jian He added a comment -

        thanks Sunil, one comment:
        we should make sure update in store first in case store operation failed, so " rmApp.getApplicationSubmissionContext().setPriority(appPriority);" should be done after

        // Update new priority in Submission Context to keep track in HA
              rmApp.getApplicationSubmissionContext().setPriority(appPriority);
              // Update to state store
              ApplicationStateData appState = ApplicationStateData.newInstance(
                  rmApp.getSubmitTime(), rmApp.getStartTime(),
                  rmApp.getApplicationSubmissionContext(), rmApp.getUser(),
                  rmApp.getCallerContext());
              appState.setApplicationTimeouts(rmApp.getApplicationTimeouts());
              rmContext.getStateStore().updateApplicationStateSynchronously(appState,
                  false, future);
        
        Show
        jianhe Jian He added a comment - thanks Sunil, one comment: we should make sure update in store first in case store operation failed, so " rmApp.getApplicationSubmissionContext().setPriority(appPriority);" should be done after // Update new priority in Submission Context to keep track in HA rmApp.getApplicationSubmissionContext().setPriority(appPriority); // Update to state store ApplicationStateData appState = ApplicationStateData.newInstance( rmApp.getSubmitTime(), rmApp.getStartTime(), rmApp.getApplicationSubmissionContext(), rmApp.getUser(), rmApp.getCallerContext()); appState.setApplicationTimeouts(rmApp.getApplicationTimeouts()); rmContext.getStateStore().updateApplicationStateSynchronously(appState, false , future );
        Hide
        rohithsharma Rohith Sharma K S added a comment - - edited

        Thanks Sunil for the patch.. couple of things to consider,

        1. As Jian comment, need to update state-store first and update in-memory second. But this would be difficult in priority update as it try to update ApplicationSubmissionContext. I think this is time to think for storing priority in ApplicaitonStateData. As I see storing priority as separate field in ApplicationStateData would be a difficult for priority update to change some of the implementation part especially during submission and recovery flow, but I think it is good to do it now. Thoughts?
        2. I see one race conditional bug since we are holding lock on applicationId. It is there in update ApplicationTimeout also. Could we do if (COMPLETED_APP_STATES.contains(application.getState())) { check either after holding lock of applicationId or in method RMStateStore#updateApplicationStateSynchronously ?? And could you update this modification for updateTimeout also?
        Show
        rohithsharma Rohith Sharma K S added a comment - - edited Thanks Sunil for the patch.. couple of things to consider, As Jian comment, need to update state-store first and update in-memory second. But this would be difficult in priority update as it try to update ApplicationSubmissionContext. I think this is time to think for storing priority in ApplicaitonStateData. As I see storing priority as separate field in ApplicationStateData would be a difficult for priority update to change some of the implementation part especially during submission and recovery flow, but I think it is good to do it now. Thoughts? I see one race conditional bug since we are holding lock on applicationId. It is there in update ApplicationTimeout also. Could we do if (COMPLETED_APP_STATES.contains(application.getState())) { check either after holding lock of applicationId or in method RMStateStore#updateApplicationStateSynchronously ?? And could you update this modification for updateTimeout also?
        Hide
        sunilg Sunil G added a comment -

        Thanks Jian He and Rohith Sharma K S for the comments.

        Generally makes sense as priority update was depending on submission context.

        I made few changes now.

        • submission context will still be used to store priority. But this will not be used as a working data in scheduler any more
        • new priority variable will be kept in RMAppImpl. This will be the in-memory storage for priority for app
        • all getters from REST/api's etc will be using RMApp#getApplicationPriority instead of the submission context api.

        Also we ensure that any edit to submission context will be done only to track HA scenarios and it will be under write lock of app id.

        Show
        sunilg Sunil G added a comment - Thanks Jian He and Rohith Sharma K S for the comments. Generally makes sense as priority update was depending on submission context. I made few changes now. submission context will still be used to store priority. But this will not be used as a working data in scheduler any more new priority variable will be kept in RMAppImpl. This will be the in-memory storage for priority for app all getters from REST/api's etc will be using RMApp#getApplicationPriority instead of the submission context api. Also we ensure that any edit to submission context will be done only to track HA scenarios and it will be under write lock of app id.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Thanks Sunil G for the patch. It looks all the reader API has changed to new interface. I am fine with that.
        One quick comment on patch is

        1. In CapacityScheduler#updateApplicationPriority, line no 2424, you are returning the appPriority. But future is not set to null. This lead to RMAppManager#updateApplicationPriority Futures.get(future, YarnException.class); to hang. So, you need to set to null before returning from scheduler. Better add a comment that you need to set to null or else it will hang. May be you can test by updating priority same as earlier which lead to test case hang.
        Show
        rohithsharma Rohith Sharma K S added a comment - Thanks Sunil G for the patch. It looks all the reader API has changed to new interface. I am fine with that. One quick comment on patch is In CapacityScheduler#updateApplicationPriority, line no 2424, you are returning the appPriority. But future is not set to null. This lead to RMAppManager#updateApplicationPriority Futures.get(future, YarnException.class); to hang. So, you need to set to null before returning from scheduler. Better add a comment that you need to set to null or else it will hang. May be you can test by updating priority same as earlier which lead to test case hang.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
        +1 mvninstall 7m 2s trunk passed
        +1 compile 0m 33s trunk passed
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 0m 39s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        +1 findbugs 1m 0s trunk passed
        +1 javadoc 0m 21s trunk passed
        +1 mvninstall 0m 32s the patch passed
        +1 compile 0m 31s the patch passed
        +1 javac 0m 31s the patch passed
        -0 checkstyle 0m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 5 new + 561 unchanged - 2 fixed = 566 total (was 563)
        +1 mvnsite 0m 37s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        +1 findbugs 1m 4s the patch passed
        -1 javadoc 0m 18s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 1 new + 935 unchanged - 0 fixed = 936 total (was 935)
        -1 unit 40m 3s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        55m 54s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation
          hadoop.yarn.server.resourcemanager.TestApplicationMasterService
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification
          hadoop.yarn.server.resourcemanager.TestTokenClientRMService
          hadoop.yarn.server.resourcemanager.TestClientRMService
          hadoop.yarn.server.resourcemanager.TestAppManager



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5865
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838735/YARN-5865.0002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 53970e262c2e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 79448d4
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13892/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/13892/artifact/patchprocess/whitespace-eol.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13892/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/13892/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13892/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13892/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files. +1 mvninstall 7m 2s trunk passed +1 compile 0m 33s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 39s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 1m 0s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 32s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed -0 checkstyle 0m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 5 new + 561 unchanged - 2 fixed = 566 total (was 563) +1 mvnsite 0m 37s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 1m 4s the patch passed -1 javadoc 0m 18s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 1 new + 935 unchanged - 0 fixed = 936 total (was 935) -1 unit 40m 3s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 55m 54s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation   hadoop.yarn.server.resourcemanager.TestApplicationMasterService   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification   hadoop.yarn.server.resourcemanager.TestTokenClientRMService   hadoop.yarn.server.resourcemanager.TestClientRMService   hadoop.yarn.server.resourcemanager.TestAppManager Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5865 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838735/YARN-5865.0002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 53970e262c2e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 79448d4 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13892/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/13892/artifact/patchprocess/whitespace-eol.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13892/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13892/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13892/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13892/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Yes Rohith Sharma K S. future needs to be set as null in case of any in b/w returns.

        Also there were many places we were using submissionContext.getPriority. All such use cases are moved to app.getApplicationPriority. So submission is used only in init/recover cases. also while storing to StateStore. hence patch is slightly bigger, but there is a lot of good cleaning up has done.

        pls help to check the same .

        Show
        sunilg Sunil G added a comment - Yes Rohith Sharma K S . future needs to be set as null in case of any in b/w returns. Also there were many places we were using submissionContext.getPriority . All such use cases are moved to app.getApplicationPriority . So submission is used only in init/recover cases. also while storing to StateStore. hence patch is slightly bigger, but there is a lot of good cleaning up has done. pls help to check the same .
        Hide
        sunilg Sunil G added a comment -

        Patch number was wrong earlier. Attaching correct patch.

        Show
        sunilg Sunil G added a comment - Patch number was wrong earlier. Attaching correct patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 8 new or modified test files.
        0 mvndep 0m 12s Maven dependency ordering for branch
        +1 mvninstall 8m 4s trunk passed
        +1 compile 5m 22s trunk passed
        +1 checkstyle 0m 55s trunk passed
        +1 mvnsite 1m 26s trunk passed
        +1 mvneclipse 0m 41s trunk passed
        +1 findbugs 2m 34s trunk passed
        +1 javadoc 0m 51s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 4s the patch passed
        +1 compile 5m 8s the patch passed
        +1 javac 5m 8s the patch passed
        -0 checkstyle 0m 51s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 632 unchanged - 2 fixed = 634 total (was 634)
        +1 mvnsite 1m 19s the patch passed
        +1 mvneclipse 0m 41s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 42s the patch passed
        -1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 1 new + 935 unchanged - 0 fixed = 936 total (was 935)
        +1 unit 0m 31s hadoop-yarn-api in the patch passed.
        -1 unit 41m 12s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 29s The patch does not generate ASF License warnings.
        83m 28s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestAppManager
          hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions
          hadoop.yarn.server.resourcemanager.TestResourceTrackerService
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebAppFairScheduler
          hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler
          hadoop.yarn.server.resourcemanager.scheduler.fair.TestAppRunnability
          hadoop.yarn.server.resourcemanager.TestTokenClientRMService



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5865
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838797/YARN-5865.0003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a05827979adc 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 6efb8c9
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13899/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13899/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/13899/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13899/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13899/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 8 new or modified test files. 0 mvndep 0m 12s Maven dependency ordering for branch +1 mvninstall 8m 4s trunk passed +1 compile 5m 22s trunk passed +1 checkstyle 0m 55s trunk passed +1 mvnsite 1m 26s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 2m 34s trunk passed +1 javadoc 0m 51s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 4s the patch passed +1 compile 5m 8s the patch passed +1 javac 5m 8s the patch passed -0 checkstyle 0m 51s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 632 unchanged - 2 fixed = 634 total (was 634) +1 mvnsite 1m 19s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 42s the patch passed -1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 1 new + 935 unchanged - 0 fixed = 936 total (was 935) +1 unit 0m 31s hadoop-yarn-api in the patch passed. -1 unit 41m 12s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 83m 28s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestAppManager   hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions   hadoop.yarn.server.resourcemanager.TestResourceTrackerService   hadoop.yarn.server.resourcemanager.webapp.TestRMWebAppFairScheduler   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler   hadoop.yarn.server.resourcemanager.scheduler.fair.TestAppRunnability   hadoop.yarn.server.resourcemanager.TestTokenClientRMService Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5865 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838797/YARN-5865.0003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a05827979adc 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6efb8c9 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13899/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13899/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13899/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13899/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13899/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Test cases are related. updating patch for same.

        Show
        sunilg Sunil G added a comment - Test cases are related. updating patch for same.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 9 new or modified test files.
        0 mvndep 0m 9s Maven dependency ordering for branch
        +1 mvninstall 7m 1s trunk passed
        +1 compile 5m 0s trunk passed
        +1 checkstyle 0m 52s trunk passed
        +1 mvnsite 1m 24s trunk passed
        +1 mvneclipse 0m 41s trunk passed
        +1 findbugs 2m 17s trunk passed
        +1 javadoc 0m 55s trunk passed
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 0m 57s the patch passed
        +1 compile 4m 51s the patch passed
        +1 javac 4m 51s the patch passed
        -0 checkstyle 0m 52s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 652 unchanged - 2 fixed = 654 total (was 654)
        +1 mvnsite 1m 20s the patch passed
        +1 mvneclipse 0m 38s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        +1 findbugs 2m 28s the patch passed
        +1 javadoc 0m 51s the patch passed
        +1 unit 0m 33s hadoop-yarn-api in the patch passed.
        -1 unit 41m 25s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 31s The patch does not generate ASF License warnings.
        81m 23s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestResourceTrackerService
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebAppFairScheduler
          hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler
          hadoop.yarn.server.resourcemanager.scheduler.fair.TestAppRunnability
          hadoop.yarn.server.resourcemanager.TestTokenClientRMService



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5865
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838819/YARN-5865.0004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 63bd496167a0 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ff0b99e
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13901/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/13901/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/13901/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13901/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13901/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 9 new or modified test files. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 7m 1s trunk passed +1 compile 5m 0s trunk passed +1 checkstyle 0m 52s trunk passed +1 mvnsite 1m 24s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 2m 17s trunk passed +1 javadoc 0m 55s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 57s the patch passed +1 compile 4m 51s the patch passed +1 javac 4m 51s the patch passed -0 checkstyle 0m 52s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 652 unchanged - 2 fixed = 654 total (was 654) +1 mvnsite 1m 20s the patch passed +1 mvneclipse 0m 38s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 2m 28s the patch passed +1 javadoc 0m 51s the patch passed +1 unit 0m 33s hadoop-yarn-api in the patch passed. -1 unit 41m 25s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 81m 23s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestResourceTrackerService   hadoop.yarn.server.resourcemanager.webapp.TestRMWebAppFairScheduler   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler   hadoop.yarn.server.resourcemanager.scheduler.fair.TestAppRunnability   hadoop.yarn.server.resourcemanager.TestTokenClientRMService Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5865 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838819/YARN-5865.0004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 63bd496167a0 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ff0b99e Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13901/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/13901/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13901/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13901/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13901/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Thanks Rohith Sharma K S for the comments.

        • Added completed apps check for timeout api also in RMAppManager.
        • Fixed test failures
        • Removed Priority#clone as changes are to a stable proto class.
        Show
        sunilg Sunil G added a comment - Thanks Rohith Sharma K S for the comments. Added completed apps check for timeout api also in RMAppManager. Fixed test failures Removed Priority#clone as changes are to a stable proto class.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 docker 3m 47s Docker failed to build yetus/hadoop:a9ad5d6.



        Subsystem Report/Notes
        JIRA Issue YARN-5865
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838950/YARN-5865.0005.patch
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13919/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 3m 47s Docker failed to build yetus/hadoop:a9ad5d6. Subsystem Report/Notes JIRA Issue YARN-5865 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838950/YARN-5865.0005.patch Console output https://builds.apache.org/job/PreCommit-YARN-Build/13919/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 9 new or modified test files.
        +1 mvninstall 7m 7s trunk passed
        +1 compile 0m 35s trunk passed
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 0m 40s trunk passed
        +1 mvneclipse 0m 18s trunk passed
        +1 findbugs 1m 3s trunk passed
        +1 javadoc 0m 22s trunk passed
        +1 mvninstall 0m 32s the patch passed
        +1 compile 0m 31s the patch passed
        +1 javac 0m 31s the patch passed
        -0 checkstyle 0m 26s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 645 unchanged - 2 fixed = 647 total (was 647)
        +1 mvnsite 0m 40s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 11s the patch passed
        +1 javadoc 0m 20s the patch passed
        -1 unit 36m 42s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        52m 59s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestTokenClientRMService



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5865
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838950/YARN-5865.0005.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c808fa5d32a8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7ffb994
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13921/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/13921/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13921/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13921/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 9 new or modified test files. +1 mvninstall 7m 7s trunk passed +1 compile 0m 35s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 40s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 3s trunk passed +1 javadoc 0m 22s trunk passed +1 mvninstall 0m 32s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed -0 checkstyle 0m 26s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 645 unchanged - 2 fixed = 647 total (was 647) +1 mvnsite 0m 40s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 11s the patch passed +1 javadoc 0m 20s the patch passed -1 unit 36m 42s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 52m 59s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestTokenClientRMService Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5865 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838950/YARN-5865.0005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c808fa5d32a8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7ffb994 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13921/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13921/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13921/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13921/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        some more comments on the patch
        AppInfo.java

        1. After current patch change, you can remove app.getApplicationSubmissionContext();

        RMAppManager.java

        1. line 401, 402, 403 has not changed. Looks like format has changed. Can you revert this ?
        2. line 571, can you check if (app.isAppInCompletedStates()) immediately after holding applicationId lock? It is not an issue, just not to create future object.
        3. line 580, can you flip code for checking priority equals and do futures.get like below?
          	      if (app.getApplicationPriority().equals(appPriority)) {
          	        return;
          	      }
                    Futures.get(future, YarnException.class);
          

        RMApp.java

        1. Java doc for API isAppInCompletedStates is repeated i.e completed/completed states. It should be completing/completed.

        YarnScheduler.java

        1. Return type of API has changed from void to Priority. I am not sure does it breaks. cc:/Jian He
        Show
        rohithsharma Rohith Sharma K S added a comment - some more comments on the patch AppInfo.java After current patch change, you can remove app.getApplicationSubmissionContext(); RMAppManager.java line 401, 402, 403 has not changed. Looks like format has changed. Can you revert this ? line 571, can you check if (app.isAppInCompletedStates()) immediately after holding applicationId lock? It is not an issue, just not to create future object. line 580, can you flip code for checking priority equals and do futures.get like below? if (app.getApplicationPriority().equals(appPriority)) { return ; } Futures.get( future , YarnException.class); RMApp.java Java doc for API isAppInCompletedStates is repeated i.e completed/completed states . It should be completing/completed. YarnScheduler.java Return type of API has changed from void to Priority. I am not sure does it breaks. cc:/ Jian He
        Hide
        sunilg Sunil G added a comment -

        Thanks Rohith Sharma K S

        After current patch change, you can remove app.getApplicationSubmissionContext();

        we need this variable to see whether its an unmanaged AM or not. But I think i can move this variable to the statement where its used.

        Return type of API has changed from void to Priority. I am not sure does it breaks

        I think its fine as we have not released 2.8 yet provided we can push this jira to 2.8. Thoughts?

        Addressed all other comments.

        Show
        sunilg Sunil G added a comment - Thanks Rohith Sharma K S After current patch change, you can remove app.getApplicationSubmissionContext(); we need this variable to see whether its an unmanaged AM or not. But I think i can move this variable to the statement where its used. Return type of API has changed from void to Priority. I am not sure does it breaks I think its fine as we have not released 2.8 yet provided we can push this jira to 2.8. Thoughts? Addressed all other comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 9 new or modified test files.
        +1 mvninstall 9m 12s trunk passed
        +1 compile 0m 41s trunk passed
        +1 checkstyle 0m 36s trunk passed
        +1 mvnsite 0m 52s trunk passed
        +1 mvneclipse 0m 20s trunk passed
        +1 findbugs 1m 12s trunk passed
        +1 javadoc 0m 29s trunk passed
        +1 mvninstall 0m 39s the patch passed
        +1 compile 0m 40s the patch passed
        +1 javac 0m 40s the patch passed
        -0 checkstyle 0m 33s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 645 unchanged - 2 fixed = 647 total (was 647)
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 20s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 27s the patch passed
        +1 javadoc 0m 24s the patch passed
        -1 unit 49m 12s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        69m 47s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5865
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839209/YARN-5865.0006.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e51241dcd3dd 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7ef290c
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13940/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/13940/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13940/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13940/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 9 new or modified test files. +1 mvninstall 9m 12s trunk passed +1 compile 0m 41s trunk passed +1 checkstyle 0m 36s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 20s trunk passed +1 findbugs 1m 12s trunk passed +1 javadoc 0m 29s trunk passed +1 mvninstall 0m 39s the patch passed +1 compile 0m 40s the patch passed +1 javac 0m 40s the patch passed -0 checkstyle 0m 33s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 645 unchanged - 2 fixed = 647 total (was 647) +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 20s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 27s the patch passed +1 javadoc 0m 24s the patch passed -1 unit 49m 12s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 69m 47s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5865 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839209/YARN-5865.0006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e51241dcd3dd 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7ef290c Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13940/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13940/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13940/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13940/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Test failures are not related.

        Show
        sunilg Sunil G added a comment - Test failures are not related.
        Hide
        sunilg Sunil G added a comment -

        Jian He and Rohith Sharma K S. Please help to review this patch.

        Show
        sunilg Sunil G added a comment - Jian He and Rohith Sharma K S . Please help to review this patch.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        +1 LGTM

        Show
        rohithsharma Rohith Sharma K S added a comment - +1 LGTM
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        I will commit it later of the day if no more objections.

        Show
        rohithsharma Rohith Sharma K S added a comment - I will commit it later of the day if no more objections.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        committed to trunk.. patch do not apply for branch-2. Sunil G would you give patch for branch-2. And if it want to committed to branch-2.8, would you give patch to branch-2.8 also?

        Show
        rohithsharma Rohith Sharma K S added a comment - committed to trunk.. patch do not apply for branch-2. Sunil G would you give patch for branch-2. And if it want to committed to branch-2.8, would you give patch to branch-2.8 also?
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10871 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10871/)
        YARN-5865. Retrospect updateApplicationPriority api to handle state (rohithsharmaks: rev a926f895c11cd69cf2117c3b970304f3f1f53d92)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TimelineServiceV1Publisher.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TimelineServiceV2Publisher.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/MockRMApp.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TestSystemMetricsPublisherForV2.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AppInfo.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/event/AppAddedSchedulerEvent.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/YarnScheduler.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TestSystemMetricsPublisher.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAppManager.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMApp.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestAppManager.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/TestRMAppTransitions.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestApplicationPriority.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterService.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/applicationsmanager/MockAsm.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ApplicationMasterService.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10871 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10871/ ) YARN-5865 . Retrospect updateApplicationPriority api to handle state (rohithsharmaks: rev a926f895c11cd69cf2117c3b970304f3f1f53d92) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TimelineServiceV1Publisher.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TimelineServiceV2Publisher.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/MockRMApp.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TestSystemMetricsPublisherForV2.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AppInfo.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/event/AppAddedSchedulerEvent.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/YarnScheduler.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TestSystemMetricsPublisher.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAppManager.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMApp.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestAppManager.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/TestRMAppTransitions.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestApplicationPriority.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/applicationsmanager/MockAsm.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ApplicationMasterService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java
        Hide
        sunilg Sunil G added a comment -

        Updating branch-2 patch.

        Show
        sunilg Sunil G added a comment - Updating branch-2 patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 13m 43s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 8 new or modified test files.
        +1 mvninstall 8m 12s branch-2 passed
        +1 compile 0m 36s branch-2 passed with JDK v1.8.0_111
        +1 compile 0m 33s branch-2 passed with JDK v1.7.0_121
        +1 checkstyle 0m 28s branch-2 passed
        +1 mvnsite 0m 37s branch-2 passed
        +1 mvneclipse 0m 16s branch-2 passed
        +1 findbugs 1m 12s branch-2 passed
        +1 javadoc 0m 20s branch-2 passed with JDK v1.8.0_111
        +1 javadoc 0m 23s branch-2 passed with JDK v1.7.0_121
        +1 mvninstall 0m 31s the patch passed
        +1 compile 0m 27s the patch passed with JDK v1.8.0_111
        +1 javac 0m 27s the patch passed
        +1 compile 0m 30s the patch passed with JDK v1.7.0_121
        +1 javac 0m 30s the patch passed
        -0 checkstyle 0m 27s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 643 unchanged - 2 fixed = 645 total (was 645)
        +1 mvnsite 0m 35s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 20s the patch passed
        +1 javadoc 0m 18s the patch passed with JDK v1.8.0_111
        +1 javadoc 0m 21s the patch passed with JDK v1.7.0_121
        +1 unit 39m 49s hadoop-yarn-server-resourcemanager in the patch passed with JDK v1.7.0_121.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        110m 56s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue YARN-5865
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840227/YARN-5865.branch-2.0001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e84e4564b3f5 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 2d94f93
        Default Java 1.7.0_121
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14050/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14050/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14050/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 13m 43s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 8 new or modified test files. +1 mvninstall 8m 12s branch-2 passed +1 compile 0m 36s branch-2 passed with JDK v1.8.0_111 +1 compile 0m 33s branch-2 passed with JDK v1.7.0_121 +1 checkstyle 0m 28s branch-2 passed +1 mvnsite 0m 37s branch-2 passed +1 mvneclipse 0m 16s branch-2 passed +1 findbugs 1m 12s branch-2 passed +1 javadoc 0m 20s branch-2 passed with JDK v1.8.0_111 +1 javadoc 0m 23s branch-2 passed with JDK v1.7.0_121 +1 mvninstall 0m 31s the patch passed +1 compile 0m 27s the patch passed with JDK v1.8.0_111 +1 javac 0m 27s the patch passed +1 compile 0m 30s the patch passed with JDK v1.7.0_121 +1 javac 0m 30s the patch passed -0 checkstyle 0m 27s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 643 unchanged - 2 fixed = 645 total (was 645) +1 mvnsite 0m 35s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 20s the patch passed +1 javadoc 0m 18s the patch passed with JDK v1.8.0_111 +1 javadoc 0m 21s the patch passed with JDK v1.7.0_121 +1 unit 39m 49s hadoop-yarn-server-resourcemanager in the patch passed with JDK v1.7.0_121. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 110m 56s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue YARN-5865 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840227/YARN-5865.branch-2.0001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e84e4564b3f5 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 2d94f93 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14050/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14050/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/14050/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Updating branch-2 patch as there were some more unnecessary changes in earlier patch.Thanks Rohith Sharma K S

        Show
        sunilg Sunil G added a comment - Updating branch-2 patch as there were some more unnecessary changes in earlier patch.Thanks Rohith Sharma K S
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 8 new or modified test files.
        +1 mvninstall 7m 9s branch-2 passed
        +1 compile 0m 35s branch-2 passed with JDK v1.8.0_111
        +1 compile 0m 34s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 0m 30s branch-2 passed
        +1 mvnsite 0m 38s branch-2 passed
        +1 mvneclipse 0m 16s branch-2 passed
        +1 findbugs 1m 12s branch-2 passed
        +1 javadoc 0m 21s branch-2 passed with JDK v1.8.0_111
        +1 javadoc 0m 27s branch-2 passed with JDK v1.7.0_111
        +1 mvninstall 0m 32s the patch passed
        +1 compile 0m 32s the patch passed with JDK v1.8.0_111
        +1 javac 0m 32s the patch passed
        +1 compile 0m 33s the patch passed with JDK v1.7.0_111
        +1 javac 0m 33s the patch passed
        -0 checkstyle 0m 29s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 643 unchanged - 2 fixed = 645 total (was 645)
        +1 mvnsite 0m 36s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 24s the patch passed
        +1 javadoc 0m 18s the patch passed with JDK v1.8.0_111
        +1 javadoc 0m 22s the patch passed with JDK v1.7.0_111
        -1 unit 39m 15s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_111.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        96m 39s



        Reason Tests
        JDK v1.8.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
        JDK v1.7.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
          hadoop.yarn.server.resourcemanager.scheduler.fair.TestContinuousScheduling
          hadoop.yarn.server.resourcemanager.TestRMRestart



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue YARN-5865
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840250/YARN-5865.branch-2.0002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8940206c60e1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 2d94f93
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14053/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14053/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_111.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14053/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14053/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 8 new or modified test files. +1 mvninstall 7m 9s branch-2 passed +1 compile 0m 35s branch-2 passed with JDK v1.8.0_111 +1 compile 0m 34s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 30s branch-2 passed +1 mvnsite 0m 38s branch-2 passed +1 mvneclipse 0m 16s branch-2 passed +1 findbugs 1m 12s branch-2 passed +1 javadoc 0m 21s branch-2 passed with JDK v1.8.0_111 +1 javadoc 0m 27s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 32s the patch passed +1 compile 0m 32s the patch passed with JDK v1.8.0_111 +1 javac 0m 32s the patch passed +1 compile 0m 33s the patch passed with JDK v1.7.0_111 +1 javac 0m 33s the patch passed -0 checkstyle 0m 29s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 643 unchanged - 2 fixed = 645 total (was 645) +1 mvnsite 0m 36s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 24s the patch passed +1 javadoc 0m 18s the patch passed with JDK v1.8.0_111 +1 javadoc 0m 22s the patch passed with JDK v1.7.0_111 -1 unit 39m 15s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_111. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 96m 39s Reason Tests JDK v1.8.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart JDK v1.7.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer   hadoop.yarn.server.resourcemanager.scheduler.fair.TestContinuousScheduling   hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue YARN-5865 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840250/YARN-5865.branch-2.0002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8940206c60e1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 2d94f93 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14053/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14053/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14053/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/14053/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Sunil G Is test cases are related? Could you check it please?

        Show
        rohithsharma Rohith Sharma K S added a comment - Sunil G Is test cases are related? Could you check it please?
        Hide
        sunilg Sunil G added a comment -
        YARN-5816 TestDelegationTokenRenewer.testCancelWithMultipleAppSubmissions
        YARN-5548 TestRMRestart.testFinishedAppRemovalAfterRMRestart
        YARN-5343 TestContinuousScheduling.testSortedNodes

        Last one is failed even after the fix in YARN-5343, mostly needs to reopen. So test failures are not related.

        Show
        sunilg Sunil G added a comment - YARN-5816 TestDelegationTokenRenewer.testCancelWithMultipleAppSubmissions YARN-5548 TestRMRestart.testFinishedAppRemovalAfterRMRestart YARN-5343 TestContinuousScheduling.testSortedNodes Last one is failed even after the fix in YARN-5343 , mostly needs to reopen. So test failures are not related.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        committed to trunk/branch-2.. thanks Sunil G for the patch.. thanks Jian for additional review.

        Show
        rohithsharma Rohith Sharma K S added a comment - committed to trunk/branch-2.. thanks Sunil G for the patch.. thanks Jian for additional review.

          People

          • Assignee:
            sunilg Sunil G
            Reporter:
            sunilg Sunil G
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development