Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: yarn
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The default port for the AMRMProxy coincides with the one for the Collector Service (port 8048). Will use a different port for the AMRMProxy.

      1. YARN-5833.003.addendum.patch
        1.0 kB
        Konstantinos Karanasos
      2. YARN-5833.003.addendum-2.patch
        0.6 kB
        Arun Suresh
      3. YARN-5833.003.patch
        5 kB
        Konstantinos Karanasos
      4. YARN-5883.001.patch
        0.9 kB
        Konstantinos Karanasos
      5. YARN-5883.002.patch
        5 kB
        Konstantinos Karanasos

        Issue Links

          Activity

          Hide
          kkaranasos Konstantinos Karanasos added a comment -

          Attaching patch.

          Show
          kkaranasos Konstantinos Karanasos added a comment - Attaching patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 2s trunk passed
          +1 compile 0m 23s trunk passed
          +1 checkstyle 0m 14s trunk passed
          +1 mvnsite 0m 26s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 0s trunk passed
          +1 javadoc 0m 16s trunk passed
          +1 mvninstall 0m 22s the patch passed
          +1 compile 0m 21s the patch passed
          +1 javac 0m 21s the patch passed
          +1 checkstyle 0m 12s the patch passed
          +1 mvnsite 0m 24s the patch passed
          +1 mvneclipse 0m 9s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 6s the patch passed
          +1 javadoc 0m 14s the patch passed
          +1 unit 0m 23s hadoop-yarn-api in the patch passed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          14m 27s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue YARN-5833
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837002/YARN-5883.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6f1ce2fa83d2 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5cad93d
          Default Java 1.8.0_111
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13777/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13777/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 2s trunk passed +1 compile 0m 23s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 26s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 0s trunk passed +1 javadoc 0m 16s trunk passed +1 mvninstall 0m 22s the patch passed +1 compile 0m 21s the patch passed +1 javac 0m 21s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 24s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 6s the patch passed +1 javadoc 0m 14s the patch passed +1 unit 0m 23s hadoop-yarn-api in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 14m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-5833 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837002/YARN-5883.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6f1ce2fa83d2 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5cad93d Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13777/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api Console output https://builds.apache.org/job/PreCommit-YARN-Build/13777/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Konstantinos Karanasos for the patch. Can you add a test in TestYarnConfiguration/TestYarnConfigurationFields to catch this early as this is likely to happen again?

          Show
          subru Subru Krishnan added a comment - Thanks Konstantinos Karanasos for the patch. Can you add a test in TestYarnConfiguration/TestYarnConfigurationFields to catch this early as this is likely to happen again?
          Hide
          kkaranasos Konstantinos Karanasos added a comment -

          Thanks for the feedback, Subru Krishnan.

          I added a new test method in TestConfigurationFieldsBase that checks for collision of default values.
          Each subclass of TestConfigurationFieldsBase can specify a set of filter strings. Then the above method goes over each of these filters and makes sure that there is no collision between the values of the default parameters that contain this filter in their name.
          The TestYarnConfigurationFields initialize method adds the "_PORT" filter in the filter set to check for default port collision.

          At the moment the method that adds the filters in the TestYarnConfigurationFields is private. Let me know if you think it's better to move it to the base class and have the YARN specific one override it.

          Show
          kkaranasos Konstantinos Karanasos added a comment - Thanks for the feedback, Subru Krishnan . I added a new test method in TestConfigurationFieldsBase that checks for collision of default values. Each subclass of TestConfigurationFieldsBase can specify a set of filter strings. Then the above method goes over each of these filters and makes sure that there is no collision between the values of the default parameters that contain this filter in their name. The TestYarnConfigurationFields initialize method adds the "_PORT" filter in the filter set to check for default port collision. At the moment the method that adds the filters in the TestYarnConfigurationFields is private. Let me know if you think it's better to move it to the base class and have the YARN specific one override it.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 7m 6s trunk passed
          +1 compile 19m 7s trunk passed
          +1 checkstyle 3m 6s trunk passed
          +1 mvnsite 1m 46s trunk passed
          +1 mvneclipse 0m 41s trunk passed
          +1 findbugs 2m 42s trunk passed
          +1 javadoc 1m 24s trunk passed
          0 mvndep 0m 19s Maven dependency ordering for patch
          +1 mvninstall 1m 18s the patch passed
          +1 compile 10m 53s the patch passed
          +1 javac 10m 53s the patch passed
          -0 checkstyle 1m 50s root: The patch generated 1 new + 309 unchanged - 0 fixed = 310 total (was 309)
          +1 mvnsite 1m 53s the patch passed
          +1 mvneclipse 0m 54s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 27s the patch passed
          +1 javadoc 1m 34s the patch passed
          +1 unit 8m 33s hadoop-common in the patch passed.
          +1 unit 0m 42s hadoop-yarn-api in the patch passed.
          +1 asflicense 0m 46s The patch does not generate ASF License warnings.
          92m 21s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue YARN-5833
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837851/YARN-5883.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 46d48c44764f 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / de3b4aa
          Default Java 1.8.0_111
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13813/artifact/patchprocess/diff-checkstyle-root.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13813/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13813/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 7m 6s trunk passed +1 compile 19m 7s trunk passed +1 checkstyle 3m 6s trunk passed +1 mvnsite 1m 46s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 2m 42s trunk passed +1 javadoc 1m 24s trunk passed 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvninstall 1m 18s the patch passed +1 compile 10m 53s the patch passed +1 javac 10m 53s the patch passed -0 checkstyle 1m 50s root: The patch generated 1 new + 309 unchanged - 0 fixed = 310 total (was 309) +1 mvnsite 1m 53s the patch passed +1 mvneclipse 0m 54s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 27s the patch passed +1 javadoc 1m 34s the patch passed +1 unit 8m 33s hadoop-common in the patch passed. +1 unit 0m 42s hadoop-yarn-api in the patch passed. +1 asflicense 0m 46s The patch does not generate ASF License warnings. 92m 21s Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue YARN-5833 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837851/YARN-5883.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 46d48c44764f 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / de3b4aa Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13813/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13813/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/13813/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          kkaranasos Konstantinos Karanasos added a comment -

          Attaching new version of the patch in which I fixed the checkstyle issue.

          Also, I ran the new test with the previous parameter of the AMRMProxy port, which was causing a collision, and got the following output:

          java.lang.AssertionError: Parameters DEFAULT_AMRM_PROXY_PORT and DEFAULT_NM_COLLECTOR_SERVICE_PORT are using the same default value!

          With the port change, the test passes successfully.

          Show
          kkaranasos Konstantinos Karanasos added a comment - Attaching new version of the patch in which I fixed the checkstyle issue. Also, I ran the new test with the previous parameter of the AMRMProxy port, which was causing a collision, and got the following output: java.lang.AssertionError: Parameters DEFAULT_AMRM_PROXY_PORT and DEFAULT_NM_COLLECTOR_SERVICE_PORT are using the same default value! With the port change, the test passes successfully.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Konstantinos Karanasos for the fix, especially the new test! +1 on the latest patch (pending Yetus).

          Show
          subru Subru Krishnan added a comment - Thanks Konstantinos Karanasos for the fix, especially the new test! +1 on the latest patch (pending Yetus).
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 7m 8s trunk passed
          +1 compile 11m 37s trunk passed
          +1 checkstyle 1m 41s trunk passed
          +1 mvnsite 1m 47s trunk passed
          +1 mvneclipse 0m 48s trunk passed
          +1 findbugs 2m 47s trunk passed
          +1 javadoc 1m 24s trunk passed
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 1m 6s the patch passed
          +1 compile 9m 57s the patch passed
          +1 javac 9m 57s the patch passed
          +1 checkstyle 1m 52s the patch passed
          +1 mvnsite 1m 52s the patch passed
          +1 mvneclipse 0m 53s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 10s the patch passed
          +1 javadoc 1m 33s the patch passed
          +1 unit 7m 38s hadoop-common in the patch passed.
          +1 unit 0m 44s hadoop-yarn-api in the patch passed.
          +1 asflicense 0m 45s The patch does not generate ASF License warnings.
          81m 54s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue YARN-5833
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837881/YARN-5833.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 26f58b12049a 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3dbad5d
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13816/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13816/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 7m 8s trunk passed +1 compile 11m 37s trunk passed +1 checkstyle 1m 41s trunk passed +1 mvnsite 1m 47s trunk passed +1 mvneclipse 0m 48s trunk passed +1 findbugs 2m 47s trunk passed +1 javadoc 1m 24s trunk passed 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 1m 6s the patch passed +1 compile 9m 57s the patch passed +1 javac 9m 57s the patch passed +1 checkstyle 1m 52s the patch passed +1 mvnsite 1m 52s the patch passed +1 mvneclipse 0m 53s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 10s the patch passed +1 javadoc 1m 33s the patch passed +1 unit 7m 38s hadoop-common in the patch passed. +1 unit 0m 44s hadoop-yarn-api in the patch passed. +1 asflicense 0m 45s The patch does not generate ASF License warnings. 81m 54s Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue YARN-5833 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837881/YARN-5833.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 26f58b12049a 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3dbad5d Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13816/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/13816/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Konstantinos Karanasos for the useful contribution, I just committed it to trunk/branch-2.

          Show
          subru Subru Krishnan added a comment - Thanks Konstantinos Karanasos for the useful contribution, I just committed it to trunk/branch-2.
          Hide
          kkaranasos Konstantinos Karanasos added a comment -

          Thanks for reviewing and committing the patch, Subru Krishnan!

          Show
          kkaranasos Konstantinos Karanasos added a comment - Thanks for reviewing and committing the patch, Subru Krishnan !
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10791 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10791/)
          YARN-5833. Add validation to ensure default ports are unique in (subru: rev 29e3b3417c16c83dc8e753f94d7ca9957dddbedd)

          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationFieldsBase.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10791 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10791/ ) YARN-5833 . Add validation to ensure default ports are unique in (subru: rev 29e3b3417c16c83dc8e753f94d7ca9957dddbedd) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationFieldsBase.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          Hide
          liuml07 Mingliang Liu added a comment -

          Is branch-2 failing with Java 7 because of this? Thanks,

          Show
          liuml07 Mingliang Liu added a comment - Is branch-2 failing with Java 7 because of this? Thanks,
          Hide
          kkaranasos Konstantinos Karanasos added a comment -

          Mingliang Liu, I have checked it on trunk.. What error are you getting on branch-2?

          Show
          kkaranasos Konstantinos Karanasos added a comment - Mingliang Liu , I have checked it on trunk.. What error are you getting on branch-2?
          Hide
          liuml07 Mingliang Liu added a comment -
          [ERROR] COMPILATION ERROR :
          [ERROR] /Users/mliu/Workspace/hadoop/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationFieldsBase.java:[755,31] cannot find symbol
            symbol:   method putIfAbsent(java.lang.String,java.lang.String)
            location: variable filteredValues of type java.util.Map<java.lang.String,java.lang.String>
          [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project hadoop-common: Compilation failure
          [ERROR] /Users/mliu/Workspace/hadoop/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationFieldsBase.java:[755,31] cannot find symbol
          [ERROR] symbol:   method putIfAbsent(java.lang.String,java.lang.String)
          [ERROR] location: variable filteredValues of type java.util.Map<java.lang.String,java.lang.String>
          [ERROR] -> [Help 1]
          [ERROR]
          [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [ERROR]
          [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
          [ERROR]
          [ERROR] After correcting the problems, you can resume the build with the command
          [ERROR]   mvn <goals> -rf :hadoop-common
          

          Java 7 on branch-2. Thanks,

          Show
          liuml07 Mingliang Liu added a comment - [ERROR] COMPILATION ERROR : [ERROR] /Users/mliu/Workspace/hadoop/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationFieldsBase.java:[755,31] cannot find symbol symbol: method putIfAbsent(java.lang. String ,java.lang. String ) location: variable filteredValues of type java.util.Map<java.lang. String ,java.lang. String > [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile ( default -testCompile) on project hadoop-common: Compilation failure [ERROR] /Users/mliu/Workspace/hadoop/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationFieldsBase.java:[755,31] cannot find symbol [ERROR] symbol: method putIfAbsent(java.lang. String ,java.lang. String ) [ERROR] location: variable filteredValues of type java.util.Map<java.lang. String ,java.lang. String > [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch . [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http: //cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <goals> -rf :hadoop-common Java 7 on branch-2 . Thanks,
          Hide
          kkaranasos Konstantinos Karanasos added a comment -

          Thanks for catching this, Mingliang Liu.
          We had compiled it with Java 8.
          Attaching addendum patch that fixes the problem.

          Show
          kkaranasos Konstantinos Karanasos added a comment - Thanks for catching this, Mingliang Liu . We had compiled it with Java 8. Attaching addendum patch that fixes the problem.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Mingliang Liu for catching this. The issue is because we used putIfAbsent. I did compile branch-2 locally before pushing but unfortunately I only have java8 installed, my bad.

          Konstantinos Karanasos is providing an addendum with a fix which I'll commit to branch-2 shortly.

          Show
          subru Subru Krishnan added a comment - Thanks Mingliang Liu for catching this. The issue is because we used putIfAbsent . I did compile branch-2 locally before pushing but unfortunately I only have java8 installed, my bad. Konstantinos Karanasos is providing an addendum with a fix which I'll commit to branch-2 shortly.
          Hide
          subru Subru Krishnan added a comment -

          I just compiled branch-2 locally with the addendum using Java7 successfully and committed it. Thanks Konstantinos Karanasos for the quick turnaround!

          Show
          subru Subru Krishnan added a comment - I just compiled branch-2 locally with the addendum using Java7 successfully and committed it. Thanks Konstantinos Karanasos for the quick turnaround!
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks for the prompt action. The branch-2 is great again.

          Show
          liuml07 Mingliang Liu added a comment - Thanks for the prompt action. The branch-2 is great again.
          Hide
          asuresh Arun Suresh added a comment - - edited

          This patch broke the following tests:
          TestAMRMProxy
          TestMROpportunisticMaps
          TestDistributedScheduling

          Think we forgot to include the changes needed in yarn-default.xml. Attaching addendum patch.

          Since these tests wont be run by Jenkins, here is the output of the tests running locally:

          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          
          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.yarn.client.api.impl.TestAMRMProxy
          Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 59.499 sec - in org.apache.hadoop.yarn.client.api.impl.TestAMRMProxy
          Running org.apache.hadoop.yarn.client.api.impl.TestDistributedScheduling
          Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 71.654 sec - in org.apache.hadoop.yarn.client.api.impl.TestDistributedScheduling
          
          Results :
          
          Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
          ...
          ...
          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.mapred.TestMROpportunisticMaps
          Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 115.501 sec - in org.apache.hadoop.mapred.TestMROpportunisticMaps
          
          Results :
          
          Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
          ....
          ...
          
          Show
          asuresh Arun Suresh added a comment - - edited This patch broke the following tests: TestAMRMProxy TestMROpportunisticMaps TestDistributedScheduling Think we forgot to include the changes needed in yarn-default.xml . Attaching addendum patch. Since these tests wont be run by Jenkins, here is the output of the tests running locally: ------------------------------------------------------- T E S T S ------------------------------------------------------- ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.yarn.client.api.impl.TestAMRMProxy Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 59.499 sec - in org.apache.hadoop.yarn.client.api.impl.TestAMRMProxy Running org.apache.hadoop.yarn.client.api.impl.TestDistributedScheduling Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 71.654 sec - in org.apache.hadoop.yarn.client.api.impl.TestDistributedScheduling Results : Tests run: 7, Failures: 0, Errors: 0, Skipped: 0 ... ... ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.mapred.TestMROpportunisticMaps Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 115.501 sec - in org.apache.hadoop.mapred.TestMROpportunisticMaps Results : Tests run: 3, Failures: 0, Errors: 0, Skipped: 0 .... ...
          Hide
          asuresh Arun Suresh added a comment -

          Committed addendum patch to trunk and branch-2

          Show
          asuresh Arun Suresh added a comment - Committed addendum patch to trunk and branch-2
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10800 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10800/)
          YARN-5833. Addendum patch to include missing changes to yarn-default.xml (arun suresh: rev 280357c29f867e3ef6386ea5bd0f7b7ca6fe04eb)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10800 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10800/ ) YARN-5833 . Addendum patch to include missing changes to yarn-default.xml (arun suresh: rev 280357c29f867e3ef6386ea5bd0f7b7ca6fe04eb) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          Hide
          kkaranasos Konstantinos Karanasos added a comment -

          Thanks Arun Suresh, indeed those tests were unfortunately not kicked off by Jenkins...

          Show
          kkaranasos Konstantinos Karanasos added a comment - Thanks Arun Suresh , indeed those tests were unfortunately not kicked off by Jenkins...

            People

            • Assignee:
              kkaranasos Konstantinos Karanasos
              Reporter:
              kkaranasos Konstantinos Karanasos
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development