[YARN-5802] updateApplicationPriority api in scheduler should ensure to re-insert app to correct ordering policy

• Type: Sub-task
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha2
• Component/s: capacity scheduler
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Bibin Chundatt
• Reporter: Bibin Chundatt
• Created: 29/Oct/16 20:17
• Updated: 06/Jan/17 07:59
• Resolved: 05/Nov/16 07:39

Description

LeafQueue#updateApplicationPriority

 getOrderingPolicy().removeSchedulableEntity(attempt);

      // Update new priority in SchedulerApplication
      attempt.setPriority(newAppPriority);

      getOrderingPolicy().addSchedulableEntity(attempt);

We should add again to ordering policy only when attempt available in first case.Else during application attempt removal will try to iterate on killed application still available in pending Ordering policy.Which can cause RM to crash.