Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5800

Delete LinuxContainerExecutor comment from yarn-default.xml

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: yarn
    • Labels:

      Description

      In yarn-default.xml there's an extraneous comment line in the yarn.nodemanager.container-executor.class property. Since admins shouldn't typically be modifying this file, this comment isn't useful.

      1. YARN-5800.001.patch
        0.7 kB
        Daniel Templeton

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user HorizonNet commented on the issue:

          https://github.com/apache/hadoop/pull/149

          This one was already applied to trunk via [this commit](https://github.com/apache/hadoop/commit/773c60bd7bd00651dc3016799b424b9bd2233eb3).

          Show
          githubbot ASF GitHub Bot added a comment - Github user HorizonNet commented on the issue: https://github.com/apache/hadoop/pull/149 This one was already applied to trunk via [this commit] ( https://github.com/apache/hadoop/commit/773c60bd7bd00651dc3016799b424b9bd2233eb3 ).
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user HorizonNet closed the pull request at:

          https://github.com/apache/hadoop/pull/149

          Show
          githubbot ASF GitHub Bot added a comment - Github user HorizonNet closed the pull request at: https://github.com/apache/hadoop/pull/149
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10736 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10736/)
          YARN-5800. Delete LinuxContainerExecutor comment from yarn-default.xml (templedf: rev 773c60bd7bd00651dc3016799b424b9bd2233eb3)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10736 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10736/ ) YARN-5800 . Delete LinuxContainerExecutor comment from yarn-default.xml (templedf: rev 773c60bd7bd00651dc3016799b424b9bd2233eb3) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          Hide
          Jan Hentschel Jan Hentschel added a comment -

          Daniel Templeton Thanks. Should I close the pull request?

          Show
          Jan Hentschel Jan Hentschel added a comment - Daniel Templeton Thanks. Should I close the pull request?
          Hide
          templedf Daniel Templeton added a comment -

          Thanks for the patch, Jan Hentschel! Committed to trunk. (I committed from the patch I posted instead of closing the pull request because it was there and a known process.)

          Show
          templedf Daniel Templeton added a comment - Thanks for the patch, Jan Hentschel ! Committed to trunk. (I committed from the patch I posted instead of closing the pull request because it was there and a known process.)
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          -1 mvninstall 4m 48s root in trunk failed.
          +1 compile 0m 28s trunk passed
          +1 mvnsite 0m 35s trunk passed
          +1 mvneclipse 0m 11s trunk passed
          +1 javadoc 0m 30s trunk passed
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 28s the patch passed
          +1 javac 0m 28s the patch passed
          +1 mvnsite 0m 34s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 javadoc 0m 29s the patch passed
          -1 unit 1m 54s hadoop-yarn-common in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          12m 0s



          Reason Tests
          Failed junit tests hadoop.yarn.util.TestFSDownload



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue YARN-5800
          GITHUB PR https://github.com/apache/hadoop/pull/149
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 6096e3596e6f 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2528bea
          Default Java 1.8.0_101
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/13703/artifact/patchprocess/branch-mvninstall-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/13703/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13703/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13703/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 mvninstall 4m 48s root in trunk failed. +1 compile 0m 28s trunk passed +1 mvnsite 0m 35s trunk passed +1 mvneclipse 0m 11s trunk passed +1 javadoc 0m 30s trunk passed +1 mvninstall 0m 32s the patch passed +1 compile 0m 28s the patch passed +1 javac 0m 28s the patch passed +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 29s the patch passed -1 unit 1m 54s hadoop-yarn-common in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 12m 0s Reason Tests Failed junit tests hadoop.yarn.util.TestFSDownload Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-5800 GITHUB PR https://github.com/apache/hadoop/pull/149 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 6096e3596e6f 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2528bea Default Java 1.8.0_101 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/13703/artifact/patchprocess/branch-mvninstall-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13703/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13703/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/13703/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          varun_saxena Varun Saxena added a comment -

          Actually I was under the impression that PR will be automatically picked up by Jenkins.
          Not sure why build wasn't invoked. Maybe I am mistaken.

          Show
          varun_saxena Varun Saxena added a comment - Actually I was under the impression that PR will be automatically picked up by Jenkins. Not sure why build wasn't invoked. Maybe I am mistaken.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 22s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 8s trunk passed
          +1 compile 0m 27s trunk passed
          +1 mvnsite 0m 30s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 javadoc 0m 27s trunk passed
          +1 mvninstall 0m 25s the patch passed
          +1 compile 0m 24s the patch passed
          +1 javac 0m 24s the patch passed
          +1 mvnsite 0m 26s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 javadoc 0m 25s the patch passed
          +1 unit 2m 15s hadoop-yarn-common in the patch passed.
          +1 asflicense 0m 15s The patch does not generate ASF License warnings.
          14m 9s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue YARN-5800
          GITHUB PR https://github.com/apache/hadoop/pull/149
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux ec0d39dd5f21 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a9d68d2
          Default Java 1.8.0_101
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13702/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13702/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 8s trunk passed +1 compile 0m 27s trunk passed +1 mvnsite 0m 30s trunk passed +1 mvneclipse 0m 13s trunk passed +1 javadoc 0m 27s trunk passed +1 mvninstall 0m 25s the patch passed +1 compile 0m 24s the patch passed +1 javac 0m 24s the patch passed +1 mvnsite 0m 26s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 javadoc 0m 25s the patch passed +1 unit 2m 15s hadoop-yarn-common in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 14m 9s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-5800 GITHUB PR https://github.com/apache/hadoop/pull/149 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux ec0d39dd5f21 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a9d68d2 Default Java 1.8.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13702/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/13702/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          I think you forgot to attach the patch Varun Saxena.

          Show
          templedf Daniel Templeton added a comment - I think you forgot to attach the patch Varun Saxena .
          Hide
          varun_saxena Varun Saxena added a comment -

          Jan Hentschel, pull request should be fine. What Naga meant was that we did not invoke Jenkins for this by submitting patch.
          But looking at the changes, its probably not even required.

          I have anyways submitted the patch though.

          Show
          varun_saxena Varun Saxena added a comment - Jan Hentschel , pull request should be fine. What Naga meant was that we did not invoke Jenkins for this by submitting patch. But looking at the changes, its probably not even required. I have anyways submitted the patch though.
          Hide
          Jan Hentschel Jan Hentschel added a comment -

          I opened the pull request. Wasn't sure about the whole process. If you like I can also attach a patch to this issue.

          Show
          Jan Hentschel Jan Hentschel added a comment - I opened the pull request. Wasn't sure about the whole process. If you like I can also attach a patch to this issue.
          Hide
          templedf Daniel Templeton added a comment -

          The PR is a little confusing for such a small patch, but I don't have an issue with it. The patch is from Jan Hentschel as https://github.com/HorizonNet.

          Show
          templedf Daniel Templeton added a comment - The PR is a little confusing for such a small patch, but I don't have an issue with it. The patch is from Jan Hentschel as https://github.com/HorizonNet .
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Patch looks fine but who submitted it and why not submit the patch ?

          Show
          Naganarasimha Naganarasimha G R added a comment - Patch looks fine but who submitted it and why not submit the patch ?
          Hide
          templedf Daniel Templeton added a comment -

          LGTM +1 I'll commit on Monday if no one objects.

          Show
          templedf Daniel Templeton added a comment - LGTM +1 I'll commit on Monday if no one objects.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user HorizonNet opened a pull request:

          https://github.com/apache/hadoop/pull/149

          YARN-5800: Deleted LinuxContainerExecutor comment from yarn-default.xml

          https://issues.apache.org/jira/browse/YARN-5800

          • Removed the comment about LinuxContainerExecutor from the yarn-default.xml file

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/ultratendency/hadoop YARN-5800

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/hadoop/pull/149.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #149


          commit a329d9d674d8bfacd60bb17474ca37de8111541a
          Author: Jan Hentschel <jan.hentschel@ultratendency.com>
          Date: 2016-10-30T08:07:28Z

          YARN-5800: Deleted LinuxContainerExecutor comment from yarn-default.xml

          • Removed the comment about LinuxContainerExecutor from the
            yarn-default.xml file

          Show
          githubbot ASF GitHub Bot added a comment - GitHub user HorizonNet opened a pull request: https://github.com/apache/hadoop/pull/149 YARN-5800 : Deleted LinuxContainerExecutor comment from yarn-default.xml https://issues.apache.org/jira/browse/YARN-5800 Removed the comment about LinuxContainerExecutor from the yarn-default.xml file You can merge this pull request into a Git repository by running: $ git pull https://github.com/ultratendency/hadoop YARN-5800 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/149.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #149 commit a329d9d674d8bfacd60bb17474ca37de8111541a Author: Jan Hentschel <jan.hentschel@ultratendency.com> Date: 2016-10-30T08:07:28Z YARN-5800 : Deleted LinuxContainerExecutor comment from yarn-default.xml Removed the comment about LinuxContainerExecutor from the yarn-default.xml file

            People

            • Assignee:
              Jan Hentschel Jan Hentschel
              Reporter:
              templedf Daniel Templeton
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development