Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5777

TestLogsCLI#testFetchApplictionLogsAsAnotherUser fails

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: test
    • Labels:
      None

      Description

      Running org.apache.hadoop.yarn.client.cli.TestLogsCLI
      Tests run: 14, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 5.876 sec <<< FAILURE! - in org.apache.hadoop.yarn.client.cli.TestLogsCLI
      testFetchApplictionLogsAsAnotherUser(org.apache.hadoop.yarn.client.cli.TestLogsCLI)  Time elapsed: 0.199 sec  <<< ERROR!
      java.io.IOException: Invalid directory or I/O error occurred for dir: /Users/aajisaka/git/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/target/logs/priority/logs/application_1477371285256_1000
              at org.apache.hadoop.fs.FileUtil.list(FileUtil.java:1148)
              at org.apache.hadoop.fs.RawLocalFileSystem.listStatus(RawLocalFileSystem.java:469)
              at org.apache.hadoop.fs.DelegateToFileSystem.listStatus(DelegateToFileSystem.java:169)
              at org.apache.hadoop.fs.ChecksumFs.listStatus(ChecksumFs.java:519)
              at org.apache.hadoop.fs.AbstractFileSystem$1.<init>(AbstractFileSystem.java:890)
              at org.apache.hadoop.fs.AbstractFileSystem.listStatusIterator(AbstractFileSystem.java:888)
              at org.apache.hadoop.fs.FileContext$22.next(FileContext.java:1492)
              at org.apache.hadoop.fs.FileContext$22.next(FileContext.java:1487)
              at org.apache.hadoop.fs.FSLinkResolver.resolve(FSLinkResolver.java:90)
              at org.apache.hadoop.fs.FileContext.listStatus(FileContext.java:1494)
              at org.apache.hadoop.yarn.logaggregation.LogCLIHelpers.getRemoteNodeFileDir(LogCLIHelpers.java:592)
              at org.apache.hadoop.yarn.logaggregation.LogCLIHelpers.dumpAllContainersLogs(LogCLIHelpers.java:348)
              at org.apache.hadoop.yarn.client.cli.LogsCLI.fetchApplicationLogs(LogsCLI.java:971)
              at org.apache.hadoop.yarn.client.cli.LogsCLI.runCommand(LogsCLI.java:299)
              at org.apache.hadoop.yarn.client.cli.LogsCLI.run(LogsCLI.java:106)
              at org.apache.hadoop.yarn.client.cli.TestLogsCLI.testFetchApplictionLogsAsAnotherUser(TestLogsCLI.java:868)
      

        Issue Links

          Activity

          Hide
          ajisakaa Akira Ajisaka added a comment -

          I ran git bisect and found HADOOP-7352 broke this.

          Show
          ajisakaa Akira Ajisaka added a comment - I ran git bisect and found HADOOP-7352 broke this.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          The test fails because RawLocalFileSystem.listStatus throws IOException after HADOOP-7302.
          I wrote a patch to catch IOE and log error message in LogCLIHelpers#getRemoteNodeFileDir. Before this patch, the method catches FileNotFoundException, AccessControlException, and AccessDeniedException, so I'm thinking it's okay to catch IOE as well.

          Show
          ajisakaa Akira Ajisaka added a comment - The test fails because RawLocalFileSystem.listStatus throws IOException after HADOOP-7302 . I wrote a patch to catch IOE and log error message in LogCLIHelpers#getRemoteNodeFileDir. Before this patch, the method catches FileNotFoundException, AccessControlException, and AccessDeniedException, so I'm thinking it's okay to catch IOE as well.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 43s trunk passed
          +1 compile 0m 26s trunk passed
          +1 checkstyle 0m 19s trunk passed
          +1 mvnsite 0m 29s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 54s trunk passed
          +1 javadoc 0m 28s trunk passed
          +1 mvninstall 0m 24s the patch passed
          +1 compile 0m 24s the patch passed
          +1 javac 0m 24s the patch passed
          +1 checkstyle 0m 15s the patch passed
          +1 mvnsite 0m 27s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 0s the patch passed
          +1 javadoc 0m 24s the patch passed
          +1 unit 2m 35s hadoop-yarn-common in the patch passed.
          +1 asflicense 0m 15s The patch does not generate ASF License warnings.
          16m 20s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835072/YARN-5777.01.patch
          JIRA Issue YARN-5777
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux bf2fe1b69240 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / dbd2057
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13496/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13496/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 43s trunk passed +1 compile 0m 26s trunk passed +1 checkstyle 0m 19s trunk passed +1 mvnsite 0m 29s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 54s trunk passed +1 javadoc 0m 28s trunk passed +1 mvninstall 0m 24s the patch passed +1 compile 0m 24s the patch passed +1 javac 0m 24s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 27s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 0s the patch passed +1 javadoc 0m 24s the patch passed +1 unit 2m 35s hadoop-yarn-common in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 16m 20s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835072/YARN-5777.01.patch JIRA Issue YARN-5777 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bf2fe1b69240 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dbd2057 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13496/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/13496/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jzhuge John Zhuge added a comment -

          +1 (non-binding) The change looks good to me. Thanks Akira Ajisaka for investigation and fix.

          Show
          jzhuge John Zhuge added a comment - +1 (non-binding) The change looks good to me. Thanks Akira Ajisaka for investigation and fix.
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks Akira Ajisaka for the catch. The analysis make sense, +1. Committing this.

          Show
          xiaochen Xiao Chen added a comment - Thanks Akira Ajisaka for the catch. The analysis make sense, +1. Committing this.
          Hide
          xiaochen Xiao Chen added a comment -

          Committed this to trunk. Thanks Akira Ajisaka for the contribution and John Zhuge for the review.

          Show
          xiaochen Xiao Chen added a comment - Committed this to trunk. Thanks Akira Ajisaka for the contribution and John Zhuge for the review.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10676 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10676/)
          YARN-5777. TestLogsCLI#testFetchApplictionLogsAsAnotherUser fails. (xiao: rev c88c1dc50c0ec4521bc93f39726248026e68063a)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/LogCLIHelpers.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10676 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10676/ ) YARN-5777 . TestLogsCLI#testFetchApplictionLogsAsAnotherUser fails. (xiao: rev c88c1dc50c0ec4521bc93f39726248026e68063a) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/LogCLIHelpers.java

            People

            • Assignee:
              ajisakaa Akira Ajisaka
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development