Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5747

Application timeline metric aggregation in timeline v2 will lose last round aggregation when an application finishes

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: timelineserver
    • Labels:
      None

      Description

      As discussed in YARN-3816, when an application finishes we should perform an extra round of application level timeline aggregation. Otherwise data posted after the last round of aggregation will get lost.

        Issue Links

          Activity

          Hide
          gtCarrera9 Li Lu added a comment -

          Upload a patch to quickly fix the issue.

          Show
          gtCarrera9 Li Lu added a comment - Upload a patch to quickly fix the issue.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 41s trunk passed
          +1 compile 0m 18s trunk passed
          +1 checkstyle 0m 13s trunk passed
          +1 mvnsite 0m 22s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 28s trunk passed
          +1 javadoc 0m 15s trunk passed
          +1 mvninstall 0m 16s the patch passed
          +1 compile 0m 16s the patch passed
          +1 javac 0m 16s the patch passed
          +1 checkstyle 0m 10s the patch passed
          +1 mvnsite 0m 19s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 34s the patch passed
          +1 javadoc 0m 12s the patch passed
          +1 unit 0m 43s hadoop-yarn-server-timelineservice in the patch passed.
          +1 asflicense 0m 15s The patch does not generate ASF License warnings.
          12m 21s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834050/YARN-5747-trunk.001.patch
          JIRA Issue YARN-5747
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 723e345b2bc5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c62ae71
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13433/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13433/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 41s trunk passed +1 compile 0m 18s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 22s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 28s trunk passed +1 javadoc 0m 15s trunk passed +1 mvninstall 0m 16s the patch passed +1 compile 0m 16s the patch passed +1 javac 0m 16s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 34s the patch passed +1 javadoc 0m 12s the patch passed +1 unit 0m 43s hadoop-yarn-server-timelineservice in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 12m 21s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834050/YARN-5747-trunk.001.patch JIRA Issue YARN-5747 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 723e345b2bc5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c62ae71 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13433/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice Console output https://builds.apache.org/job/PreCommit-YARN-Build/13433/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          varun_saxena Varun Saxena added a comment -

          Thanks Li Lu for the patch. Changes LGTM.
          Probably the only thing missing is the test case. But I can see the difficulty in adding a test case here because of scheduled thread pool executor and anyways change is very small.

          I will commit it later today unless there are further comments.

          Show
          varun_saxena Varun Saxena added a comment - Thanks Li Lu for the patch. Changes LGTM. Probably the only thing missing is the test case. But I can see the difficulty in adding a test case here because of scheduled thread pool executor and anyways change is very small. I will commit it later today unless there are further comments.
          Hide
          vrushalic Vrushali C added a comment -

          LGTM too.

          Show
          vrushalic Vrushali C added a comment - LGTM too.
          Hide
          sjlee0 Sangjin Lee added a comment -

          +1.

          Show
          sjlee0 Sangjin Lee added a comment - +1.
          Hide
          varun_saxena Varun Saxena added a comment -

          Committed to trunk, YARN-5355 and YARN-5355-branch-2.
          Thanks Li Lu for your contribution and Vrushali C and Sangjin Lee for reviews.

          Show
          varun_saxena Varun Saxena added a comment - Committed to trunk, YARN-5355 and YARN-5355 -branch-2. Thanks Li Lu for your contribution and Vrushali C and Sangjin Lee for reviews.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10654 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10654/)
          YARN-5747. Application timeline metric aggregation in timeline v2 will (varunsaxena: rev 44eb2bd7ae39cca77fc8c7ad493b52ea1bb43530)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/collector/AppLevelTimelineCollector.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10654 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10654/ ) YARN-5747 . Application timeline metric aggregation in timeline v2 will (varunsaxena: rev 44eb2bd7ae39cca77fc8c7ad493b52ea1bb43530) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/collector/AppLevelTimelineCollector.java

            People

            • Assignee:
              gtCarrera9 Li Lu
              Reporter:
              gtCarrera9 Li Lu
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development