[YARN-5736] YARN container executor config does not handle white space

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha2
• Component/s: nodemanager
• Labels: oct16-medium
• Hadoop Flags: Reviewed
• Assignee: Miklos Szegedi
• Reporter: Miklos Szegedi
• Created: 14/Oct/16 00:47
• Updated: 10/Aug/17 18:47
• Resolved: 15/Nov/16 21:04

Description

The container executor configuration reader does not handle white spaces or malformed key value pairs in the config file correctly or gracefully
as an example the following key value line which is part of the configuration (note the << is used as a marker to show the extra trailing space):
yarn.nodemanager.linux-container-executor.group=yarn <<
is a valid line but when you run the check over the file:
[root@test]#./container-executor --checksetup
Can't get group information for yarn - Success.
[root@test]#
It fails to find the yarn group but it really tries to find the "yarn " group which fails. There is no trimming anywhere while processing the lines. If a space would be added in before or after the = sign a failure would also occur.
Minor nit is the fact that a failure still is logged as a Success