Details
-
Type:
Task
-
Status: Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 3.0.0-alpha2
-
Component/s: nodemanager
-
Labels:None
-
Target Version/s:
Description
The container-executor build should declare the C standard it uses.
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Allen Wittenauer would you mind taking a look?
I'll try to run this through a few different OSes when I get a chance. Offhand it looks fine, but want to make sure FreeBSD and Illumos work.
Does someone have cycles to take a look at this? Varun Vasudev, Allen Wittenauer, Sidharta Seethana?
+1 from my end. I tried it on Mac and Linux and it worked fine. Allen Wittenauer - can I go ahead and commit this?
 -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 15s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| +1 | mvninstall | 8m 20s | trunk passed |
| +1 | compile | 0m 30s | trunk passed |
| +1 | mvnsite | 0m 30s | trunk passed |
| +1 | mvneclipse | 0m 14s | trunk passed |
| +1 | mvninstall | 0m 25s | the patch passed |
| +1 | compile | 0m 27s | the patch passed |
| +1 | cc | 0m 27s | the patch passed |
| +1 | javac | 0m 27s | the patch passed |
| +1 | mvnsite | 0m 27s | the patch passed |
| +1 | mvneclipse | 0m 11s | the patch passed |
| +1 | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 | unit | 13m 17s | hadoop-yarn-server-nodemanager in the patch passed. |
| +1 | asflicense | 0m 18s | The patch does not generate ASF License warnings. |
| 25m 14s |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12832559/YARN-5719.000.patch |
| Optional Tests | asflicense compile cc mvnsite javac unit |
| uname | Linux ab7e8bb43e96 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / f66f618 |
| Default Java | 1.8.0_111 |
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/14260/testReport/ |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/14260/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
I'll commit this tomorrow if no one objects.
Committed to trunk. Let me know if you want this to go into branch-2 as well. Thanks for the patch Chris Douglas!
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11049 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11049/)
YARN-5719. Enforce a C standard for native container-executor. (vvasudev: rev 972da46cb48725ad49d3e0a033742bd1a8228f51)
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/CMakeLists.txt
There's a convenient option in recent versions of cmake to set the C standard in a portable way, but this is unavailable in the minimum version of cmake we require (2.6). v000 uses a set of switches based on a subset of compiler ids we're likely
to support. The options themselves I pulled from cursory searches; I haven't tested with anything but gcc 4.8.4.
The LCE doesn't compile with ANSI C (-std=c89), but required almost no changes with C99. The only change with -pedantic-errors required some minor tweaks to get_user_info.