Details
-
Type:
Task
-
Status: Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.8.0, 3.0.0-alpha1, 3.0.0-alpha2
-
Fix Version/s: 2.9.0, 3.0.0-alpha2
-
Component/s: yarn
-
Labels:None
-
Hadoop Flags:Reviewed
Description
YARN-5704 added functionality to disable certain features in container-executor. Most of the changes cannot be tested via container-executor - however, is_feature_enabled can be tested if it were made public. (It is currently static).
Issue Links
- blocks
-
YARN-5704
Provide config knobs to control enabling/disabling new/work in progress features in container-executor
-
- Resolved
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
 -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 17s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
| +1 | mvninstall | 7m 20s | trunk passed |
| +1 | compile | 0m 33s | trunk passed |
| +1 | mvnsite | 0m 29s | trunk passed |
| +1 | mvneclipse | 0m 13s | trunk passed |
| +1 | mvninstall | 0m 25s | the patch passed |
| +1 | compile | 0m 26s | the patch passed |
| -1 | cc | 0m 26s | hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 31 new + 1 unchanged - 0 fixed = 32 total (was 1) |
| +1 | javac | 0m 26s | the patch passed |
| +1 | mvnsite | 0m 25s | the patch passed |
| +1 | mvneclipse | 0m 11s | the patch passed |
| +1 | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 | unit | 15m 1s | hadoop-yarn-server-nodemanager in the patch passed. |
| +1 | asflicense | 0m 15s | The patch does not generate ASF License warnings. |
| 25m 49s |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12832795/YARN-5717.001.patch |
| JIRA Issue | |
| Optional Tests | asflicense compile cc mvnsite javac unit |
| uname | Linux 359c0e622595 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 3c9a010 |
| Default Java | 1.8.0_101 |
| cc | https://builds.apache.org/job/PreCommit-YARN-Build/13352/artifact/patchprocess/diff-compile-cc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt |
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/13352/testReport/ |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/13352/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
Uploaded a new patch to fix compiler warnings.
 +1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 18s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
| +1 | mvninstall | 7m 2s | trunk passed |
| +1 | compile | 0m 28s | trunk passed |
| +1 | mvnsite | 0m 28s | trunk passed |
| +1 | mvneclipse | 0m 13s | trunk passed |
| +1 | mvninstall | 0m 23s | the patch passed |
| +1 | compile | 0m 25s | the patch passed |
| +1 | cc | 0m 25s | the patch passed |
| +1 | javac | 0m 25s | the patch passed |
| +1 | mvnsite | 0m 26s | the patch passed |
| +1 | mvneclipse | 0m 11s | the patch passed |
| +1 | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 | unit | 14m 51s | hadoop-yarn-server-nodemanager in the patch passed. |
| +1 | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
| 25m 17s |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12832803/YARN-5717.002.patch |
| JIRA Issue | |
| Optional Tests | asflicense compile cc mvnsite javac unit |
| uname | Linux f506f2ab96e5 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / b84c489 |
| Default Java | 1.8.0_101 |
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/13353/testReport/ |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/13353/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
Allen Wittenauer, Chris Douglas : could you please review this patch?
thanks,
-Sidharta
+1 I committed this. Thanks, Sid
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10608 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10608/)
YARN-5717. Add tests for container-executor is_feature_enabled. (cdouglas: rev cf3f43e95bf46030875137fc36da5c1fbe14250d)
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.h
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c
Thanks, Chris Douglas.
Attaching a patch with tests for is_feature_enabled and changes to display_usage to use fprintf directly.