ByteArrayOutputStream resource will not be freed in case of errors in write method
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10486 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10486/)
YARN-5663. Small refactor in ZKRMStateStore. Contributed by Oleksii (aajisaka: rev 14a696f369f7e3802587f57c8fff3aa51b5ab576)
Committed this to trunk, branch-2, and branch-2.8. Thanks Oleksii Dymytrov for the contribution and thanks Daniel Templeton for the review.
This message was automatically generated.
+1 pending Jenkins.
Akira Ajisaka or Ray Chiang, wanna take a look?
As soon as I get you added to the contributors list, I'll reassign the issue to you.
Thanks for the update, Oleksii Dymytrov. +1 (non-binding)
Hi, Daniel Templeton.
Please, review my new patch YARN_5663_v1_002_patch.
I don't think that's actually a leak, but I don't mind the refactor to make it simpler. Please remove the semicolon from the try line. Also, the indentation on line 864 was correct before you modified it. Please put it back where it was. I always like to see unit tests, especially with refactoring, but this one's fundamental enough that it's probably OK to let it slide.