Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: resourcemanager
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      ByteArrayOutputStream resource will not be freed in case of errors in write method

      1. YARN_5663_v1_001_patch.patch
        2 kB
        Oleksii Dymytrov
      2. YARN_5663_v1_002_patch.patch
        1 kB
        Oleksii Dymytrov

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10486 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10486/)
        YARN-5663. Small refactor in ZKRMStateStore. Contributed by Oleksii (aajisaka: rev 14a696f369f7e3802587f57c8fff3aa51b5ab576)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10486 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10486/ ) YARN-5663 . Small refactor in ZKRMStateStore. Contributed by Oleksii (aajisaka: rev 14a696f369f7e3802587f57c8fff3aa51b5ab576) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk, branch-2, and branch-2.8. Thanks Oleksii Dymytrov for the contribution and thanks Daniel Templeton for the review.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks Oleksii Dymytrov for the contribution and thanks Daniel Templeton for the review.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 12s trunk passed
        +1 compile 0m 33s trunk passed
        +1 checkstyle 0m 19s trunk passed
        +1 mvnsite 0m 38s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        +1 findbugs 0m 57s trunk passed
        +1 javadoc 0m 22s trunk passed
        +1 mvninstall 0m 30s the patch passed
        +1 compile 0m 32s the patch passed
        +1 javac 0m 32s the patch passed
        +1 checkstyle 0m 17s the patch passed
        +1 mvnsite 0m 36s the patch passed
        +1 mvneclipse 0m 16s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 17s the patch passed
        +1 javadoc 0m 19s the patch passed
        +1 unit 34m 1s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        49m 16s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830067/YARN_5663_v1_002_patch.patch
        JIRA Issue YARN-5663
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 12da0da83d0c 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5707f88
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13208/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13208/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 12s trunk passed +1 compile 0m 33s trunk passed +1 checkstyle 0m 19s trunk passed +1 mvnsite 0m 38s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 0m 57s trunk passed +1 javadoc 0m 22s trunk passed +1 mvninstall 0m 30s the patch passed +1 compile 0m 32s the patch passed +1 javac 0m 32s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 0m 36s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 17s the patch passed +1 javadoc 0m 19s the patch passed +1 unit 34m 1s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 49m 16s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830067/YARN_5663_v1_002_patch.patch JIRA Issue YARN-5663 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 12da0da83d0c 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5707f88 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13208/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13208/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1 pending Jenkins.

        Show
        ajisakaa Akira Ajisaka added a comment - +1 pending Jenkins.
        Hide
        templedf Daniel Templeton added a comment -

        Akira Ajisaka or Ray Chiang, wanna take a look?

        Show
        templedf Daniel Templeton added a comment - Akira Ajisaka or Ray Chiang , wanna take a look?
        Hide
        templedf Daniel Templeton added a comment -

        As soon as I get you added to the contributors list, I'll reassign the issue to you.

        Show
        templedf Daniel Templeton added a comment - As soon as I get you added to the contributors list, I'll reassign the issue to you.
        Hide
        templedf Daniel Templeton added a comment -

        Thanks for the update, Oleksii Dymytrov. +1 (non-binding)

        Show
        templedf Daniel Templeton added a comment - Thanks for the update, Oleksii Dymytrov . +1 (non-binding)
        Hide
        ameks94 Oleksii Dymytrov added a comment -

        Hi, Daniel Templeton.
        Please, review my new patch YARN_5663_v1_002_patch.

        Show
        ameks94 Oleksii Dymytrov added a comment - Hi, Daniel Templeton . Please, review my new patch YARN_5663_v1_002_patch .
        Hide
        templedf Daniel Templeton added a comment -

        I don't think that's actually a leak, but I don't mind the refactor to make it simpler. Please remove the semicolon from the try line. Also, the indentation on line 864 was correct before you modified it. Please put it back where it was. I always like to see unit tests, especially with refactoring, but this one's fundamental enough that it's probably OK to let it slide.

        Show
        templedf Daniel Templeton added a comment - I don't think that's actually a leak, but I don't mind the refactor to make it simpler. Please remove the semicolon from the try line. Also, the indentation on line 864 was correct before you modified it. Please put it back where it was. I always like to see unit tests, especially with refactoring, but this one's fundamental enough that it's probably OK to let it slide.

          People

          • Assignee:
            ameks94 Oleksii Dymytrov
            Reporter:
            ameks94 Oleksii Dymytrov
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development