This is to track timeout rendering in old and new yarn web UI
Add Application timeouts in Application report and CLI
Could you also please attach screen shots. 1) app which will be timedout after few seconds 2) app which is timedout.
This message was automatically generated.
screen shots looks good for me.
one comment in general. Could we move the template code as a component so that we may be able to reuse this module later?. Thank you.
Rohith Sharma K S
As per jira title, this is for new and old ui. But the UX look will differ for both. We could add old ui change here too, thoughts.?
I think we should not show the application timeout bar if application is finished/failed/killed. Let the progress bar appear only when application is running. Thoughts?
we can show remaining timeout only when remaining time is more than 0. In all other cases, the timeout bar need not to be shown. So screenshot-1 will only be handled. Akhil PB could you please upload a patch by handling only case which is remainingTime > 0
Latest patch is uploaded which handles only the scenario you mentioned, which is remainingTimeInSecs > 0
javadoc issue reported on AppBlock is known and its done as per hamlet framework. Test not needed as its UI.
Patch generally looks fine for me. I will wait for comments from Rohith Sharma K S if any.
+1 from end. I will commit later today if there are no objections.
Thanks Akhil PB.
I have committed patch to trunk.
For branch-2, UI2 changes are not needed. Could you please give me a patch without UI2 changes so that i commit to branch-2.
Rohith Sharma K S, is that fine?
Hi Sunil G, Rohith Sharma K S
I have uploaded a patch for branch-2 which contains changes for old UI only.
Test case failures are unrelated and already tracked via another jira.
This is a UI fix, hence test cases are not needed.
AppBlock related javadoc errors are for the whole file. This patch follows the same syntax.
cc Sunil G
Committing to branch-2.
Thanks Akhil PB for the contribution and thanks Rohith Sharma K S for additional review. committed to trunk and branch-2