Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: scheduler
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This is to track timeout rendering in old and new yarn web UI

      1. YARN-5650-branch-2.001.patch
        3 kB
        Akhil PB
      2. YARN-5650.005.patch
        14 kB
        Akhil PB
      3. YARN-5650.004.patch
        11 kB
        Akhil PB
      4. YARN-5650.003.patch
        11 kB
        Akhil PB
      5. screenshot-2.png
        97 kB
        Akhil PB
      6. screenshot-1.png
        86 kB
        Akhil PB
      7. YARN-5650.002.patch
        7 kB
        Akhil PB
      8. YARN-5650.001.patch
        11 kB
        Akhil PB

        Issue Links

          Activity

          Hide
          sunilg Sunil G added a comment -

          Thanks Akhil PB for the contribution and thanks Rohith Sharma K S for additional review. committed to trunk and branch-2

          Show
          sunilg Sunil G added a comment - Thanks Akhil PB for the contribution and thanks Rohith Sharma K S for additional review. committed to trunk and branch-2
          Hide
          sunilg Sunil G added a comment -

          Thanks. +1
          Committing to branch-2.

          Show
          sunilg Sunil G added a comment - Thanks. +1 Committing to branch-2.
          Hide
          akhilpb Akhil PB added a comment -

          Test case failures are unrelated and already tracked via another jira.
          This is a UI fix, hence test cases are not needed.
          AppBlock related javadoc errors are for the whole file. This patch follows the same syntax.

          cc Sunil G

          Show
          akhilpb Akhil PB added a comment - Test case failures are unrelated and already tracked via another jira. This is a UI fix, hence test cases are not needed. AppBlock related javadoc errors are for the whole file. This patch follows the same syntax. cc Sunil G
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 20s Maven dependency ordering for branch
          +1 mvninstall 6m 26s branch-2 passed
          +1 compile 1m 10s branch-2 passed with JDK v1.8.0_111
          +1 compile 1m 24s branch-2 passed with JDK v1.7.0_121
          +1 checkstyle 0m 33s branch-2 passed
          +1 mvnsite 1m 3s branch-2 passed
          +1 mvneclipse 0m 30s branch-2 passed
          +1 findbugs 1m 54s branch-2 passed
          +1 javadoc 0m 35s branch-2 passed with JDK v1.8.0_111
          +1 javadoc 0m 41s branch-2 passed with JDK v1.7.0_121
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 0m 51s the patch passed
          +1 compile 1m 5s the patch passed with JDK v1.8.0_111
          +1 javac 1m 5s the patch passed
          +1 compile 1m 23s the patch passed with JDK v1.7.0_121
          +1 javac 1m 23s the patch passed
          -0 checkstyle 0m 29s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 1 new + 80 unchanged - 1 fixed = 81 total (was 81)
          +1 mvnsite 0m 59s the patch passed
          +1 mvneclipse 0m 27s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 18s the patch passed
          -1 javadoc 0m 14s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdk1.8.0_111 with JDK v1.8.0_111 generated 2 new + 159 unchanged - 0 fixed = 161 total (was 159)
          +1 javadoc 0m 38s the patch passed with JDK v1.7.0_121
          +1 unit 0m 27s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_121.
          -1 unit 38m 49s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          106m 34s



          Reason Tests
          JDK v1.8.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
          JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue YARN-5650
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843811/YARN-5650-branch-2.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 09b58f6e71f4 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 0cb99db
          Default Java 1.7.0_121
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14363/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14363/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdk1.8.0_111.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/14363/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt
          JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14363/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14363/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 20s Maven dependency ordering for branch +1 mvninstall 6m 26s branch-2 passed +1 compile 1m 10s branch-2 passed with JDK v1.8.0_111 +1 compile 1m 24s branch-2 passed with JDK v1.7.0_121 +1 checkstyle 0m 33s branch-2 passed +1 mvnsite 1m 3s branch-2 passed +1 mvneclipse 0m 30s branch-2 passed +1 findbugs 1m 54s branch-2 passed +1 javadoc 0m 35s branch-2 passed with JDK v1.8.0_111 +1 javadoc 0m 41s branch-2 passed with JDK v1.7.0_121 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 0m 51s the patch passed +1 compile 1m 5s the patch passed with JDK v1.8.0_111 +1 javac 1m 5s the patch passed +1 compile 1m 23s the patch passed with JDK v1.7.0_121 +1 javac 1m 23s the patch passed -0 checkstyle 0m 29s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 1 new + 80 unchanged - 1 fixed = 81 total (was 81) +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 18s the patch passed -1 javadoc 0m 14s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdk1.8.0_111 with JDK v1.8.0_111 generated 2 new + 159 unchanged - 0 fixed = 161 total (was 159) +1 javadoc 0m 38s the patch passed with JDK v1.7.0_121 +1 unit 0m 27s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_121. -1 unit 38m 49s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 106m 34s Reason Tests JDK v1.8.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue YARN-5650 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843811/YARN-5650-branch-2.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 09b58f6e71f4 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 0cb99db Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14363/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14363/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdk1.8.0_111.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14363/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14363/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server Console output https://builds.apache.org/job/PreCommit-YARN-Build/14363/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          akhilpb Akhil PB added a comment -

          Hi Sunil G, Rohith Sharma K S
          I have uploaded a patch for branch-2 which contains changes for old UI only.

          Show
          akhilpb Akhil PB added a comment - Hi Sunil G , Rohith Sharma K S I have uploaded a patch for branch-2 which contains changes for old UI only.
          Hide
          sunilg Sunil G added a comment -

          Thanks Akhil PB.
          I have committed patch to trunk.

          For branch-2, UI2 changes are not needed. Could you please give me a patch without UI2 changes so that i commit to branch-2.
          Rohith Sharma K S, is that fine?

          Show
          sunilg Sunil G added a comment - Thanks Akhil PB . I have committed patch to trunk. For branch-2, UI2 changes are not needed. Could you please give me a patch without UI2 changes so that i commit to branch-2. Rohith Sharma K S , is that fine?
          Hide
          sunilg Sunil G added a comment -

          +1 from end. I will commit later today if there are no objections.

          Show
          sunilg Sunil G added a comment - +1 from end. I will commit later today if there are no objections.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          +1 LGTM

          Show
          rohithsharma Rohith Sharma K S added a comment - +1 LGTM
          Hide
          sunilg Sunil G added a comment -

          javadoc issue reported on AppBlock is known and its done as per hamlet framework. Test not needed as its UI.

          Patch generally looks fine for me. I will wait for comments from Rohith Sharma K S if any.

          Show
          sunilg Sunil G added a comment - javadoc issue reported on AppBlock is known and its done as per hamlet framework. Test not needed as its UI. Patch generally looks fine for me. I will wait for comments from Rohith Sharma K S if any.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 22s Maven dependency ordering for branch
          +1 mvninstall 7m 1s trunk passed
          +1 compile 4m 57s trunk passed
          +1 checkstyle 0m 44s trunk passed
          +1 mvnsite 1m 31s trunk passed
          +1 mvneclipse 0m 40s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
          +1 findbugs 1m 36s trunk passed
          +1 javadoc 0m 48s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 0m 58s the patch passed
          +1 compile 4m 41s the patch passed
          +1 javac 4m 41s the patch passed
          -0 checkstyle 0m 44s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 79 unchanged - 1 fixed = 80 total (was 80)
          +1 mvnsite 1m 27s the patch passed
          +1 mvneclipse 0m 38s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
          +1 findbugs 1m 50s the patch passed
          -1 javadoc 0m 16s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 2 new + 159 unchanged - 0 fixed = 161 total (was 159)
          +1 unit 0m 28s hadoop-yarn-server-common in the patch passed.
          +1 unit 42m 38s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 unit 2m 28s hadoop-yarn-ui in the patch passed.
          +1 asflicense 0m 30s The patch does not generate ASF License warnings.
          83m 2s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5650
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843402/YARN-5650.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3e334afc6d12 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 64a2d5b
          Default Java 1.8.0_111
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14329/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14329/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14329/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14329/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 22s Maven dependency ordering for branch +1 mvninstall 7m 1s trunk passed +1 compile 4m 57s trunk passed +1 checkstyle 0m 44s trunk passed +1 mvnsite 1m 31s trunk passed +1 mvneclipse 0m 40s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui +1 findbugs 1m 36s trunk passed +1 javadoc 0m 48s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 58s the patch passed +1 compile 4m 41s the patch passed +1 javac 4m 41s the patch passed -0 checkstyle 0m 44s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 79 unchanged - 1 fixed = 80 total (was 80) +1 mvnsite 1m 27s the patch passed +1 mvneclipse 0m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui +1 findbugs 1m 50s the patch passed -1 javadoc 0m 16s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 2 new + 159 unchanged - 0 fixed = 161 total (was 159) +1 unit 0m 28s hadoop-yarn-server-common in the patch passed. +1 unit 42m 38s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 2m 28s hadoop-yarn-ui in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 83m 2s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5650 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843402/YARN-5650.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3e334afc6d12 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 64a2d5b Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14329/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14329/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14329/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14329/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          0m 43s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5650
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843160/YARN-5650.004.patch
          Optional Tests asflicense
          uname Linux 846770fb6e6c 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ada876c
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14292/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 0m 43s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5650 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843160/YARN-5650.004.patch Optional Tests asflicense uname Linux 846770fb6e6c 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ada876c modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui Console output https://builds.apache.org/job/PreCommit-YARN-Build/14292/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          akhilpb Akhil PB added a comment - - edited

          Sunil G
          Latest patch is uploaded which handles only the scenario you mentioned, which is remainingTimeInSecs > 0

          Show
          akhilpb Akhil PB added a comment - - edited Sunil G Latest patch is uploaded which handles only the scenario you mentioned, which is remainingTimeInSecs > 0
          Hide
          sunilg Sunil G added a comment - - edited

          we can show remaining timeout only when remaining time is more than 0. In all other cases, the timeout bar need not to be shown. So screenshot-1 will only be handled. Akhil PB could you please upload a patch by handling only case which is remainingTime > 0

          Show
          sunilg Sunil G added a comment - - edited we can show remaining timeout only when remaining time is more than 0. In all other cases, the timeout bar need not to be shown. So screenshot-1 will only be handled. Akhil PB could you please upload a patch by handling only case which is remainingTime > 0
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          I think we should not show the application timeout bar if application is finished/failed/killed. Let the progress bar appear only when application is running. Thoughts?

          Show
          rohithsharma Rohith Sharma K S added a comment - I think we should not show the application timeout bar if application is finished/failed/killed. Let the progress bar appear only when application is running. Thoughts?
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 asflicense 0m 15s The patch does not generate ASF License warnings.
          0m 48s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5650
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842147/YARN-5650.003.patch
          Optional Tests asflicense
          uname Linux 6fc7c84a6b4f 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 563480d
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14207/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 0m 48s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5650 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842147/YARN-5650.003.patch Optional Tests asflicense uname Linux 6fc7c84a6b4f 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 563480d modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui Console output https://builds.apache.org/job/PreCommit-YARN-Build/14207/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          Rohith Sharma K S
          As per jira title, this is for new and old ui. But the UX look will differ for both. We could add old ui change here too, thoughts.?

          Show
          sunilg Sunil G added a comment - Rohith Sharma K S As per jira title, this is for new and old ui. But the UX look will differ for both. We could add old ui change here too, thoughts.?
          Hide
          sunilg Sunil G added a comment -

          screen shots looks good for me.

          one comment in general. Could we move the template code as a component so that we may be able to reuse this module later?. Thank you.

          Show
          sunilg Sunil G added a comment - screen shots looks good for me. one comment in general. Could we move the template code as a component so that we may be able to reuse this module later?. Thank you.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 33s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 asflicense 0m 15s The patch generated 2 ASF License warnings.
          1m 4s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5650
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842117/YARN-5650.001.patch
          Optional Tests asflicense
          uname Linux 6861d2b60e18 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 563480d
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/14204/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14204/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 33s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s The patch has no whitespace issues. -1 asflicense 0m 15s The patch generated 2 ASF License warnings. 1m 4s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5650 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842117/YARN-5650.001.patch Optional Tests asflicense uname Linux 6861d2b60e18 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 563480d asflicense https://builds.apache.org/job/PreCommit-YARN-Build/14204/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui Console output https://builds.apache.org/job/PreCommit-YARN-Build/14204/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          Akhil PB

          Could you also please attach screen shots. 1) app which will be timedout after few seconds 2) app which is timedout.

          Thanks

          Show
          sunilg Sunil G added a comment - Akhil PB Could you also please attach screen shots. 1) app which will be timedout after few seconds 2) app which is timedout. Thanks

            People

            • Assignee:
              akhilpb Akhil PB
              Reporter:
              rohithsharma Rohith Sharma K S
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development