Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      I am conducting research on log related bugs. I tried to make a tool to fix repetitive yet simple patterns of bugs that are related to logs. Typos in log messages are one of the reoccurring bugs. Therefore, I made a tool find typos in log statements. During my experiments, I managed to find the following typos in Hadoop YARN:

      In file /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/event/AsyncDispatcher.java, LOG.info("AsyncDispatcher is draining to stop igonring any new events."),
      igonring should be ignoring

      In file /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/YarnAuthorizationProvider.java, LOG.info(authorizerClass.getName() + " is instiantiated."),
      instiantiated should be instantiated

      In file /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/FileSystemApplicationHistoryStore.java, LOG.info("Completed reading history information of all conatiners"+ " of application attempt " + appAttemptId),
      conatiners should be containers

      In file /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java, LOG.info("Neither virutal-memory nor physical-memory monitoring is " +"needed. Not running the monitor-thread"),
      virutal should be virtual

      In file /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/AbstractReservationSystem.java, LOG.info("Intialized plan {} based on reservable queue {}" plan.toString() planQueueName),
      Intialized should be Initialized

      In file /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java, LOG.info("Initializing " + queueName + "\n" +"capacity = " + queueCapacities.getCapacity() +" [= (float) configuredCapacity / 100 ]" + "\n" +"asboluteCapacity = " + queueCapacities.getAbsoluteCapacity() +" [= parentAbsoluteCapacity * capacity ]" + "\n" +"maxCapacity = " + queueCapacities.getMaximumCapacity() +" [= configuredMaxCapacity ]" + "\n" +"absoluteMaxCapacity = " + queueCapacities.getAbsoluteMaximumCapacity() +" [= 1.0 maximumCapacity undefined " +"(parentAbsoluteMaxCapacity * maximumCapacity) / 100 otherwise ]" +"\n" +"userLimit = " + userLimit +" [= configuredUserLimit ]" + "\n" +"userLimitFactor = " + userLimitFactor +" [= configuredUserLimitFactor ]" + "\n" +"maxApplications = " + maxApplications +" [= configuredMaximumSystemApplicationsPerQueue or" +" (int)(configuredMaximumSystemApplications * absoluteCapacity)]" +"\n" +"maxApplicationsPerUser = " + maxApplicationsPerUser +" [= (int)(maxApplications * (userLimit / 100.0f) * " +"userLimitFactor) ]" + "\n" +"usedCapacity = " + queueCapacities.getUsedCapacity() +" [= usedResourcesMemory / " +"(clusterResourceMemory * absoluteCapacity)]" + "\n" +"absoluteUsedCapacity = " + absoluteUsedCapacity +" [= usedResourcesMemory / clusterResourceMemory]" + "\n" +"maxAMResourcePerQueuePercent = " + maxAMResourcePerQueuePercent +" [= configuredMaximumAMResourcePercent ]" + "\n" +"minimumAllocationFactor = " + minimumAllocationFactor +" [= (float)(maximumAllocationMemory - minimumAllocationMemory) / " +"maximumAllocationMemory ]" + "\n" +"maximumAllocation = " + maximumAllocation +" [= configuredMaxAllocation ]" + "\n" +"numContainers = " + numContainers +" [= currentNumContainers ]" + "\n" +"state = " + state +" [= configuredState ]" + "\n" +"acls = " + aclsString +" [= configuredAcls ]" + "\n" +"nodeLocalityDelay = " + nodeLocalityDelay + "\n" +"labels=" + labelStrBuilder.toString() + "\n" +"reservationsContinueLooking = " +reservationsContinueLooking + "\n" +"preemptionDisabled = " + getPreemptionDisabled() + "\n" +"defaultAppPriorityPerQueue = " + defaultAppPriorityPerQueue),
      asbolute should be absolute

      In file /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/ParentQueue.java, LOG.info(queueName +" capacity=" + this.queueCapacities.getCapacity() +" asboluteCapacity=" + this.queueCapacities.getAbsoluteCapacity() +" maxCapacity=" + this.queueCapacities.getMaximumCapacity() +" asboluteMaxCapacity=" + this.queueCapacities.getAbsoluteMaximumCapacity() +" state=" + state +" acls=" + aclsString +" labels=" + labelStrBuilder.toString() + "\n" +" reservationsContinueLooking=" + reservationsContinueLooking),
      asbolute should be absolute

      In file /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/ParentQueue.java, LOG.info(queueName +" capacity=" + this.queueCapacities.getCapacity() +" asboluteCapacity=" + this.queueCapacities.getAbsoluteCapacity() +" maxCapacity=" + this.queueCapacities.getMaximumCapacity() +" asboluteMaxCapacity=" + this.queueCapacities.getAbsoluteMaximumCapacity() +" state=" + state +" acls=" + aclsString +" labels=" + labelStrBuilder.toString() + "\n" +" reservationsContinueLooking=" + reservationsContinueLooking), asbolute should be absolute

      In file /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java, LOG.info("Calling allocate on removed " +"or non existant application " + appAttemptId),
      existant should be existent

      1. YARN-5642.001.patch
        10 kB
        Mehran Hassani
      2. YARN-5642.002.patch
        10 kB
        Mehran Hassani

        Activity

        Hide
        busbey Sean Busbey added a comment -

        good finds! interested in coming up with a patch for fixing these? Our contributor guide covers everything needed to work across the code base, but I'd imagine for these things a simple manual test of compilation before and after the changes should suffice.

        Show
        busbey Sean Busbey added a comment - good finds! interested in coming up with a patch for fixing these? Our contributor guide covers everything needed to work across the code base, but I'd imagine for these things a simple manual test of compilation before and after the changes should suffice.
        Hide
        raviprak Ravi Prakash added a comment -

        Interesting research Mehran! Thanks for your contribution. In addition to typos, does your research also discover grammatical errors?

        Show
        raviprak Ravi Prakash added a comment - Interesting research Mehran! Thanks for your contribution. In addition to typos, does your research also discover grammatical errors?
        Hide
        MehranHassani Mehran Hassani added a comment -

        It's currently not in our toolset since we find logs from source code that may not have the complete sentence. But we will try to detect grammar issues later.

        Show
        MehranHassani Mehran Hassani added a comment - It's currently not in our toolset since we find logs from source code that may not have the complete sentence. But we will try to detect grammar issues later.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 4s YARN-5642 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828778/YARN-5642.001.patch
        JIRA Issue YARN-5642
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13119/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s YARN-5642 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828778/YARN-5642.001.patch JIRA Issue YARN-5642 Console output https://builds.apache.org/job/PreCommit-YARN-Build/13119/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        MehranHassani Mehran Hassani added a comment -

        This means my patch has conflicts with the trunk ?

        Show
        MehranHassani Mehran Hassani added a comment - This means my patch has conflicts with the trunk ?
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Have assigned the jira to you Mehran Hassani! and yes you need to get the latest code and apply the modifications again

        Show
        Naganarasimha Naganarasimha G R added a comment - Have assigned the jira to you Mehran Hassani ! and yes you need to get the latest code and apply the modifications again
        Hide
        MehranHassani Mehran Hassani added a comment -

        Thanks, will do shortly and add a new patch.

        Show
        MehranHassani Mehran Hassani added a comment - Thanks, will do shortly and add a new patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 11s Maven dependency ordering for branch
        +1 mvninstall 6m 53s trunk passed
        +1 compile 2m 19s trunk passed
        +1 checkstyle 0m 40s trunk passed
        +1 mvnsite 1m 56s trunk passed
        +1 mvneclipse 0m 56s trunk passed
        +1 findbugs 3m 5s trunk passed
        +1 javadoc 1m 20s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 35s the patch passed
        +1 compile 2m 16s the patch passed
        +1 javac 2m 16s the patch passed
        -1 checkstyle 0m 37s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 231 unchanged - 1 fixed = 232 total (was 232)
        +1 mvnsite 1m 49s the patch passed
        +1 mvneclipse 0m 49s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 3m 25s the patch passed
        +1 javadoc 1m 11s the patch passed
        +1 unit 2m 17s hadoop-yarn-common in the patch passed.
        -1 unit 14m 11s hadoop-yarn-server-nodemanager in the patch failed.
        -1 unit 3m 10s hadoop-yarn-server-applicationhistoryservice in the patch failed.
        +1 unit 39m 4s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        89m 34s



        Reason Tests
        Failed junit tests hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor
          hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828844/YARN-5642.002.patch
        JIRA Issue YARN-5642
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 439e1ff02c70 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / b09a03c
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13121/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/13121/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/13121/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/13121/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/13121/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/13121/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13121/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13121/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 6m 53s trunk passed +1 compile 2m 19s trunk passed +1 checkstyle 0m 40s trunk passed +1 mvnsite 1m 56s trunk passed +1 mvneclipse 0m 56s trunk passed +1 findbugs 3m 5s trunk passed +1 javadoc 1m 20s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 35s the patch passed +1 compile 2m 16s the patch passed +1 javac 2m 16s the patch passed -1 checkstyle 0m 37s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 231 unchanged - 1 fixed = 232 total (was 232) +1 mvnsite 1m 49s the patch passed +1 mvneclipse 0m 49s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 3m 25s the patch passed +1 javadoc 1m 11s the patch passed +1 unit 2m 17s hadoop-yarn-common in the patch passed. -1 unit 14m 11s hadoop-yarn-server-nodemanager in the patch failed. -1 unit 3m 10s hadoop-yarn-server-applicationhistoryservice in the patch failed. +1 unit 39m 4s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 89m 34s Reason Tests Failed junit tests hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor   hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828844/YARN-5642.002.patch JIRA Issue YARN-5642 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 439e1ff02c70 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b09a03c Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13121/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/13121/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13121/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13121/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/13121/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/13121/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13121/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13121/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks for the contribution Mehran Hassani

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks for the contribution Mehran Hassani
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10454 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10454/)
        YARN-5642. Typos in 9 log messages. Contributed by Mehran Hassani (naganarasimha_gr: rev 4174b9756c8c7877797545c4356b1f40df603ec5)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/YarnAuthorizationProvider.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/FileSystemApplicationHistoryStore.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/ParentQueue.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/event/AsyncDispatcher.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/AbstractReservationSystem.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10454 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10454/ ) YARN-5642 . Typos in 9 log messages. Contributed by Mehran Hassani (naganarasimha_gr: rev 4174b9756c8c7877797545c4356b1f40df603ec5) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/YarnAuthorizationProvider.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/FileSystemApplicationHistoryStore.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/ParentQueue.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/event/AsyncDispatcher.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/AbstractReservationSystem.java

          People

          • Assignee:
            MehranHassani Mehran Hassani
            Reporter:
            MehranHassani Mehran Hassani
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development