Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      To aid in debugging launch failures, it would be valuable to have an application's launch script and logs posted to ATS. Because the application's command line may contain private credentials or other secure information, access to the data in ATS should be restricted to the job owner, including the at-rest data.

      Along with making the data available through ATS, the configuration parameter introduced in YARN-5549 and the log line that it guards should be removed.

      1. 0001-YARN-5599.patch
        10 kB
        Rohith Sharma K S
      2. 0002-YARN-5599.patch
        15 kB
        Rohith Sharma K S
      3. 0003-YARN-5599.patch
        16 kB
        Rohith Sharma K S
      4. YARN-5599-branch-2.patch
        14 kB
        Rohith Sharma K S
      5. YARN-5599-branch-2.patch
        13 kB
        Rohith Sharma K S
      6. YARN-5599-YARN-5355-branch-2.01.patch
        5 kB
        Varun Saxena

        Activity

        Hide
        varun_saxena Varun Saxena added a comment -

        Updated the patch used for YARN-5355-branch-2

        Show
        varun_saxena Varun Saxena added a comment - Updated the patch used for YARN-5355 -branch-2
        Hide
        varun_saxena Varun Saxena added a comment -

        Backported this fix to YARN-5355-branch-2

        Show
        varun_saxena Varun Saxena added a comment - Backported this fix to YARN-5355 -branch-2
        Hide
        varun_saxena Varun Saxena added a comment -

        Committed to trunk, branch-2 and branch-2.8
        Thanks Rohith Sharma K S for your contribution
        Thanks Daniel Templeton for reviews and reporting the issue.

        Show
        varun_saxena Varun Saxena added a comment - Committed to trunk, branch-2 and branch-2.8 Thanks Rohith Sharma K S for your contribution Thanks Daniel Templeton for reviews and reporting the issue.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 52s Maven dependency ordering for branch
        +1 mvninstall 7m 35s branch-2 passed
        +1 compile 2m 9s branch-2 passed with JDK v1.8.0_101
        +1 compile 2m 21s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 0m 45s branch-2 passed
        +1 mvnsite 2m 6s branch-2 passed
        +1 mvneclipse 0m 58s branch-2 passed
        +1 findbugs 4m 13s branch-2 passed
        +1 javadoc 1m 20s branch-2 passed with JDK v1.8.0_101
        +1 javadoc 1m 32s branch-2 passed with JDK v1.7.0_111
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 41s the patch passed
        +1 compile 1m 48s the patch passed with JDK v1.8.0_101
        +1 javac 1m 48s the patch passed
        +1 compile 2m 12s the patch passed with JDK v1.7.0_111
        +1 javac 2m 12s the patch passed
        -1 checkstyle 0m 40s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 231 unchanged - 2 fixed = 233 total (was 233)
        +1 mvnsite 1m 54s the patch passed
        +1 mvneclipse 0m 51s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 4m 57s the patch passed
        +1 javadoc 1m 10s the patch passed with JDK v1.8.0_101
        +1 javadoc 1m 24s the patch passed with JDK v1.7.0_111
        +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_101.
        +1 unit 2m 6s hadoop-yarn-common in the patch passed with JDK v1.8.0_101.
        +1 unit 0m 22s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_101.
        +1 unit 38m 36s hadoop-yarn-server-resourcemanager in the patch passed with JDK v1.8.0_101.
        +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_111.
        +1 unit 2m 26s hadoop-yarn-common in the patch passed with JDK v1.7.0_111.
        +1 unit 0m 27s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_111.
        -1 unit 35m 2s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_111.
        +1 asflicense 0m 28s The patch does not generate ASF License warnings.
        122m 59s



        Reason Tests
        JDK v1.7.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStorePerf



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831455/YARN-5599-branch-2.patch
        JIRA Issue YARN-5599
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 46c3d757cb81 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 612aa0c
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13272/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/13272/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_111.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/13272/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_111.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13272/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13272/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 52s Maven dependency ordering for branch +1 mvninstall 7m 35s branch-2 passed +1 compile 2m 9s branch-2 passed with JDK v1.8.0_101 +1 compile 2m 21s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 45s branch-2 passed +1 mvnsite 2m 6s branch-2 passed +1 mvneclipse 0m 58s branch-2 passed +1 findbugs 4m 13s branch-2 passed +1 javadoc 1m 20s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 32s branch-2 passed with JDK v1.7.0_111 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 41s the patch passed +1 compile 1m 48s the patch passed with JDK v1.8.0_101 +1 javac 1m 48s the patch passed +1 compile 2m 12s the patch passed with JDK v1.7.0_111 +1 javac 2m 12s the patch passed -1 checkstyle 0m 40s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 231 unchanged - 2 fixed = 233 total (was 233) +1 mvnsite 1m 54s the patch passed +1 mvneclipse 0m 51s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 57s the patch passed +1 javadoc 1m 10s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 24s the patch passed with JDK v1.7.0_111 +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_101. +1 unit 2m 6s hadoop-yarn-common in the patch passed with JDK v1.8.0_101. +1 unit 0m 22s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_101. +1 unit 38m 36s hadoop-yarn-server-resourcemanager in the patch passed with JDK v1.8.0_101. +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_111. +1 unit 2m 26s hadoop-yarn-common in the patch passed with JDK v1.7.0_111. +1 unit 0m 27s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_111. -1 unit 35m 2s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_111. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 122m 59s Reason Tests JDK v1.7.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStorePerf Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831455/YARN-5599-branch-2.patch JIRA Issue YARN-5599 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 46c3d757cb81 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 612aa0c Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13272/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13272/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_111.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/13272/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13272/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13272/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        updated patch test assertion.

        Show
        rohithsharma Rohith Sharma K S added a comment - updated patch test assertion.
        Hide
        varun_saxena Varun Saxena added a comment - - edited

        Thanks Rohith Sharma K S for branch-2 patch.
        One nit : It seems assertions in TestSystemMetricsPublisher have been missed.

        Can you update the patch again ?

        Show
        varun_saxena Varun Saxena added a comment - - edited Thanks Rohith Sharma K S for branch-2 patch. One nit : It seems assertions in TestSystemMetricsPublisher have been missed. Can you update the patch again ?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 14m 36s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 2m 30s Maven dependency ordering for branch
        +1 mvninstall 7m 19s branch-2 passed
        +1 compile 1m 57s branch-2 passed with JDK v1.8.0_101
        +1 compile 2m 16s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 0m 42s branch-2 passed
        +1 mvnsite 2m 3s branch-2 passed
        +1 mvneclipse 0m 57s branch-2 passed
        +1 findbugs 4m 16s branch-2 passed
        +1 javadoc 1m 20s branch-2 passed with JDK v1.8.0_101
        +1 javadoc 1m 30s branch-2 passed with JDK v1.7.0_111
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 1m 41s the patch passed
        +1 compile 1m 50s the patch passed with JDK v1.8.0_101
        +1 javac 1m 50s the patch passed
        +1 compile 2m 13s the patch passed with JDK v1.7.0_111
        +1 javac 2m 13s the patch passed
        -1 checkstyle 0m 40s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 232 unchanged - 1 fixed = 233 total (was 233)
        +1 mvnsite 1m 52s the patch passed
        +1 mvneclipse 0m 48s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 4m 58s the patch passed
        +1 javadoc 1m 11s the patch passed with JDK v1.8.0_101
        +1 javadoc 1m 24s the patch passed with JDK v1.7.0_111
        +1 unit 0m 21s hadoop-yarn-api in the patch passed with JDK v1.8.0_101.
        +1 unit 2m 7s hadoop-yarn-common in the patch passed with JDK v1.8.0_101.
        +1 unit 0m 22s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_101.
        +1 unit 33m 9s hadoop-yarn-server-resourcemanager in the patch passed with JDK v1.8.0_101.
        +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.7.0_111.
        +1 unit 2m 25s hadoop-yarn-common in the patch passed with JDK v1.7.0_111.
        +1 unit 0m 27s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_111.
        +1 unit 34m 31s hadoop-yarn-server-resourcemanager in the patch passed with JDK v1.7.0_111.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        131m 55s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830749/YARN-5599-branch-2.patch
        JIRA Issue YARN-5599
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 0e55e9ede2f4 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / baf8aac
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13238/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13238/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13238/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 14m 36s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 2m 30s Maven dependency ordering for branch +1 mvninstall 7m 19s branch-2 passed +1 compile 1m 57s branch-2 passed with JDK v1.8.0_101 +1 compile 2m 16s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 42s branch-2 passed +1 mvnsite 2m 3s branch-2 passed +1 mvneclipse 0m 57s branch-2 passed +1 findbugs 4m 16s branch-2 passed +1 javadoc 1m 20s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 30s branch-2 passed with JDK v1.7.0_111 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 41s the patch passed +1 compile 1m 50s the patch passed with JDK v1.8.0_101 +1 javac 1m 50s the patch passed +1 compile 2m 13s the patch passed with JDK v1.7.0_111 +1 javac 2m 13s the patch passed -1 checkstyle 0m 40s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 232 unchanged - 1 fixed = 233 total (was 233) +1 mvnsite 1m 52s the patch passed +1 mvneclipse 0m 48s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 58s the patch passed +1 javadoc 1m 11s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 24s the patch passed with JDK v1.7.0_111 +1 unit 0m 21s hadoop-yarn-api in the patch passed with JDK v1.8.0_101. +1 unit 2m 7s hadoop-yarn-common in the patch passed with JDK v1.8.0_101. +1 unit 0m 22s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_101. +1 unit 33m 9s hadoop-yarn-server-resourcemanager in the patch passed with JDK v1.8.0_101. +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.7.0_111. +1 unit 2m 25s hadoop-yarn-common in the patch passed with JDK v1.7.0_111. +1 unit 0m 27s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_111. +1 unit 34m 31s hadoop-yarn-server-resourcemanager in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 131m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830749/YARN-5599-branch-2.patch JIRA Issue YARN-5599 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 0e55e9ede2f4 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / baf8aac Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13238/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13238/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13238/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        updated branch-2 patch

        Show
        rohithsharma Rohith Sharma K S added a comment - updated branch-2 patch
        Hide
        varun_saxena Varun Saxena added a comment -

        Rohith Sharma K S can you provide a branch-2 patch ?
        This would basically mean dropping ATSv2 changes.

        Show
        varun_saxena Varun Saxena added a comment - Rohith Sharma K S can you provide a branch-2 patch ? This would basically mean dropping ATSv2 changes.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10506 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10506/)
        YARN-5599. Publish AM launch command to ATS (Rohith Sharma K S via Varun (varunsaxena: rev 9b0fd01d2ee002ac4c30c2862e18ca8f1626fa8d)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/amlauncher/AMLauncher.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TestSystemMetricsPublisher.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TestSystemMetricsPublisherForV2.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TimelineServiceV1Publisher.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/metrics/ApplicationMetricsConstants.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TimelineServiceV2Publisher.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10506 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10506/ ) YARN-5599 . Publish AM launch command to ATS (Rohith Sharma K S via Varun (varunsaxena: rev 9b0fd01d2ee002ac4c30c2862e18ca8f1626fa8d) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/amlauncher/AMLauncher.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TestSystemMetricsPublisher.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TestSystemMetricsPublisherForV2.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TimelineServiceV1Publisher.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/metrics/ApplicationMetricsConstants.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TimelineServiceV2Publisher.java
        Hide
        varun_saxena Varun Saxena added a comment -

        +1.
        Will commit shortly.

        Show
        varun_saxena Varun Saxena added a comment - +1. Will commit shortly.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 22m 34s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 1m 12s Maven dependency ordering for branch
        +1 mvninstall 9m 58s trunk passed
        +1 compile 3m 6s trunk passed
        +1 checkstyle 0m 55s trunk passed
        +1 mvnsite 2m 31s trunk passed
        +1 mvneclipse 1m 9s trunk passed
        +1 findbugs 4m 21s trunk passed
        +1 javadoc 1m 41s trunk passed
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 2m 14s the patch passed
        +1 compile 3m 4s the patch passed
        +1 javac 3m 4s the patch passed
        -1 checkstyle 0m 48s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 221 unchanged - 1 fixed = 222 total (was 222)
        +1 mvnsite 2m 16s the patch passed
        +1 mvneclipse 0m 58s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 findbugs 4m 45s the patch passed
        +1 javadoc 1m 29s the patch passed
        +1 unit 0m 30s hadoop-yarn-api in the patch passed.
        +1 unit 2m 30s hadoop-yarn-common in the patch passed.
        +1 unit 0m 33s hadoop-yarn-server-common in the patch passed.
        +1 unit 40m 48s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        109m 18s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830538/0003-YARN-5599.patch
        JIRA Issue YARN-5599
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 6446ddc731b2 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8ae4729
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13227/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13227/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13227/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 22m 34s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 1m 12s Maven dependency ordering for branch +1 mvninstall 9m 58s trunk passed +1 compile 3m 6s trunk passed +1 checkstyle 0m 55s trunk passed +1 mvnsite 2m 31s trunk passed +1 mvneclipse 1m 9s trunk passed +1 findbugs 4m 21s trunk passed +1 javadoc 1m 41s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 2m 14s the patch passed +1 compile 3m 4s the patch passed +1 javac 3m 4s the patch passed -1 checkstyle 0m 48s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 221 unchanged - 1 fixed = 222 total (was 222) +1 mvnsite 2m 16s the patch passed +1 mvneclipse 0m 58s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 4m 45s the patch passed +1 javadoc 1m 29s the patch passed +1 unit 0m 30s hadoop-yarn-api in the patch passed. +1 unit 2m 30s hadoop-yarn-common in the patch passed. +1 unit 0m 33s hadoop-yarn-server-common in the patch passed. +1 unit 40m 48s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 109m 18s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830538/0003-YARN-5599.patch JIRA Issue YARN-5599 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 6446ddc731b2 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8ae4729 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13227/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13227/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13227/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        +1 pending Jenkins.

        Show
        templedf Daniel Templeton added a comment - +1 pending Jenkins.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Updated patch fixing review comments

        Show
        rohithsharma Rohith Sharma K S added a comment - Updated patch fixing review comments
        Hide
        templedf Daniel Templeton added a comment -

        Looks fine to me. The unused import in the checkstyle comments should be removed. Also, in the tests, instead of:

            List<String> commands = new ArrayList<String>();
            commands.add("java -Xmx1024m");

        it would be better to use:

            List<String> commands = Collections.singletonList("java -Xmx1024m");

        or maybe skip defining the variable at all.

        Show
        templedf Daniel Templeton added a comment - Looks fine to me. The unused import in the checkstyle comments should be removed. Also, in the tests, instead of: List< String > commands = new ArrayList< String >(); commands.add( "java -Xmx1024m" ); it would be better to use: List< String > commands = Collections.singletonList( "java -Xmx1024m" ); or maybe skip defining the variable at all.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 58s Maven dependency ordering for branch
        +1 mvninstall 7m 6s trunk passed
        +1 compile 2m 19s trunk passed
        +1 checkstyle 0m 42s trunk passed
        +1 mvnsite 1m 57s trunk passed
        +1 mvneclipse 0m 55s trunk passed
        +1 findbugs 3m 38s trunk passed
        +1 javadoc 1m 20s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 36s the patch passed
        +1 compile 2m 20s the patch passed
        +1 javac 2m 20s the patch passed
        -1 checkstyle 0m 39s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 220 unchanged - 1 fixed = 222 total (was 221)
        +1 mvnsite 1m 52s the patch passed
        +1 mvneclipse 0m 47s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 findbugs 4m 13s the patch passed
        +1 javadoc 1m 17s the patch passed
        +1 unit 0m 23s hadoop-yarn-api in the patch passed.
        +1 unit 2m 22s hadoop-yarn-common in the patch passed.
        +1 unit 0m 28s hadoop-yarn-server-common in the patch passed.
        +1 unit 33m 41s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        70m 24s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830495/0002-YARN-5599.patch
        JIRA Issue YARN-5599
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux a0768ca406c9 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ebf528c
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13224/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13224/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13224/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 58s Maven dependency ordering for branch +1 mvninstall 7m 6s trunk passed +1 compile 2m 19s trunk passed +1 checkstyle 0m 42s trunk passed +1 mvnsite 1m 57s trunk passed +1 mvneclipse 0m 55s trunk passed +1 findbugs 3m 38s trunk passed +1 javadoc 1m 20s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 36s the patch passed +1 compile 2m 20s the patch passed +1 javac 2m 20s the patch passed -1 checkstyle 0m 39s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 220 unchanged - 1 fixed = 222 total (was 221) +1 mvnsite 1m 52s the patch passed +1 mvneclipse 0m 47s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 4m 13s the patch passed +1 javadoc 1m 17s the patch passed +1 unit 0m 23s hadoop-yarn-api in the patch passed. +1 unit 2m 22s hadoop-yarn-common in the patch passed. +1 unit 0m 28s hadoop-yarn-server-common in the patch passed. +1 unit 33m 41s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 70m 24s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830495/0002-YARN-5599.patch JIRA Issue YARN-5599 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux a0768ca406c9 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ebf528c Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13224/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13224/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13224/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        varun_saxena Varun Saxena added a comment -

        Thanks Rohith Sharma K S for the patch.

        for v2, whole test class does not verify for published entities. this task need to do in separate JIRA.

        I am fine with that.

        The patch looks fine to me. Will commit it pending Jenkins and review from Daniel Templeton. The JIRA mentions application logs should also be available. But we do have a REST endpoint in AHS to get container logs from HDFS so that should be fine IMO.

        Show
        varun_saxena Varun Saxena added a comment - Thanks Rohith Sharma K S for the patch. for v2, whole test class does not verify for published entities. this task need to do in separate JIRA. I am fine with that. The patch looks fine to me. Will commit it pending Jenkins and review from Daniel Templeton . The JIRA mentions application logs should also be available. But we do have a REST endpoint in AHS to get container logs from HDFS so that should be fine IMO.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Updated the patch with following changes

        1. reverts the configurations
        2. Removes the log messages which prints am commands
        3. publishes AM commands to v1 and v2 timeline server
        4. adds a test and verify for published entities in v1. for v2, whole test class does not verify for published entities. this task need to do in separate JIRA.
        Show
        rohithsharma Rohith Sharma K S added a comment - Updated the patch with following changes reverts the configurations Removes the log messages which prints am commands publishes AM commands to v1 and v2 timeline server adds a test and verify for published entities in v1. for v2, whole test class does not verify for published entities. this task need to do in separate JIRA.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Agree to Daniel Templeton's comment we are logging the commands at debug level, which should be avoided and hope the fix is done in all the ATS versions...

        Show
        Naganarasimha Naganarasimha G R added a comment - Agree to Daniel Templeton 's comment we are logging the commands at debug level, which should be avoided and hope the fix is done in all the ATS versions...
        Hide
        templedf Daniel Templeton added a comment -

        Looks like the patch adds back the log line in createAMContainerLaunchContext(), which reintroduces the security vulnerability we were trying to eliminate. The log line should be dropped altogether.

        Show
        templedf Daniel Templeton added a comment - Looks like the patch adds back the log line in createAMContainerLaunchContext() , which reintroduces the security vulnerability we were trying to eliminate. The log line should be dropped altogether.
        Hide
        templedf Daniel Templeton added a comment -

        The original intent was to cover for the removal of a log message from the RM that output the launch command. With the log message gone, we wanted to have another source for the launch command so that launch failures can be debugged.

        Show
        templedf Daniel Templeton added a comment - The original intent was to cover for the removal of a log message from the RM that output the launch command. With the log message gone, we wanted to have another source for the launch command so that launch failures can be debugged.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        IMO it would be better to capture it in any version of ATS, as it will help in analysis.

        in case of container launch failures YARN already keeps track of diagnostics message and also publishes to ATS.

        Yes but IIRC it would collect the 4k bytes log message as failure to launch but may not be the launch command which we are trying to capture here right ?

        Show
        Naganarasimha Naganarasimha G R added a comment - IMO it would be better to capture it in any version of ATS, as it will help in analysis. in case of container launch failures YARN already keeps track of diagnostics message and also publishes to ATS. Yes but IIRC it would collect the 4k bytes log message as failure to launch but may not be the launch command which we are trying to capture here right ?
        Hide
        rohithsharma Rohith Sharma K S added a comment - - edited

        IIUC, the scope of the JIRA is to publish AM launcher artifacts to ATSv2 for debugging in case of launch failure. May be issue reporter can make it clear. cc:-/Daniel Templeton
        On flip-side, in case of container launch failures YARN already keeps track of diagnostics message and also publishes to ATS.

        And regarding security of these data, ATSv2 has to take care which will be supported in future.

        Show
        rohithsharma Rohith Sharma K S added a comment - - edited IIUC, the scope of the JIRA is to publish AM launcher artifacts to ATSv2 for debugging in case of launch failure. May be issue reporter can make it clear. cc:-/ Daniel Templeton On flip-side, in case of container launch failures YARN already keeps track of diagnostics message and also publishes to ATS. And regarding security of these data, ATSv2 has to take care which will be supported in future.
        Hide
        varun_saxena Varun Saxena added a comment -

        Thanks Rohith Sharma K S for the patch. Should we do this for ATSv1 too because ATSv2 is still in alpha phase.

        From the patch, the test does not check if AM command is published or not. The test with the changes passes with or without the core changes. Looking at the test code, probably we can add a check somewhere in verifyEntity method. Or can add some other way of verifying if entity with this info has been published.

        IMO, app level authorization in ATS should be enough as an access control mechanism. If you have authorization to read app details, you should be able to read it as well.
        I am not sure about the part regarding publishing application logs. Access to aggregated container logs in HDFS will be controlled based on user. And in AHS/ATSv1 we provide an endpoint to access container logs too. We plan to add this in ATSv2 too, pending discussion.

        Show
        varun_saxena Varun Saxena added a comment - Thanks Rohith Sharma K S for the patch. Should we do this for ATSv1 too because ATSv2 is still in alpha phase. From the patch, the test does not check if AM command is published or not. The test with the changes passes with or without the core changes. Looking at the test code, probably we can add a check somewhere in verifyEntity method. Or can add some other way of verifying if entity with this info has been published. IMO, app level authorization in ATS should be enough as an access control mechanism. If you have authorization to read app details, you should be able to read it as well. I am not sure about the part regarding publishing application logs. Access to aggregated container logs in HDFS will be controlled based on user. And in AHS/ATSv1 we provide an endpoint to access container logs too. We plan to add this in ATSv2 too, pending discussion.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 9s Maven dependency ordering for branch
        +1 mvninstall 6m 55s trunk passed
        +1 compile 2m 23s trunk passed
        +1 checkstyle 0m 40s trunk passed
        +1 mvnsite 1m 57s trunk passed
        +1 mvneclipse 0m 54s trunk passed
        +1 findbugs 3m 37s trunk passed
        +1 javadoc 1m 22s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 39s the patch passed
        +1 compile 2m 17s the patch passed
        +1 javac 2m 17s the patch passed
        +1 checkstyle 0m 42s the patch passed
        +1 mvnsite 1m 52s the patch passed
        +1 mvneclipse 0m 48s the patch passed
        +1 whitespace 0m 1s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 4m 0s the patch passed
        +1 javadoc 1m 13s the patch passed
        +1 unit 0m 22s hadoop-yarn-api in the patch passed.
        +1 unit 2m 17s hadoop-yarn-common in the patch passed.
        +1 unit 0m 26s hadoop-yarn-server-common in the patch passed.
        +1 unit 33m 58s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        69m 14s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829144/0001-YARN-5599.patch
        JIRA Issue YARN-5599
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 61e73891b726 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 3552c2b
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13144/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13144/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 6m 55s trunk passed +1 compile 2m 23s trunk passed +1 checkstyle 0m 40s trunk passed +1 mvnsite 1m 57s trunk passed +1 mvneclipse 0m 54s trunk passed +1 findbugs 3m 37s trunk passed +1 javadoc 1m 22s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 39s the patch passed +1 compile 2m 17s the patch passed +1 javac 2m 17s the patch passed +1 checkstyle 0m 42s the patch passed +1 mvnsite 1m 52s the patch passed +1 mvneclipse 0m 48s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 0s the patch passed +1 javadoc 1m 13s the patch passed +1 unit 0m 22s hadoop-yarn-api in the patch passed. +1 unit 2m 17s hadoop-yarn-common in the patch passed. +1 unit 0m 26s hadoop-yarn-server-common in the patch passed. +1 unit 33m 58s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 69m 14s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829144/0001-YARN-5599.patch JIRA Issue YARN-5599 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 61e73891b726 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3552c2b Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13144/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13144/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Daniel Templeton Naganarasimha Garla kindly review the patch.

        Show
        rohithsharma Rohith Sharma K S added a comment - Daniel Templeton Naganarasimha Garla kindly review the patch.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Attached patch with following changes.

        1. Reverted the configurations and log added in YARN-5549.
        2. Publishing AM launcher command to ATSv2 when app is created.
        Show
        rohithsharma Rohith Sharma K S added a comment - Attached patch with following changes. Reverted the configurations and log added in YARN-5549 . Publishing AM launcher command to ATSv2 when app is created.

          People

          • Assignee:
            rohithsharma Rohith Sharma K S
            Reporter:
            templedf Daniel Templeton
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development