Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5572

HBaseTimelineWriterImpl appears to reference a bad property name

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This constructor:

        public HBaseTimelineWriterImpl(Configuration conf) throws IOException {
          super(conf.get("yarn.application.id",
              HBaseTimelineWriterImpl.class.getName()));
        }
      

      references "yarn.application.id", which is the only reference to this property I could find.

        Activity

        Hide
        varun_saxena Varun Saxena added a comment -

        This constructor is unnecessary. Removed it.

        Show
        varun_saxena Varun Saxena added a comment - This constructor is unnecessary. Removed it.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
        0 mvndep 0m 56s Maven dependency ordering for branch
        +1 mvninstall 7m 43s trunk passed
        +1 compile 1m 46s trunk passed
        +1 checkstyle 0m 30s trunk passed
        +1 mvnsite 0m 45s trunk passed
        +1 mvneclipse 0m 29s trunk passed
        +1 findbugs 0m 58s trunk passed
        +1 javadoc 0m 26s trunk passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 0m 34s the patch passed
        +1 compile 1m 27s the patch passed
        +1 javac 1m 27s the patch passed
        +1 checkstyle 0m 28s the patch passed
        +1 mvnsite 0m 43s the patch passed
        +1 mvneclipse 0m 29s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 19s the patch passed
        +1 javadoc 0m 24s the patch passed
        +1 unit 0m 48s hadoop-yarn-server-timelineservice in the patch passed.
        +1 unit 4m 45s hadoop-yarn-server-timelineservice-hbase-tests in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        30m 24s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5572
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840099/YARN-5572.01.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 7ffd7418aad9 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 005850b
        Default Java 1.8.0_111
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14063/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14063/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files. 0 mvndep 0m 56s Maven dependency ordering for branch +1 mvninstall 7m 43s trunk passed +1 compile 1m 46s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 0m 45s trunk passed +1 mvneclipse 0m 29s trunk passed +1 findbugs 0m 58s trunk passed +1 javadoc 0m 26s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 34s the patch passed +1 compile 1m 27s the patch passed +1 javac 1m 27s the patch passed +1 checkstyle 0m 28s the patch passed +1 mvnsite 0m 43s the patch passed +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 19s the patch passed +1 javadoc 0m 24s the patch passed +1 unit 0m 48s hadoop-yarn-server-timelineservice in the patch passed. +1 unit 4m 45s hadoop-yarn-server-timelineservice-hbase-tests in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 30m 24s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5572 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840099/YARN-5572.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7ffd7418aad9 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 005850b Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14063/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server Console output https://builds.apache.org/job/PreCommit-YARN-Build/14063/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        LGTM, +1.

        Show
        ajisakaa Akira Ajisaka added a comment - LGTM, +1.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks Varun Saxena, for working on the patch, HBaseTimelineWriterImpl is created through reflection and initialized by the configuration object later

          public void serviceInit(Configuration conf) throws Exception {
            writer = ReflectionUtils.newInstance(conf.getClass(
                YarnConfiguration.TIMELINE_SERVICE_WRITER_CLASS,
                HBaseTimelineWriterImpl.class,
                TimelineWriter.class), conf);
            writer.init(conf);
        ...
        }
        

        hence i do not see the need for the constructor. Will commit the patch shortly.

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks Varun Saxena , for working on the patch, HBaseTimelineWriterImpl is created through reflection and initialized by the configuration object later public void serviceInit(Configuration conf) throws Exception { writer = ReflectionUtils.newInstance(conf.getClass( YarnConfiguration.TIMELINE_SERVICE_WRITER_CLASS, HBaseTimelineWriterImpl.class, TimelineWriter.class), conf); writer.init(conf); ... } hence i do not see the need for the constructor. Will commit the patch shortly.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10895 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10895/)
        YARN-5572. HBaseTimelineWriterImpl appears to reference a bad property (naganarasimha_gr: rev c06114d6a360dddeb66c2dd9ad4fa5dae0cfbfb1)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/DataGeneratorForTest.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/flow/TestHBaseStorageFlowRunCompaction.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/flow/TestHBaseStorageFlowRun.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/storage/HBaseTimelineWriterImpl.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/flow/TestHBaseStorageFlowActivity.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/TestHBaseTimelineStorageEntities.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/TestHBaseTimelineStorageApps.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10895 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10895/ ) YARN-5572 . HBaseTimelineWriterImpl appears to reference a bad property (naganarasimha_gr: rev c06114d6a360dddeb66c2dd9ad4fa5dae0cfbfb1) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/DataGeneratorForTest.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/flow/TestHBaseStorageFlowRunCompaction.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/flow/TestHBaseStorageFlowRun.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/storage/HBaseTimelineWriterImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/flow/TestHBaseStorageFlowActivity.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/TestHBaseTimelineStorageEntities.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/TestHBaseTimelineStorageApps.java
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks for the contribution Varun Saxena and review from Akira Ajisaka ! Committed it to trunk!

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks for the contribution Varun Saxena and review from Akira Ajisaka ! Committed it to trunk!
        Hide
        sjlee0 Sangjin Lee added a comment -

        I also committed this to YARN-5355-branch-2. Any trunk changes for timeline service v.2 needs to be committed to YARN-5355-branch-2 as they are not picked up by rebase.

        Show
        sjlee0 Sangjin Lee added a comment - I also committed this to YARN-5355 -branch-2. Any trunk changes for timeline service v.2 needs to be committed to YARN-5355 -branch-2 as they are not picked up by rebase.

          People

          • Assignee:
            varun_saxena Varun Saxena
            Reporter:
            templedf Daniel Templeton
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development