[YARN-5566] Client-side NM graceful decom is not triggered when jobs finish

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8.0
• Fix Version/s: 2.8.0, 3.0.0-alpha2
• Component/s: nodemanager
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Robert Kanter
• Reporter: Robert Kanter
• Created: 26/Aug/16 07:55
• Updated: 25/Oct/19 20:26
• Resolved: 09/Sep/16 04:22

Description

I was testing the client-side NM graceful decommission and noticed that it was always waiting for the timeout, even if all jobs running on that node (or even the cluster) had already finished.

For example:

1. JobA is running with at least one container on NodeA
2. User runs client-side decom on NodeA at 5:00am with a timeout of 3 hours --> NodeA enters DECOMMISSIONING state
3. JobA finishes at 6:00am and there are no other jobs running on NodeA
4. User's client reaches the timeout at 8:00am, and forcibly decommissions NodeA

NodeA should have decommissioned at 6:00am.

Issue Links

• breaks: YARN-5655 TestContainerManagerSecurity#testNMTokens is asserting