[YARN-5560] Clean up bad exception catching practices in TestYarnClient

• Type: Test
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Hadoop Flags: Reviewed
• Assignee: Sean Po
• Reporter: Sean Po
• Created: 24/Aug/16 22:58
• Updated: 30/Aug/16 00:59
• Resolved: 29/Aug/16 16:22

Description

In TestYarnClient, tests commonly wrap methods that throw exceptions in a try catch statement similar to the following:

try {
    client.submitApplication(context);
} catch (Exception e) {
    Assert.fail("Exception is not expected.");
}

This hides useful error messages, and surfaces less helpful ones.