Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5559

Analyse 2.8.0/3.0.0 jdiff reports and fix any issues

    Details

    1. YARN-5559.1.patch
      12 kB
      Wangda Tan
    2. YARN-5559.2.patch
      12 kB
      Akira Ajisaka
    3. YARN-5559.3.patch
      13 kB
      Akira Ajisaka
    4. YARN-5559.4.patch
      12 kB
      Akira Ajisaka
    5. YARN-5559.5.patch
      12 kB
      Akira Ajisaka
    6. YARN-5559.6.patch
      13 kB
      Akira Ajisaka
    7. YARN-5559.7.patch
      13 kB
      Akira Ajisaka
    8. YARN-5559.8.patch
      13 kB
      Akira Ajisaka

      Issue Links

        Activity

        Hide
        leftnoteasy Wangda Tan added a comment -

        Really apologize for my delayed response, thanks a lot to Akira Ajisaka for taking care of this. And thanks Jian He/Junping Du for reviewing the patch.

        Show
        leftnoteasy Wangda Tan added a comment - Really apologize for my delayed response, thanks a lot to Akira Ajisaka for taking care of this. And thanks Jian He / Junping Du for reviewing the patch.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10939 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10939/)
        YARN-5559. Analyse 2.8.0/3.0.0 jdiff reports and fix any issues. (jianhe: rev 43ebff2e354142bddcb42755766a965ae8a503a6)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/GetClusterNodeLabelsResponsePBImpl.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/state/InvalidStateTransitionException.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/GetClusterNodeLabelsResponse.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/ContainerTokenIdentifier.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/state/InvalidStateTransitonException.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10939 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10939/ ) YARN-5559 . Analyse 2.8.0/3.0.0 jdiff reports and fix any issues. (jianhe: rev 43ebff2e354142bddcb42755766a965ae8a503a6) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/GetClusterNodeLabelsResponsePBImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/state/InvalidStateTransitionException.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/GetClusterNodeLabelsResponse.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/ContainerTokenIdentifier.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/state/InvalidStateTransitonException.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java
        Hide
        jianhe Jian He added a comment -

        Committed to trunk, branch-2, branch-2.8

        Thanks Akira Ajisaka, Wangda Tan !

        Show
        jianhe Jian He added a comment - Committed to trunk, branch-2, branch-2.8 Thanks Akira Ajisaka , Wangda Tan !
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 29s Maven dependency ordering for branch
        +1 mvninstall 9m 21s trunk passed
        +1 compile 6m 39s trunk passed
        +1 checkstyle 0m 58s trunk passed
        +1 mvnsite 3m 9s trunk passed
        +1 mvneclipse 1m 37s trunk passed
        +1 findbugs 4m 37s trunk passed
        +1 javadoc 2m 6s trunk passed
        0 mvndep 0m 13s Maven dependency ordering for patch
        +1 mvninstall 2m 13s the patch passed
        +1 compile 5m 51s the patch passed
        +1 javac 5m 51s the patch passed
        -0 checkstyle 0m 53s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 93 unchanged - 1 fixed = 94 total (was 94)
        +1 mvnsite 2m 51s the patch passed
        +1 mvneclipse 1m 39s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 5m 7s the patch passed
        +1 javadoc 1m 51s the patch passed
        +1 unit 0m 31s hadoop-yarn-api in the patch passed.
        +1 unit 2m 28s hadoop-yarn-common in the patch passed.
        -1 unit 43m 0s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 unit 16m 23s hadoop-yarn-client in the patch passed.
        +1 asflicense 0m 30s The patch does not generate ASF License warnings.
        121m 45s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5559
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841652/YARN-5559.8.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 501c1173f56a 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f885160
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14182/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14182/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14182/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14182/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 29s Maven dependency ordering for branch +1 mvninstall 9m 21s trunk passed +1 compile 6m 39s trunk passed +1 checkstyle 0m 58s trunk passed +1 mvnsite 3m 9s trunk passed +1 mvneclipse 1m 37s trunk passed +1 findbugs 4m 37s trunk passed +1 javadoc 2m 6s trunk passed 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 2m 13s the patch passed +1 compile 5m 51s the patch passed +1 javac 5m 51s the patch passed -0 checkstyle 0m 53s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 93 unchanged - 1 fixed = 94 total (was 94) +1 mvnsite 2m 51s the patch passed +1 mvneclipse 1m 39s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 5m 7s the patch passed +1 javadoc 1m 51s the patch passed +1 unit 0m 31s hadoop-yarn-api in the patch passed. +1 unit 2m 28s hadoop-yarn-common in the patch passed. -1 unit 43m 0s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 16m 23s hadoop-yarn-client in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 121m 45s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5559 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841652/YARN-5559.8.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 501c1173f56a 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f885160 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14182/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14182/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14182/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14182/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        08 patch: fixed findbugs warnings

        Show
        ajisakaa Akira Ajisaka added a comment - 08 patch: fixed findbugs warnings
        Hide
        jianhe Jian He added a comment -

        Akira Ajisaka, mind check the findbugs warning?

        Show
        jianhe Jian He added a comment - Akira Ajisaka , mind check the findbugs warning?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 36s Maven dependency ordering for branch
        +1 mvninstall 6m 57s trunk passed
        +1 compile 4m 52s trunk passed
        +1 checkstyle 0m 44s trunk passed
        +1 mvnsite 2m 24s trunk passed
        +1 mvneclipse 1m 18s trunk passed
        +1 findbugs 3m 52s trunk passed
        +1 javadoc 1m 44s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 2m 6s the patch passed
        +1 compile 10m 29s the patch passed
        +1 javac 10m 29s the patch passed
        -0 checkstyle 2m 4s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 93 unchanged - 1 fixed = 94 total (was 94)
        +1 mvnsite 3m 23s the patch passed
        +1 mvneclipse 1m 16s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 1m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
        +1 javadoc 1m 39s the patch passed
        +1 unit 0m 31s hadoop-yarn-api in the patch passed.
        +1 unit 2m 23s hadoop-yarn-common in the patch passed.
        -1 unit 40m 4s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 unit 16m 5s hadoop-yarn-client in the patch passed.
        +1 asflicense 0m 31s The patch does not generate ASF License warnings.
        116m 8s



        Reason Tests
        FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
          Inconsistent synchronization of org.apache.hadoop.yarn.api.protocolrecords.impl.pb.GetClusterNodeLabelsResponsePBImpl.builder; locked 44% of time Unsynchronized access at GetClusterNodeLabelsResponsePBImpl.java:44% of time Unsynchronized access at GetClusterNodeLabelsResponsePBImpl.java:[line 62]
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5559
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841607/YARN-5559.7.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 73cb8e9b4e71 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f885160
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14177/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14177/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14177/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14177/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14177/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 36s Maven dependency ordering for branch +1 mvninstall 6m 57s trunk passed +1 compile 4m 52s trunk passed +1 checkstyle 0m 44s trunk passed +1 mvnsite 2m 24s trunk passed +1 mvneclipse 1m 18s trunk passed +1 findbugs 3m 52s trunk passed +1 javadoc 1m 44s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 2m 6s the patch passed +1 compile 10m 29s the patch passed +1 javac 10m 29s the patch passed -0 checkstyle 2m 4s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 93 unchanged - 1 fixed = 94 total (was 94) +1 mvnsite 3m 23s the patch passed +1 mvneclipse 1m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 1m 39s the patch passed +1 unit 0m 31s hadoop-yarn-api in the patch passed. +1 unit 2m 23s hadoop-yarn-common in the patch passed. -1 unit 40m 4s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 16m 5s hadoop-yarn-client in the patch passed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 116m 8s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common   Inconsistent synchronization of org.apache.hadoop.yarn.api.protocolrecords.impl.pb.GetClusterNodeLabelsResponsePBImpl.builder; locked 44% of time Unsynchronized access at GetClusterNodeLabelsResponsePBImpl.java:44% of time Unsynchronized access at GetClusterNodeLabelsResponsePBImpl.java: [line 62] Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5559 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841607/YARN-5559.7.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 73cb8e9b4e71 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f885160 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14177/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14177/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html unit https://builds.apache.org/job/PreCommit-YARN-Build/14177/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14177/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14177/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        07 patch: reflected Jian's comment.

        Show
        ajisakaa Akira Ajisaka added a comment - 07 patch: reflected Jian's comment.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Jian He for the review. Agreed to synchronize these methods and return a usual list.

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Jian He for the review. Agreed to synchronize these methods and return a usual list.
        Hide
        jianhe Jian He added a comment -

        Akira Ajisaka, the patch looks good to me, only that I saw CopyOnWriteArrayList is used for NodeLabel list.
        This list will be returned to user code in the getNodeLabelList(), and it has some uncommon characteristics like certain operations on the iterator is not supported, I wonder whether it's better to return a usual list and synchronize these methods directly ?

        Show
        jianhe Jian He added a comment - Akira Ajisaka , the patch looks good to me, only that I saw CopyOnWriteArrayList is used for NodeLabel list. This list will be returned to user code in the getNodeLabelList(), and it has some uncommon characteristics like certain operations on the iterator is not supported, I wonder whether it's better to return a usual list and synchronize these methods directly ?
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 10s Maven dependency ordering for branch
        +1 mvninstall 8m 33s trunk passed
        +1 compile 5m 31s trunk passed
        +1 checkstyle 0m 44s trunk passed
        +1 mvnsite 2m 30s trunk passed
        +1 mvneclipse 1m 21s trunk passed
        +1 findbugs 4m 25s trunk passed
        +1 javadoc 1m 54s trunk passed
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 1m 58s the patch passed
        +1 compile 4m 41s the patch passed
        +1 javac 4m 41s the patch passed
        -0 checkstyle 0m 48s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 93 unchanged - 1 fixed = 94 total (was 94)
        +1 mvnsite 2m 17s the patch passed
        +1 mvneclipse 1m 20s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 4m 44s the patch passed
        +1 javadoc 1m 40s the patch passed
        +1 unit 0m 31s hadoop-yarn-api in the patch passed.
        +1 unit 2m 27s hadoop-yarn-common in the patch passed.
        +1 unit 43m 22s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 unit 16m 26s hadoop-yarn-client in the patch passed.
        +1 asflicense 0m 30s The patch does not generate ASF License warnings.
        114m 57s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5559
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841205/YARN-5559.6.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 506728f103fa 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1f7613b
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14140/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14140/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14140/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 8m 33s trunk passed +1 compile 5m 31s trunk passed +1 checkstyle 0m 44s trunk passed +1 mvnsite 2m 30s trunk passed +1 mvneclipse 1m 21s trunk passed +1 findbugs 4m 25s trunk passed +1 javadoc 1m 54s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 58s the patch passed +1 compile 4m 41s the patch passed +1 javac 4m 41s the patch passed -0 checkstyle 0m 48s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 93 unchanged - 1 fixed = 94 total (was 94) +1 mvnsite 2m 17s the patch passed +1 mvneclipse 1m 20s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 44s the patch passed +1 javadoc 1m 40s the patch passed +1 unit 0m 31s hadoop-yarn-api in the patch passed. +1 unit 2m 27s hadoop-yarn-common in the patch passed. +1 unit 43m 22s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 16m 26s hadoop-yarn-client in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 114m 57s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5559 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841205/YARN-5559.6.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 506728f103fa 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1f7613b Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14140/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14140/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14140/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        GetClusterNodeLabelsResponsePBImpl is not thread safe. Changing the implementation of the list to CopyOnWriteArrayList.

        Detail: getNodeLabels method iterates updateNodeLabels, and setNodeLabelList method calls updateNodeLabels.addAll. If the two methods are called at the same time, ConcurrentModificationException can happen.

        Show
        ajisakaa Akira Ajisaka added a comment - GetClusterNodeLabelsResponsePBImpl is not thread safe. Changing the implementation of the list to CopyOnWriteArrayList. Detail: getNodeLabels method iterates updateNodeLabels , and setNodeLabelList method calls updateNodeLabels.addAll . If the two methods are called at the same time, ConcurrentModificationException can happen.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Jian He for the review!
        06 patch:

        • Fixed javac and checkstyle warnings
        • Renamed get/setNodeLabelsList to get/setNodeLabelList
        • Changed the name of the local variable in GetClusterNodeLabelsResponse#newInstance: request -> response
        • GetClusterNodeLabelsResponsePBImpl#getNodeLabels calls getNodeLabelsList twice. Made it once.
        • GetClusterNodeLabelsResponsePBImpl is not thread safe. Changing the implementation of the list to CopyOnWriteArrayList.
        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Jian He for the review! 06 patch: Fixed javac and checkstyle warnings Renamed get/setNodeLabelsList to get/setNodeLabelList Changed the name of the local variable in GetClusterNodeLabelsResponse#newInstance: request -> response GetClusterNodeLabelsResponsePBImpl#getNodeLabels calls getNodeLabelsList twice. Made it once. GetClusterNodeLabelsResponsePBImpl is not thread safe. Changing the implementation of the list to CopyOnWriteArrayList.
        Hide
        jianhe Jian He added a comment -

        sorry, I meant get/setNodeLabelList ... no 's'.. would you also if the jenkins warnings are related

        Show
        jianhe Jian He added a comment - sorry, I meant get/setNodeLabelList ... no 's'.. would you also if the jenkins warnings are related
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 22m 31s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 51s Maven dependency ordering for branch
        +1 mvninstall 8m 26s trunk passed
        +1 compile 5m 36s trunk passed
        +1 checkstyle 0m 46s trunk passed
        +1 mvnsite 2m 25s trunk passed
        +1 mvneclipse 1m 23s trunk passed
        +1 findbugs 4m 15s trunk passed
        +1 javadoc 1m 55s trunk passed
        0 mvndep 0m 12s Maven dependency ordering for patch
        +1 mvninstall 2m 6s the patch passed
        +1 compile 5m 5s the patch passed
        -1 javac 5m 5s hadoop-yarn-project_hadoop-yarn generated 1 new + 37 unchanged - 0 fixed = 38 total (was 37)
        -0 checkstyle 0m 44s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 93 unchanged - 1 fixed = 95 total (was 94)
        +1 mvnsite 2m 29s the patch passed
        +1 mvneclipse 1m 23s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 4m 36s the patch passed
        -1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 4 new + 123 unchanged - 0 fixed = 127 total (was 123)
        -1 javadoc 0m 34s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 10 new + 4579 unchanged - 0 fixed = 4589 total (was 4579)
        +1 unit 0m 33s hadoop-yarn-api in the patch passed.
        +1 unit 2m 40s hadoop-yarn-common in the patch passed.
        -1 unit 44m 56s hadoop-yarn-server-resourcemanager in the patch failed.
        -1 unit 17m 2s hadoop-yarn-client in the patch failed.
        +1 asflicense 0m 40s The patch does not generate ASF License warnings.
        140m 59s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
          hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
          hadoop.yarn.server.resourcemanager.scheduler.fair.TestContinuousScheduling
          hadoop.yarn.client.api.impl.TestAMRMProxy



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5559
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840996/YARN-5559.5.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8998323b4b5d 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / aeecfa2
        Default Java 1.8.0_111
        findbugs v3.0.0
        javac https://builds.apache.org/job/PreCommit-YARN-Build/14117/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14117/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14117/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14117/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14117/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14117/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14117/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14117/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 22m 31s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 51s Maven dependency ordering for branch +1 mvninstall 8m 26s trunk passed +1 compile 5m 36s trunk passed +1 checkstyle 0m 46s trunk passed +1 mvnsite 2m 25s trunk passed +1 mvneclipse 1m 23s trunk passed +1 findbugs 4m 15s trunk passed +1 javadoc 1m 55s trunk passed 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 2m 6s the patch passed +1 compile 5m 5s the patch passed -1 javac 5m 5s hadoop-yarn-project_hadoop-yarn generated 1 new + 37 unchanged - 0 fixed = 38 total (was 37) -0 checkstyle 0m 44s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 93 unchanged - 1 fixed = 95 total (was 94) +1 mvnsite 2m 29s the patch passed +1 mvneclipse 1m 23s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 36s the patch passed -1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 4 new + 123 unchanged - 0 fixed = 127 total (was 123) -1 javadoc 0m 34s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 10 new + 4579 unchanged - 0 fixed = 4589 total (was 4579) +1 unit 0m 33s hadoop-yarn-api in the patch passed. +1 unit 2m 40s hadoop-yarn-common in the patch passed. -1 unit 44m 56s hadoop-yarn-server-resourcemanager in the patch failed. -1 unit 17m 2s hadoop-yarn-client in the patch failed. +1 asflicense 0m 40s The patch does not generate ASF License warnings. 140m 59s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer   hadoop.yarn.server.resourcemanager.scheduler.fair.TestContinuousScheduling   hadoop.yarn.client.api.impl.TestAMRMProxy Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5559 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840996/YARN-5559.5.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8998323b4b5d 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / aeecfa2 Default Java 1.8.0_111 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-YARN-Build/14117/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14117/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14117/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14117/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14117/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14117/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14117/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14117/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 11s Maven dependency ordering for branch
        +1 mvninstall 7m 50s trunk passed
        +1 compile 5m 22s trunk passed
        +1 checkstyle 0m 49s trunk passed
        +1 mvnsite 2m 25s trunk passed
        +1 mvneclipse 1m 23s trunk passed
        +1 findbugs 4m 6s trunk passed
        +1 javadoc 1m 52s trunk passed
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 1m 54s the patch passed
        +1 compile 4m 52s the patch passed
        -1 javac 4m 52s hadoop-yarn-project_hadoop-yarn generated 1 new + 37 unchanged - 0 fixed = 38 total (was 37)
        -0 checkstyle 0m 46s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 93 unchanged - 1 fixed = 95 total (was 94)
        +1 mvnsite 2m 21s the patch passed
        +1 mvneclipse 1m 18s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 4m 20s the patch passed
        -1 javadoc 0m 21s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 4 new + 123 unchanged - 0 fixed = 127 total (was 123)
        -1 javadoc 0m 32s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 10 new + 4579 unchanged - 0 fixed = 4589 total (was 4579)
        +1 unit 0m 32s hadoop-yarn-api in the patch passed.
        +1 unit 2m 30s hadoop-yarn-common in the patch passed.
        -1 unit 39m 6s hadoop-yarn-server-resourcemanager in the patch failed.
        -1 unit 16m 21s hadoop-yarn-client in the patch failed.
        +1 asflicense 0m 31s The patch does not generate ASF License warnings.
        109m 10s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
          hadoop.yarn.client.api.impl.TestAMRMClient



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5559
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840996/YARN-5559.5.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 49df6a5b8fd6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / aeecfa2
        Default Java 1.8.0_111
        findbugs v3.0.0
        javac https://builds.apache.org/job/PreCommit-YARN-Build/14118/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14118/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14118/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14118/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14118/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14118/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14118/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14118/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 7m 50s trunk passed +1 compile 5m 22s trunk passed +1 checkstyle 0m 49s trunk passed +1 mvnsite 2m 25s trunk passed +1 mvneclipse 1m 23s trunk passed +1 findbugs 4m 6s trunk passed +1 javadoc 1m 52s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 54s the patch passed +1 compile 4m 52s the patch passed -1 javac 4m 52s hadoop-yarn-project_hadoop-yarn generated 1 new + 37 unchanged - 0 fixed = 38 total (was 37) -0 checkstyle 0m 46s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 93 unchanged - 1 fixed = 95 total (was 94) +1 mvnsite 2m 21s the patch passed +1 mvneclipse 1m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 20s the patch passed -1 javadoc 0m 21s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 4 new + 123 unchanged - 0 fixed = 127 total (was 123) -1 javadoc 0m 32s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 10 new + 4579 unchanged - 0 fixed = 4589 total (was 4579) +1 unit 0m 32s hadoop-yarn-api in the patch passed. +1 unit 2m 30s hadoop-yarn-common in the patch passed. -1 unit 39m 6s hadoop-yarn-server-resourcemanager in the patch failed. -1 unit 16m 21s hadoop-yarn-client in the patch failed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 109m 10s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.client.api.impl.TestAMRMClient Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5559 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840996/YARN-5559.5.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 49df6a5b8fd6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / aeecfa2 Default Java 1.8.0_111 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-YARN-Build/14118/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14118/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14118/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14118/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14118/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14118/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14118/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14118/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 docker 22m 23s Docker failed to build yetus/hadoop:a9ad5d6.



        Subsystem Report/Notes
        JIRA Issue YARN-5559
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840992/YARN-5559.4.patch
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14115/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 22m 23s Docker failed to build yetus/hadoop:a9ad5d6. Subsystem Report/Notes JIRA Issue YARN-5559 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840992/YARN-5559.4.patch Console output https://builds.apache.org/job/PreCommit-YARN-Build/14115/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        05 patch: made setNodeLabels(List<NodeLabel>) to setNodeLabelsList(List<NodeLabel>).

        Show
        ajisakaa Akira Ajisaka added a comment - 05 patch: made setNodeLabels(List<NodeLabel>) to setNodeLabelsList(List<NodeLabel>).
        Hide
        jianhe Jian He added a comment -

        we can make setNodeLabels(List<NodeLabel>) to setNodeLabelsList(List<NodeLabel>

        sounds good, how about call it 'getNodeLabelList' and 'setNodeLabelList' ?

        Show
        jianhe Jian He added a comment - we can make setNodeLabels(List<NodeLabel>) to setNodeLabelsList(List<NodeLabel> sounds good, how about call it 'getNodeLabelList' and 'setNodeLabelList' ?
        Hide
        ajisakaa Akira Ajisaka added a comment -

        04 patch: Removed the change in YarnConfiguration.

        Show
        ajisakaa Akira Ajisaka added a comment - 04 patch: Removed the change in YarnConfiguration.
        Hide
        ajisakaa Akira Ajisaka added a comment - - edited

        Found that the getter/setter name is inconsistent, make it set/getNodeLabels ?

        public abstract Set<NodeLabel> getNodeLabels() already exists, so we cannot make getNodeLabelsList() to getNodeLabels(). Instead, we can make setNodeLabels(List<NodeLabel>) to setNodeLabelsList(List<NodeLabel>). What do you think?

        I still think we don't need to add back this config, it is only used by RM's own code, user code is not using this. your opinion ?

        Agreed.

        Show
        ajisakaa Akira Ajisaka added a comment - - edited Found that the getter/setter name is inconsistent, make it set/getNodeLabels ? public abstract Set<NodeLabel> getNodeLabels() already exists, so we cannot make getNodeLabelsList() to getNodeLabels() . Instead, we can make setNodeLabels(List<NodeLabel>) to setNodeLabelsList(List<NodeLabel>) . What do you think? I still think we don't need to add back this config, it is only used by RM's own code, user code is not using this. your opinion ? Agreed.
        Hide
        jianhe Jian He added a comment -

        Thanks for updating !

        • Found that the getter/setter name is inconsistent, make it set/getNodeLabels ?
            public abstract void setNodeLabels(List<NodeLabel> labels);
            public abstract List<NodeLabel> getNodeLabelsList();
          
        • I still think we don't need to add back this config, it is only used by RM's own code, user code is not using this. your opinion ?
            @Deprecated
            public static final String RM_NODEMANAGER_CONNECT_RETIRES =
                RM_NODEMANAGER_CONNECT_RETRIES;
          
        Show
        jianhe Jian He added a comment - Thanks for updating ! Found that the getter/setter name is inconsistent, make it set/getNodeLabels ? public abstract void setNodeLabels(List<NodeLabel> labels); public abstract List<NodeLabel> getNodeLabelsList(); I still think we don't need to add back this config, it is only used by RM's own code, user code is not using this. your opinion ? @Deprecated public static final String RM_NODEMANAGER_CONNECT_RETIRES = RM_NODEMANAGER_CONNECT_RETRIES;
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 9s Maven dependency ordering for branch
        +1 mvninstall 6m 49s trunk passed
        +1 compile 5m 5s trunk passed
        +1 checkstyle 0m 48s trunk passed
        +1 mvnsite 2m 23s trunk passed
        +1 mvneclipse 1m 20s trunk passed
        +1 findbugs 3m 49s trunk passed
        +1 javadoc 1m 46s trunk passed
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 1m 41s the patch passed
        +1 compile 4m 36s the patch passed
        -1 javac 4m 36s hadoop-yarn-project_hadoop-yarn generated 1 new + 37 unchanged - 0 fixed = 38 total (was 37)
        -0 checkstyle 0m 47s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 299 unchanged - 0 fixed = 301 total (was 299)
        +1 mvnsite 2m 16s the patch passed
        +1 mvneclipse 1m 17s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 4m 18s the patch passed
        -1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 4 new + 123 unchanged - 0 fixed = 127 total (was 123)
        -1 javadoc 0m 32s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 10 new + 4579 unchanged - 0 fixed = 4589 total (was 4579)
        +1 unit 0m 32s hadoop-yarn-api in the patch passed.
        +1 unit 2m 26s hadoop-yarn-common in the patch passed.
        -1 unit 42m 35s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 unit 16m 29s hadoop-yarn-client in the patch passed.
        +1 asflicense 0m 29s The patch does not generate ASF License warnings.
        110m 23s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5559
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840832/YARN-5559.3.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 56e757aa6f7a 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0945125
        Default Java 1.8.0_111
        findbugs v3.0.0
        javac https://builds.apache.org/job/PreCommit-YARN-Build/14096/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14096/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14096/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14096/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/14096/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14096/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14096/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 6m 49s trunk passed +1 compile 5m 5s trunk passed +1 checkstyle 0m 48s trunk passed +1 mvnsite 2m 23s trunk passed +1 mvneclipse 1m 20s trunk passed +1 findbugs 3m 49s trunk passed +1 javadoc 1m 46s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 41s the patch passed +1 compile 4m 36s the patch passed -1 javac 4m 36s hadoop-yarn-project_hadoop-yarn generated 1 new + 37 unchanged - 0 fixed = 38 total (was 37) -0 checkstyle 0m 47s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 299 unchanged - 0 fixed = 301 total (was 299) +1 mvnsite 2m 16s the patch passed +1 mvneclipse 1m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 18s the patch passed -1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 4 new + 123 unchanged - 0 fixed = 127 total (was 123) -1 javadoc 0m 32s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 10 new + 4579 unchanged - 0 fixed = 4589 total (was 4579) +1 unit 0m 32s hadoop-yarn-api in the patch passed. +1 unit 2m 26s hadoop-yarn-common in the patch passed. -1 unit 42m 35s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 16m 29s hadoop-yarn-client in the patch passed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 110m 23s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5559 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840832/YARN-5559.3.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 56e757aa6f7a 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0945125 Default Java 1.8.0_111 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-YARN-Build/14096/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14096/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14096/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14096/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14096/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14096/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14096/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        03 patch: Fixed checkstyle issue.

        Show
        ajisakaa Akira Ajisaka added a comment - 03 patch: Fixed checkstyle issue.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        02 patch: Addressed my previous comment.

        Show
        ajisakaa Akira Ajisaka added a comment - 02 patch: Addressed my previous comment.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        3) One of ContainerTokenIdentifier newInstance method removed

        YARN-2581 (fixed in 2.6.0)

        Sorry, YARN-3354 is the correct and this issue was fixed in Hadoop 2.8.0. Therefore we don't need to provide a patch for branch-2.6/2.7.

        Show
        ajisakaa Akira Ajisaka added a comment - 3) One of ContainerTokenIdentifier newInstance method removed YARN-2581 (fixed in 2.6.0) Sorry, YARN-3354 is the correct and this issue was fixed in Hadoop 2.8.0. Therefore we don't need to provide a patch for branch-2.6/2.7.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, thanks Jian He and Junping Du.

        Show
        ajisakaa Akira Ajisaka added a comment - +1, thanks Jian He and Junping Du .
        Hide
        djp Junping Du added a comment -

        I think we can use this single jira and upload two patches one for branch-2/trunk and one for branch-2.6?

        +1 on this proposal. Akira Ajisaka, what do you think?

        Show
        djp Junping Du added a comment - I think we can use this single jira and upload two patches one for branch-2/trunk and one for branch-2.6? +1 on this proposal. Akira Ajisaka , what do you think?
        Hide
        jianhe Jian He added a comment -

        Akira Ajisaka, wangda is off for a while. would you like to update the patch according to your comments? I can commit it.

        I'm thinking we should separate the patch into (3) and the rest. (3) should be fixed in branch-2.6 and above.

        I think we can use this single jira and upload two patches one for branch-2/trunk and one for branch-2.6 ?

        Show
        jianhe Jian He added a comment - Akira Ajisaka , wangda is off for a while. would you like to update the patch according to your comments? I can commit it. I'm thinking we should separate the patch into (3) and the rest. (3) should be fixed in branch-2.6 and above. I think we can use this single jira and upload two patches one for branch-2/trunk and one for branch-2.6 ?
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Ping Wangda Tan. How is this issue going on?

        Show
        ajisakaa Akira Ajisaka added a comment - Ping Wangda Tan . How is this issue going on?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 27m 32s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 12s Maven dependency ordering for branch
        +1 mvninstall 9m 12s trunk passed
        +1 compile 6m 41s trunk passed
        +1 checkstyle 0m 58s trunk passed
        +1 mvnsite 3m 6s trunk passed
        +1 mvneclipse 1m 39s trunk passed
        +1 findbugs 4m 38s trunk passed
        +1 javadoc 2m 6s trunk passed
        0 mvndep 0m 12s Maven dependency ordering for patch
        +1 mvninstall 2m 16s the patch passed
        +1 compile 5m 43s the patch passed
        -1 javac 5m 43s hadoop-yarn-project_hadoop-yarn generated 1 new + 34 unchanged - 0 fixed = 35 total (was 34)
        -0 checkstyle 0m 56s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 299 unchanged - 0 fixed = 301 total (was 299)
        +1 mvnsite 2m 47s the patch passed
        +1 mvneclipse 1m 32s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 5m 12s the patch passed
        +1 javadoc 1m 47s the patch passed
        +1 unit 0m 31s hadoop-yarn-api in the patch passed.
        +1 unit 2m 23s hadoop-yarn-common in the patch passed.
        +1 unit 43m 41s hadoop-yarn-server-resourcemanager in the patch passed.
        -1 unit 1m 3s hadoop-yarn-client in the patch failed.
        +1 asflicense 0m 29s The patch does not generate ASF License warnings.
        133m 32s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-5559
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825337/YARN-5559.1.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8589bfb9fd8a 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 59bfcbf
        Default Java 1.8.0_111
        findbugs v3.0.0
        javac https://builds.apache.org/job/PreCommit-YARN-Build/13944/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13944/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/13944/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13944/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13944/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 27m 32s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 12s Maven dependency ordering for branch +1 mvninstall 9m 12s trunk passed +1 compile 6m 41s trunk passed +1 checkstyle 0m 58s trunk passed +1 mvnsite 3m 6s trunk passed +1 mvneclipse 1m 39s trunk passed +1 findbugs 4m 38s trunk passed +1 javadoc 2m 6s trunk passed 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 2m 16s the patch passed +1 compile 5m 43s the patch passed -1 javac 5m 43s hadoop-yarn-project_hadoop-yarn generated 1 new + 34 unchanged - 0 fixed = 35 total (was 34) -0 checkstyle 0m 56s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 299 unchanged - 0 fixed = 301 total (was 299) +1 mvnsite 2m 47s the patch passed +1 mvneclipse 1m 32s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 5m 12s the patch passed +1 javadoc 1m 47s the patch passed +1 unit 0m 31s hadoop-yarn-api in the patch passed. +1 unit 2m 23s hadoop-yarn-common in the patch passed. +1 unit 43m 41s hadoop-yarn-server-resourcemanager in the patch passed. -1 unit 1m 3s hadoop-yarn-client in the patch failed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 133m 32s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5559 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825337/YARN-5559.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8589bfb9fd8a 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 59bfcbf Default Java 1.8.0_111 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-YARN-Build/13944/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13944/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13944/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13944/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13944/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Ping, seems like this patch is pretty close? Can we get it committed?

        Show
        andrew.wang Andrew Wang added a comment - Ping, seems like this patch is pretty close? Can we get it committed?
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Additional comment: Would you add javadoc to document the replacements when deprecating APIs?

        Show
        ajisakaa Akira Ajisaka added a comment - Additional comment: Would you add javadoc to document the replacements when deprecating APIs?
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Mostly looks good to me. I checked what issue broke the compatibility.

        1) Incompatible changes in GetClusterNodeLabelResponse.java (signature changed)

        YARN-3413 (fixed in 2.8.0)

        3) One of ContainerTokenIdentifier newInstance method removed

        YARN-2581 (fixed in 2.6.0)

        I'm thinking we should separate the patch into (3) and the rest. (3) should be fixed in branch-2.6 and above.

        Show
        ajisakaa Akira Ajisaka added a comment - Mostly looks good to me. I checked what issue broke the compatibility. 1) Incompatible changes in GetClusterNodeLabelResponse.java (signature changed) YARN-3413 (fixed in 2.8.0) 3) One of ContainerTokenIdentifier newInstance method removed YARN-2581 (fixed in 2.6.0) I'm thinking we should separate the patch into (3) and the rest. (3) should be fixed in branch-2.6 and above.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Jian He, since they're all marked as @Public/@Stable, which is not correct, but we still should not make such changes.
        @Evolving should not broken in practices as well.

        Please let me know about your thoughts.

        Show
        leftnoteasy Wangda Tan added a comment - Jian He , since they're all marked as @Public/@Stable , which is not correct, but we still should not make such changes. @Evolving should not broken in practices as well. Please let me know about your thoughts.
        Hide
        jianhe Jian He added a comment -
        • Do we need the change in GetClusterNodeLabelsResponse ? it’s evolving. it should be fine to change the signature ? Also, the newInstance method is not user-facing.
        • I think adding back this config is not needed, it’s used by RM only.
            @Deprecated
            public static final String RM_NODEMANAGER_CONNECT_RETIRES =
                RM_NODEMANAGER_CONNECT_RETRIES;
          
          
        Show
        jianhe Jian He added a comment - Do we need the change in GetClusterNodeLabelsResponse ? it’s evolving. it should be fine to change the signature ? Also, the newInstance method is not user-facing. I think adding back this config is not needed, it’s used by RM only. @Deprecated public static final String RM_NODEMANAGER_CONNECT_RETIRES = RM_NODEMANAGER_CONNECT_RETRIES;
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 10s Maven dependency ordering for branch
        +1 mvninstall 7m 26s trunk passed
        +1 compile 2m 18s trunk passed
        +1 checkstyle 0m 41s trunk passed
        +1 mvnsite 1m 57s trunk passed
        +1 mvneclipse 0m 56s trunk passed
        +1 findbugs 3m 19s trunk passed
        +1 javadoc 1m 21s trunk passed
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 1m 35s the patch passed
        +1 compile 2m 14s the patch passed
        -1 javac 2m 14s hadoop-yarn-project_hadoop-yarn generated 1 new + 35 unchanged - 0 fixed = 36 total (was 35)
        -1 checkstyle 0m 39s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 303 unchanged - 0 fixed = 305 total (was 303)
        +1 mvnsite 1m 50s the patch passed
        +1 mvneclipse 0m 50s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 41s the patch passed
        +1 javadoc 1m 13s the patch passed
        +1 unit 0m 23s hadoop-yarn-api in the patch passed.
        +1 unit 2m 18s hadoop-yarn-common in the patch passed.
        +1 unit 37m 52s hadoop-yarn-server-resourcemanager in the patch passed.
        -1 unit 16m 27s hadoop-yarn-client in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        89m 1s



        Reason Tests
        Failed junit tests hadoop.yarn.client.api.impl.TestAMRMProxy
          hadoop.yarn.client.api.impl.TestYarnClient



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825337/YARN-5559.1.patch
        JIRA Issue YARN-5559
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux d7c03be3c90e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a1f3293
        Default Java 1.8.0_101
        findbugs v3.0.0
        javac https://builds.apache.org/job/PreCommit-YARN-Build/12882/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12882/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/12882/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12882/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12882/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12882/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 7m 26s trunk passed +1 compile 2m 18s trunk passed +1 checkstyle 0m 41s trunk passed +1 mvnsite 1m 57s trunk passed +1 mvneclipse 0m 56s trunk passed +1 findbugs 3m 19s trunk passed +1 javadoc 1m 21s trunk passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 35s the patch passed +1 compile 2m 14s the patch passed -1 javac 2m 14s hadoop-yarn-project_hadoop-yarn generated 1 new + 35 unchanged - 0 fixed = 36 total (was 35) -1 checkstyle 0m 39s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 303 unchanged - 0 fixed = 305 total (was 303) +1 mvnsite 1m 50s the patch passed +1 mvneclipse 0m 50s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 41s the patch passed +1 javadoc 1m 13s the patch passed +1 unit 0m 23s hadoop-yarn-api in the patch passed. +1 unit 2m 18s hadoop-yarn-common in the patch passed. +1 unit 37m 52s hadoop-yarn-server-resourcemanager in the patch passed. -1 unit 16m 27s hadoop-yarn-client in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 89m 1s Reason Tests Failed junit tests hadoop.yarn.client.api.impl.TestAMRMProxy   hadoop.yarn.client.api.impl.TestYarnClient Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825337/YARN-5559.1.patch JIRA Issue YARN-5559 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d7c03be3c90e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a1f3293 Default Java 1.8.0_101 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-YARN-Build/12882/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12882/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12882/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12882/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12882/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12882/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Ping related folks:

        Jian He, Harsh J, Brahma Reddy Battula, Akira Ajisaka, Vinod Kumar Vavilapalli to review this patch.

        Thanks!\

        Show
        leftnoteasy Wangda Tan added a comment - Ping related folks: Jian He , Harsh J , Brahma Reddy Battula , Akira Ajisaka , Vinod Kumar Vavilapalli to review this patch. Thanks!\
        Hide
        leftnoteasy Wangda Tan added a comment -

        Attached ver.1 patch for review, it fixed:

        1) Incompatible changes in GetClusterNodeLabelResponse.java (signature changed)

        2) Configuration key variable name changed by HADOOP-12458

        3) One of ContainerTokenIdentifier newInstance method removed

        4) InvalidStateTransitionException changes from YARN-3381
        (The exception class with name fixed should extend the old class).

        Show
        leftnoteasy Wangda Tan added a comment - Attached ver.1 patch for review, it fixed: 1) Incompatible changes in GetClusterNodeLabelResponse.java (signature changed) 2) Configuration key variable name changed by HADOOP-12458 3) One of ContainerTokenIdentifier newInstance method removed 4) InvalidStateTransitionException changes from YARN-3381 (The exception class with name fixed should extend the old class).

          People

          • Assignee:
            ajisakaa Akira Ajisaka
            Reporter:
            leftnoteasy Wangda Tan
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development