Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5552

Add Builder methods for common yarn API records

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently yarn API records such as ResourceRequest, AllocateRequest/Respone as well as AMRMClient.ContainerRequest have multiple constructors / newInstance methods. This makes it very difficult to add new fields to these records.

      It would probably be better if we had Builder classes for many of these records, which would make evolution of these records a bit easier.

      (suggested by Karthik Kambatla)

      1. YARN-5552.000.patch
        31 kB
        Tao Jie
      2. YARN-5552.001.patch
        31 kB
        Tao Jie
      3. YARN-5552.002.patch
        62 kB
        Tao Jie
      4. YARN-5552.003.patch
        32 kB
        Tao Jie
      5. YARN-5552.004.patch
        30 kB
        Tao Jie
      6. YARN-5552.005.patch
        30 kB
        Tao Jie
      7. YARN-5552.006.patch
        34 kB
        Tao Jie
      8. YARN-5552.007.patch
        33 kB
        Tao Jie
      9. YARN-5552.008.patch
        34 kB
        Tao Jie
      10. YARN-5552.009.patch
        39 kB
        Tao Jie

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10824 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10824/)
        YARN-5552. Add Builder methods for common yarn API records. (Tao Jie via (wangda: rev ede1a473f5061cf40f6affc1c8c30a645c1fef6c)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/FiCaSchedulerApp.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceRequest.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/AMRMClient.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/AllocateRequest.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/AllocateResponse.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10824 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10824/ ) YARN-5552 . Add Builder methods for common yarn API records. (Tao Jie via (wangda: rev ede1a473f5061cf40f6affc1c8c30a645c1fef6c) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/FiCaSchedulerApp.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceRequest.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/AMRMClient.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/AllocateRequest.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/AllocateResponse.java
        Hide
        leftnoteasy Wangda Tan added a comment -

        Committed to trunk/branch-2, thanks Tao Jie for working on the patch and thanks Karthik Kambatla for reviewing the patch!

        Show
        leftnoteasy Wangda Tan added a comment - Committed to trunk/branch-2, thanks Tao Jie for working on the patch and thanks Karthik Kambatla for reviewing the patch!
        Hide
        kasha Karthik Kambatla added a comment -

        Eye-balled the changes and they look good to me. Defer to Wangda Tan for a more thorough review.

        Show
        kasha Karthik Kambatla added a comment - Eye-balled the changes and they look good to me. Defer to Wangda Tan for a more thorough review.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Patch looks good, will wait till next Monday before committing. Any other suggestions? Arun Suresh / Karthik Kambatla.

        Show
        leftnoteasy Wangda Tan added a comment - Patch looks good, will wait till next Monday before committing. Any other suggestions? Arun Suresh / Karthik Kambatla .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 9s Maven dependency ordering for branch
        +1 mvninstall 7m 9s trunk passed
        +1 compile 2m 23s trunk passed
        +1 checkstyle 0m 40s trunk passed
        +1 mvnsite 2m 4s trunk passed
        +1 mvneclipse 0m 59s trunk passed
        +1 findbugs 3m 29s trunk passed
        +1 javadoc 1m 23s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 45s the patch passed
        +1 compile 2m 31s the patch passed
        +1 javac 2m 31s the patch passed
        +1 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 109 unchanged - 8 fixed = 109 total (was 117)
        +1 mvnsite 2m 0s the patch passed
        +1 mvneclipse 0m 55s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 52s the patch passed
        +1 javadoc 1m 19s the patch passed
        +1 unit 0m 25s hadoop-yarn-api in the patch passed.
        +1 unit 2m 18s hadoop-yarn-common in the patch passed.
        -1 unit 35m 52s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 unit 16m 24s hadoop-yarn-client in the patch passed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        95m 20s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue YARN-5552
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836714/YARN-5552.009.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f9d578bde5d4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7e521c5
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-YARN-Build/13765/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13765/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13765/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 7m 9s trunk passed +1 compile 2m 23s trunk passed +1 checkstyle 0m 40s trunk passed +1 mvnsite 2m 4s trunk passed +1 mvneclipse 0m 59s trunk passed +1 findbugs 3m 29s trunk passed +1 javadoc 1m 23s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 45s the patch passed +1 compile 2m 31s the patch passed +1 javac 2m 31s the patch passed +1 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 109 unchanged - 8 fixed = 109 total (was 117) +1 mvnsite 2m 0s the patch passed +1 mvneclipse 0m 55s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 52s the patch passed +1 javadoc 1m 19s the patch passed +1 unit 0m 25s hadoop-yarn-api in the patch passed. +1 unit 2m 18s hadoop-yarn-common in the patch passed. -1 unit 35m 52s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 16m 24s hadoop-yarn-client in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 95m 20s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-5552 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836714/YARN-5552.009.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f9d578bde5d4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7e521c5 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/13765/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13765/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13765/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Tao Jie could you check Java docs warnings as well? Our policy is make sure no new java docs warnings added for committed patch.

        Thanks,

        Show
        leftnoteasy Wangda Tan added a comment - Tao Jie could you check Java docs warnings as well? Our policy is make sure no new java docs warnings added for committed patch. Thanks,
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 53s Maven dependency ordering for branch
        +1 mvninstall 6m 52s trunk passed
        +1 compile 2m 28s trunk passed
        +1 checkstyle 0m 42s trunk passed
        +1 mvnsite 2m 8s trunk passed
        +1 mvneclipse 0m 56s trunk passed
        +1 findbugs 3m 38s trunk passed
        +1 javadoc 1m 23s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 42s the patch passed
        +1 compile 2m 27s the patch passed
        +1 javac 2m 27s the patch passed
        +1 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 110 unchanged - 8 fixed = 110 total (was 118)
        +1 mvnsite 2m 1s the patch passed
        +1 mvneclipse 0m 54s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 54s the patch passed
        -1 javadoc 0m 17s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 56 new + 123 unchanged - 0 fixed = 179 total (was 123)
        +1 unit 0m 25s hadoop-yarn-api in the patch passed.
        +1 unit 2m 16s hadoop-yarn-common in the patch passed.
        +1 unit 35m 24s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 unit 16m 3s hadoop-yarn-client in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        94m 56s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue YARN-5552
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836513/YARN-5552.008.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 16a865124b74 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / cb5cc0d
        Default Java 1.8.0_101
        findbugs v3.0.0
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13748/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13748/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13748/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 53s Maven dependency ordering for branch +1 mvninstall 6m 52s trunk passed +1 compile 2m 28s trunk passed +1 checkstyle 0m 42s trunk passed +1 mvnsite 2m 8s trunk passed +1 mvneclipse 0m 56s trunk passed +1 findbugs 3m 38s trunk passed +1 javadoc 1m 23s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 42s the patch passed +1 compile 2m 27s the patch passed +1 javac 2m 27s the patch passed +1 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 110 unchanged - 8 fixed = 110 total (was 118) +1 mvnsite 2m 1s the patch passed +1 mvneclipse 0m 54s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 54s the patch passed -1 javadoc 0m 17s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 56 new + 123 unchanged - 0 fixed = 179 total (was 123) +1 unit 0m 25s hadoop-yarn-api in the patch passed. +1 unit 2m 16s hadoop-yarn-common in the patch passed. +1 unit 35m 24s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 16m 3s hadoop-yarn-client in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 94m 56s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-5552 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836513/YARN-5552.008.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 16a865124b74 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cb5cc0d Default Java 1.8.0_101 findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13748/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13748/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13748/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks Tao Jie, generally looks good.

        Could you also mark AllocateResponse#newBuilder as private and unstable?
        And also, it seems javadocs failure is related to the patch, could you double check?

        Show
        leftnoteasy Wangda Tan added a comment - Thanks Tao Jie , generally looks good. Could you also mark AllocateResponse#newBuilder as private and unstable? And also, it seems javadocs failure is related to the patch, could you double check?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 11s Maven dependency ordering for branch
        +1 mvninstall 6m 59s trunk passed
        +1 compile 2m 19s trunk passed
        +1 checkstyle 0m 40s trunk passed
        +1 mvnsite 2m 1s trunk passed
        +1 mvneclipse 0m 59s trunk passed
        +1 findbugs 3m 34s trunk passed
        +1 javadoc 1m 23s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 43s the patch passed
        +1 compile 2m 24s the patch passed
        +1 javac 2m 24s the patch passed
        +1 checkstyle 0m 40s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 109 unchanged - 8 fixed = 109 total (was 117)
        +1 mvnsite 2m 2s the patch passed
        +1 mvneclipse 0m 56s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 4m 9s the patch passed
        -1 javadoc 0m 18s hadoop-yarn-api in the patch failed.
        +1 unit 0m 27s hadoop-yarn-api in the patch passed.
        +1 unit 2m 19s hadoop-yarn-common in the patch passed.
        +1 unit 40m 28s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 unit 16m 4s hadoop-yarn-client in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        99m 45s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue YARN-5552
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836347/YARN-5552.007.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux faeceec36a20 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5b577f4
        Default Java 1.8.0_101
        findbugs v3.0.0
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13734/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13734/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13734/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 6m 59s trunk passed +1 compile 2m 19s trunk passed +1 checkstyle 0m 40s trunk passed +1 mvnsite 2m 1s trunk passed +1 mvneclipse 0m 59s trunk passed +1 findbugs 3m 34s trunk passed +1 javadoc 1m 23s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 43s the patch passed +1 compile 2m 24s the patch passed +1 javac 2m 24s the patch passed +1 checkstyle 0m 40s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 109 unchanged - 8 fixed = 109 total (was 117) +1 mvnsite 2m 2s the patch passed +1 mvneclipse 0m 56s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 9s the patch passed -1 javadoc 0m 18s hadoop-yarn-api in the patch failed. +1 unit 0m 27s hadoop-yarn-api in the patch passed. +1 unit 2m 19s hadoop-yarn-common in the patch passed. +1 unit 40m 28s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 16m 4s hadoop-yarn-client in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 99m 45s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-5552 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836347/YARN-5552.007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux faeceec36a20 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5b577f4 Default Java 1.8.0_101 findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13734/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13734/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13734/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 9s Maven dependency ordering for branch
        +1 mvninstall 6m 44s trunk passed
        +1 compile 2m 20s trunk passed
        +1 checkstyle 0m 39s trunk passed
        +1 mvnsite 1m 59s trunk passed
        +1 mvneclipse 0m 58s trunk passed
        +1 findbugs 3m 23s trunk passed
        +1 javadoc 1m 24s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 40s the patch passed
        +1 compile 2m 18s the patch passed
        +1 javac 2m 18s the patch passed
        -0 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 39 new + 109 unchanged - 8 fixed = 148 total (was 117)
        +1 mvnsite 1m 57s the patch passed
        +1 mvneclipse 0m 55s the patch passed
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        +1 findbugs 3m 51s the patch passed
        -1 javadoc 0m 17s hadoop-yarn-api in the patch failed.
        -1 javadoc 0m 14s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client generated 16 new + 158 unchanged - 0 fixed = 174 total (was 158)
        +1 unit 0m 25s hadoop-yarn-api in the patch passed.
        +1 unit 2m 17s hadoop-yarn-common in the patch passed.
        +1 unit 38m 29s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 unit 15m 56s hadoop-yarn-client in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        96m 21s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue YARN-5552
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836327/YARN-5552.006.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux fb41009ae70f 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7d2d8d2
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13729/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/13729/artifact/patchprocess/whitespace-eol.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13729/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13729/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13729/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13729/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 6m 44s trunk passed +1 compile 2m 20s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 1m 59s trunk passed +1 mvneclipse 0m 58s trunk passed +1 findbugs 3m 23s trunk passed +1 javadoc 1m 24s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 40s the patch passed +1 compile 2m 18s the patch passed +1 javac 2m 18s the patch passed -0 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 39 new + 109 unchanged - 8 fixed = 148 total (was 117) +1 mvnsite 1m 57s the patch passed +1 mvneclipse 0m 55s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 3m 51s the patch passed -1 javadoc 0m 17s hadoop-yarn-api in the patch failed. -1 javadoc 0m 14s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client generated 16 new + 158 unchanged - 0 fixed = 174 total (was 158) +1 unit 0m 25s hadoop-yarn-api in the patch passed. +1 unit 2m 17s hadoop-yarn-common in the patch passed. +1 unit 38m 29s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 15m 56s hadoop-yarn-client in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 96m 21s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-5552 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836327/YARN-5552.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fb41009ae70f 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7d2d8d2 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13729/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/13729/artifact/patchprocess/whitespace-eol.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13729/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13729/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13729/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13729/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Cancelling the patch based on previous @wangda's comments, which i too agree upon !

        Show
        Naganarasimha Naganarasimha G R added a comment - Cancelling the patch based on previous @wangda's comments, which i too agree upon !
        Hide
        leftnoteasy Wangda Tan added a comment - - edited

        Thanks Tao Jie.

        Few minor comments from my side:

        1) New added methods of AllocateResponse should be all @Private and @Unstable, we should not mark original write-methods of AllocateResponse to @Public at the beginning, the reason is AllocateResponse should be read-only by YARN app, no YARN app should set these fields. YARN services should take care of settings these fields of AllocateResponse.

        2) Can we merge common sanity check logic of ContainerRequestBuilder#build and ContainerRequest#constructor?

        3) For all new added write methods of builder, it's better to add a javadocs link-to reference original method.

        Show
        leftnoteasy Wangda Tan added a comment - - edited Thanks Tao Jie . Few minor comments from my side: 1) New added methods of AllocateResponse should be all @Private and @Unstable, we should not mark original write-methods of AllocateResponse to @Public at the beginning, the reason is AllocateResponse should be read-only by YARN app, no YARN app should set these fields. YARN services should take care of settings these fields of AllocateResponse. 2) Can we merge common sanity check logic of ContainerRequestBuilder#build and ContainerRequest#constructor? 3) For all new added write methods of builder, it's better to add a javadocs link-to reference original method.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 9s Maven dependency ordering for branch
        +1 mvninstall 6m 57s trunk passed
        +1 compile 2m 22s trunk passed
        +1 checkstyle 0m 38s trunk passed
        +1 mvnsite 2m 0s trunk passed
        +1 mvneclipse 0m 56s trunk passed
        +1 findbugs 3m 21s trunk passed
        +1 javadoc 1m 19s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 38s the patch passed
        +1 compile 2m 16s the patch passed
        +1 javac 2m 16s the patch passed
        +1 checkstyle 0m 37s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 108 unchanged - 8 fixed = 108 total (was 116)
        +1 mvnsite 1m 50s the patch passed
        +1 mvneclipse 0m 48s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 50s the patch passed
        +1 javadoc 1m 13s the patch passed
        +1 unit 0m 23s hadoop-yarn-api in the patch passed.
        +1 unit 2m 18s hadoop-yarn-common in the patch passed.
        +1 unit 39m 35s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 unit 16m 14s hadoop-yarn-client in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        90m 12s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833366/YARN-5552.005.patch
        JIRA Issue YARN-5552
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 1e64c4e288c1 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / dbe663d
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13393/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13393/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 6m 57s trunk passed +1 compile 2m 22s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 2m 0s trunk passed +1 mvneclipse 0m 56s trunk passed +1 findbugs 3m 21s trunk passed +1 javadoc 1m 19s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 38s the patch passed +1 compile 2m 16s the patch passed +1 javac 2m 16s the patch passed +1 checkstyle 0m 37s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 108 unchanged - 8 fixed = 108 total (was 116) +1 mvnsite 1m 50s the patch passed +1 mvneclipse 0m 48s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 50s the patch passed +1 javadoc 1m 13s the patch passed +1 unit 0m 23s hadoop-yarn-api in the patch passed. +1 unit 2m 18s hadoop-yarn-common in the patch passed. +1 unit 39m 35s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 16m 14s hadoop-yarn-client in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 90m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833366/YARN-5552.005.patch JIRA Issue YARN-5552 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1e64c4e288c1 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dbe663d Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13393/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13393/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        Tao Jie Tao Jie added a comment -

        Updated the patch according to Wangda Tan's suggestion.
        Arun Suresh, Karthik Kambatla, Wangda Tan would you mind reviewing the latest patch again?

        Show
        Tao Jie Tao Jie added a comment - Updated the patch according to Wangda Tan 's suggestion. Arun Suresh , Karthik Kambatla , Wangda Tan would you mind reviewing the latest patch again?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 9s Maven dependency ordering for branch
        +1 mvninstall 6m 58s trunk passed
        +1 compile 2m 17s trunk passed
        +1 checkstyle 0m 39s trunk passed
        +1 mvnsite 1m 59s trunk passed
        +1 mvneclipse 0m 56s trunk passed
        +1 findbugs 3m 23s trunk passed
        +1 javadoc 1m 21s trunk passed
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 1m 37s the patch passed
        +1 compile 2m 16s the patch passed
        +1 javac 2m 16s the patch passed
        -1 checkstyle 0m 37s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 116 unchanged - 8 fixed = 117 total (was 124)
        +1 mvnsite 1m 56s the patch passed
        +1 mvneclipse 0m 48s the patch passed
        -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 3m 43s the patch passed
        +1 javadoc 1m 22s the patch passed
        +1 unit 0m 27s hadoop-yarn-api in the patch passed.
        -1 unit 2m 35s hadoop-yarn-common in the patch failed.
        -1 unit 36m 37s hadoop-yarn-server-resourcemanager in the patch failed.
        -1 unit 16m 2s hadoop-yarn-client in the patch failed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        87m 31s



        Reason Tests
        Failed junit tests hadoop.yarn.api.TestPBImplRecords
          hadoop.yarn.server.resourcemanager.scheduler.TestSchedulingWithAllocationRequestId
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps
          hadoop.yarn.client.TestYarnApiClasses
          hadoop.yarn.client.api.impl.TestAMRMClient



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833336/YARN-5552.004.patch
        JIRA Issue YARN-5552
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a984406adea5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / dbe663d
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13392/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/13392/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/13392/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/13392/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/13392/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/13392/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/13392/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/13392/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13392/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13392/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 6m 58s trunk passed +1 compile 2m 17s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 1m 59s trunk passed +1 mvneclipse 0m 56s trunk passed +1 findbugs 3m 23s trunk passed +1 javadoc 1m 21s trunk passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 37s the patch passed +1 compile 2m 16s the patch passed +1 javac 2m 16s the patch passed -1 checkstyle 0m 37s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 116 unchanged - 8 fixed = 117 total (was 124) +1 mvnsite 1m 56s the patch passed +1 mvneclipse 0m 48s the patch passed -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 3m 43s the patch passed +1 javadoc 1m 22s the patch passed +1 unit 0m 27s hadoop-yarn-api in the patch passed. -1 unit 2m 35s hadoop-yarn-common in the patch failed. -1 unit 36m 37s hadoop-yarn-server-resourcemanager in the patch failed. -1 unit 16m 2s hadoop-yarn-client in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 87m 31s Reason Tests Failed junit tests hadoop.yarn.api.TestPBImplRecords   hadoop.yarn.server.resourcemanager.scheduler.TestSchedulingWithAllocationRequestId   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps   hadoop.yarn.client.TestYarnApiClasses   hadoop.yarn.client.api.impl.TestAMRMClient Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833336/YARN-5552.004.patch JIRA Issue YARN-5552 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a984406adea5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dbe663d Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13392/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/13392/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13392/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13392/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13392/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/13392/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/13392/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/13392/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13392/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13392/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        Tao Jie Tao Jie added a comment -

        Sure, thank you for your suggestion.

        Show
        Tao Jie Tao Jie added a comment - Sure, thank you for your suggestion.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Tao Jie,

        Storing local variables in builder here is to give a default value for fields and avoid potential NPE. It is better to set default value also in builder constructor like:

        Got it, but I think it's better to set these default fields within a default newInstance() method of -PBImpl.

        Karthik Kambatla,

        Deprecating the old API sounds reasonable. That way, we could stop adding new fields to it.

        Agree.
        Tao Jie, are you agree with it?

        Show
        leftnoteasy Wangda Tan added a comment - Tao Jie , Storing local variables in builder here is to give a default value for fields and avoid potential NPE. It is better to set default value also in builder constructor like: Got it, but I think it's better to set these default fields within a default newInstance() method of -PBImpl. Karthik Kambatla , Deprecating the old API sounds reasonable. That way, we could stop adding new fields to it. Agree. Tao Jie , are you agree with it?
        Hide
        Tao Jie Tao Jie added a comment - - edited

        Thank you for your comment,Wangda Tan!
        Storing local variables in builder here is to give a default value for fields and avoid potential NPE. It is better to set default value also in builder constructor like:

            private ResourceRequestBuilder() {
              ResourceRequest request = Records.newRecord(ResourceRequest.class);
              request.setResourceName(ResourceRequest.ANY);
              request.setPriority(Priority.newInstance(0));
              ...
            }
        
        Show
        Tao Jie Tao Jie added a comment - - edited Thank you for your comment, Wangda Tan ! Storing local variables in builder here is to give a default value for fields and avoid potential NPE. It is better to set default value also in builder constructor like: private ResourceRequestBuilder() { ResourceRequest request = Records.newRecord(ResourceRequest.class); request.setResourceName(ResourceRequest.ANY); request.setPriority(Priority.newInstance(0)); ... }
        Hide
        kasha Karthik Kambatla added a comment -

        Deprecating the old API sounds reasonable. That way, we could stop adding new fields to it.

        Show
        kasha Karthik Kambatla added a comment - Deprecating the old API sounds reasonable. That way, we could stop adding new fields to it.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks Tao Jie working on this.

        I think builder-like API has better readability than newInstance. I also used builder API while drafting YARN-5478.

        But considering overheads to maintain two set of APIs, I think it's better to deprecate the old API. Is that the plan in your mind? Arun Suresh, Karthik Kambatla.

        And one comment to the patch after a overall review:

        • Instead of storing variables locally in the builder, like:
          115	    private Priority priority = Priority.newInstance(0);
          116	    private String resourceName = ResourceRequest.ANY;
          117	    private Resource capability = null;
          

          Is it better to create a fresh record with the Builder constructor, and invoke set... when methods like (priority(...)) is invoked.

        Show
        leftnoteasy Wangda Tan added a comment - Thanks Tao Jie working on this. I think builder-like API has better readability than newInstance. I also used builder API while drafting YARN-5478 . But considering overheads to maintain two set of APIs, I think it's better to deprecate the old API. Is that the plan in your mind? Arun Suresh , Karthik Kambatla . And one comment to the patch after a overall review: Instead of storing variables locally in the builder, like: 115 private Priority priority = Priority.newInstance(0); 116 private String resourceName = ResourceRequest.ANY; 117 private Resource capability = null ; Is it better to create a fresh record with the Builder constructor, and invoke set... when methods like (priority(...)) is invoked.
        Hide
        Tao Jie Tao Jie added a comment -

        Failed testcase passed in my local environment.

        Show
        Tao Jie Tao Jie added a comment - Failed testcase passed in my local environment.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 9s Maven dependency ordering for branch
        +1 mvninstall 6m 55s trunk passed
        +1 compile 2m 24s trunk passed
        +1 checkstyle 0m 38s trunk passed
        +1 mvnsite 2m 2s trunk passed
        +1 mvneclipse 1m 2s trunk passed
        +1 findbugs 3m 29s trunk passed
        +1 javadoc 1m 21s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 39s the patch passed
        +1 compile 2m 23s the patch passed
        +1 javac 2m 23s the patch passed
        -1 checkstyle 0m 37s hadoop-yarn-project/hadoop-yarn: The patch generated 36 new + 115 unchanged - 8 fixed = 151 total (was 123)
        +1 mvnsite 1m 53s the patch passed
        +1 mvneclipse 0m 51s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 0m 38s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
        +1 javadoc 1m 13s the patch passed
        +1 unit 0m 24s hadoop-yarn-api in the patch passed.
        +1 unit 2m 19s hadoop-yarn-common in the patch passed.
        -1 unit 38m 1s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 unit 16m 5s hadoop-yarn-client in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        89m 10s



        Reason Tests
        FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
          org.apache.hadoop.yarn.client.api.AMRMClient$ContainerRequest$ContainerRequestBuilder.nodes(String[]) may expose internal representation by storing an externally mutable object into AMRMClient$ContainerRequest$ContainerRequestBuilder.nodes At AMRMClient.java:by storing an externally mutable object into AMRMClient$ContainerRequest$ContainerRequestBuilder.nodes At AMRMClient.java:[line 398]
          org.apache.hadoop.yarn.client.api.AMRMClient$ContainerRequest$ContainerRequestBuilder.racks(String[]) may expose internal representation by storing an externally mutable object into AMRMClient$ContainerRequest$ContainerRequestBuilder.racks At AMRMClient.java:by storing an externally mutable object into AMRMClient$ContainerRequest$ContainerRequestBuilder.racks At AMRMClient.java:[line 403]
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826755/YARN-5552.003.patch
        JIRA Issue YARN-5552
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 903ea21838c1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0690f09
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13005/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/13005/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.html
        unit https://builds.apache.org/job/PreCommit-YARN-Build/13005/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/13005/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13005/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13005/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 6m 55s trunk passed +1 compile 2m 24s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 2m 2s trunk passed +1 mvneclipse 1m 2s trunk passed +1 findbugs 3m 29s trunk passed +1 javadoc 1m 21s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 39s the patch passed +1 compile 2m 23s the patch passed +1 javac 2m 23s the patch passed -1 checkstyle 0m 37s hadoop-yarn-project/hadoop-yarn: The patch generated 36 new + 115 unchanged - 8 fixed = 151 total (was 123) +1 mvnsite 1m 53s the patch passed +1 mvneclipse 0m 51s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 38s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 javadoc 1m 13s the patch passed +1 unit 0m 24s hadoop-yarn-api in the patch passed. +1 unit 2m 19s hadoop-yarn-common in the patch passed. -1 unit 38m 1s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 16m 5s hadoop-yarn-client in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 89m 10s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client   org.apache.hadoop.yarn.client.api.AMRMClient$ContainerRequest$ContainerRequestBuilder.nodes(String[]) may expose internal representation by storing an externally mutable object into AMRMClient$ContainerRequest$ContainerRequestBuilder.nodes At AMRMClient.java:by storing an externally mutable object into AMRMClient$ContainerRequest$ContainerRequestBuilder.nodes At AMRMClient.java: [line 398]   org.apache.hadoop.yarn.client.api.AMRMClient$ContainerRequest$ContainerRequestBuilder.racks(String[]) may expose internal representation by storing an externally mutable object into AMRMClient$ContainerRequest$ContainerRequestBuilder.racks At AMRMClient.java:by storing an externally mutable object into AMRMClient$ContainerRequest$ContainerRequestBuilder.racks At AMRMClient.java: [line 403] Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826755/YARN-5552.003.patch JIRA Issue YARN-5552 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 903ea21838c1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0690f09 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13005/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/13005/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.html unit https://builds.apache.org/job/PreCommit-YARN-Build/13005/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/13005/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13005/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13005/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        Tao Jie Tao Jie added a comment -

        Attached patch fixed checkstyle and failed test.
        Arun Suresh, Karthik Kambatla, would you mind giving it a review? Thank you!

        Show
        Tao Jie Tao Jie added a comment - Attached patch fixed checkstyle and failed test. Arun Suresh , Karthik Kambatla , would you mind giving it a review? Thank you!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 9s Maven dependency ordering for branch
        +1 mvninstall 6m 53s trunk passed
        +1 compile 2m 23s trunk passed
        +1 checkstyle 0m 41s trunk passed
        +1 mvnsite 2m 0s trunk passed
        +1 mvneclipse 0m 59s trunk passed
        +1 findbugs 3m 12s trunk passed
        +1 javadoc 1m 10s trunk passed
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 1m 39s the patch passed
        +1 compile 2m 19s the patch passed
        +1 javac 2m 19s the patch passed
        -1 checkstyle 0m 40s hadoop-yarn-project/hadoop-yarn: The patch generated 110 new + 210 unchanged - 8 fixed = 320 total (was 218)
        +1 mvnsite 1m 52s the patch passed
        +1 mvneclipse 0m 52s the patch passed
        -1 whitespace 0m 0s The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix.
        -1 findbugs 0m 40s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
        +1 javadoc 1m 3s the patch passed
        +1 unit 0m 24s hadoop-yarn-api in the patch passed.
        -1 unit 13m 25s hadoop-yarn-server-nodemanager in the patch failed.
        -1 unit 38m 43s hadoop-yarn-server-resourcemanager in the patch failed.
        -1 unit 10m 59s hadoop-yarn-client in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        94m 59s



        Reason Tests
        FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
          org.apache.hadoop.yarn.client.api.AMRMClient$ContainerRequest$ContainerRequestBuilder.nodes(String[]) may expose internal representation by storing an externally mutable object into AMRMClient$ContainerRequest$ContainerRequestBuilder.nodes At AMRMClient.java:by storing an externally mutable object into AMRMClient$ContainerRequest$ContainerRequestBuilder.nodes At AMRMClient.java:[line 394]
          org.apache.hadoop.yarn.client.api.AMRMClient$ContainerRequest$ContainerRequestBuilder.racks(String[]) may expose internal representation by storing an externally mutable object into AMRMClient$ContainerRequest$ContainerRequestBuilder.racks At AMRMClient.java:by storing an externally mutable object into AMRMClient$ContainerRequest$ContainerRequestBuilder.racks At AMRMClient.java:[line 399]
        Failed junit tests hadoop.yarn.server.nodemanager.amrmproxy.TestAMRMProxyService
          hadoop.yarn.server.resourcemanager.TestRMRestart
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesHttpStaticUserPermissions
          hadoop.yarn.server.resourcemanager.TestRM
          hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler
          hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps
          hadoop.yarn.server.resourcemanager.TestClientRMService
          hadoop.yarn.client.TestResourceTrackerOnHA
          hadoop.yarn.client.api.impl.TestYarnClient
          hadoop.yarn.client.TestApplicationClientProtocolOnHA
          hadoop.yarn.client.TestApplicationMasterServiceProtocolOnHA
          hadoop.yarn.client.api.async.impl.TestAMRMClientAsync
          hadoop.yarn.client.api.impl.TestAHSClient
          hadoop.yarn.client.TestRMFailover



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826646/YARN-5552.002.patch
        JIRA Issue YARN-5552
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 37510e32cd27 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 08f55cc
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12989/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12989/artifact/patchprocess/whitespace-eol.txt
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12989/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.html
        unit https://builds.apache.org/job/PreCommit-YARN-Build/12989/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/12989/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/12989/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12989/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/12989/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/12989/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12989/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12989/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 6m 53s trunk passed +1 compile 2m 23s trunk passed +1 checkstyle 0m 41s trunk passed +1 mvnsite 2m 0s trunk passed +1 mvneclipse 0m 59s trunk passed +1 findbugs 3m 12s trunk passed +1 javadoc 1m 10s trunk passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 39s the patch passed +1 compile 2m 19s the patch passed +1 javac 2m 19s the patch passed -1 checkstyle 0m 40s hadoop-yarn-project/hadoop-yarn: The patch generated 110 new + 210 unchanged - 8 fixed = 320 total (was 218) +1 mvnsite 1m 52s the patch passed +1 mvneclipse 0m 52s the patch passed -1 whitespace 0m 0s The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 findbugs 0m 40s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 javadoc 1m 3s the patch passed +1 unit 0m 24s hadoop-yarn-api in the patch passed. -1 unit 13m 25s hadoop-yarn-server-nodemanager in the patch failed. -1 unit 38m 43s hadoop-yarn-server-resourcemanager in the patch failed. -1 unit 10m 59s hadoop-yarn-client in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 94m 59s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client   org.apache.hadoop.yarn.client.api.AMRMClient$ContainerRequest$ContainerRequestBuilder.nodes(String[]) may expose internal representation by storing an externally mutable object into AMRMClient$ContainerRequest$ContainerRequestBuilder.nodes At AMRMClient.java:by storing an externally mutable object into AMRMClient$ContainerRequest$ContainerRequestBuilder.nodes At AMRMClient.java: [line 394]   org.apache.hadoop.yarn.client.api.AMRMClient$ContainerRequest$ContainerRequestBuilder.racks(String[]) may expose internal representation by storing an externally mutable object into AMRMClient$ContainerRequest$ContainerRequestBuilder.racks At AMRMClient.java:by storing an externally mutable object into AMRMClient$ContainerRequest$ContainerRequestBuilder.racks At AMRMClient.java: [line 399] Failed junit tests hadoop.yarn.server.nodemanager.amrmproxy.TestAMRMProxyService   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesHttpStaticUserPermissions   hadoop.yarn.server.resourcemanager.TestRM   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps   hadoop.yarn.server.resourcemanager.TestClientRMService   hadoop.yarn.client.TestResourceTrackerOnHA   hadoop.yarn.client.api.impl.TestYarnClient   hadoop.yarn.client.TestApplicationClientProtocolOnHA   hadoop.yarn.client.TestApplicationMasterServiceProtocolOnHA   hadoop.yarn.client.api.async.impl.TestAMRMClientAsync   hadoop.yarn.client.api.impl.TestAHSClient   hadoop.yarn.client.TestRMFailover Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826646/YARN-5552.002.patch JIRA Issue YARN-5552 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 37510e32cd27 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 08f55cc Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12989/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12989/artifact/patchprocess/whitespace-eol.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12989/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.html unit https://builds.apache.org/job/PreCommit-YARN-Build/12989/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12989/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12989/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12989/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/12989/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/12989/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12989/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12989/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        Tao Jie Tao Jie added a comment -

        Rebased the patch.
        And find out api records with quite a few properties and multiple newInstance methods to add builder:
        Container, ApplicationReport, ContainerReport, GetApplicationsRequest

        Show
        Tao Jie Tao Jie added a comment - Rebased the patch. And find out api records with quite a few properties and multiple newInstance methods to add builder: Container, ApplicationReport, ContainerReport, GetApplicationsRequest
        Hide
        Tao Jie Tao Jie added a comment -

        Initialized the patch, added builder for mentioned 4 records.
        constructors and newInstance methods are still retained to keep compatibility.
        Also use builder instead of newInstance somewhere, but not in test yet.

        Show
        Tao Jie Tao Jie added a comment - Initialized the patch, added builder for mentioned 4 records. constructors and newInstance methods are still retained to keep compatibility. Also use builder instead of newInstance somewhere, but not in test yet.
        Hide
        asuresh Arun Suresh added a comment -

        Sure Tao Jie.. Assigning this to you. Thanks !!

        Show
        asuresh Arun Suresh added a comment - Sure Tao Jie .. Assigning this to you. Thanks !!
        Hide
        Tao Jie Tao Jie added a comment -

        Hi Arun Suresh, I would like to take this Jira over, if you have not started it yet.

        Show
        Tao Jie Tao Jie added a comment - Hi Arun Suresh , I would like to take this Jira over, if you have not started it yet.

          People

          • Assignee:
            Tao Jie Tao Jie
            Reporter:
            asuresh Arun Suresh
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development