Details

    • Hadoop Flags:
      Reviewed

      Description

      The comment for org.apache.hadoop.yarn.api.records.DecommissionType.FORCEFUL is a little unclear. It says:

      /** Forceful decommissioning of nodes which are already in progress **/
      

      It's not exactly clear of what the nodes are in progress. It should say something like "Forceful decommissioning of nodes which are already in progress of decommissioning".

      1. YARN-5514.002.patch
        1 kB
        Vrushali C
      2. YARN-5514.001.patch
        0.8 kB
        Vrushali C

        Activity

        Hide
        vrushalic Vrushali C added a comment -

        Thanks Varun Saxena!

        Show
        vrushalic Vrushali C added a comment - Thanks Varun Saxena !
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10282 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10282/)
        YARN-5514. Clarify DecommissionType.FORCEFUL comment (Vrushali C via (varunsaxena: rev ffe1fff5262bb1d77f68059f12ae43f9849b530f)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/DecommissionType.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10282 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10282/ ) YARN-5514 . Clarify DecommissionType.FORCEFUL comment (Vrushali C via (varunsaxena: rev ffe1fff5262bb1d77f68059f12ae43f9849b530f) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/DecommissionType.java
        Hide
        varun_saxena Varun Saxena added a comment -

        Committed to trunk, branch-2
        Thanks Vrushali for your contribution.

        Show
        varun_saxena Varun Saxena added a comment - Committed to trunk, branch-2 Thanks Vrushali for your contribution.
        Hide
        varun_saxena Varun Saxena added a comment -

        +1 LGTM
        Will commit it.

        Show
        varun_saxena Varun Saxena added a comment - +1 LGTM Will commit it.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 25s trunk passed
        +1 compile 0m 23s trunk passed
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 27s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 1s trunk passed
        +1 javadoc 0m 18s trunk passed
        +1 mvninstall 0m 24s the patch passed
        +1 compile 0m 22s the patch passed
        +1 javac 0m 22s the patch passed
        +1 checkstyle 0m 9s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api: The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4)
        +1 mvnsite 0m 25s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 5s the patch passed
        +1 javadoc 0m 14s the patch passed
        +1 unit 0m 22s hadoop-yarn-api in the patch passed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        15m 18s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823556/YARN-5514.002.patch
        JIRA Issue YARN-5514
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 60bb3a1af1eb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 23c6e3c
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12763/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12763/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 25s trunk passed +1 compile 0m 23s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 27s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 1s trunk passed +1 javadoc 0m 18s trunk passed +1 mvninstall 0m 24s the patch passed +1 compile 0m 22s the patch passed +1 javac 0m 22s the patch passed +1 checkstyle 0m 9s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api: The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) +1 mvnsite 0m 25s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 5s the patch passed +1 javadoc 0m 14s the patch passed +1 unit 0m 22s hadoop-yarn-api in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 15m 18s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823556/YARN-5514.002.patch JIRA Issue YARN-5514 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 60bb3a1af1eb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 23c6e3c Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12763/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api Console output https://builds.apache.org/job/PreCommit-YARN-Build/12763/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        vrushalic Vrushali C added a comment -

        Uploading patch v002 that fixes all the checkstyle warnings existing in this class.

        Show
        vrushalic Vrushali C added a comment - Uploading patch v002 that fixes all the checkstyle warnings existing in this class.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 13s trunk passed
        +1 compile 0m 23s trunk passed
        +1 checkstyle 0m 12s trunk passed
        +1 mvnsite 0m 26s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 0s trunk passed
        +1 javadoc 0m 17s trunk passed
        +1 mvninstall 0m 22s the patch passed
        +1 compile 0m 20s the patch passed
        +1 javac 0m 20s the patch passed
        -1 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api: The patch generated 1 new + 3 unchanged - 1 fixed = 4 total (was 4)
        +1 mvnsite 0m 23s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 4s the patch passed
        +1 javadoc 0m 15s the patch passed
        +1 unit 0m 22s hadoop-yarn-api in the patch passed.
        +1 asflicense 0m 14s The patch does not generate ASF License warnings.
        13m 58s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823543/YARN-5514.001.patch
        JIRA Issue YARN-5514
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a20254bba2d4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 23c6e3c
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12762/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12762/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12762/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 13s trunk passed +1 compile 0m 23s trunk passed +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 26s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 0s trunk passed +1 javadoc 0m 17s trunk passed +1 mvninstall 0m 22s the patch passed +1 compile 0m 20s the patch passed +1 javac 0m 20s the patch passed -1 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api: The patch generated 1 new + 3 unchanged - 1 fixed = 4 total (was 4) +1 mvnsite 0m 23s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 4s the patch passed +1 javadoc 0m 15s the patch passed +1 unit 0m 22s hadoop-yarn-api in the patch passed. +1 asflicense 0m 14s The patch does not generate ASF License warnings. 13m 58s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823543/YARN-5514.001.patch JIRA Issue YARN-5514 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a20254bba2d4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 23c6e3c Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12762/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12762/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api Console output https://builds.apache.org/job/PreCommit-YARN-Build/12762/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        vrushalic Vrushali C added a comment -

        Uploading v1.
        How does this wording look to you Robert Kanter

        Show
        vrushalic Vrushali C added a comment - Uploading v1. How does this wording look to you Robert Kanter

          People

          • Assignee:
            vrushalic Vrushali C
            Reporter:
            rkanter Robert Kanter
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development