Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      • Disable tests as we don't have UTs.
      • Disable lint & hint as they are not followed by the current codebase, and are throwing build errors.
      • Disable clearing of UI package on building, so that n/w is required only in the first build.
      • Remove duplicate bower installs.
        Change the default packaging.type to 'war' as our UI is a Web application - Will keep it in the profile
        Final war should just contain the end result of the build and not all files

      Tan, Wangda Vinod Kumar Vavilapalli Sunil G please share your thoughts.

      1. YARN-5504-YARN-3368-0002.patch
        4 kB
        Sreenath Somarajapuram
      2. YARN-5504-YARN-3368-0001.patch
        3 kB
        Sreenath Somarajapuram

        Activity

        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Wangda Tan Please review.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Wangda Tan Please review.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        -1 mvninstall 0m 6s root in YARN-3368 failed.
        -1 compile 0m 4s hadoop-yarn-ui in YARN-3368 failed.
        -1 mvnsite 0m 6s hadoop-yarn-ui in YARN-3368 failed.
        -1 mvneclipse 0m 4s hadoop-yarn-ui in YARN-3368 failed.
        -1 javadoc 0m 5s hadoop-yarn-ui in YARN-3368 failed.
        -1 mvninstall 0m 4s hadoop-yarn-ui in the patch failed.
        -1 compile 0m 5s hadoop-yarn-ui in the patch failed.
        -1 javac 0m 5s hadoop-yarn-ui in the patch failed.
        -1 mvnsite 0m 5s hadoop-yarn-ui in the patch failed.
        -1 mvneclipse 0m 4s hadoop-yarn-ui in the patch failed.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        -1 javadoc 0m 4s hadoop-yarn-ui in the patch failed.
        -1 unit 0m 5s hadoop-yarn-ui in the patch failed.
        0 asflicense 0m 6s ASF License check generated no output?
        1m 55s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:d13f52f
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823124/YARN-5504-YARN-3368-0001.patch
        JIRA Issue YARN-5504
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux 9b9fa44723a6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-3368 / aba48e6
        Default Java 1.8.0_101
        mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/branch-mvninstall-root.txt
        compile https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        mvneclipse https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/branch-mvneclipse-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        compile https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        javac https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        mvneclipse https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/patch-mvneclipse-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12728/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12728/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 mvninstall 0m 6s root in YARN-3368 failed. -1 compile 0m 4s hadoop-yarn-ui in YARN-3368 failed. -1 mvnsite 0m 6s hadoop-yarn-ui in YARN-3368 failed. -1 mvneclipse 0m 4s hadoop-yarn-ui in YARN-3368 failed. -1 javadoc 0m 5s hadoop-yarn-ui in YARN-3368 failed. -1 mvninstall 0m 4s hadoop-yarn-ui in the patch failed. -1 compile 0m 5s hadoop-yarn-ui in the patch failed. -1 javac 0m 5s hadoop-yarn-ui in the patch failed. -1 mvnsite 0m 5s hadoop-yarn-ui in the patch failed. -1 mvneclipse 0m 4s hadoop-yarn-ui in the patch failed. +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. -1 javadoc 0m 4s hadoop-yarn-ui in the patch failed. -1 unit 0m 5s hadoop-yarn-ui in the patch failed. 0 asflicense 0m 6s ASF License check generated no output? 1m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:d13f52f JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823124/YARN-5504-YARN-3368-0001.patch JIRA Issue YARN-5504 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 9b9fa44723a6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3368 / aba48e6 Default Java 1.8.0_101 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt mvneclipse https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/branch-mvneclipse-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt mvneclipse https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/patch-mvneclipse-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12728/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui Console output https://builds.apache.org/job/PreCommit-YARN-Build/12728/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Thanks Sreenath Somarajapuram.
        I have doubt. In which all cases, we need to clean node_modules etc. Do we have a case where we must delete this, and if so, how we could do same from maven (may be --force-clean). Thoughts?

        Show
        sunilg Sunil G added a comment - Thanks Sreenath Somarajapuram . I have doubt. In which all cases, we need to clean node_modules etc. Do we have a case where we must delete this, and if so, how we could do same from maven (may be --force-clean). Thoughts?
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks Sreenath Somarajapuram,

        Few questions/comments:
        1) Instead of skipping clean up directories, can we leverage tools like https://www.npmjs.com/package/npm-cache to install from cache? I think it doesn't look good if we do not clean up temp npm files. And it brings troubles to developers (see a lot of git untracked files) when they switching Hadoop branches.

        2)

        Change the default packaging.type to 'war' as our UI is a Web application- - Will keep it in the profile

        I didn't see this change in the patch

        3)

        Disable tests as we don't have UTs.

        I think we should have few UTs, adding more tests is very important for better quality. Is there any benefit we can get from disabling UTs?

        Show
        leftnoteasy Wangda Tan added a comment - Thanks Sreenath Somarajapuram , Few questions/comments: 1) Instead of skipping clean up directories, can we leverage tools like https://www.npmjs.com/package/npm-cache to install from cache? I think it doesn't look good if we do not clean up temp npm files. And it brings troubles to developers (see a lot of git untracked files) when they switching Hadoop branches. 2) Change the default packaging.type to 'war' as our UI is a Web application- - Will keep it in the profile I didn't see this change in the patch 3) Disable tests as we don't have UTs. I think we should have few UTs, adding more tests is very important for better quality. Is there any benefit we can get from disabling UTs?
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        I have doubt. In which all cases, we need to clean node_modules etc. Do we have a case where we must delete this, and if so, how we could do same from maven (may be --force-clean). Thoughts?

        • Do we have a case: We could, I have observed permission issues when multiple users try to build on the same codebase.
        • Guess force-clean, could be a good addition.

        Instead of skipping clean up directories, can we leverage tools like https://www.npmjs.com/package/npm-cache to install from cache? I think it doesn't look good if we do not clean up temp npm files. And it brings troubles to developers (see a lot of git untracked files) when they switching Hadoop branches.

        • npm-cache is an npm package like other items in node_modules, so the question is, where would the npm-cached be cached?
        • Currently npm install works as the frontend-maven-plugin can download, cache and use node, NPM, bower and few other build tools.
        • Also in effect, npm-cached looks similar to not deleting the directories.
        • Now regarding the untracked file - Ideally both node_modules and bower_components must be part of .gitignore. And if we move to a branch without hadoop-yarn-ui, then doesn't the list go only till hadoop-yarn-ui?

        I think we should have few UTs, adding more tests is very important for better quality. Is there any benefit we can get from disabling UTs?

        • Totally agree that UTs are required. But ember uses PhantomJs to run the integration tests, and Phantom JS have some issue when the build is run from behind a proxy. Considering that some of our builds run behind a cache proxy, this might cause issues. We are facing this in Tez. So guess it would be better to add them once PhantomJS dependency issues are fixed.
        • Also it might be better to add them after hinting is enabled. And that is going to be a big change.
        Show
        Sreenath Sreenath Somarajapuram added a comment - I have doubt. In which all cases, we need to clean node_modules etc. Do we have a case where we must delete this, and if so, how we could do same from maven (may be --force-clean). Thoughts? Do we have a case: We could, I have observed permission issues when multiple users try to build on the same codebase. Guess force-clean, could be a good addition. Instead of skipping clean up directories, can we leverage tools like https://www.npmjs.com/package/npm-cache to install from cache? I think it doesn't look good if we do not clean up temp npm files. And it brings troubles to developers (see a lot of git untracked files) when they switching Hadoop branches. npm-cache is an npm package like other items in node_modules, so the question is, where would the npm-cached be cached? Currently npm install works as the frontend-maven-plugin can download, cache and use node, NPM, bower and few other build tools. Also in effect, npm-cached looks similar to not deleting the directories. Now regarding the untracked file - Ideally both node_modules and bower_components must be part of .gitignore. And if we move to a branch without hadoop-yarn-ui, then doesn't the list go only till hadoop-yarn-ui? I think we should have few UTs, adding more tests is very important for better quality. Is there any benefit we can get from disabling UTs? Totally agree that UTs are required. But ember uses PhantomJs to run the integration tests, and Phantom JS have some issue when the build is run from behind a proxy. Considering that some of our builds run behind a cache proxy, this might cause issues. We are facing this in Tez. So guess it would be better to add them once PhantomJS dependency issues are fixed. Also it might be better to add them after hinting is enabled. And that is going to be a big change.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks for explanations, Sreenath Somarajapuram.

        I think it will be fine to leave some options to developers to say keep node_components and bower_components, and also, it gonna be very important to make sure all untracked files generated by build process will be removed after run "mvn clean". For example, we cannot add node_component and bower_components gitignore file from all branches. That causes issue if a developer switch to a different branch.

        I would like to propose one solution: can we cleanup npm_components, etc. by default, and have an option (like -Dkeep-yarn-ui-build-files) to explicitly tell mvn to keep these temporary files. Sounds like a plan? Sunil G.

        For npm-cached: does it store files in a default location such as ~/.npm? Just like maven, we will store downloaded files to local ~/.m2, this cannot solve all the issues, but can speed up the whole build since it doesn't need to re-download dependencies.

        For unit test, not quite sure when the issues will be triggered. What does the "cache proxy" means? Is the "cache proxy" enabled by default? And what efforts needed for enable hinting?

        Thanks

        Show
        leftnoteasy Wangda Tan added a comment - Thanks for explanations, Sreenath Somarajapuram . I think it will be fine to leave some options to developers to say keep node_components and bower_components, and also, it gonna be very important to make sure all untracked files generated by build process will be removed after run "mvn clean". For example, we cannot add node_component and bower_components gitignore file from all branches. That causes issue if a developer switch to a different branch. I would like to propose one solution: can we cleanup npm_components, etc. by default, and have an option (like -Dkeep-yarn-ui-build-files) to explicitly tell mvn to keep these temporary files. Sounds like a plan? Sunil G . For npm-cached: does it store files in a default location such as ~/.npm? Just like maven, we will store downloaded files to local ~/.m2, this cannot solve all the issues, but can speed up the whole build since it doesn't need to re-download dependencies. For unit test, not quite sure when the issues will be triggered. What does the "cache proxy" means? Is the "cache proxy" enabled by default? And what efforts needed for enable hinting? Thanks
        Hide
        sunilg Sunil G added a comment -

        As discussed offline with Sreenath Somarajapuram, we can clean node_component and bower_component while doing mvn clean. And as suggested by wangda, we can try keep the file if passed and option like *keep-ui-build-cache" or something like. This seems fine for me

        Yes we do not have a full coverage UT yet, we can still keep what we have. Later we can add an improvement to enhance UT with phantomJS if possible.

        Show
        sunilg Sunil G added a comment - As discussed offline with Sreenath Somarajapuram , we can clean node_component and bower_component while doing mvn clean. And as suggested by wangda, we can try keep the file if passed and option like *keep-ui-build-cache" or something like. This seems fine for me Yes we do not have a full coverage UT yet, we can still keep what we have. Later we can add an improvement to enhance UT with phantomJS if possible.
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Attaching a second patch with some of the comments addressed.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Attaching a second patch with some of the comments addressed.
        Hide
        Sreenath Sreenath Somarajapuram added a comment -
        • Have added -Dkeep-ui-build-cache as discussed.
        • I doubt if the UTs were functional as the requisites for UTs are not available. Can enable them sometime later, but for the time being lets keep them dormant.
        Show
        Sreenath Sreenath Somarajapuram added a comment - Have added -Dkeep-ui-build-cache as discussed. I doubt if the UTs were functional as the requisites for UTs are not available. Can enable them sometime later, but for the time being lets keep them dormant.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 54s YARN-3368 passed
        +1 compile 0m 10s YARN-3368 passed
        +1 mvnsite 0m 10s YARN-3368 passed
        +1 mvneclipse 0m 11s YARN-3368 passed
        +1 javadoc 0m 9s YARN-3368 passed
        +1 mvninstall 0m 8s the patch passed
        +1 compile 0m 6s the patch passed
        +1 javac 0m 6s the patch passed
        +1 mvnsite 0m 8s the patch passed
        +1 mvneclipse 0m 8s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 javadoc 0m 7s the patch passed
        +1 unit 0m 6s hadoop-yarn-ui in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        10m 29s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:6068a84
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825335/YARN-5504-YARN-3368-0002.patch
        JIRA Issue YARN-5504
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux cf941070665c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-3368 / e6afd27
        Default Java 1.8.0_101
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12881/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12881/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 54s YARN-3368 passed +1 compile 0m 10s YARN-3368 passed +1 mvnsite 0m 10s YARN-3368 passed +1 mvneclipse 0m 11s YARN-3368 passed +1 javadoc 0m 9s YARN-3368 passed +1 mvninstall 0m 8s the patch passed +1 compile 0m 6s the patch passed +1 javac 0m 6s the patch passed +1 mvnsite 0m 8s the patch passed +1 mvneclipse 0m 8s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 javadoc 0m 7s the patch passed +1 unit 0m 6s hadoop-yarn-ui in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 10m 29s Subsystem Report/Notes Docker Image:yetus/hadoop:6068a84 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825335/YARN-5504-YARN-3368-0002.patch JIRA Issue YARN-5504 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux cf941070665c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3368 / e6afd27 Default Java 1.8.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12881/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui Console output https://builds.apache.org/job/PreCommit-YARN-Build/12881/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        sunilg Sunil G added a comment - - edited

        I tested patch with keep-ui-build-cache, and it works fine.

        However i am confused whether we need test. I think we can keep another ticket open for UT itself.
        I think we must have some UT's and I ll help to get them in soon.

        +1 for current patch, i will commit if there are no other objections.

        Show
        sunilg Sunil G added a comment - - edited I tested patch with keep-ui-build-cache , and it works fine. However i am confused whether we need test . I think we can keep another ticket open for UT itself. I think we must have some UT's and I ll help to get them in soon. +1 for current patch, i will commit if there are no other objections.
        Hide
        sunilg Sunil G added a comment -

        Thanks Sreenath Somarajapuram for the patch. Committed to branch!

        Show
        sunilg Sunil G added a comment - Thanks Sreenath Somarajapuram for the patch. Committed to branch!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10778 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10778/)
        YARN-5504. YARN-3368 Fix YARN UI build pom.xml (Sreenath Somarajapuram (wangda: rev 7005580752bf9346b57f80f1e73ccd5737ae11a5)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/ember-cli-build.js
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/pom.xml
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/package.json
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10778 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10778/ ) YARN-5504 . YARN-3368 Fix YARN UI build pom.xml (Sreenath Somarajapuram (wangda: rev 7005580752bf9346b57f80f1e73ccd5737ae11a5) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/ember-cli-build.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/pom.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/package.json

          People

          • Assignee:
            Sreenath Sreenath Somarajapuram
            Reporter:
            Sreenath Sreenath Somarajapuram
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development