Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      • Feel it might be good to have a readme file with the basic instructions.
      • Change package type to war, as ours is a web application
      • Just noticed that the hidden files that must be present in the base directory of ember app, are missing. Most of them are used for configuration, and when missing the default vakues would be used by ember.
        • They include - .bowerrc, .editorconfig, .ember-cli, .gitignore, .jshintrc, .travis.yml, .watchmanconfig
      1. YARN-5503-YARN-3368.0005.patch
        7 kB
        Sunil G
      2. YARN-5503-YARN-3368.0006.patch
        5 kB
        Sunil G
      3. YARN-5503-YARN-3368-0001.patch
        5 kB
        Sreenath Somarajapuram
      4. YARN-5503-YARN-3368-0001.patch
        10 kB
        Sreenath Somarajapuram
      5. YARN-5503-YARN-3368-0002.patch
        10 kB
        Sreenath Somarajapuram
      6. YARN-5503-YARN-3368-0003.patch
        10 kB
        Sreenath Somarajapuram
      7. YARN-5503-YARN-3368-0004.patch
        7 kB
        Sreenath Somarajapuram

        Activity

        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Tan, Wangda Attaching a patch with the missing files and readme. Please review.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Tan, Wangda Attaching a patch with the missing files and readme. Please review.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        -1 mvninstall 0m 6s root in YARN-3368 failed.
        -1 compile 0m 5s hadoop-yarn-ui in YARN-3368 failed.
        -1 mvnsite 0m 4s hadoop-yarn-ui in YARN-3368 failed.
        -1 mvneclipse 0m 5s hadoop-yarn-ui in YARN-3368 failed.
        -1 javadoc 0m 4s hadoop-yarn-ui in YARN-3368 failed.
        -1 mvninstall 0m 5s hadoop-yarn-ui in the patch failed.
        -1 compile 0m 4s hadoop-yarn-ui in the patch failed.
        -1 javac 0m 4s hadoop-yarn-ui in the patch failed.
        -1 mvnsite 0m 4s hadoop-yarn-ui in the patch failed.
        -1 mvneclipse 0m 4s hadoop-yarn-ui in the patch failed.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        -1 javadoc 0m 4s hadoop-yarn-ui in the patch failed.
        -1 unit 0m 4s hadoop-yarn-ui in the patch failed.
        0 asflicense 0m 6s ASF License check generated no output?
        1m 54s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:d13f52f
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823118/YARN-5503-YARN-3368-0001.patch
        JIRA Issue YARN-5503
        Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml
        uname Linux 28a987c0bf00 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-3368 / aba48e6
        Default Java 1.8.0_101
        mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/branch-mvninstall-root.txt
        compile https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        mvneclipse https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/branch-mvneclipse-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        compile https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        javac https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        mvneclipse https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/patch-mvneclipse-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12727/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12727/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 mvninstall 0m 6s root in YARN-3368 failed. -1 compile 0m 5s hadoop-yarn-ui in YARN-3368 failed. -1 mvnsite 0m 4s hadoop-yarn-ui in YARN-3368 failed. -1 mvneclipse 0m 5s hadoop-yarn-ui in YARN-3368 failed. -1 javadoc 0m 4s hadoop-yarn-ui in YARN-3368 failed. -1 mvninstall 0m 5s hadoop-yarn-ui in the patch failed. -1 compile 0m 4s hadoop-yarn-ui in the patch failed. -1 javac 0m 4s hadoop-yarn-ui in the patch failed. -1 mvnsite 0m 4s hadoop-yarn-ui in the patch failed. -1 mvneclipse 0m 4s hadoop-yarn-ui in the patch failed. +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. -1 javadoc 0m 4s hadoop-yarn-ui in the patch failed. -1 unit 0m 4s hadoop-yarn-ui in the patch failed. 0 asflicense 0m 6s ASF License check generated no output? 1m 54s Subsystem Report/Notes Docker Image:yetus/hadoop:d13f52f JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823118/YARN-5503-YARN-3368-0001.patch JIRA Issue YARN-5503 Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml uname Linux 28a987c0bf00 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3368 / aba48e6 Default Java 1.8.0_101 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt mvneclipse https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/branch-mvneclipse-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt mvneclipse https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/patch-mvneclipse-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12727/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12727/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui Console output https://builds.apache.org/job/PreCommit-YARN-Build/12727/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Attaching a second patch with with a small change in README. Added `-Pyarn-ui` in the build command.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Attaching a second patch with with a small change in README. Added `-Pyarn-ui` in the build command.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        -1 mvninstall 0m 7s root in YARN-3368 failed.
        -1 compile 0m 5s hadoop-yarn-ui in YARN-3368 failed.
        -1 mvnsite 0m 4s hadoop-yarn-ui in YARN-3368 failed.
        -1 mvneclipse 0m 4s hadoop-yarn-ui in YARN-3368 failed.
        -1 javadoc 0m 5s hadoop-yarn-ui in YARN-3368 failed.
        -1 mvninstall 0m 5s hadoop-yarn-ui in the patch failed.
        -1 compile 0m 4s hadoop-yarn-ui in the patch failed.
        -1 javac 0m 4s hadoop-yarn-ui in the patch failed.
        -1 mvnsite 0m 4s hadoop-yarn-ui in the patch failed.
        -1 mvneclipse 0m 4s hadoop-yarn-ui in the patch failed.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        -1 javadoc 0m 4s hadoop-yarn-ui in the patch failed.
        -1 unit 0m 4s hadoop-yarn-ui in the patch failed.
        0 asflicense 0m 6s ASF License check generated no output?
        1m 46s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:d13f52f
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823180/YARN-5503-YARN-3368-0002.patch
        JIRA Issue YARN-5503
        Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml
        uname Linux 527f309c6eff 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-3368 / aba48e6
        Default Java 1.8.0_101
        mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/branch-mvninstall-root.txt
        compile https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        mvneclipse https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/branch-mvneclipse-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        compile https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        javac https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        mvneclipse https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/patch-mvneclipse-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12742/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12742/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 mvninstall 0m 7s root in YARN-3368 failed. -1 compile 0m 5s hadoop-yarn-ui in YARN-3368 failed. -1 mvnsite 0m 4s hadoop-yarn-ui in YARN-3368 failed. -1 mvneclipse 0m 4s hadoop-yarn-ui in YARN-3368 failed. -1 javadoc 0m 5s hadoop-yarn-ui in YARN-3368 failed. -1 mvninstall 0m 5s hadoop-yarn-ui in the patch failed. -1 compile 0m 4s hadoop-yarn-ui in the patch failed. -1 javac 0m 4s hadoop-yarn-ui in the patch failed. -1 mvnsite 0m 4s hadoop-yarn-ui in the patch failed. -1 mvneclipse 0m 4s hadoop-yarn-ui in the patch failed. +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. -1 javadoc 0m 4s hadoop-yarn-ui in the patch failed. -1 unit 0m 4s hadoop-yarn-ui in the patch failed. 0 asflicense 0m 6s ASF License check generated no output? 1m 46s Subsystem Report/Notes Docker Image:yetus/hadoop:d13f52f JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823180/YARN-5503-YARN-3368-0002.patch JIRA Issue YARN-5503 Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml uname Linux 527f309c6eff 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3368 / aba48e6 Default Java 1.8.0_101 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt mvneclipse https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/branch-mvneclipse-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt mvneclipse https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/patch-mvneclipse-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12742/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12742/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui Console output https://builds.apache.org/job/PreCommit-YARN-Build/12742/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Thanks Sreenath Somarajapuram
        Patch looks fine. I will do one test after fixing build error, and will commit the same.

        Show
        sunilg Sunil G added a comment - Thanks Sreenath Somarajapuram Patch looks fine. I will do one test after fixing build error, and will commit the same.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks Sreenath Somarajapuram,

        Some comments:

        • I'm not sure if all these dot-files are necessary, I removed them according to one previous comment: https://issues.apache.org/jira/browse/YARN-4734?focusedCommentId=15167771&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15167771. could you check if all of them are necessary and add a short note about why we need to keep them?
        • For war file changes, will it affect final project packaging, which we want to launch UI inside RM, Sunil G, could you check and confirm?
        • We put all these ignore files to a top-level .gitignore file, could you add them to that place?
        • For compile and installation, we should put them to top-level BUILDING.txt, and for usage (like configurations) and developper related information, we should put them to hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/YarnUI2.md

        Thoughts?

        Show
        leftnoteasy Wangda Tan added a comment - Thanks Sreenath Somarajapuram , Some comments: I'm not sure if all these dot-files are necessary, I removed them according to one previous comment: https://issues.apache.org/jira/browse/YARN-4734?focusedCommentId=15167771&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15167771 . could you check if all of them are necessary and add a short note about why we need to keep them? For war file changes, will it affect final project packaging, which we want to launch UI inside RM, Sunil G , could you check and confirm? We put all these ignore files to a top-level .gitignore file, could you add them to that place? For compile and installation, we should put them to top-level BUILDING.txt, and for usage (like configurations) and developper related information, we should put them to hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/YarnUI2.md Thoughts?
        Hide
        sunilg Sunil G added a comment - - edited

        Ideally these looks fine to fix. Sreenath Somarajapuram, pls help to confirm.
        I ran a UI with this patch, looks fine for now.

        Show
        sunilg Sunil G added a comment - - edited Ideally these looks fine to fix. Sreenath Somarajapuram , pls help to confirm. I ran a UI with this patch, looks fine for now.
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Thanks Tan, Wangda
        Attaching a patch with the comments addressed.

        • I have removed .travis.yml. If required we can add them later when UTs are added.
        • Sunil G Thansk for confirming the war change
        • Minor changes were made to .gitignore file in top-level
        • Other dot-files are for configuring the packages that we use for development, so guess its better to have those.
        • I haven't touched YarnUI2.md as that talks mostly from a deployment perspective. Should I modify YarnUI2.md instead of adding README.md?
        Show
        Sreenath Sreenath Somarajapuram added a comment - Thanks Tan, Wangda Attaching a patch with the comments addressed. I have removed .travis.yml. If required we can add them later when UTs are added. Sunil G Thansk for confirming the war change Minor changes were made to .gitignore file in top-level Other dot-files are for configuring the packages that we use for development, so guess its better to have those. I haven't touched YarnUI2.md as that talks mostly from a deployment perspective. Should I modify YarnUI2.md instead of adding README.md?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 4m 18s Maven dependency ordering for branch
        +1 mvninstall 6m 57s YARN-3368 passed
        +1 compile 7m 5s YARN-3368 passed
        +1 mvnsite 9m 34s YARN-3368 passed
        +1 mvneclipse 2m 33s YARN-3368 passed
        +1 javadoc 4m 43s YARN-3368 passed
        0 mvndep 0m 14s Maven dependency ordering for patch
        +1 mvninstall 7m 7s the patch passed
        +1 compile 6m 55s the patch passed
        +1 javac 6m 55s the patch passed
        +1 mvnsite 9m 15s the patch passed
        +1 mvneclipse 1m 0s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 javadoc 5m 40s the patch passed
        -1 unit 3m 42s root in the patch failed.
        -1 asflicense 0m 21s The patch generated 2 ASF License warnings.
        70m 26s



        Reason Tests
        Failed junit tests hadoop.security.authentication.util.TestZKSignerSecretProvider



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:6068a84
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825308/YARN-5503-YARN-3368-0003.patch
        JIRA Issue YARN-5503
        Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml
        uname Linux 8a849c9287c8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-3368 / e6afd27
        Default Java 1.8.0_101
        unit https://builds.apache.org/job/PreCommit-YARN-Build/12878/artifact/patchprocess/patch-unit-root.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12878/artifact/patchprocess/patch-unit-root.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12878/testReport/
        asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12878/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui . U: .
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12878/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 4m 18s Maven dependency ordering for branch +1 mvninstall 6m 57s YARN-3368 passed +1 compile 7m 5s YARN-3368 passed +1 mvnsite 9m 34s YARN-3368 passed +1 mvneclipse 2m 33s YARN-3368 passed +1 javadoc 4m 43s YARN-3368 passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 7m 7s the patch passed +1 compile 6m 55s the patch passed +1 javac 6m 55s the patch passed +1 mvnsite 9m 15s the patch passed +1 mvneclipse 1m 0s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 5m 40s the patch passed -1 unit 3m 42s root in the patch failed. -1 asflicense 0m 21s The patch generated 2 ASF License warnings. 70m 26s Reason Tests Failed junit tests hadoop.security.authentication.util.TestZKSignerSecretProvider Subsystem Report/Notes Docker Image:yetus/hadoop:6068a84 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825308/YARN-5503-YARN-3368-0003.patch JIRA Issue YARN-5503 Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml uname Linux 8a849c9287c8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3368 / e6afd27 Default Java 1.8.0_101 unit https://builds.apache.org/job/PreCommit-YARN-Build/12878/artifact/patchprocess/patch-unit-root.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12878/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12878/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12878/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui . U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/12878/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Attaching patch 4 without readme, as that must go into the wiki.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Attaching patch 4 without readme, as that must go into the wiki.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 1m 31s Maven dependency ordering for branch
        +1 mvninstall 6m 54s YARN-3368 passed
        +1 compile 6m 56s YARN-3368 passed
        +1 mvnsite 9m 18s YARN-3368 passed
        +1 mvneclipse 2m 36s YARN-3368 passed
        +1 javadoc 4m 46s YARN-3368 passed
        0 mvndep 0m 14s Maven dependency ordering for patch
        +1 mvninstall 6m 50s the patch passed
        +1 compile 6m 55s the patch passed
        +1 javac 6m 55s the patch passed
        +1 mvnsite 10m 22s the patch passed
        +1 mvneclipse 1m 3s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 javadoc 4m 51s the patch passed
        -1 unit 10m 54s root in the patch failed.
        -1 asflicense 0m 23s The patch generated 2 ASF License warnings.
        74m 34s



        Reason Tests
        Failed junit tests hadoop.net.TestDNS



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:6068a84
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825327/YARN-5503-YARN-3368-0004.patch
        JIRA Issue YARN-5503
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux fbcd999590db 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-3368 / e6afd27
        Default Java 1.8.0_101
        unit https://builds.apache.org/job/PreCommit-YARN-Build/12880/artifact/patchprocess/patch-unit-root.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12880/artifact/patchprocess/patch-unit-root.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12880/testReport/
        asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12880/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui . U: .
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12880/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 1m 31s Maven dependency ordering for branch +1 mvninstall 6m 54s YARN-3368 passed +1 compile 6m 56s YARN-3368 passed +1 mvnsite 9m 18s YARN-3368 passed +1 mvneclipse 2m 36s YARN-3368 passed +1 javadoc 4m 46s YARN-3368 passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 6m 50s the patch passed +1 compile 6m 55s the patch passed +1 javac 6m 55s the patch passed +1 mvnsite 10m 22s the patch passed +1 mvneclipse 1m 3s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 4m 51s the patch passed -1 unit 10m 54s root in the patch failed. -1 asflicense 0m 23s The patch generated 2 ASF License warnings. 74m 34s Reason Tests Failed junit tests hadoop.net.TestDNS Subsystem Report/Notes Docker Image:yetus/hadoop:6068a84 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825327/YARN-5503-YARN-3368-0004.patch JIRA Issue YARN-5503 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux fbcd999590db 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3368 / e6afd27 Default Java 1.8.0_101 unit https://builds.apache.org/job/PreCommit-YARN-Build/12880/artifact/patchprocess/patch-unit-root.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12880/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12880/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12880/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui . U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/12880/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        could you please check the ASF warnings.

        Show
        sunilg Sunil G added a comment - could you please check the ASF warnings.
        Hide
        sunilg Sunil G added a comment -

        updating new patch to check asf warnings.

        Show
        sunilg Sunil G added a comment - updating new patch to check asf warnings.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 1m 32s Maven dependency ordering for branch
        +1 mvninstall 7m 9s YARN-3368 passed
        +1 compile 7m 9s YARN-3368 passed
        +1 mvnsite 9m 39s YARN-3368 passed
        +1 mvneclipse 1m 1s YARN-3368 passed
        +1 javadoc 4m 53s YARN-3368 passed
        0 mvndep 0m 14s Maven dependency ordering for patch
        +1 mvninstall 7m 17s the patch passed
        +1 compile 7m 12s the patch passed
        +1 javac 7m 12s the patch passed
        +1 mvnsite 9m 39s the patch passed
        +1 mvneclipse 1m 0s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 javadoc 4m 47s the patch passed
        -1 unit 121m 56s root in the patch failed.
        -1 asflicense 0m 23s The patch generated 2 ASF License warnings.
        184m 56s



        Reason Tests
        Failed junit tests hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:6068a84
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825476/YARN-5503-YARN-3368.0005.patch
        JIRA Issue YARN-5503
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux c1bc80840fb1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-3368 / e6afd27
        Default Java 1.8.0_101
        unit https://builds.apache.org/job/PreCommit-YARN-Build/12893/artifact/patchprocess/patch-unit-root.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12893/artifact/patchprocess/patch-unit-root.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12893/testReport/
        asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12893/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui . U: .
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12893/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 1m 32s Maven dependency ordering for branch +1 mvninstall 7m 9s YARN-3368 passed +1 compile 7m 9s YARN-3368 passed +1 mvnsite 9m 39s YARN-3368 passed +1 mvneclipse 1m 1s YARN-3368 passed +1 javadoc 4m 53s YARN-3368 passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 7m 17s the patch passed +1 compile 7m 12s the patch passed +1 javac 7m 12s the patch passed +1 mvnsite 9m 39s the patch passed +1 mvneclipse 1m 0s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 4m 47s the patch passed -1 unit 121m 56s root in the patch failed. -1 asflicense 0m 23s The patch generated 2 ASF License warnings. 184m 56s Reason Tests Failed junit tests hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices Subsystem Report/Notes Docker Image:yetus/hadoop:6068a84 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825476/YARN-5503-YARN-3368.0005.patch JIRA Issue YARN-5503 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux c1bc80840fb1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3368 / e6afd27 Default Java 1.8.0_101 unit https://builds.apache.org/job/PreCommit-YARN-Build/12893/artifact/patchprocess/patch-unit-root.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12893/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12893/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12893/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui . U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/12893/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 14s Maven dependency ordering for branch
        +1 mvninstall 6m 45s YARN-3368 passed
        +1 compile 6m 54s YARN-3368 passed
        +1 mvnsite 9m 16s YARN-3368 passed
        +1 mvneclipse 0m 59s YARN-3368 passed
        +1 javadoc 4m 42s YARN-3368 passed
        0 mvndep 0m 14s Maven dependency ordering for patch
        +1 mvninstall 6m 52s the patch passed
        +1 compile 7m 2s the patch passed
        +1 javac 7m 2s the patch passed
        +1 mvnsite 11m 4s the patch passed
        +1 mvneclipse 1m 5s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 javadoc 5m 35s the patch passed
        -1 unit 3m 43s root in the patch failed.
        -1 asflicense 0m 21s The patch generated 2 ASF License warnings.
        65m 48s



        Reason Tests
        Failed junit tests hadoop.security.authentication.util.TestZKSignerSecretProvider



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:6068a84
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825476/YARN-5503-YARN-3368.0005.patch
        JIRA Issue YARN-5503
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux a8f4aee3f21d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-3368 / e6afd27
        Default Java 1.8.0_101
        unit https://builds.apache.org/job/PreCommit-YARN-Build/12896/artifact/patchprocess/patch-unit-root.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12896/artifact/patchprocess/patch-unit-root.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12896/testReport/
        asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12896/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui . U: .
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12896/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 45s YARN-3368 passed +1 compile 6m 54s YARN-3368 passed +1 mvnsite 9m 16s YARN-3368 passed +1 mvneclipse 0m 59s YARN-3368 passed +1 javadoc 4m 42s YARN-3368 passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 6m 52s the patch passed +1 compile 7m 2s the patch passed +1 javac 7m 2s the patch passed +1 mvnsite 11m 4s the patch passed +1 mvneclipse 1m 5s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 javadoc 5m 35s the patch passed -1 unit 3m 43s root in the patch failed. -1 asflicense 0m 21s The patch generated 2 ASF License warnings. 65m 48s Reason Tests Failed junit tests hadoop.security.authentication.util.TestZKSignerSecretProvider Subsystem Report/Notes Docker Image:yetus/hadoop:6068a84 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825476/YARN-5503-YARN-3368.0005.patch JIRA Issue YARN-5503 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux a8f4aee3f21d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3368 / e6afd27 Default Java 1.8.0_101 unit https://builds.apache.org/job/PreCommit-YARN-Build/12896/artifact/patchprocess/patch-unit-root.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12896/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12896/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12896/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui . U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/12896/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        As discussed, ASF warnings are not related to the patch. Hence its fine. Also local test with rat plugin too came fine.

        Still as discussed with Varun, could you please split patch so that .gitignore changes can be done separately as it touching all unit test cases from base folder and those are failing. Thoughts?

        Show
        sunilg Sunil G added a comment - As discussed, ASF warnings are not related to the patch. Hence its fine. Also local test with rat plugin too came fine. Still as discussed with Varun, could you please split patch so that .gitignore changes can be done separately as it touching all unit test cases from base folder and those are failing. Thoughts?
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Canceling the patch to be split into two - root level, and YARN level changes.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Canceling the patch to be split into two - root level, and YARN level changes.
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Attaching a fresh patch without root level changes. Those will be added as part of YARN-5583.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Attaching a fresh patch without root level changes. Those will be added as part of YARN-5583 .
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Sunil G Please help.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Sunil G Please help.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 10m 1s YARN-3368 passed
        +1 compile 0m 9s YARN-3368 passed
        +1 mvnsite 0m 13s YARN-3368 passed
        +1 mvneclipse 0m 11s YARN-3368 passed
        +1 javadoc 0m 10s YARN-3368 passed
        +1 mvninstall 0m 8s the patch passed
        +1 compile 0m 7s the patch passed
        +1 javac 0m 7s the patch passed
        +1 mvnsite 0m 8s the patch passed
        +1 mvneclipse 0m 7s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 javadoc 0m 6s the patch passed
        +1 unit 0m 7s hadoop-yarn-ui in the patch passed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        12m 33s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:f62df43
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826161/YARN-5503-YARN-3368-0001.patch
        JIRA Issue YARN-5503
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux dc13dbbb52c7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-3368 / 91efda9
        Default Java 1.8.0_101
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12940/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12940/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 10m 1s YARN-3368 passed +1 compile 0m 9s YARN-3368 passed +1 mvnsite 0m 13s YARN-3368 passed +1 mvneclipse 0m 11s YARN-3368 passed +1 javadoc 0m 10s YARN-3368 passed +1 mvninstall 0m 8s the patch passed +1 compile 0m 7s the patch passed +1 javac 0m 7s the patch passed +1 mvnsite 0m 8s the patch passed +1 mvneclipse 0m 7s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 6s the patch passed +1 unit 0m 7s hadoop-yarn-ui in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 12m 33s Subsystem Report/Notes Docker Image:yetus/hadoop:f62df43 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826161/YARN-5503-YARN-3368-0001.patch JIRA Issue YARN-5503 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux dc13dbbb52c7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3368 / 91efda9 Default Java 1.8.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12940/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui Console output https://builds.apache.org/job/PreCommit-YARN-Build/12940/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Regarding test4tests: The patch doesn't add or modify any business logic. So tests are not required.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Regarding test4tests: The patch doesn't add or modify any business logic. So tests are not required.
        Hide
        sunilg Sunil G added a comment -

        Patch looks good to me. Attaching same patch with correct version number for tracking. Will commit once jenkins is back.

        Show
        sunilg Sunil G added a comment - Patch looks good to me. Attaching same patch with correct version number for tracking. Will commit once jenkins is back.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 1m 35s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 10m 2s YARN-3368 passed
        +1 compile 0m 9s YARN-3368 passed
        +1 mvnsite 0m 13s YARN-3368 passed
        +1 mvneclipse 0m 16s YARN-3368 passed
        +1 javadoc 0m 11s YARN-3368 passed
        +1 mvninstall 0m 8s the patch passed
        +1 compile 0m 6s the patch passed
        +1 javac 0m 6s the patch passed
        +1 mvnsite 0m 8s the patch passed
        +1 mvneclipse 0m 7s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 javadoc 0m 6s the patch passed
        +1 unit 0m 6s hadoop-yarn-ui in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        13m 57s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:f62df43
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826191/YARN-5503-YARN-3368.0006.patch
        JIRA Issue YARN-5503
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux 050b0755271b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-3368 / a58afc2
        Default Java 1.8.0_101
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12944/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12944/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 1m 35s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 10m 2s YARN-3368 passed +1 compile 0m 9s YARN-3368 passed +1 mvnsite 0m 13s YARN-3368 passed +1 mvneclipse 0m 16s YARN-3368 passed +1 javadoc 0m 11s YARN-3368 passed +1 mvninstall 0m 8s the patch passed +1 compile 0m 6s the patch passed +1 javac 0m 6s the patch passed +1 mvnsite 0m 8s the patch passed +1 mvneclipse 0m 7s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 javadoc 0m 6s the patch passed +1 unit 0m 6s hadoop-yarn-ui in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 13m 57s Subsystem Report/Notes Docker Image:yetus/hadoop:f62df43 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826191/YARN-5503-YARN-3368.0006.patch JIRA Issue YARN-5503 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 050b0755271b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3368 / a58afc2 Default Java 1.8.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12944/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui Console output https://builds.apache.org/job/PreCommit-YARN-Build/12944/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Thanks Sreenath Somarajapuram for the contribution. Committed to branch!

        Show
        sunilg Sunil G added a comment - Thanks Sreenath Somarajapuram for the contribution. Committed to branch!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10778 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10778/)
        YARN-5503. YARN-3368 Add missing hidden files in webapp folder for (wangda: rev f6574d9ff6940ffc526bef2efae403df0efb2195)

        • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/.jshintrc
        • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/.bowerrc
        • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/.ember-cli
        • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/.watchmanconfig
        • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/.editorconfig
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/pom.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10778 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10778/ ) YARN-5503 . YARN-3368 Add missing hidden files in webapp folder for (wangda: rev f6574d9ff6940ffc526bef2efae403df0efb2195) (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/.jshintrc (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/.bowerrc (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/.ember-cli (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/.watchmanconfig (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/.editorconfig (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/pom.xml

          People

          • Assignee:
            Sreenath Sreenath Somarajapuram
            Reporter:
            Sreenath Sreenath Somarajapuram
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development