Following on YARN-5455, let's document the DefaultContainerExecutor as well.
This patch adds JavaDocs and does some basic cleanup. I'd love some confirmation that my interpretations of the methods are all accurate.
looks good to me +1(non-binding)
I took a quick look and it seems good to me too. However, it doesn't apply cleanly anymore. Can you rebase and I'll take a closer look?
A few things (this would be so much easier if we used something like reviewboard):
Default constructor to allow for creation via reflection.
@param script the path make executable
* @param signal signal to send
* (for logging).
This message was automatically generated.
Addressed comments, added javadoc for a method I had missed, and improved my cleanup of one of the print statements.
Addressed checkstyle and javadoc issues.
Looks like NetBeans got creative with that last refactor. Fixed the new javadoc errors.
Thanks Daniel Templeton. Committed to trunk and branch-2!
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10627 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10627/)
YARN-5466. DefaultContainerExecutor needs JavaDocs (templedf via (rkanter: rev f5d92359145dfb820a9521e00e2d44c4ee96e67e)