Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5441

Fixing minor Scheduler test case failures

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      YARN-5351 added ExecutionTypeRequest to the ResourceRequest comparator but the ResourceRequest object created via utility methods in few tests like TestFifoScheduler and TestCapacityScheduler do not set ExecutionTypeRequest which results in null pointer exceptions. This JIRA proposes a simple fix by setting ExecutionTypeRequest in the utility methods.

      1. YARN-5441-v1.patch
        4 kB
        Subru Krishnan

        Issue Links

          Activity

          Hide
          subru Subru Krishnan added a comment -

          Attaching a patch that sets import ExecutionTypeRequest whenever ResourceRequest is created through BuilderUtils.

          Show
          subru Subru Krishnan added a comment - Attaching a patch that sets import ExecutionTypeRequest whenever ResourceRequest is created through BuilderUtils .
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 8s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 9s Maven dependency ordering for branch
          +1 mvninstall 6m 40s trunk passed
          +1 compile 2m 13s trunk passed
          +1 checkstyle 0m 38s trunk passed
          +1 mvnsite 0m 51s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 1m 29s trunk passed
          +1 javadoc 0m 42s trunk passed
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 0m 43s the patch passed
          +1 compile 2m 13s the patch passed
          +1 javac 2m 13s the patch passed
          +1 checkstyle 0m 36s the patch passed
          +1 mvnsite 0m 47s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 44s the patch passed
          +1 javadoc 0m 39s the patch passed
          +1 unit 2m 20s hadoop-yarn-common in the patch passed.
          +1 unit 0m 28s hadoop-yarn-server-common in the patch passed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          24m 17s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820574/YARN-5441-v1.patch
          JIRA Issue YARN-5441
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 92d00e1bde61 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / eb7ff0c
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12530/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12530/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 6m 40s trunk passed +1 compile 2m 13s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 1m 29s trunk passed +1 javadoc 0m 42s trunk passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 0m 43s the patch passed +1 compile 2m 13s the patch passed +1 javac 2m 13s the patch passed +1 checkstyle 0m 36s the patch passed +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 44s the patch passed +1 javadoc 0m 39s the patch passed +1 unit 2m 20s hadoop-yarn-common in the patch passed. +1 unit 0m 28s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 24m 17s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820574/YARN-5441-v1.patch JIRA Issue YARN-5441 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 92d00e1bde61 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / eb7ff0c Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12530/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12530/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          asuresh Arun Suresh added a comment -

          Thanks for raising this Subru Krishnan. +1
          Please also verify this fixes the tests Kuhu Shukla mentioned in YARN-5351

          Show
          asuresh Arun Suresh added a comment - Thanks for raising this Subru Krishnan . +1 Please also verify this fixes the tests Kuhu Shukla mentioned in YARN-5351
          Hide
          subru Subru Krishnan added a comment -

          Thanks Arun Suresh for the quick review. I double checked that the patch fixes the test failures seen by Kuhu Shukla.

          I committed it to trunk/branch-2.

          Show
          subru Subru Krishnan added a comment - Thanks Arun Suresh for the quick review. I double checked that the patch fixes the test failures seen by Kuhu Shukla . I committed it to trunk/branch-2.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #10166 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10166/)
          YARN-5441. Fixing minor Scheduler test case failures (subru: rev d2cbfd7de33fde526089a395550deafb4628fc6f)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/utils/BuilderUtils.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/TestPBImplRecords.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10166 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10166/ ) YARN-5441 . Fixing minor Scheduler test case failures (subru: rev d2cbfd7de33fde526089a395550deafb4628fc6f) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/utils/BuilderUtils.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/TestPBImplRecords.java

            People

            • Assignee:
              subru Subru Krishnan
              Reporter:
              subru Subru Krishnan
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development