Details

    • Hadoop Flags:
      Reviewed

      Description

      As detailed in the proposal in the umbrella JIRA, we are introducing a new component that routes client request to appropriate ResourceManager(s). This JIRA tracks the creation of a proxy for ApplicationClientProtocol in the Router. This provides a placeholder for:
      1) throttling mis-behaving clients (YARN-1546)
      3) mask the access to multiple RMs (YARN-3659)

      We are planning to follow the interceptor pattern like we did in YARN-2884 to generalize the approach and have only dynamically coupling for Federation.

      1. YARN-5411-YARN-2915.v7.patch
        158 kB
        Giovanni Matteo Fumarola
      2. YARN-5411-YARN-2915.v6.patch
        158 kB
        Giovanni Matteo Fumarola
      3. YARN-5411-YARN-2915.v5.patch
        156 kB
        Giovanni Matteo Fumarola
      4. YARN-5411-YARN-2915.v4.patch
        166 kB
        Giovanni Matteo Fumarola
      5. YARN-5411-YARN-2915.v3.patch
        166 kB
        Giovanni Matteo Fumarola
      6. YARN-5411-YARN-2915.v2.patch
        166 kB
        Giovanni Matteo Fumarola
      7. YARN-5411-YARN-2915.v1.patch
        127 kB
        Giovanni Matteo Fumarola

        Issue Links

          Activity

          Hide
          luhuichun luhuichun added a comment - - edited

          Giovanni Matteo Fumarola Hi Giovanni, I'd like to contribute and work on this, if you haven't started working on it yet. Thank you.

          Show
          luhuichun luhuichun added a comment - - edited Giovanni Matteo Fumarola Hi Giovanni, I'd like to contribute and work on this, if you haven't started working on it yet. Thank you.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          0 mvndep 0m 10s Maven dependency ordering for branch
          +1 mvninstall 17m 16s YARN-2915 passed
          +1 compile 11m 42s YARN-2915 passed
          +1 checkstyle 0m 55s YARN-2915 passed
          +1 mvnsite 0m 57s YARN-2915 passed
          +1 mvneclipse 0m 42s YARN-2915 passed
          +1 findbugs 1m 37s YARN-2915 passed
          +1 javadoc 0m 45s YARN-2915 passed
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 0m 40s the patch passed
          +1 compile 9m 45s the patch passed
          +1 javac 9m 45s the patch passed
          -0 checkstyle 0m 53s hadoop-yarn-project/hadoop-yarn: The patch generated 20 new + 206 unchanged - 0 fixed = 226 total (was 206)
          +1 mvnsite 0m 54s the patch passed
          +1 mvneclipse 0m 39s the patch passed
          -1 whitespace 0m 0s The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 xml 0m 2s The patch has no ill-formed XML file.
          -1 findbugs 0m 38s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          -1 javadoc 0m 19s hadoop-yarn-server-router in the patch failed.
          -1 unit 0m 33s hadoop-yarn-api in the patch failed.
          -1 unit 0m 21s hadoop-yarn-server-router in the patch failed.
          +1 asflicense 0m 34s The patch does not generate ASF License warnings.
          60m 42s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router
            org.apache.hadoop.yarn.server.router.clientrmproxy.ClientRMProxyService$RequestInterceptorChainWrapper.finalize() is public; should be protected At ClientRMProxyService.java:protected At ClientRMProxyService.java:[lines 535-536]
          Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ac17dc
          JIRA Issue YARN-5411
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865044/YARN-5411-YARN-2915.v1.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux d7245664ecec 3.13.0-110-generic #157-Ubuntu SMP Mon Feb 20 11:54:05 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / a92e684
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15746/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15746/artifact/patchprocess/whitespace-eol.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15746/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.html
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15746/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15746/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15746/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15746/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15746/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 17m 16s YARN-2915 passed +1 compile 11m 42s YARN-2915 passed +1 checkstyle 0m 55s YARN-2915 passed +1 mvnsite 0m 57s YARN-2915 passed +1 mvneclipse 0m 42s YARN-2915 passed +1 findbugs 1m 37s YARN-2915 passed +1 javadoc 0m 45s YARN-2915 passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 0m 40s the patch passed +1 compile 9m 45s the patch passed +1 javac 9m 45s the patch passed -0 checkstyle 0m 53s hadoop-yarn-project/hadoop-yarn: The patch generated 20 new + 206 unchanged - 0 fixed = 226 total (was 206) +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 39s the patch passed -1 whitespace 0m 0s The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 xml 0m 2s The patch has no ill-formed XML file. -1 findbugs 0m 38s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) -1 javadoc 0m 19s hadoop-yarn-server-router in the patch failed. -1 unit 0m 33s hadoop-yarn-api in the patch failed. -1 unit 0m 21s hadoop-yarn-server-router in the patch failed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 60m 42s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router   org.apache.hadoop.yarn.server.router.clientrmproxy.ClientRMProxyService$RequestInterceptorChainWrapper.finalize() is public; should be protected At ClientRMProxyService.java:protected At ClientRMProxyService.java: [lines 535-536] Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue YARN-5411 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865044/YARN-5411-YARN-2915.v1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux d7245664ecec 3.13.0-110-generic #157-Ubuntu SMP Mon Feb 20 11:54:05 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / a92e684 Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15746/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15746/artifact/patchprocess/whitespace-eol.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15746/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.html javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15746/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15746/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15746/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15746/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/15746/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Giovanni Matteo Fumarola for the patch. I looked at it & please find my comments below:

          • There are quite a few Yetus warnings, kindly fix them.
          • I saw some TODOs, can you either address them or open follow-up jira and refer in comment.
          • LRUCacheHashMap should be moved to yarn-common as it's generally useful.
          • I feel we should drop the proxy suffix in package names.
          • I am not a fan of adding more configs in YarnConfiguration. Can we reuse from the RM config, for e.g.: the number of worker threads.
          • There's a typo in YarnConfiguration, ROUTER_PREFIX should be YARN_FEDERATION_PREFIX + "router".
          • In ClientRMProxyService, please add code comments on the usage of LRUCache.
          • We should refactor & reuse ClientRMProxyService::getInterceptorClassNames/createRequestInterceptorChain with AMRMProxyService?
          • getPipelines should have only test visibility in ClientRMProxyService.
          • ClientRequestInterceptor::init, may be more efficient to directly use UGI as we seem to double translating now.
          • Rename clientRM --> clientRMProxy in DefaultClientRequestInterceptor.

          Feedback on tests:

          • We should run the ClientRMProxyService with the DefaultClientRequestInterceptor directly using the TestClientRMService in the RM module.
          • MockResourceManagerFacade - we already added one in YARN-2884 and I have already suggested to reuse it in YARN-5531. Can you also refactor into common module and reuse?
          • MockClientRequestInterceptor should extend DefaultClientRequestInterceptor and only override init.
          • testRequestInterceptorChainCreation - remove the switch case as it's confusing.
          • I didn't grok testUsersChainMapWithLRUCache, the pipeline count should not increase as we are not using different users and even if it did increase, test1 should be evicted?
          Show
          subru Subru Krishnan added a comment - Thanks Giovanni Matteo Fumarola for the patch. I looked at it & please find my comments below: There are quite a few Yetus warnings, kindly fix them. I saw some TODOs, can you either address them or open follow-up jira and refer in comment. LRUCacheHashMap should be moved to yarn-common as it's generally useful. I feel we should drop the proxy suffix in package names. I am not a fan of adding more configs in YarnConfiguration . Can we reuse from the RM config, for e.g.: the number of worker threads. There's a typo in YarnConfiguration , ROUTER_PREFIX should be YARN_FEDERATION_PREFIX + "router". In ClientRMProxyService , please add code comments on the usage of LRUCache. We should refactor & reuse ClientRMProxyService::getInterceptorClassNames/createRequestInterceptorChain with AMRMProxyService ? getPipelines should have only test visibility in ClientRMProxyService . ClientRequestInterceptor::init , may be more efficient to directly use UGI as we seem to double translating now. Rename clientRM --> clientRMProxy in DefaultClientRequestInterceptor . Feedback on tests: We should run the ClientRMProxyService with the DefaultClientRequestInterceptor directly using the TestClientRMService in the RM module. MockResourceManagerFacade - we already added one in YARN-2884 and I have already suggested to reuse it in YARN-5531 . Can you also refactor into common module and reuse? MockClientRequestInterceptor should extend DefaultClientRequestInterceptor and only override init. testRequestInterceptorChainCreation - remove the switch case as it's confusing. I didn't grok testUsersChainMapWithLRUCache , the pipeline count should not increase as we are not using different users and even if it did increase, test1 should be evicted?
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - - edited

          Thanks Subru Krishnan for the feedbacks.

          • Done.
          • I opened YARN-6539, I will update in the next patch.
          • Done.
          • Done.
          • Done.
          • Done.
          • The 2 chains have different objects. Refactoring and Reusing will add additional complexity to the code and it may reduce the stability. I tested this code for long time.
          • Done.
          • There is no a double translation.
          • Done.
          • I opened YARN-6537 to track this.
          • Moved to a yarn-server-common. I add in the pom.xml in nodemanager and router the test-dependency on it. Right now it has the version dependency, I did not find a way to avoid it.
          • Done.
          • I added comments to avoid confusions.
          • test1, test2 are the names of UGIs.
          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - - edited Thanks Subru Krishnan for the feedbacks. Done. I opened YARN-6539 , I will update in the next patch. Done. Done. Done. Done. The 2 chains have different objects. Refactoring and Reusing will add additional complexity to the code and it may reduce the stability. I tested this code for long time. Done. There is no a double translation. Done. I opened YARN-6537 to track this. Moved to a yarn-server-common. I add in the pom.xml in nodemanager and router the test-dependency on it. Right now it has the version dependency, I did not find a way to avoid it. Done. I added comments to avoid confusions. test1, test2 are the names of UGIs.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 8 new or modified test files.
          0 mvndep 0m 44s Maven dependency ordering for branch
          +1 mvninstall 14m 24s YARN-2915 passed
          +1 compile 11m 53s YARN-2915 passed
          +1 checkstyle 0m 54s YARN-2915 passed
          +1 mvnsite 2m 45s YARN-2915 passed
          +1 mvneclipse 1m 47s YARN-2915 passed
          -1 findbugs 1m 5s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in YARN-2915 has 2 extant Findbugs warnings.
          -1 findbugs 0m 51s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in YARN-2915 has 5 extant Findbugs warnings.
          +1 javadoc 2m 8s YARN-2915 passed
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 2m 2s the patch passed
          +1 compile 9m 34s the patch passed
          -1 javac 9m 34s hadoop-yarn-project_hadoop-yarn generated 1 new + 40 unchanged - 1 fixed = 41 total (was 41)
          -0 checkstyle 0m 53s hadoop-yarn-project/hadoop-yarn: The patch generated 19 new + 207 unchanged - 4 fixed = 226 total (was 211)
          +1 mvnsite 2m 36s the patch passed
          +1 mvneclipse 1m 42s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 5s The patch has no ill-formed XML file.
          +1 findbugs 5m 0s the patch passed
          -1 javadoc 0m 17s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
          +1 unit 0m 33s hadoop-yarn-api in the patch passed.
          +1 unit 2m 26s hadoop-yarn-common in the patch passed.
          +1 unit 1m 14s hadoop-yarn-server-common in the patch passed.
          +1 unit 12m 54s hadoop-yarn-server-nodemanager in the patch passed.
          -1 unit 0m 21s hadoop-yarn-server-router in the patch failed.
          +1 asflicense 0m 36s The patch does not generate ASF License warnings.
          91m 27s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ac17dc
          JIRA Issue YARN-5411
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865795/YARN-5411-YARN-2915.v2.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 2935a6010208 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / a92e684
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15782/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15782/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html
          javac https://builds.apache.org/job/PreCommit-YARN-Build/15782/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15782/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15782/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15782/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15782/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15782/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 8 new or modified test files. 0 mvndep 0m 44s Maven dependency ordering for branch +1 mvninstall 14m 24s YARN-2915 passed +1 compile 11m 53s YARN-2915 passed +1 checkstyle 0m 54s YARN-2915 passed +1 mvnsite 2m 45s YARN-2915 passed +1 mvneclipse 1m 47s YARN-2915 passed -1 findbugs 1m 5s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in YARN-2915 has 2 extant Findbugs warnings. -1 findbugs 0m 51s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in YARN-2915 has 5 extant Findbugs warnings. +1 javadoc 2m 8s YARN-2915 passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 2m 2s the patch passed +1 compile 9m 34s the patch passed -1 javac 9m 34s hadoop-yarn-project_hadoop-yarn generated 1 new + 40 unchanged - 1 fixed = 41 total (was 41) -0 checkstyle 0m 53s hadoop-yarn-project/hadoop-yarn: The patch generated 19 new + 207 unchanged - 4 fixed = 226 total (was 211) +1 mvnsite 2m 36s the patch passed +1 mvneclipse 1m 42s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 5s The patch has no ill-formed XML file. +1 findbugs 5m 0s the patch passed -1 javadoc 0m 17s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) +1 unit 0m 33s hadoop-yarn-api in the patch passed. +1 unit 2m 26s hadoop-yarn-common in the patch passed. +1 unit 1m 14s hadoop-yarn-server-common in the patch passed. +1 unit 12m 54s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 0m 21s hadoop-yarn-server-router in the patch failed. +1 asflicense 0m 36s The patch does not generate ASF License warnings. 91m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue YARN-5411 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865795/YARN-5411-YARN-2915.v2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 2935a6010208 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / a92e684 Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15782/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15782/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html javac https://builds.apache.org/job/PreCommit-YARN-Build/15782/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15782/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15782/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15782/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15782/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/15782/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment -

          The findbugs and javac errors are not related to the patch. Fixed the remaining errors except HiddenField error.

          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - The findbugs and javac errors are not related to the patch. Fixed the remaining errors except HiddenField error.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 8 new or modified test files.
          0 mvndep 0m 43s Maven dependency ordering for branch
          +1 mvninstall 14m 36s YARN-2915 passed
          +1 compile 10m 50s YARN-2915 passed
          +1 checkstyle 0m 55s YARN-2915 passed
          +1 mvnsite 2m 35s YARN-2915 passed
          +1 mvneclipse 1m 44s YARN-2915 passed
          -1 findbugs 1m 3s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in YARN-2915 has 2 extant Findbugs warnings.
          -1 findbugs 0m 51s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in YARN-2915 has 5 extant Findbugs warnings.
          +1 javadoc 2m 6s YARN-2915 passed
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 53s the patch passed
          +1 compile 9m 50s the patch passed
          -1 javac 9m 50s hadoop-yarn-project_hadoop-yarn generated 1 new + 40 unchanged - 1 fixed = 41 total (was 41)
          -0 checkstyle 0m 54s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 207 unchanged - 4 fixed = 211 total (was 211)
          +1 mvnsite 2m 36s the patch passed
          +1 mvneclipse 1m 40s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 5s The patch has no ill-formed XML file.
          +1 findbugs 5m 28s the patch passed
          -1 javadoc 0m 33s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 unit 0m 39s hadoop-yarn-api in the patch passed.
          -1 unit 0m 29s hadoop-yarn-common in the patch failed.
          -1 unit 0m 27s hadoop-yarn-server-common in the patch failed.
          +1 unit 13m 22s hadoop-yarn-server-nodemanager in the patch passed.
          -1 unit 0m 20s hadoop-yarn-server-router in the patch failed.
          +1 asflicense 0m 34s The patch does not generate ASF License warnings.
          88m 50s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ac17dc
          JIRA Issue YARN-5411
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865833/YARN-5411-YARN-2915.v3.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux f90fdd4bdcf4 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / a92e684
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15787/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15787/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html
          javac https://builds.apache.org/job/PreCommit-YARN-Build/15787/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15787/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15787/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15787/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15787/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15787/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15787/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15787/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 8 new or modified test files. 0 mvndep 0m 43s Maven dependency ordering for branch +1 mvninstall 14m 36s YARN-2915 passed +1 compile 10m 50s YARN-2915 passed +1 checkstyle 0m 55s YARN-2915 passed +1 mvnsite 2m 35s YARN-2915 passed +1 mvneclipse 1m 44s YARN-2915 passed -1 findbugs 1m 3s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in YARN-2915 has 2 extant Findbugs warnings. -1 findbugs 0m 51s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in YARN-2915 has 5 extant Findbugs warnings. +1 javadoc 2m 6s YARN-2915 passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 53s the patch passed +1 compile 9m 50s the patch passed -1 javac 9m 50s hadoop-yarn-project_hadoop-yarn generated 1 new + 40 unchanged - 1 fixed = 41 total (was 41) -0 checkstyle 0m 54s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 207 unchanged - 4 fixed = 211 total (was 211) +1 mvnsite 2m 36s the patch passed +1 mvneclipse 1m 40s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 5s The patch has no ill-formed XML file. +1 findbugs 5m 28s the patch passed -1 javadoc 0m 33s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 unit 0m 39s hadoop-yarn-api in the patch passed. -1 unit 0m 29s hadoop-yarn-common in the patch failed. -1 unit 0m 27s hadoop-yarn-server-common in the patch failed. +1 unit 13m 22s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 0m 20s hadoop-yarn-server-router in the patch failed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 88m 50s Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue YARN-5411 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865833/YARN-5411-YARN-2915.v3.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux f90fdd4bdcf4 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / a92e684 Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15787/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15787/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html javac https://builds.apache.org/job/PreCommit-YARN-Build/15787/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15787/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15787/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15787/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15787/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15787/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15787/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/15787/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Thanks Giovanni Matteo Fumarola. Took a brief look at the patch and discussed with Subru Krishnan offline. The general approach looks fine.

          Show
          leftnoteasy Wangda Tan added a comment - Thanks Giovanni Matteo Fumarola . Took a brief look at the patch and discussed with Subru Krishnan offline. The general approach looks fine.
          Hide
          subru Subru Krishnan added a comment - - edited

          Thanks Giovanni Matteo Fumarola for addressing my comments. I have manually kicked Yetus as it didn't pick up the latest patch.

          Regarding the version in pom.xml, you should add the test-jar in the hadoop main pom here and then the version gets automatically inherited.

          You seemed to have missed this suggestion:

          MockClientRequestInterceptor should extend DefaultClientRequestInterceptor and only override init.

          A clarification regarding MockResourceManagerFacade - why do we need it as there's MockRM already which is widely used in tests. IF we do need it, call out in the class Javadocs that it's used by AMRMProxy/Router tests.

          Show
          subru Subru Krishnan added a comment - - edited Thanks Giovanni Matteo Fumarola for addressing my comments. I have manually kicked Yetus as it didn't pick up the latest patch. Regarding the version in pom.xml, you should add the test-jar in the hadoop main pom here and then the version gets automatically inherited. You seemed to have missed this suggestion: MockClientRequestInterceptor should extend DefaultClientRequestInterceptor and only override init. A clarification regarding MockResourceManagerFacade - why do we need it as there's MockRM already which is widely used in tests. IF we do need it, call out in the class Javadocs that it's used by AMRMProxy/Router tests.
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment -

          Thanks Subru Krishnan. I fixed the version in pom.xml and the missed suggestion.

          About this:

          A clarification regarding MockResourceManagerFacade - why do we need it as there's MockRM already which is widely used in tests. IF we do need it, call out in the class Javadocs that it's used by AMRMProxy/Router tests.

          It is a good idea, but it requires additional work. I am opening a JIRA under FederationV2 to track this: YARN-6553

          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - Thanks Subru Krishnan . I fixed the version in pom.xml and the missed suggestion. About this: A clarification regarding MockResourceManagerFacade - why do we need it as there's MockRM already which is widely used in tests. IF we do need it, call out in the class Javadocs that it's used by AMRMProxy/Router tests. It is a good idea, but it requires additional work. I am opening a JIRA under FederationV2 to track this: YARN-6553
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 8 new or modified test files.
          0 mvndep 0m 45s Maven dependency ordering for branch
          +1 mvninstall 14m 37s YARN-2915 passed
          +1 compile 11m 31s YARN-2915 passed
          +1 checkstyle 0m 54s YARN-2915 passed
          +1 mvnsite 2m 35s YARN-2915 passed
          +1 mvneclipse 1m 45s YARN-2915 passed
          -1 findbugs 1m 3s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in YARN-2915 has 2 extant Findbugs warnings.
          -1 findbugs 0m 48s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in YARN-2915 has 5 extant Findbugs warnings.
          +1 javadoc 2m 6s YARN-2915 passed
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 55s the patch passed
          +1 compile 8m 52s the patch passed
          -1 javac 8m 52s hadoop-yarn-project_hadoop-yarn generated 1 new + 40 unchanged - 1 fixed = 41 total (was 41)
          +1 checkstyle 0m 54s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 207 unchanged - 4 fixed = 207 total (was 211)
          +1 mvnsite 2m 33s the patch passed
          +1 mvneclipse 1m 41s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 4s The patch has no ill-formed XML file.
          +1 findbugs 4m 54s the patch passed
          +1 javadoc 2m 2s the patch passed
          +1 unit 0m 33s hadoop-yarn-api in the patch passed.
          +1 unit 2m 26s hadoop-yarn-common in the patch passed.
          +1 unit 1m 14s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 16s hadoop-yarn-server-nodemanager in the patch passed.
          -1 unit 0m 22s hadoop-yarn-server-router in the patch failed.
          +1 asflicense 0m 36s The patch does not generate ASF License warnings.
          90m 12s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ac17dc
          JIRA Issue YARN-5411
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866091/YARN-5411-YARN-2915.v4.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux baa569fd424d 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / a92e684
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15811/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15811/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html
          javac https://builds.apache.org/job/PreCommit-YARN-Build/15811/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15811/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15811/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15811/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 8 new or modified test files. 0 mvndep 0m 45s Maven dependency ordering for branch +1 mvninstall 14m 37s YARN-2915 passed +1 compile 11m 31s YARN-2915 passed +1 checkstyle 0m 54s YARN-2915 passed +1 mvnsite 2m 35s YARN-2915 passed +1 mvneclipse 1m 45s YARN-2915 passed -1 findbugs 1m 3s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in YARN-2915 has 2 extant Findbugs warnings. -1 findbugs 0m 48s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in YARN-2915 has 5 extant Findbugs warnings. +1 javadoc 2m 6s YARN-2915 passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 55s the patch passed +1 compile 8m 52s the patch passed -1 javac 8m 52s hadoop-yarn-project_hadoop-yarn generated 1 new + 40 unchanged - 1 fixed = 41 total (was 41) +1 checkstyle 0m 54s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 207 unchanged - 4 fixed = 207 total (was 211) +1 mvnsite 2m 33s the patch passed +1 mvneclipse 1m 41s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 4s The patch has no ill-formed XML file. +1 findbugs 4m 54s the patch passed +1 javadoc 2m 2s the patch passed +1 unit 0m 33s hadoop-yarn-api in the patch passed. +1 unit 2m 26s hadoop-yarn-common in the patch passed. +1 unit 1m 14s hadoop-yarn-server-common in the patch passed. +1 unit 13m 16s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 0m 22s hadoop-yarn-server-router in the patch failed. +1 asflicense 0m 36s The patch does not generate ASF License warnings. 90m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue YARN-5411 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866091/YARN-5411-YARN-2915.v4.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux baa569fd424d 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / a92e684 Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15811/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15811/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html javac https://builds.apache.org/job/PreCommit-YARN-Build/15811/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15811/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15811/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/15811/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          botong Botong Huang added a comment -

          Please change the Log in MockResourceManagerFacade to Log4j, thx

          Show
          botong Botong Huang added a comment - Please change the Log in MockResourceManagerFacade to Log4j, thx
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - - edited

          Thanks Botong Huang, I added log4j and removed TestRouter.
          The Findbugs and javac errors are not related to the patch.

          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - - edited Thanks Botong Huang , I added log4j and removed TestRouter. The Findbugs and javac errors are not related to the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 8 new or modified test files.
          0 mvndep 1m 25s Maven dependency ordering for branch
          +1 mvninstall 14m 25s YARN-2915 passed
          +1 compile 15m 43s YARN-2915 passed
          +1 checkstyle 1m 59s YARN-2915 passed
          +1 mvnsite 2m 57s YARN-2915 passed
          +1 mvneclipse 2m 6s YARN-2915 passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          -1 findbugs 1m 6s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in YARN-2915 has 2 extant Findbugs warnings.
          -1 findbugs 0m 51s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in YARN-2915 has 5 extant Findbugs warnings.
          +1 javadoc 2m 35s YARN-2915 passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 2m 14s the patch passed
          +1 compile 14m 21s the patch passed
          -1 javac 14m 21s root generated 1 new + 777 unchanged - 1 fixed = 778 total (was 778)
          +1 checkstyle 2m 12s root: The patch generated 0 new + 207 unchanged - 4 fixed = 207 total (was 211)
          +1 mvnsite 3m 32s the patch passed
          +1 mvneclipse 2m 21s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 6s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 5m 29s the patch passed
          +1 javadoc 2m 58s the patch passed
          +1 unit 0m 20s hadoop-project in the patch passed.
          +1 unit 0m 38s hadoop-yarn-api in the patch passed.
          +1 unit 2m 44s hadoop-yarn-common in the patch passed.
          +1 unit 1m 26s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 20s hadoop-yarn-server-nodemanager in the patch passed.
          -1 unit 0m 30s hadoop-yarn-server-router in the patch failed.
          +1 asflicense 0m 43s The patch does not generate ASF License warnings.
          124m 49s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ac17dc
          JIRA Issue YARN-5411
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866242/YARN-5411-YARN-2915.v5.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 6961bab5ebbb 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / a92e684
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15814/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15814/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html
          javac https://builds.apache.org/job/PreCommit-YARN-Build/15814/artifact/patchprocess/diff-compile-javac-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15814/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15814/testReport/
          modules C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15814/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 8 new or modified test files. 0 mvndep 1m 25s Maven dependency ordering for branch +1 mvninstall 14m 25s YARN-2915 passed +1 compile 15m 43s YARN-2915 passed +1 checkstyle 1m 59s YARN-2915 passed +1 mvnsite 2m 57s YARN-2915 passed +1 mvneclipse 2m 6s YARN-2915 passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project -1 findbugs 1m 6s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in YARN-2915 has 2 extant Findbugs warnings. -1 findbugs 0m 51s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in YARN-2915 has 5 extant Findbugs warnings. +1 javadoc 2m 35s YARN-2915 passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 2m 14s the patch passed +1 compile 14m 21s the patch passed -1 javac 14m 21s root generated 1 new + 777 unchanged - 1 fixed = 778 total (was 778) +1 checkstyle 2m 12s root: The patch generated 0 new + 207 unchanged - 4 fixed = 207 total (was 211) +1 mvnsite 3m 32s the patch passed +1 mvneclipse 2m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 6s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 5m 29s the patch passed +1 javadoc 2m 58s the patch passed +1 unit 0m 20s hadoop-project in the patch passed. +1 unit 0m 38s hadoop-yarn-api in the patch passed. +1 unit 2m 44s hadoop-yarn-common in the patch passed. +1 unit 1m 26s hadoop-yarn-server-common in the patch passed. +1 unit 13m 20s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 0m 30s hadoop-yarn-server-router in the patch failed. +1 asflicense 0m 43s The patch does not generate ASF License warnings. 124m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue YARN-5411 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866242/YARN-5411-YARN-2915.v5.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 6961bab5ebbb 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / a92e684 Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15814/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15814/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html javac https://builds.apache.org/job/PreCommit-YARN-Build/15814/artifact/patchprocess/diff-compile-javac-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15814/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15814/testReport/ modules C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/15814/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 9 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 14m 49s YARN-2915 passed
          +1 compile 16m 55s YARN-2915 passed
          +1 checkstyle 2m 1s YARN-2915 passed
          +1 mvnsite 3m 6s YARN-2915 passed
          +1 mvneclipse 2m 4s YARN-2915 passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          -1 findbugs 1m 5s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in YARN-2915 has 2 extant Findbugs warnings.
          -1 findbugs 0m 50s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in YARN-2915 has 5 extant Findbugs warnings.
          +1 javadoc 2m 35s YARN-2915 passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 2m 21s the patch passed
          +1 compile 14m 2s the patch passed
          -1 javac 14m 2s root generated 1 new + 777 unchanged - 1 fixed = 778 total (was 778)
          +1 checkstyle 2m 1s root: The patch generated 0 new + 207 unchanged - 4 fixed = 207 total (was 211)
          +1 mvnsite 3m 17s the patch passed
          +1 mvneclipse 2m 26s the patch passed
          +1 whitespace 0m 1s The patch has no whitespace issues.
          +1 xml 0m 6s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 5m 27s the patch passed
          +1 javadoc 2m 56s the patch passed
          +1 unit 0m 22s hadoop-project in the patch passed.
          +1 unit 0m 41s hadoop-yarn-api in the patch passed.
          +1 unit 2m 35s hadoop-yarn-common in the patch passed.
          +1 unit 1m 21s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 23s hadoop-yarn-server-nodemanager in the patch passed.
          -1 unit 0m 28s hadoop-yarn-server-router in the patch failed.
          +1 asflicense 0m 41s The patch does not generate ASF License warnings.
          124m 43s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ac17dc
          JIRA Issue YARN-5411
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866257/YARN-5411-YARN-2915.v6.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 745d7638304d 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / a92e684
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15815/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15815/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html
          javac https://builds.apache.org/job/PreCommit-YARN-Build/15815/artifact/patchprocess/diff-compile-javac-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15815/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15815/testReport/
          modules C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15815/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 9 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 14m 49s YARN-2915 passed +1 compile 16m 55s YARN-2915 passed +1 checkstyle 2m 1s YARN-2915 passed +1 mvnsite 3m 6s YARN-2915 passed +1 mvneclipse 2m 4s YARN-2915 passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project -1 findbugs 1m 5s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in YARN-2915 has 2 extant Findbugs warnings. -1 findbugs 0m 50s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in YARN-2915 has 5 extant Findbugs warnings. +1 javadoc 2m 35s YARN-2915 passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 2m 21s the patch passed +1 compile 14m 2s the patch passed -1 javac 14m 2s root generated 1 new + 777 unchanged - 1 fixed = 778 total (was 778) +1 checkstyle 2m 1s root: The patch generated 0 new + 207 unchanged - 4 fixed = 207 total (was 211) +1 mvnsite 3m 17s the patch passed +1 mvneclipse 2m 26s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 xml 0m 6s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 5m 27s the patch passed +1 javadoc 2m 56s the patch passed +1 unit 0m 22s hadoop-project in the patch passed. +1 unit 0m 41s hadoop-yarn-api in the patch passed. +1 unit 2m 35s hadoop-yarn-common in the patch passed. +1 unit 1m 21s hadoop-yarn-server-common in the patch passed. +1 unit 13m 23s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 0m 28s hadoop-yarn-server-router in the patch failed. +1 asflicense 0m 41s The patch does not generate ASF License warnings. 124m 43s Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue YARN-5411 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866257/YARN-5411-YARN-2915.v6.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 745d7638304d 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / a92e684 Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15815/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15815/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html javac https://builds.apache.org/job/PreCommit-YARN-Build/15815/artifact/patchprocess/diff-compile-javac-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15815/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15815/testReport/ modules C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/15815/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment -

          Fixed logger by using slf4j and added hadoop-common test dependency for Router tests.

          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - Fixed logger by using slf4j and added hadoop-common test dependency for Router tests.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 25s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 9 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 15m 0s YARN-2915 passed
          +1 compile 17m 23s YARN-2915 passed
          +1 checkstyle 2m 0s YARN-2915 passed
          +1 mvnsite 3m 1s YARN-2915 passed
          +1 mvneclipse 2m 5s YARN-2915 passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          -1 findbugs 1m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in YARN-2915 has 2 extant Findbugs warnings.
          -1 findbugs 0m 58s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in YARN-2915 has 5 extant Findbugs warnings.
          +1 javadoc 2m 30s YARN-2915 passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 2m 30s the patch passed
          +1 compile 15m 43s the patch passed
          -1 javac 15m 43s root generated 1 new + 777 unchanged - 1 fixed = 778 total (was 778)
          +1 checkstyle 2m 53s root: The patch generated 0 new + 207 unchanged - 4 fixed = 207 total (was 211)
          +1 mvnsite 3m 36s the patch passed
          +1 mvneclipse 2m 27s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 6s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 5m 39s the patch passed
          +1 javadoc 2m 59s the patch passed
          +1 unit 0m 17s hadoop-project in the patch passed.
          +1 unit 0m 39s hadoop-yarn-api in the patch passed.
          +1 unit 2m 39s hadoop-yarn-common in the patch passed.
          +1 unit 1m 26s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 19s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 0m 27s hadoop-yarn-server-router in the patch passed.
          +1 asflicense 0m 39s The patch does not generate ASF License warnings.
          128m 55s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ac17dc
          JIRA Issue YARN-5411
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866286/YARN-5411-YARN-2915.v7.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux fd2247ac7010 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / a92e684
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15816/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15816/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html
          javac https://builds.apache.org/job/PreCommit-YARN-Build/15816/artifact/patchprocess/diff-compile-javac-root.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15816/testReport/
          modules C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15816/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 9 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 15m 0s YARN-2915 passed +1 compile 17m 23s YARN-2915 passed +1 checkstyle 2m 0s YARN-2915 passed +1 mvnsite 3m 1s YARN-2915 passed +1 mvneclipse 2m 5s YARN-2915 passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project -1 findbugs 1m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in YARN-2915 has 2 extant Findbugs warnings. -1 findbugs 0m 58s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in YARN-2915 has 5 extant Findbugs warnings. +1 javadoc 2m 30s YARN-2915 passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 2m 30s the patch passed +1 compile 15m 43s the patch passed -1 javac 15m 43s root generated 1 new + 777 unchanged - 1 fixed = 778 total (was 778) +1 checkstyle 2m 53s root: The patch generated 0 new + 207 unchanged - 4 fixed = 207 total (was 211) +1 mvnsite 3m 36s the patch passed +1 mvneclipse 2m 27s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 6s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 5m 39s the patch passed +1 javadoc 2m 59s the patch passed +1 unit 0m 17s hadoop-project in the patch passed. +1 unit 0m 39s hadoop-yarn-api in the patch passed. +1 unit 2m 39s hadoop-yarn-common in the patch passed. +1 unit 1m 26s hadoop-yarn-server-common in the patch passed. +1 unit 13m 19s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 0m 27s hadoop-yarn-server-router in the patch passed. +1 asflicense 0m 39s The patch does not generate ASF License warnings. 128m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue YARN-5411 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866286/YARN-5411-YARN-2915.v7.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux fd2247ac7010 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / a92e684 Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15816/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15816/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html javac https://builds.apache.org/job/PreCommit-YARN-Build/15816/artifact/patchprocess/diff-compile-javac-root.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15816/testReport/ modules C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/15816/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Giovanni Matteo Fumarola for the contribution and Wangda Tan for the validation. +1 on v7 patch, just committed this to branch YARN-2915.

          Show
          subru Subru Krishnan added a comment - Thanks Giovanni Matteo Fumarola for the contribution and Wangda Tan for the validation. +1 on v7 patch, just committed this to branch YARN-2915 .

            People

            • Assignee:
              giovanni.fumarola Giovanni Matteo Fumarola
              Reporter:
              subru Subru Krishnan
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development