Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      This JIRA tracks effort to create a mechanism to resolve nodes/racks resource names to sub-cluster identifiers. This is needed by the federation policies in YARN-5323, YARN-5324, YARN-5325 to operate correctly.

      1. YARN-5390-YARN-2915.v0.patch
        22 kB
        Ellen Hui
      2. YARN-5390-YARN-2915.v1.patch
        21 kB
        Ellen Hui
      3. YARN-5390-YARN-2915.v2.patch
        22 kB
        Ellen Hui
      4. YARN-5390-YARN-2915.v3.patch
        23 kB
        Ellen Hui
      5. YARN-5390-YARN-2915.v4.patch
        23 kB
        Ellen Hui

        Issue Links

          Activity

          Hide
          subru Subru Krishnan added a comment -

          I just committed this to branch YARN-2915. Thanks Ellen Hui for the contribution and Wangda Tan for the review.

          Show
          subru Subru Krishnan added a comment - I just committed this to branch YARN-2915 . Thanks Ellen Hui for the contribution and Wangda Tan for the review.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Ellen Hui for addressing my comments. I'll be committing this soon.

          Show
          subru Subru Krishnan added a comment - Thanks Ellen Hui for addressing my comments. I'll be committing this soon.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          0 shelldocs 0m 0s Shelldocs was not available.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 1m 2s Maven dependency ordering for branch
          +1 mvninstall 8m 26s YARN-2915 passed
          +1 compile 2m 50s YARN-2915 passed
          +1 checkstyle 0m 48s YARN-2915 passed
          +1 mvnsite 1m 39s YARN-2915 passed
          +1 mvneclipse 0m 50s YARN-2915 passed
          +1 findbugs 3m 4s YARN-2915 passed
          +1 javadoc 1m 13s YARN-2915 passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 24s the patch passed
          +1 compile 2m 42s the patch passed
          +1 javac 2m 42s the patch passed
          +1 checkstyle 0m 44s the patch passed
          +1 mvnsite 1m 25s the patch passed
          +1 mvneclipse 0m 40s the patch passed
          +1 shellcheck 0m 12s The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75)
          +1 whitespace 0m 1s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 3m 22s the patch passed
          +1 javadoc 1m 13s the patch passed
          +1 unit 0m 28s hadoop-yarn-api in the patch passed.
          +1 unit 2m 28s hadoop-yarn-common in the patch passed.
          +1 unit 0m 34s hadoop-yarn-server-common in the patch passed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          36m 51s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822135/YARN-5390-YARN-2915.v4.patch
          JIRA Issue YARN-5390
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml shellcheck shelldocs
          uname Linux 4e882ba003f3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / 22db8fd
          Default Java 1.8.0_101
          shellcheck v0.4.4
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12649/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12649/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. 0 shelldocs 0m 0s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 1m 2s Maven dependency ordering for branch +1 mvninstall 8m 26s YARN-2915 passed +1 compile 2m 50s YARN-2915 passed +1 checkstyle 0m 48s YARN-2915 passed +1 mvnsite 1m 39s YARN-2915 passed +1 mvneclipse 0m 50s YARN-2915 passed +1 findbugs 3m 4s YARN-2915 passed +1 javadoc 1m 13s YARN-2915 passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 24s the patch passed +1 compile 2m 42s the patch passed +1 javac 2m 42s the patch passed +1 checkstyle 0m 44s the patch passed +1 mvnsite 1m 25s the patch passed +1 mvneclipse 0m 40s the patch passed +1 shellcheck 0m 12s The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75) +1 whitespace 0m 1s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 3m 22s the patch passed +1 javadoc 1m 13s the patch passed +1 unit 0m 28s hadoop-yarn-api in the patch passed. +1 unit 2m 28s hadoop-yarn-common in the patch passed. +1 unit 0m 34s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 36m 51s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822135/YARN-5390-YARN-2915.v4.patch JIRA Issue YARN-5390 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml shellcheck shelldocs uname Linux 4e882ba003f3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / 22db8fd Default Java 1.8.0_101 shellcheck v0.4.4 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12649/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12649/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ellenfkh Ellen Hui added a comment -

          Fix indentation in pom.xml

          Show
          ellenfkh Ellen Hui added a comment - Fix indentation in pom.xml
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          0 shelldocs 0m 0s Shelldocs was not available.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 3m 36s Maven dependency ordering for branch
          +1 mvninstall 8m 36s YARN-2915 passed
          +1 compile 2m 59s YARN-2915 passed
          +1 checkstyle 0m 51s YARN-2915 passed
          +1 mvnsite 1m 53s YARN-2915 passed
          +1 mvneclipse 0m 51s YARN-2915 passed
          +1 findbugs 3m 23s YARN-2915 passed
          +1 javadoc 1m 12s YARN-2915 passed
          0 mvndep 0m 12s Maven dependency ordering for patch
          +1 mvninstall 1m 31s the patch passed
          +1 compile 3m 15s the patch passed
          +1 javac 3m 15s the patch passed
          +1 checkstyle 0m 48s the patch passed
          +1 mvnsite 1m 41s the patch passed
          +1 mvneclipse 0m 43s the patch passed
          +1 shellcheck 0m 13s The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75)
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 3s The patch has no ill-formed XML file.
          +1 findbugs 3m 1s the patch passed
          +1 javadoc 1m 0s the patch passed
          +1 unit 0m 26s hadoop-yarn-api in the patch passed.
          +1 unit 2m 20s hadoop-yarn-common in the patch passed.
          +1 unit 0m 29s hadoop-yarn-server-common in the patch passed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          40m 48s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822113/YARN-5390-YARN-2915.v3.patch
          JIRA Issue YARN-5390
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml shellcheck shelldocs
          uname Linux 938587890c10 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / 22db8fd
          Default Java 1.8.0_101
          shellcheck v0.4.4
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12647/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12647/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. 0 shelldocs 0m 0s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 3m 36s Maven dependency ordering for branch +1 mvninstall 8m 36s YARN-2915 passed +1 compile 2m 59s YARN-2915 passed +1 checkstyle 0m 51s YARN-2915 passed +1 mvnsite 1m 53s YARN-2915 passed +1 mvneclipse 0m 51s YARN-2915 passed +1 findbugs 3m 23s YARN-2915 passed +1 javadoc 1m 12s YARN-2915 passed 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 1m 31s the patch passed +1 compile 3m 15s the patch passed +1 javac 3m 15s the patch passed +1 checkstyle 0m 48s the patch passed +1 mvnsite 1m 41s the patch passed +1 mvneclipse 0m 43s the patch passed +1 shellcheck 0m 13s The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75) +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 3s The patch has no ill-formed XML file. +1 findbugs 3m 1s the patch passed +1 javadoc 1m 0s the patch passed +1 unit 0m 26s hadoop-yarn-api in the patch passed. +1 unit 2m 20s hadoop-yarn-common in the patch passed. +1 unit 0m 29s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 40m 48s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822113/YARN-5390-YARN-2915.v3.patch JIRA Issue YARN-5390 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml shellcheck shelldocs uname Linux 938587890c10 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / 22db8fd Default Java 1.8.0_101 shellcheck v0.4.4 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12647/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12647/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ellenfkh Ellen Hui added a comment -

          Address feedback from Subru Krishnan.

          Show
          ellenfkh Ellen Hui added a comment - Address feedback from Subru Krishnan .
          Hide
          subru Subru Krishnan added a comment - - edited

          Thanks Wangda Tan for reviewing the patch.

          Thanks Ellen Hui for the patch. It mostly LGTM, just a couple of minor comments:

          • Can you add a YARN_FEDERATION_PREFIX in YarnConfiguration as we are going to be using it a lot more in subsequent JIRAs.
          • Please add findbugs exclusion for nodes and nodes-malformed test resources.
          • I feel the checkstyle warnings are not blockers but will good to fix if it's easy to do so.
          Show
          subru Subru Krishnan added a comment - - edited Thanks Wangda Tan for reviewing the patch. Thanks Ellen Hui for the patch. It mostly LGTM, just a couple of minor comments: Can you add a YARN_FEDERATION_PREFIX in YarnConfiguration as we are going to be using it a lot more in subsequent JIRAs. Please add findbugs exclusion for nodes and nodes-malformed test resources. I feel the checkstyle warnings are not blockers but will good to fix if it's easy to do so.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Thanks Ellen Hui,

          I don't have strong opinions about using non-static or static, it totally depends on how it will be used. If lots of modules will use it, static class could be a better choice, if only limited modules will use it, and they're all related to federation, keep it non-static and can be get from FederationContext will be also good.

          For general purpose of this JIRA, the patch looks fine. I hope someone who is more familiar with federation code could take a deeper look at this patch. cc: Subru Krishnan / Carlo Curino.

          Show
          leftnoteasy Wangda Tan added a comment - Thanks Ellen Hui , I don't have strong opinions about using non-static or static, it totally depends on how it will be used. If lots of modules will use it, static class could be a better choice, if only limited modules will use it, and they're all related to federation, keep it non-static and can be get from FederationContext will be also good. For general purpose of this JIRA, the patch looks fine. I hope someone who is more familiar with federation code could take a deeper look at this patch. cc: Subru Krishnan / Carlo Curino .
          Hide
          ellenfkh Ellen Hui added a comment - - edited

          Hi Wangda Tan, thanks for the quick feedback!

          • This interface will be used in the three patches you looked at, although you are correct that they have not been updated yet. For instance, the LocalityMulticastAMRMProxyFederationPolicy prototype in YARN-5325 uses the FederationSubClusterResolver interface to split resource requests. There are some examples of the resolver being used in the splitResourceRequests method of that class, although some of the classnames are out of date. From the javadoc:

          host localized ResourceRequest are always forwarded to the RM
          that owns the node, based on the feedback of a FederationSubClusterResolver

          rack localized ResourceRequest are forwarded to the RM that owns
          the rack (if the FederationSubClusterResolver provides this info) or
          they are forwarded as if they were ANY (this is important for deployment that
          stripe racks across sub-clusters) as there is not a single resolution.

          ANY request corresponding to node/rack local requests are only forwarded
          to the set of RMs that owns the node-local requests. The number of containers
          listed in each ANY is proportional to the number of node-local container
          requests (associated to this ANY via the same allocateRequestId)

          • The FederationInterceptor from YARN-5325 will be responsible for managing the lifecyle of the SubClusterResolver.
          • I think it's better to leave the SubClusterResolver methods non-static, since we want to allow the implementation to be pluggable and I can't think of a particular reason it should be static. Please let me know if you disagree, I may be missing something.

          Thanks!

          Show
          ellenfkh Ellen Hui added a comment - - edited Hi Wangda Tan , thanks for the quick feedback! This interface will be used in the three patches you looked at, although you are correct that they have not been updated yet. For instance, the LocalityMulticastAMRMProxyFederationPolicy prototype in YARN-5325 uses the FederationSubClusterResolver interface to split resource requests. There are some examples of the resolver being used in the splitResourceRequests method of that class, although some of the classnames are out of date. From the javadoc: host localized ResourceRequest are always forwarded to the RM that owns the node, based on the feedback of a FederationSubClusterResolver rack localized ResourceRequest are forwarded to the RM that owns the rack (if the FederationSubClusterResolver provides this info) or they are forwarded as if they were ANY (this is important for deployment that stripe racks across sub-clusters) as there is not a single resolution. ANY request corresponding to node/rack local requests are only forwarded to the set of RMs that owns the node-local requests. The number of containers listed in each ANY is proportional to the number of node-local container requests (associated to this ANY via the same allocateRequestId) The FederationInterceptor from YARN-5325 will be responsible for managing the lifecyle of the SubClusterResolver. I think it's better to leave the SubClusterResolver methods non-static, since we want to allow the implementation to be pluggable and I can't think of a particular reason it should be static. Please let me know if you disagree, I may be missing something. Thanks!
          Hide
          leftnoteasy Wangda Tan added a comment -

          Ellen Hui,

          I took a quick look at the patch attached,

          I'm not sure if you can provide some ideas about:

          • How these interfaces will be used.
          • How/Who to manage lifecycle of SubResolver (initialize, update/reload)
          • Is it better to use non-static interface in this patch or static interfaces like RackResolver.

          It will be better to have some examples to show how this resolver will be used by other components. I checked patches attached to YARN-5323, YARN-5324, YARN-5325, they look like not updated to this patch.

          Thanks,

          Show
          leftnoteasy Wangda Tan added a comment - Ellen Hui , I took a quick look at the patch attached, I'm not sure if you can provide some ideas about: How these interfaces will be used. How/Who to manage lifecycle of SubResolver (initialize, update/reload) Is it better to use non-static interface in this patch or static interfaces like RackResolver. It will be better to have some examples to show how this resolver will be used by other components. I checked patches attached to YARN-5323 , YARN-5324 , YARN-5325 , they look like not updated to this patch. Thanks,
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          0 shelldocs 0m 0s Shelldocs was not available.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 11s Maven dependency ordering for branch
          +1 mvninstall 6m 43s YARN-2915 passed
          +1 compile 2m 21s YARN-2915 passed
          +1 checkstyle 0m 43s YARN-2915 passed
          +1 mvnsite 1m 33s YARN-2915 passed
          +1 mvneclipse 0m 45s YARN-2915 passed
          +1 findbugs 2m 46s YARN-2915 passed
          +1 javadoc 1m 8s YARN-2915 passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 9s the patch passed
          +1 compile 2m 16s the patch passed
          +1 javac 2m 16s the patch passed
          -1 checkstyle 0m 39s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 208 unchanged - 0 fixed = 210 total (was 208)
          +1 mvnsite 1m 17s the patch passed
          +1 mvneclipse 0m 37s the patch passed
          +1 shellcheck 0m 13s The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75)
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 2m 54s the patch passed
          +1 javadoc 0m 58s the patch passed
          +1 unit 0m 24s hadoop-yarn-api in the patch passed.
          +1 unit 2m 18s hadoop-yarn-common in the patch passed.
          +1 unit 0m 29s hadoop-yarn-server-common in the patch passed.
          -1 asflicense 0m 18s The patch generated 2 ASF License warnings.
          31m 11s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821387/YARN-5390-YARN-2915.v2.patch
          JIRA Issue YARN-5390
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml shellcheck shelldocs
          uname Linux 0c5031a65a46 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / 22db8fd
          Default Java 1.8.0_101
          shellcheck v0.4.4
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12593/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12593/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12593/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12593/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. 0 shelldocs 0m 0s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 6m 43s YARN-2915 passed +1 compile 2m 21s YARN-2915 passed +1 checkstyle 0m 43s YARN-2915 passed +1 mvnsite 1m 33s YARN-2915 passed +1 mvneclipse 0m 45s YARN-2915 passed +1 findbugs 2m 46s YARN-2915 passed +1 javadoc 1m 8s YARN-2915 passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 9s the patch passed +1 compile 2m 16s the patch passed +1 javac 2m 16s the patch passed -1 checkstyle 0m 39s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 208 unchanged - 0 fixed = 210 total (was 208) +1 mvnsite 1m 17s the patch passed +1 mvneclipse 0m 37s the patch passed +1 shellcheck 0m 13s The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75) +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 54s the patch passed +1 javadoc 0m 58s the patch passed +1 unit 0m 24s hadoop-yarn-api in the patch passed. +1 unit 2m 18s hadoop-yarn-common in the patch passed. +1 unit 0m 29s hadoop-yarn-server-common in the patch passed. -1 asflicense 0m 18s The patch generated 2 ASF License warnings. 31m 11s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821387/YARN-5390-YARN-2915.v2.patch JIRA Issue YARN-5390 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml shellcheck shelldocs uname Linux 0c5031a65a46 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / 22db8fd Default Java 1.8.0_101 shellcheck v0.4.4 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12593/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12593/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12593/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12593/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          0 shelldocs 0m 0s Shelldocs was not available.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 3m 0s Maven dependency ordering for branch
          +1 mvninstall 6m 50s YARN-2915 passed
          +1 compile 2m 39s YARN-2915 passed
          +1 checkstyle 0m 47s YARN-2915 passed
          +1 mvnsite 1m 2s YARN-2915 passed
          +1 mvneclipse 0m 34s YARN-2915 passed
          +1 findbugs 1m 53s YARN-2915 passed
          +1 javadoc 0m 44s YARN-2915 passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 0m 49s the patch passed
          +1 compile 2m 46s the patch passed
          +1 javac 2m 46s the patch passed
          -1 checkstyle 0m 45s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 208 unchanged - 0 fixed = 210 total (was 208)
          +1 mvnsite 0m 58s the patch passed
          +1 mvneclipse 0m 32s the patch passed
          +1 shellcheck 0m 12s The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75)
          +1 whitespace 0m 1s The patch has no whitespace issues.
          +1 findbugs 2m 4s the patch passed
          +1 javadoc 0m 33s the patch passed
          -1 unit 0m 25s hadoop-yarn-api in the patch failed.
          +1 unit 0m 30s hadoop-yarn-server-common in the patch passed.
          -1 asflicense 0m 21s The patch generated 2 ASF License warnings.
          28m 45s



          Reason Tests
          Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821366/YARN-5390-YARN-2915.v1.patch
          JIRA Issue YARN-5390
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle shellcheck shelldocs
          uname Linux 57bdd1539f3d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / 22db8fd
          Default Java 1.8.0_101
          shellcheck v0.4.4
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12590/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12590/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12590/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12590/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12590/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12590/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. 0 shelldocs 0m 0s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 3m 0s Maven dependency ordering for branch +1 mvninstall 6m 50s YARN-2915 passed +1 compile 2m 39s YARN-2915 passed +1 checkstyle 0m 47s YARN-2915 passed +1 mvnsite 1m 2s YARN-2915 passed +1 mvneclipse 0m 34s YARN-2915 passed +1 findbugs 1m 53s YARN-2915 passed +1 javadoc 0m 44s YARN-2915 passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 49s the patch passed +1 compile 2m 46s the patch passed +1 javac 2m 46s the patch passed -1 checkstyle 0m 45s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 208 unchanged - 0 fixed = 210 total (was 208) +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 32s the patch passed +1 shellcheck 0m 12s The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75) +1 whitespace 0m 1s The patch has no whitespace issues. +1 findbugs 2m 4s the patch passed +1 javadoc 0m 33s the patch passed -1 unit 0m 25s hadoop-yarn-api in the patch failed. +1 unit 0m 30s hadoop-yarn-server-common in the patch passed. -1 asflicense 0m 21s The patch generated 2 ASF License warnings. 28m 45s Reason Tests Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821366/YARN-5390-YARN-2915.v1.patch JIRA Issue YARN-5390 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle shellcheck shelldocs uname Linux 57bdd1539f3d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / 22db8fd Default Java 1.8.0_101 shellcheck v0.4.4 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12590/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12590/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12590/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12590/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12590/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12590/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.

            People

            • Assignee:
              ellenfkh Ellen Hui
              Reporter:
              curino Carlo Curino
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development