Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5380

NMTimelinePublisher should use getMemorySize instead of getMemory

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: timelineserver
    • Labels:

      Description

      NMTimelinePublisher should use getMemorySize instead of getMemory, because the latter is deprecated in favor of the former.

        Activity

        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks Vrushali C for fixing this and reviews from Karthik Kambatla/Naganarasimha Garla!

        Show
        leftnoteasy Wangda Tan added a comment - Thanks Vrushali C for fixing this and reviews from Karthik Kambatla / Naganarasimha Garla !
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #10104 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10104/)
        YARN-5380. NMTimelinePublisher should use getMemorySize instead of (naganarasimha_gr: rev b5ee7dbd8dde756bc556f823327328f511048021)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/timelineservice/NMTimelinePublisher.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10104 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10104/ ) YARN-5380 . NMTimelinePublisher should use getMemorySize instead of (naganarasimha_gr: rev b5ee7dbd8dde756bc556f823327328f511048021) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/timelineservice/NMTimelinePublisher.java
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks for working on the patch Vrushali C and Karthik Kambatla for the review

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks for working on the patch Vrushali C and Karthik Kambatla for the review
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Seems to be a simple fix, will commit the patch shortly !

        Show
        Naganarasimha Naganarasimha G R added a comment - Seems to be a simple fix, will commit the patch shortly !
        Hide
        kasha Karthik Kambatla added a comment -

        I am experiencing technically difficulties checking this in.

        Wangda Tan, Jian He - can either of you take care of this?

        Show
        kasha Karthik Kambatla added a comment - I am experiencing technically difficulties checking this in. Wangda Tan , Jian He - can either of you take care of this?
        Hide
        kasha Karthik Kambatla added a comment -

        +1. Checking this in.

        Show
        kasha Karthik Kambatla added a comment - +1. Checking this in.
        Hide
        vrushalic Vrushali C added a comment -


        The findbugs is unrelated to this patch. I filed jira YARN-5383 to fix that findbugs warning.

        Show
        vrushalic Vrushali C added a comment - The findbugs is unrelated to this patch. I filed jira YARN-5383 to fix that findbugs warning.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 30s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 42s trunk passed
        +1 compile 0m 26s trunk passed
        +1 checkstyle 0m 16s trunk passed
        +1 mvnsite 0m 28s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        -1 findbugs 0m 40s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in trunk has 1 extant Findbugs warnings.
        +1 javadoc 0m 17s trunk passed
        +1 mvninstall 0m 22s the patch passed
        +1 compile 0m 24s the patch passed
        +1 javac 0m 24s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 0 new + 17 unchanged - 1 fixed = 17 total (was 18)
        +1 checkstyle 0m 13s the patch passed
        +1 mvnsite 0m 25s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 47s the patch passed
        +1 javadoc 0m 14s the patch passed
        +1 unit 13m 4s hadoop-yarn-server-nodemanager in the patch passed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        26m 5s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818044/YARN-5380.01.patch
        JIRA Issue YARN-5380
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 921408c350cf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e549a9a
        Default Java 1.8.0_91
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12334/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12334/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12334/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 30s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 42s trunk passed +1 compile 0m 26s trunk passed +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 28s trunk passed +1 mvneclipse 0m 13s trunk passed -1 findbugs 0m 40s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in trunk has 1 extant Findbugs warnings. +1 javadoc 0m 17s trunk passed +1 mvninstall 0m 22s the patch passed +1 compile 0m 24s the patch passed +1 javac 0m 24s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 0 new + 17 unchanged - 1 fixed = 17 total (was 18) +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 25s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 47s the patch passed +1 javadoc 0m 14s the patch passed +1 unit 13m 4s hadoop-yarn-server-nodemanager in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 26m 5s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818044/YARN-5380.01.patch JIRA Issue YARN-5380 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 921408c350cf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e549a9a Default Java 1.8.0_91 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12334/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12334/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/12334/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        vrushalic Vrushali C added a comment -

        Uploading patch v1

        Show
        vrushalic Vrushali C added a comment - Uploading patch v1
        Hide
        vrushalic Vrushali C added a comment -

        Taking this up, will post a patch shortly

        Show
        vrushalic Vrushali C added a comment - Taking this up, will post a patch shortly

          People

          • Assignee:
            vrushalic Vrushali C
            Reporter:
            kasha Karthik Kambatla
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development