Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: webapp
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It will be better if we have a common Refresh button in all pages to get the latest information in all tables such as apps/nodes/queue etc.

      1. YARN-5334-YARN-3368-0002.patch
        43 kB
        Sreenath Somarajapuram
      2. YARN-5334-YARN-3368-0001.patch
        26 kB
        Sreenath Somarajapuram

        Activity

        Hide
        sunilg Sunil G added a comment -

        Assigning to Sreenath Somarajapuram as he has done a similar effort. Pls help to take over.

        Show
        sunilg Sunil G added a comment - Assigning to Sreenath Somarajapuram as he has done a similar effort. Pls help to take over.
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Sunil G Wangda Tan Please help.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Sunil G Wangda Tan Please help.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 docker 0m 3s Docker failed to build yetus/hadoop:6d3a5f5.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821818/YARN-5334-YARN-3368-0001.patch
        JIRA Issue YARN-5334
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12626/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 0m 3s Docker failed to build yetus/hadoop:6d3a5f5. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821818/YARN-5334-YARN-3368-0001.patch JIRA Issue YARN-5334 Console output https://builds.apache.org/job/PreCommit-YARN-Build/12626/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Thanks Sreenath Somarajapuram for the patch and for working on same. Its really a nice feature and helpful add-on while using the UI.

        Few comments from my side:
        1. In cluster-overview.js , I think we also need to unload yarn-app as it will get fresh set of RUNNING apps.
        2. Also in yarn-apps.js, we can unload yarn-app.
        3. In yarn-nodes.js, we can unload yarn-rm-node
        4. in yarn-queue-apps.js, we can unload yarn-app.
        5. In yarn-queue.js, could we remove the unwanted console logs which prints all items. Similarly in yarn-queues.js
        6. <button type="button" class="btn btn-sm btn-primary refresh" action "refresh">Refresh</button> if we can have custom button which can take property like btn-sm btn-primary, it ll be helpful. Yes, we can remove whole line in various templates, but its a big changes in all routes (for the common action) and templates. We could come with an optimization and improvement ticket later for same.

        I also did an initial sanity tests. Looks good. Will do some more test and update if I find some issues.

        Show
        sunilg Sunil G added a comment - Thanks Sreenath Somarajapuram for the patch and for working on same. Its really a nice feature and helpful add-on while using the UI. Few comments from my side: 1. In cluster-overview.js , I think we also need to unload yarn-app as it will get fresh set of RUNNING apps. 2. Also in yarn-apps.js , we can unload yarn-app . 3. In yarn-nodes.js , we can unload yarn-rm-node 4. in yarn-queue-apps.js , we can unload yarn-app . 5. In yarn-queue.js , could we remove the unwanted console logs which prints all items. Similarly in yarn-queues.js 6. <button type="button" class="btn btn-sm btn-primary refresh" action "refresh">Refresh</button> if we can have custom button which can take property like btn-sm btn-primary , it ll be helpful. Yes, we can remove whole line in various templates, but its a big changes in all routes (for the common action) and templates. We could come with an optimization and improvement ticket later for same. I also did an initial sanity tests. Looks good. Will do some more test and update if I find some issues.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks so much for working on this! Sreenath Somarajapuram, this is extremely helpful for end user experiences.

        I did some tests for this, so far so good.

        Sunil G, I'm not quite sure about what 2.-4. means in your comments, I didn't see issues here.

        Show
        leftnoteasy Wangda Tan added a comment - Thanks so much for working on this! Sreenath Somarajapuram , this is extremely helpful for end user experiences. I did some tests for this, so far so good. Sunil G , I'm not quite sure about what 2.-4. means in your comments, I didn't see issues here.
        Hide
        sunilg Sunil G added a comment -

        Hi Wangda Tan,
        For points 2~4, its same as point 1. For pages like cluster-overview or yarn-apps, we have to unload the model and query/find it again to refresh.
        The items which I have mentioned in the comments were queried without unloading. So we may not get fresh data in.

        Tests may seem fine. Sreenath Somarajapuram, could you also please confirm the same.

        Show
        sunilg Sunil G added a comment - Hi Wangda Tan , For points 2~4, its same as point 1. For pages like cluster-overview or yarn-apps, we have to unload the model and query/find it again to refresh. The items which I have mentioned in the comments were queried without unloading. So we may not get fresh data in. Tests may seem fine. Sreenath Somarajapuram , could you also please confirm the same.
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Thanks Sunil G & Wangda Tan

        Without unload: Existing record objects would be reused, and only values in them would be updated.
        With unload: Entity records would be deleted from store and recreated.

        Our current components are just listening to the record thats passed into it, they don't listen to change in values inside the record. So they would update only when the record change. Unloading and then querying would ensure that the components are provided with new records, and thus we can ensure that they are updating.

        Current patch, unloads the records only when required. But probably for the time being, we can unload all records to ensure that nothing left behind to refresh. Once the components are made better, we can remove the unloads. But guess that refactoring can be done at a later stage.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Thanks Sunil G & Wangda Tan Without unload: Existing record objects would be reused, and only values in them would be updated. With unload: Entity records would be deleted from store and recreated. Our current components are just listening to the record thats passed into it, they don't listen to change in values inside the record. So they would update only when the record change. Unloading and then querying would ensure that the components are provided with new records, and thus we can ensure that they are updating. Current patch, unloads the records only when required. But probably for the time being, we can unload all records to ensure that nothing left behind to refresh. Once the components are made better, we can remove the unloads. But guess that refactoring can be done at a later stage.
        Hide
        sunilg Sunil G added a comment -

        Thanks Sreenath Somarajapuram for the detailed clarifications. +1 for the approach suggested. Once we do a detailed optimized model, such cases could be handled.

        Show
        sunilg Sunil G added a comment - Thanks Sreenath Somarajapuram for the detailed clarifications. +1 for the approach suggested. Once we do a detailed optimized model, such cases could be handled.
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Sunil G

        • Attaching a fresh patch with blind unload of all loaded entities, hope it makes the refresh functionality fool-proof.

        Additional changes to minimize code duplication:

        • Created an abstract route class for adding common route functionalities.
        • Created a breadcrumb-bar component, with breadcrumb and refresh button.
        Show
        Sreenath Sreenath Somarajapuram added a comment - Sunil G Attaching a fresh patch with blind unload of all loaded entities, hope it makes the refresh functionality fool-proof. Additional changes to minimize code duplication: Created an abstract route class for adding common route functionalities. Created a breadcrumb-bar component, with breadcrumb and refresh button.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 docker 0m 5s Docker failed to build yetus/hadoop:6d3a5f5.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822268/YARN-5334-YARN-3368-0002.patch
        JIRA Issue YARN-5334
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12656/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 0m 5s Docker failed to build yetus/hadoop:6d3a5f5. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822268/YARN-5334-YARN-3368-0002.patch JIRA Issue YARN-5334 Console output https://builds.apache.org/job/PreCommit-YARN-Build/12656/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        It seems jenkins has not yet ran. Kicking it again.

        Show
        sunilg Sunil G added a comment - It seems jenkins has not yet ran. Kicking it again.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 2m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        0 asflicense 0m 6s ASF License check generated no output?
        2m 33s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:d13f52f
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822268/YARN-5334-YARN-3368-0002.patch
        JIRA Issue YARN-5334
        Optional Tests asflicense
        uname Linux d03875ada963 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-3368 / 3c2c918
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12708/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 2m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s The patch has no whitespace issues. 0 asflicense 0m 6s ASF License check generated no output? 2m 33s Subsystem Report/Notes Docker Image:yetus/hadoop:d13f52f JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822268/YARN-5334-YARN-3368-0002.patch JIRA Issue YARN-5334 Optional Tests asflicense uname Linux d03875ada963 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3368 / 3c2c918 modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui Console output https://builds.apache.org/job/PreCommit-YARN-Build/12708/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        +1.
        Thanks Sreenath Somarajapuram for the contribution. Committed to the branch

        Show
        sunilg Sunil G added a comment - +1. Thanks Sreenath Somarajapuram for the contribution. Committed to the branch

          People

          • Assignee:
            Sreenath Sreenath Somarajapuram
            Reporter:
            sunilg Sunil G
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development