Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5286

Add RPC port info in RM web service's response when getting app status

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When getting app status by RM web service(/ws/v1/cluster/apps/{appid}), there is no RPC port info in the response. The port info is very important to communicate with AM.

      BTW: there is RPC port info when running bin/yarn application -status appid.

      1. YARN-5286.01.patch
        2 kB
        Jun Gong
      2. YARN-5286.02.patch
        5 kB
        Jun Gong
      3. YARN-5286.03.patch
        9 kB
        Jun Gong
      4. YARN-5286.04.patch
        9 kB
        Jun Gong
      5. YARN-5286.05.patch
        9 kB
        Jun Gong

        Activity

        Hide
        hex108 Jun Gong added a comment -

        Attach a patch to fix it.

        Show
        hex108 Jun Gong added a comment - Attach a patch to fix it.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 10s trunk passed
        +1 compile 0m 30s trunk passed
        +1 checkstyle 0m 19s trunk passed
        +1 mvnsite 0m 33s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 53s trunk passed
        +1 javadoc 0m 19s trunk passed
        +1 mvninstall 0m 27s the patch passed
        +1 compile 0m 26s the patch passed
        +1 javac 0m 26s the patch passed
        +1 checkstyle 0m 17s the patch passed
        +1 mvnsite 0m 31s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 57s the patch passed
        +1 javadoc 0m 16s the patch passed
        -1 unit 31m 34s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        44m 48s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:e2f6409
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812474/YARN-5286.01.patch
        JIRA Issue YARN-5286
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 4a69740b63eb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d433b16
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-YARN-Build/12105/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12105/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12105/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12105/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 10s trunk passed +1 compile 0m 30s trunk passed +1 checkstyle 0m 19s trunk passed +1 mvnsite 0m 33s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 53s trunk passed +1 javadoc 0m 19s trunk passed +1 mvninstall 0m 27s the patch passed +1 compile 0m 26s the patch passed +1 javac 0m 26s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 0m 31s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 57s the patch passed +1 javadoc 0m 16s the patch passed -1 unit 31m 34s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 44m 48s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps Subsystem Report/Notes Docker Image:yetus/hadoop:e2f6409 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812474/YARN-5286.01.patch JIRA Issue YARN-5286 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4a69740b63eb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d433b16 Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/12105/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12105/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12105/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/12105/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hex108 Jun Gong added a comment -

        Attach a new patch to fix test case error.

        Show
        hex108 Jun Gong added a comment - Attach a new patch to fix test case error.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 1s trunk passed
        +1 compile 0m 32s trunk passed
        +1 checkstyle 0m 21s trunk passed
        +1 mvnsite 0m 36s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 3s trunk passed
        +1 javadoc 0m 20s trunk passed
        +1 mvninstall 0m 31s the patch passed
        +1 compile 0m 31s the patch passed
        +1 javac 0m 31s the patch passed
        -1 checkstyle 0m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 57 unchanged - 1 fixed = 58 total (was 58)
        +1 mvnsite 0m 36s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 1s The patch has no whitespace issues.
        +1 findbugs 1m 8s the patch passed
        +1 javadoc 0m 18s the patch passed
        -1 unit 31m 55s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        46m 52s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.metrics.TestSystemMetricsPublisher



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:85209cc
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12814134/YARN-5286.02.patch
        JIRA Issue YARN-5286
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e75c8073b576 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / be38e53
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12157/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/12157/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12157/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12157/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12157/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 1s trunk passed +1 compile 0m 32s trunk passed +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 36s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 3s trunk passed +1 javadoc 0m 20s trunk passed +1 mvninstall 0m 31s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed -1 checkstyle 0m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 57 unchanged - 1 fixed = 58 total (was 58) +1 mvnsite 0m 36s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 findbugs 1m 8s the patch passed +1 javadoc 0m 18s the patch passed -1 unit 31m 55s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 46m 52s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.metrics.TestSystemMetricsPublisher Subsystem Report/Notes Docker Image:yetus/hadoop:85209cc JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12814134/YARN-5286.02.patch JIRA Issue YARN-5286 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e75c8073b576 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / be38e53 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12157/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12157/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12157/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12157/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/12157/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hex108 Jun Gong added a comment -

        Test case error is not related and addressed in YARN-5240. Checkstyle is an old problem.

        Show
        hex108 Jun Gong added a comment - Test case error is not related and addressed in YARN-5240 . Checkstyle is an old problem.
        Hide
        varun_saxena Varun Saxena added a comment -

        Jun Gong, thanks for the patch.
        A couple of comments :
        AM RPC address in AppInfo.java is being filled inside the check for master container not being null.
        But Master container is set when its allocated by scheduler, whereas AM host and RPC port is set when AM registers. There will be some time difference between both these events. I think we can explicitly check if host is not "N/A" and RPC port is not -1 to fill AM RPC address in response.

        Moreover, the additional field added can be added in documentation too in hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md. That is add the field in the response under the apps and app REST endpoint sections.

        Show
        varun_saxena Varun Saxena added a comment - Jun Gong , thanks for the patch. A couple of comments : AM RPC address in AppInfo.java is being filled inside the check for master container not being null. But Master container is set when its allocated by scheduler, whereas AM host and RPC port is set when AM registers. There will be some time difference between both these events. I think we can explicitly check if host is not "N/A" and RPC port is not -1 to fill AM RPC address in response. Moreover, the additional field added can be added in documentation too in hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md . That is add the field in the response under the apps and app REST endpoint sections.
        Hide
        hex108 Jun Gong added a comment -

        Thanks Varun Saxena for the review and comments!

        Attach a new patch to address above comments.

        Show
        hex108 Jun Gong added a comment - Thanks Varun Saxena for the review and comments! Attach a new patch to address above comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 27s Maven dependency ordering for branch
        +1 mvninstall 6m 50s trunk passed
        +1 compile 2m 12s trunk passed
        +1 checkstyle 0m 37s trunk passed
        +1 mvnsite 0m 52s trunk passed
        +1 mvneclipse 0m 24s trunk passed
        0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
        +1 findbugs 1m 1s trunk passed
        +1 javadoc 0m 33s trunk passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 0m 39s the patch passed
        +1 compile 2m 23s the patch passed
        +1 javac 2m 23s the patch passed
        -1 checkstyle 0m 37s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 57 unchanged - 1 fixed = 59 total (was 58)
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 20s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
        +1 findbugs 1m 9s the patch passed
        +1 javadoc 0m 30s the patch passed
        -1 unit 36m 31s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 unit 0m 8s hadoop-yarn-site in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        57m 36s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMAdminService
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebAppFairScheduler



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:85209cc
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12815873/YARN-5286.03.patch
        JIRA Issue YARN-5286
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 103c63c7fab9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8b281bc
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12174/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/12174/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12174/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12174/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12174/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 27s Maven dependency ordering for branch +1 mvninstall 6m 50s trunk passed +1 compile 2m 12s trunk passed +1 checkstyle 0m 37s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 24s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 1m 1s trunk passed +1 javadoc 0m 33s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 39s the patch passed +1 compile 2m 23s the patch passed +1 javac 2m 23s the patch passed -1 checkstyle 0m 37s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 57 unchanged - 1 fixed = 59 total (was 58) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 20s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 1m 9s the patch passed +1 javadoc 0m 30s the patch passed -1 unit 36m 31s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 0m 8s hadoop-yarn-site in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 57m 36s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMAdminService   hadoop.yarn.server.resourcemanager.webapp.TestRMWebAppFairScheduler Subsystem Report/Notes Docker Image:yetus/hadoop:85209cc JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12815873/YARN-5286.03.patch JIRA Issue YARN-5286 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 103c63c7fab9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8b281bc Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12174/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12174/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12174/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12174/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12174/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hex108 Jun Gong added a comment -

        Fix checkstyle error and test case error.

        Show
        hex108 Jun Gong added a comment - Fix checkstyle error and test case error.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 8s Maven dependency ordering for branch
        +1 mvninstall 6m 40s trunk passed
        +1 compile 2m 11s trunk passed
        +1 checkstyle 0m 36s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 24s trunk passed
        0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
        +1 findbugs 0m 56s trunk passed
        +1 javadoc 0m 31s trunk passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 0m 37s the patch passed
        +1 compile 2m 7s the patch passed
        +1 javac 2m 7s the patch passed
        -1 checkstyle 0m 35s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 57 unchanged - 1 fixed = 58 total (was 58)
        +1 mvnsite 0m 47s the patch passed
        +1 mvneclipse 0m 21s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
        +1 findbugs 1m 2s the patch passed
        +1 javadoc 0m 27s the patch passed
        -1 unit 37m 45s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 unit 0m 8s hadoop-yarn-site in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        57m 39s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
          hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:85209cc
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12815983/YARN-5286.04.patch
        JIRA Issue YARN-5286
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e924b01e7009 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 2e835d9
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12177/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/12177/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12177/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12177/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12177/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 6m 40s trunk passed +1 compile 2m 11s trunk passed +1 checkstyle 0m 36s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 24s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 56s trunk passed +1 javadoc 0m 31s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 37s the patch passed +1 compile 2m 7s the patch passed +1 javac 2m 7s the patch passed -1 checkstyle 0m 35s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 57 unchanged - 1 fixed = 58 total (was 58) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 1m 2s the patch passed +1 javadoc 0m 27s the patch passed -1 unit 37m 45s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 0m 8s hadoop-yarn-site in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 57m 39s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:85209cc JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12815983/YARN-5286.04.patch JIRA Issue YARN-5286 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e924b01e7009 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2e835d9 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12177/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12177/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12177/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12177/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12177/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hex108 Jun Gong added a comment -

        Test cases errors are not related.

        Show
        hex108 Jun Gong added a comment - Test cases errors are not related.
        Hide
        varun_saxena Varun Saxena added a comment -

        Thanks Jun Gong for the patch.
        I think we can reuse RMAppAttempt object used for getting master container in getAmRPCAddressFromRMApp instead of getting current attempt again.
        Moreover in getAmRPCAddressFromRMApp, we can store host and RPC port in a local variable or move this logic of generating AM RPC address to RMAppAttemptImpl and put it inside read lock. Reason being that in code below, host and rpc port may change between check for N/A and -1 and populating amRPCAddress if attempt fails in between. This may lead to an inconsistent response back to client.

        if (attempt != null && !"N/A".equals(attempt.getHost())
                && attempt.getRpcPort() != -1) {
              amRPCAddress = attempt.getHost() + ":" + attempt.getRpcPort();
            }
        
        Show
        varun_saxena Varun Saxena added a comment - Thanks Jun Gong for the patch. I think we can reuse RMAppAttempt object used for getting master container in getAmRPCAddressFromRMApp instead of getting current attempt again. Moreover in getAmRPCAddressFromRMApp, we can store host and RPC port in a local variable or move this logic of generating AM RPC address to RMAppAttemptImpl and put it inside read lock. Reason being that in code below, host and rpc port may change between check for N/A and -1 and populating amRPCAddress if attempt fails in between. This may lead to an inconsistent response back to client. if (attempt != null && ! "N/A" .equals(attempt.getHost()) && attempt.getRpcPort() != -1) { amRPCAddress = attempt.getHost() + ":" + attempt.getRpcPort(); }
        Hide
        hex108 Jun Gong added a comment -

        Thanks Varun Saxena for the review and comments.

        Attach a new patch to address your comments. I think there is no need to add extra interface to RMAppAttempt, so I store host and RPC port in a local variable according to your first suggestion.

        Show
        hex108 Jun Gong added a comment - Thanks Varun Saxena for the review and comments. Attach a new patch to address your comments. I think there is no need to add extra interface to RMAppAttempt, so I store host and RPC port in a local variable according to your first suggestion.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 12s Maven dependency ordering for branch
        +1 mvninstall 7m 37s trunk passed
        +1 compile 2m 26s trunk passed
        +1 checkstyle 0m 41s trunk passed
        +1 mvnsite 0m 53s trunk passed
        +1 mvneclipse 0m 25s trunk passed
        0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
        +1 findbugs 1m 5s trunk passed
        +1 javadoc 0m 32s trunk passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 0m 41s the patch passed
        +1 compile 2m 12s the patch passed
        +1 javac 2m 12s the patch passed
        -1 checkstyle 0m 33s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 57 unchanged - 1 fixed = 58 total (was 58)
        +1 mvnsite 0m 43s the patch passed
        +1 mvneclipse 0m 19s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
        +1 findbugs 1m 0s the patch passed
        +1 javadoc 0m 24s the patch passed
        +1 unit 35m 19s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 unit 0m 7s hadoop-yarn-site in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        56m 37s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:85209cc
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12816106/YARN-5286.05.patch
        JIRA Issue YARN-5286
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 369faeb8c487 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8b4b525
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12183/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12183/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12183/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 12s Maven dependency ordering for branch +1 mvninstall 7m 37s trunk passed +1 compile 2m 26s trunk passed +1 checkstyle 0m 41s trunk passed +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 25s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 1m 5s trunk passed +1 javadoc 0m 32s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 41s the patch passed +1 compile 2m 12s the patch passed +1 javac 2m 12s the patch passed -1 checkstyle 0m 33s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 57 unchanged - 1 fixed = 58 total (was 58) +1 mvnsite 0m 43s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 1m 0s the patch passed +1 javadoc 0m 24s the patch passed +1 unit 35m 19s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 0m 7s hadoop-yarn-site in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 56m 37s Subsystem Report/Notes Docker Image:yetus/hadoop:85209cc JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12816106/YARN-5286.05.patch JIRA Issue YARN-5286 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 369faeb8c487 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8b4b525 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12183/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12183/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12183/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        varun_saxena Varun Saxena added a comment -

        +1 for the latest patch.
        Will commit it shortly.

        Show
        varun_saxena Varun Saxena added a comment - +1 for the latest patch. Will commit it shortly.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #10050 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10050/)
        YARN-5286. Add RPC port info in RM web service's response when getting (varunsaxena: rev 8e672e3c717bb6f02ae9f93747f78ca3ab5d74a6)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AppInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10050 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10050/ ) YARN-5286 . Add RPC port info in RM web service's response when getting (varunsaxena: rev 8e672e3c717bb6f02ae9f93747f78ca3ab5d74a6) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AppInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
        Hide
        varun_saxena Varun Saxena added a comment -

        Committed this to trunk, branch-2. Thanks Jun Gong for your contribution.
        I have not committed it to branch-2.8 as target version wasnt specified. Is it required ?

        Show
        varun_saxena Varun Saxena added a comment - Committed this to trunk, branch-2. Thanks Jun Gong for your contribution. I have not committed it to branch-2.8 as target version wasnt specified. Is it required ?
        Hide
        hex108 Jun Gong added a comment -

        Thanks Varun Saxena for the review, suggestions and commit!

        I think it might be useful to be merged into branch-2.8.

        Show
        hex108 Jun Gong added a comment - Thanks Varun Saxena for the review, suggestions and commit! I think it might be useful to be merged into branch-2.8.
        Hide
        varun_saxena Varun Saxena added a comment -

        Committed to branch-2.8 too

        Show
        varun_saxena Varun Saxena added a comment - Committed to branch-2.8 too

          People

          • Assignee:
            hex108 Jun Gong
            Reporter:
            hex108 Jun Gong
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development